1. 05 Jun, 2018 1 commit
  2. 04 Jun, 2018 4 commits
    • Janet Kuo's avatar
      Test job backoffLimit correctly · de622012
      Janet Kuo authored
      de622012
    • Maciej Szulik's avatar
      Never clean backoff in job controller · 5df27553
      Maciej Szulik authored
      5df27553
    • Kubernetes Submit Queue's avatar
      Merge pull request #64665 from stealthybox/feature/kubeadm_845-systemd-resolved · 86ae84b1
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      kubeadm: Set the kubelet `--resolv-conf` flag conditionally on init
      
      **What this PR does / why we need it**:
      `kubeadm init` detects if systemd-resolved is running and configures the kubelet to use a working resolv.conf.
      This patch also removes the warning message prompting manual user action for this configuration.
      
      /area kubeadm
      /area kubelet
      /area dns
      /kind bug
      /priority important-soon
      
      /sig cluster-lifecycle
      /assign @timothysc
      
      **Which issue(s) this PR fixes** 
      Fixes https://github.com/kubernetes/kubeadm/issues/845
      
      **Special notes for your reviewer**:
      See the difference in `KUBELET_KUBEADM_ARGS` when running with this build and enabling the resolved daemon on Ubuntu 17.10:
      ```bash
      root@vagrant:/vagrant/bin# bash << EOF
      systemctl start systemd-resolved
      ./845_kubeadm init |& tail -n5
      cat /var/lib/kubelet/kubeadm-flags.env
      
      ./845_kubeadm reset --force |& tail -n2
      systemctl stop systemd-resolved
      echo nameserver 8.8.8.8 > /etc/resolv.conf
      
      ./845_kubeadm init |& tail -n5
      cat /var/lib/kubelet/kubeadm-flags.env
      
      EOF
      You can now join any number of machines by running the following on each node
      as root:
      
        kubeadm join 10.0.2.15:6443 --token 77q84j.0342evur7rrfrwwx --discovery-token-ca-cert-hash sha256:190040f9c3adf8410bc6766dac79f8679870190564e15e8f8d1704fafa03f678
      
      KUBELET_KUBEADM_ARGS=--cgroup-driver=cgroupfs --cni-bin-dir=/opt/cni/bin --cni-conf-dir=/etc/cni/net.d --network-plugin=cni --resolv-conf=/run/systemd/resolve/resolv.conf
      I0603 06:49:16.592482   14106 reset.go:276] [reset] deleting contents of config directories: [/etc/kubernetes/manifests /etc/kubernetes/pki]
      I0603 06:49:16.592858   14106 reset.go:290] [reset] deleting files: [/etc/kubernetes/admin.conf /etc/kubernetes/kubelet.conf /etc/kubernetes/bootstrap-kubelet.conf /etc/kubernetes/controller-manager.conf /etc/kubernetes/scheduler.conf]
      You can now join any number of machines by running the following on each node
      as root:
      
        kubeadm join 10.0.2.15:6443 --token 8mdart.gp67vq3nh9urq4z5 --discovery-token-ca-cert-hash sha256:da6b2e5841546eae134524b045e782f0dd91a6b53becc8d69c15d9eab9c88758
      
      KUBELET_KUBEADM_ARGS=--cgroup-driver=cgroupfs --cni-bin-dir=/opt/cni/bin --cni-conf-dir=/etc/cni/net.d --network-plugin=cni
      ```
      
      **Release note**:
      ```release-note
      `kubeadm init` detects if systemd-resolved is running and configures the kubelet to use a working resolv.conf.
      ```
      86ae84b1
    • Kubernetes Submit Queue's avatar
      Merge pull request #63270 from andyzhangx/volume-partition-azure-fix · 1635393b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      fix data loss issue if using existing azure disk with partitions in disk mount 
      
      **What this PR does / why we need it**:
      When use an existing azure disk(also called [static provisioning](https://github.com/andyzhangx/demo/tree/master/linux/azuredisk#static-provisioning-for-azure-disk)) in pod, if that disk has multiple partitions, the disk will be formatted in the pod mounting.
      
      This PR removes `formatIfNotFormatted` func in `WaitForAttach` which uses `lsblk` command to check whether disk is formatted or not
      https://github.com/kubernetes/kubernetes/blob/b87a392b1a7ece8335ad3ade410e5070e29f216e/pkg/volume/azure_dd/azure_common_linux.go#L213-L215
      
      And finally the format disk operation will happen in `MountDevice` in which it uses common k8s code(`SafeFormatAndMount.GetDiskFormat`) using `blkid` to detect disk format, `blkid` could detect multiple partitions
      https://github.com/kubernetes/kubernetes/blob/b87a392b1a7ece8335ad3ade410e5070e29f216e/pkg/util/mount/mount_linux.go#L541-L543
      
       - so if we use common k8s code(`SafeFormatAndMount.GetDiskFormat`), following error will be returned for mulitple partition disks, which is expected:
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #63235
      
      **Special notes for your reviewer**:
      This PR depends on https://github.com/kubernetes/kubernetes/pull/63248
      
      **Release note**:
      
      ```
      fix data loss issue if using existing azure disk with partitions in disk mount 
      ```
      
      /sig azure
      /assign @khenidak
      1635393b
  3. 03 Jun, 2018 7 commits
  4. 02 Jun, 2018 24 commits
  5. 01 Jun, 2018 4 commits