1. 20 Apr, 2018 14 commits
  2. 19 Apr, 2018 26 commits
    • yankaiz's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #62606 from smarterclayton/defer_delete · 2142bff9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61962, 58972, 62509, 62606). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Allow a test suite reusing framework to register namespaces to delete
      
      If the suite bypasses CreateNamespace (because it wants to create more
      specialized namespaces) it has no way to register deletes.
      
      @liggitt this was something that came up in an older rebase and was missed (for things creating projects)
      2142bff9
    • Kubernetes Submit Queue's avatar
      Merge pull request #62509 from sjenning/qos-reserved-feature-gate · e9374411
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61962, 58972, 62509, 62606). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      kubelet: move QOSReserved from experimental to alpha feature gate
      
      Fixes https://github.com/kubernetes/kubernetes/issues/61665
      
      **Release note**:
      ```release-note
      The --experimental-qos-reserve kubelet flags is replaced by the alpha level --qos-reserved flag or QOSReserved field in the kubeletconfig and requires the QOSReserved feature gate to be enabled.
      ```
      
      /sig node
      /assign  @derekwaynecarr 
      /cc @mtaufen
      e9374411
    • Kubernetes Submit Queue's avatar
      Merge pull request #58972 from soltysh/issue54870 · 139309f7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61962, 58972, 62509, 62606). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fix job's backoff limit for restart policy OnFailure
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #54870
      
      **Release note**:
      ```release-note
      NONE
      ```
      
      /assign janetkuo
      139309f7
    • Kubernetes Submit Queue's avatar
      Merge pull request #61962 from liggitt/flag-race · f3599ba3
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61962, 58972, 62509, 62606). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Avoid data races in unit tests
      
      Setting global flags in unit tests leads to data races like this:
      
      ```
      ==================
      WARNING: DATA RACE
      Write at 0x0000028f5241 by goroutine 47:
        flag.(*boolValue).Set()
            /home/jliggitt/.gvm/gos/go1.9.5/src/flag/flag.go:91 +0x7b
        flag.(*FlagSet).Set()
            /home/jliggitt/.gvm/gos/go1.9.5/src/flag/flag.go:366 +0x10c
        flag.Set()
            /home/jliggitt/.gvm/gos/go1.9.5/src/flag/flag.go:379 +0x76
        k8s.io/kubernetes/pkg/kubelet/cm/devicemanager.TestPodContainerDeviceAllocation()
            /home/jliggitt/go/src/k8s.io/kubernetes/pkg/kubelet/cm/devicemanager/manager_test.go:549 +0x126
        testing.tRunner()
            /home/jliggitt/.gvm/gos/go1.9.5/src/testing/testing.go:746 +0x16c
      
      Previous read at 0x0000028f5241 by goroutine 34:
        k8s.io/kubernetes/vendor/github.com/golang/glog.(*loggingT).output()
            /home/jliggitt/go/src/k8s.io/kubernetes/vendor/github.com/golang/glog/glog.go:682 +0x730
        k8s.io/kubernetes/vendor/github.com/golang/glog.(*loggingT).printf()
            /home/jliggitt/go/src/k8s.io/kubernetes/vendor/github.com/golang/glog/glog.go:655 +0x259
        k8s.io/kubernetes/vendor/github.com/golang/glog.Errorf()
            /home/jliggitt/go/src/k8s.io/kubernetes/vendor/github.com/golang/glog/glog.go:1118 +0x74
        k8s.io/kubernetes/pkg/kubelet/cm/devicemanager.(*endpointImpl).run()
            /home/jliggitt/go/src/k8s.io/kubernetes/pkg/kubelet/cm/devicemanager/endpoint.go:132 +0x1c7e
        k8s.io/kubernetes/pkg/kubelet/cm/devicemanager.(*ManagerImpl).addEndpoint.func1()
            /home/jliggitt/go/src/k8s.io/kubernetes/pkg/kubelet/cm/devicemanager/manager.go:378 +0x3f
      
      Goroutine 47 (running) created at:
        testing.(*T).Run()
            /home/jliggitt/.gvm/gos/go1.9.5/src/testing/testing.go:789 +0x568
        testing.runTests.func1()
            /home/jliggitt/.gvm/gos/go1.9.5/src/testing/testing.go:1004 +0xa7
        testing.tRunner()
            /home/jliggitt/.gvm/gos/go1.9.5/src/testing/testing.go:746 +0x16c
        testing.runTests()
            /home/jliggitt/.gvm/gos/go1.9.5/src/testing/testing.go:1002 +0x521
        testing.(*M).Run()
            /home/jliggitt/.gvm/gos/go1.9.5/src/testing/testing.go:921 +0x206
        main.main()
            k8s.io/kubernetes/pkg/kubelet/cm/devicemanager/_test/_testmain.go:68 +0x1d3
      
      Goroutine 34 (finished) created at:
        k8s.io/kubernetes/pkg/kubelet/cm/devicemanager.(*ManagerImpl).addEndpoint()
            /home/jliggitt/go/src/k8s.io/kubernetes/pkg/kubelet/cm/devicemanager/manager.go:377 +0x9d6
      ==================
      --- FAIL: TestPodContainerDeviceAllocation (0.00s)
      	testing.go:699: race detected during execution of test
      FAIL
      FAIL	k8s.io/kubernetes/pkg/kubelet/cm/devicemanager	0.124s
      
      ```
      f3599ba3
    • juanvallejo's avatar
      aggregate objs before printing in apply cmd · d9f26576
      juanvallejo authored
      d9f26576
    • Kubernetes Submit Queue's avatar
      Merge pull request #62873 from sigma/pr/fix-rpm · 560e15fb
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62642, 62855, 62487, 62858, 62873). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      build/rpms: fix kubeadm rpm
      
      **What this PR does / why we need it**:
      
      Change #61633 doesn't seem quite correct, and breaks bazel builds.
      This patch makes sure that:
      - there is no conflict between directory files and build targets
      - rpm files are properly packaged after being installed
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      I'm not sure how the previous attempt passed CI, but the corollary is that the status for this one might be considered suspect as well.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      560e15fb
    • Kubernetes Submit Queue's avatar
      Merge pull request #62858 from deads2k/cli-32-more-record-02 · 019c805f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62642, 62855, 62487, 62858, 62873). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
       final record flag cleanup
      
      This ties off the remainder of the record flag uses.  Trying to merge different types of patches is fraught, so I added a way to get a merge patch (not a strategic patch) back from the annotation update.
      
      @kubernetes/sig-cli-maintainers 
      /assign @soltysh 
      /assign @juanvallejo 
      
      ```release-note
      NONE
      ```
      019c805f
    • Kubernetes Submit Queue's avatar
      Merge pull request #62487 from juanvallejo/jvallejo/wire-print-flags-apply.go · ea069dcd
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62642, 62855, 62487, 62858, 62873). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      wire print flags through apply cmd
      
      **Release note**:
      ```release-note
      NONE
      ```
      
      Depends on https://github.com/kubernetes/kubernetes/pull/62300
      Adds PrintFlags to `apply` command.
      
      cc @soltysh @deads2k
      ea069dcd
    • Kubernetes Submit Queue's avatar
      Merge pull request #62855 from deads2k/cli-30-clientcache · 4642d5e6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62642, 62855, 62487, 62858, 62873). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      simplify the client cache
      
      We created the client cache back when we negotiated versions to create a config and a client.  Now we don't, so this is just debt.  This removes all the obvious places.  I'll open a separate WIP to try to kill the rest.
      
      @kubernetes/sig-cli-maintainers 
      @soltysh 
      
      ```release-note
      NONE
      ```
      4642d5e6
    • Kubernetes Submit Queue's avatar
      Merge pull request #62642 from ceshihao/kubectl_get_pod_status · 9031f9a8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62642, 62855, 62487, 62858, 62873). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Make pod status to Running if some are Running and some are Completed
      
      **What this PR does / why we need it**:
      Make pod status to Running if some are Running and some are Completed
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #62588
      
      **Special notes for your reviewer**:
      Only Set Pod status to Completed when no other reason, no Running container and only Completed containers.
      
      Set status to Running if some are Running and some are Completed
      
      **Release note**:
      
      ```release-note
      Set pod status to "Running" if there is at least one container still reporting as "Running" status and others are "Completed".
      ```
      9031f9a8
    • Nick Sardo's avatar
      Fix ILB issue updating load balancers · be705419
      Nick Sardo authored
      be705419
    • Kubernetes Submit Queue's avatar
      Merge pull request #62243 from resouer/fix-62068 · 1e39d68e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 59592, 62308, 62523, 62635, 62243). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Separate pod priority from preemption
      
      **What this PR does / why we need it**:
      Users request to split priority and preemption feature gate so they can use priority separately.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #62068 
      
      **Special notes for your reviewer**:
      
      ~~I kept use `ENABLE_POD_PRIORITY` as ENV name for gce cluster scripts for backward compatibility reason. Please let me know if other approach is preffered.~~
      
      ~~This is a potential **break change** as existing clusters will be affected, we may need to include this in 1.11 maybe?~~
      
      TODO: update this doc https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/
      
      [Update] Usage: in config file for scheduler:
      ```yaml
      apiVersion: componentconfig/v1alpha1
      kind: KubeSchedulerConfiguration
      ...
      disablePreemption: true
      ```
      
      **Release note**:
      
      ```release-note
      Split PodPriority and PodPreemption feature gate
      ```
      1e39d68e
    • Kubernetes Submit Queue's avatar
      Merge pull request #62635 from cofyc/reduce_e2e_timeout · 281f00bc
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 59592, 62308, 62523, 62635, 62243). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Use shorter timeout when we expecting failure
      
      **What this PR does / why we need it**:
      
      Use shorter timeout when we wait pod to not be running or PVC to not be bound
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #55174
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      281f00bc
    • Kubernetes Submit Queue's avatar
      Merge pull request #62523 from wackxu/ldoc · a95d9f0e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 59592, 62308, 62523, 62635, 62243). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
       update comments for local volume
      
      **What this PR does / why we need it**:
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes # https://github.com/kubernetes/kubernetes/issues/62278
      
      **Special notes for your reviewer**:
      /assign @jsafrane @msau42 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      a95d9f0e
    • Kubernetes Submit Queue's avatar
      Merge pull request #62308 from harsh-px/px-resize-master · 607edb82
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 59592, 62308, 62523, 62635, 62243). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Add support to resize Portworx volume
      Signed-off-by: 's avatarHarsh Desai <harsh@portworx.com>
      
      **What this PR does / why we need it**:
      
      This PR adds support in the Portworx volume plugin to expand an existing PVC.
      
      **Which issue(s) this PR fixes**:
      
      Closes #62305
      
      **Release note**:
      
      ```release-note
      Add support to resize Portworx volumes.
      ```
      607edb82
    • Kubernetes Submit Queue's avatar
      Merge pull request #59592 from soltysh/roundtrip_tests · dffe94a0
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 59592, 62308, 62523, 62635, 62243). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Roundtrip test helper for external types
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #54698
      
      **Special notes for your reviewer**:
      /assign @deads2k @sttts 
      Since you've asked for it in the original issue. The FIXME I've pointed out to is worth addressing, but I'd prefer to do it afterwards. Do we want to implement appropriate test for all the api groups from `k8s.io/api` ?
      
      **Release note**:
      ```release-note
      NONE
      ```
      dffe94a0
    • Anago GCB's avatar
      Add CHANGELOG-1.11.md for v1.11.0-alpha.1. · 26778e3f
      Anago GCB authored
      26778e3f
    • Kubernetes Submit Queue's avatar
      Merge pull request #58740 from YuxiJin-tobeyjin/add-ut-for-kuberuntime-gc · c778d871
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      add ut for kuberuntime-gc
      
      **What this PR does / why we need it**:
      Add ut for kuberuntime-gc to cover more situations:
      1) Add two uncovered cases to test sandbox-gc 
      (1)  When there are more than one exited sandboxes,the older exited sandboxes without containers for existing pods should be garbage collected;
      (2)  Even though there are more than one exited sandboxes,the older exited sandboxes with containers for existing pods should not be garbage collected. 
      2) Add one uncovered case to test container-gc
      (1)  To cover the situation when allSourcesReady is set false;
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
       "NONE"
      ```
      c778d871
    • Harsh Desai's avatar
      Add support to resize Portworx volume · adc71854
      Harsh Desai authored
      Closes #62305
      Signed-off-by: 's avatarHarsh Desai <harsh@portworx.com>
      
      update comment and variable references to GiB
      Signed-off-by: 's avatarHarsh Desai <harsh@portworx.com>
      
      explicitly check volume size after resize and fix size volume spec
      Signed-off-by: 's avatarHarsh Desai <harsh@portworx.com>
      
      If Portworx volume is already greater than new size, skip resize
      Signed-off-by: 's avatarHarsh Desai <harsh@portworx.com>
      
      Allow updated volume to be greater than requested size
      Signed-off-by: 's avatarHarsh Desai <harsh@portworx.com>
      adc71854
    • Yann Hodique's avatar
      build/rpms: fix kubeadm rpm · 898320bb
      Yann Hodique authored
      Change #61633 doesn't seem quite correct, and breaks bazel builds.
      This patch makes sure that:
      - there is no conflict between directory files and build targets
      - rpm files are properly packaged after being installed
      898320bb
    • David Eads's avatar
      final record flag cleanup · ecd9a6be
      David Eads authored
      ecd9a6be
    • Kubernetes Submit Queue's avatar
      Merge pull request #62583 from vantuvt/testify_update · 4761788b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62726, 60085, 62583). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Update github.com/stretchr/testify to v1.2.1
      
      cd $GOPATH/src/k8s.io/kubernetes
      hack/godep-restore.sh
      rm -rf Godeps
      rm -rf vendor
      hack/godep-save.sh
      
      
      
      **What this PR does / why we need it**:
      v1.2.1 of Testify includes new functions (e.g., ElementsMatch) that make it easier to compare data structures such as slices.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      
      ```
      4761788b
    • Kubernetes Submit Queue's avatar
      Merge pull request #60085 from jpeeler/remove-podpreset · 43a5c659
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62726, 60085, 62583). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Remove podpreset in local up cluster
      
      This was enabled in 6a7aca31, but
      shouldn't have been since the podpreset implementation is in the process
      of being moved into service-catalog.
      
      Release note:
      ```release-note
      NONE
      ```
      43a5c659
    • Kubernetes Submit Queue's avatar
      Merge pull request #62726 from xiangpengzhao/kubeadm-json-name · 500b63ae
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62726, 60085, 62583). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
       Refactor kubeadm api validation.
      
      **What this PR does / why we need it**:
      This PR refactor kubeadm api validation to use field json name. When users get a validation error, they can easily know which field is invalid in their config files.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      @fabriziopandini I remember we mentioned this refactoring in some comment. I didn't see this change was done, so I send this PR to address this.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      500b63ae
    • David Eads's avatar
      simplify the client cache · df3439c2
      David Eads authored
      df3439c2