- 17 Apr, 2017 17 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Don't check runtime condition for rktnetes rktnetes is not a CRI implementation, and does not provide runtime conditions. This change fixes the issue where rkt will never be considered running from kubelet's point of view.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 44519, 43194, 44513) Use regexp instead of substring to do search and replace. enisoc pointed out how ToLower can change (lengthen even!) the length of a string given arbitrary input. Follow-up to #44421 for #44419
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 44519, 43194, 44513) [Federation] Add type-agnostic e2e crud test This PR proposes an e2e test that reuses the type-agnostic crudtester already used for integration testing to validate crud against a deployed cluster. It is intended to to eventually replace the existing e2e tests for simple types like secrets, but for now will run in addition to the existing testing to gain confidence in the coverage it provides. The deletion corner cases - when orphanDependents is nil or true - do not involve operations in the member clusters and are already well-tested in integration testing and so are not reimplemented here. Where it can be applied, this approach of abstracting a test from its execution environment - making the test 'retargetable' - can reduce the cost of test development since the bulk of the work can be iterated on as an integration test. It can also serve as a check on assumptions made in the integration test about how a deployed environment will behave. cc: @kubernetes/sig-federation-pr-reviews @kubernetes/sig-testing-misc @smarterclayton @derekwaynecarr
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Remove deprecatedPublicIPs field
-
Yu-Ju Hong authored
rktnetes is not a CRI implementation, and does not provide runtime conditions. This change fixes the issue where rkt will never be considered running from kubelet's point of view.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 44560, 44217) [Federation] Move sync controller This PR moves the sync controller to its own package in support of parallel efforts to use it for more types than just secrets. The secret controller unit tests have been retained for now. Once good unit test coverage exists for the sync controller, the existing secret controller unit testing can go away. cc: @kubernetes/sig-federation-pr-reviews @perotinus
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue fix typo TerminalSize **What this PR does / why we need it**: fixes typo in comments **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Maru Newby authored
-
Maru Newby authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue [Federation] Add federated type registry This PR adds a registry for federated types. The goal is to simplify the consumption of federated type configuration by controllers/integration tests/e2e tests/upgrade tests. Consumers can iterate over ``fedtypes.FederatedTypes()``, as per the usage in the crud integration test and controller manager in this PR. The previous name for the the adapter package - ``typeadapters`` - has been changed to ``fedtypes`` to reflect the fact that more than just type adapters are defined there. I'm happy to take suggestions on the name, ``fedtypes`` was just the first thing that came to mind. cc: @kubernetes/sig-federation-pr-reviews
-
Nick Stott authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue change event count type event count type had better to be uint. thx all.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue fix typo in build/common.sh **What this PR does / why we need it**: It fixes the typo in comments in `build/common.sh`: - backgound -> background - stoped -> stopped **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Maru Newby authored
-
Maru Newby authored
-
Maru Newby authored
-
Maru Newby authored
-
- 16 Apr, 2017 3 commits
-
-
StevenYCChou authored
-
Tim Hockin authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue vendor: Update elazarl/goproxy to fix e2e test with go1.8 **What this PR does / why we need it**: This updates the dependency `github.com/elazarl/goproxy` to include this fix https://github.com/elazarl/goproxy/commit/c4fc26588b6ef8af07a191fcb6476387bdd46711 which makes kubernetes e2e tests build with go1.8. It was crashing before as described in https://github.com/elazarl/goproxy/issues/188#issuecomment-281092250 and #38228 **Which issue this PR fixes** This is part of the fix for #38228 **Special notes for your reviewer**: **Release note**: ```release-note ```
-
- 15 Apr, 2017 7 commits
-
-
Tim Hockin authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 44343, 44344) delete ubuntu kube-up ```release-note Remove deprecated ubuntu kube-up deployment. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue delete ovirt kube-up untouched since 2014. I'm not sure what this file is.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Use OS-specific libs when computing client User-Agent in kubectl, etc. **What this PR does / why we need it**: The User-Agent reported by clients (e.g. kubectl) in request headers should include the name of the client executable but not the full path to that executable. This PR changes how this name is determined by using the operating-system specific package "path/filepath" (meant for working with file system paths) instead of the "path" package (meant for URL paths). This fixes a problem on the Windows OS in the case where, if the user has not set their PATH to point to the location of their client executable, the User-Agent includes the full path - which is unnecessary. Fixes: #44419 ```release-note Use OS-specific libs when computing client User-Agent in kubectl, etc. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 44364, 44361, 42498) Fix the certificate rotation threshold and add jitter. Adjusts the certificate rotation threshold to be fixed, with some jitter to spread out the load on the Certificate Signing Request API. The rotation threshold is fixed at 20% now, meaning when 20% of the certificate's total duration is remaining, the certificate manager will attempt to rotate, with jitter +/-10%. For certificates of duration 1 month that means they will rotate after 24 days, +/- 3 days. On a 6000 node cluster, assuming all nodes added at nearly the same time, this should result in 6000 nodes rotating spread over 6 days (total range of the jitter), or ~42 nodes / hour requesting new certificates.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 44364, 44361, 42498) Move v1 helpers The first 3 commits are other PRs. This PR move pkg/api/v1/helpers.go to a subpackage, which is almost symmetric to #44296, where pkg/api/helpers.go was moved. This PR is mostly mechanic, except that 1. moved the 3 methods of Taint and Toleration to pkg/api/methods.go 2. moved constants and types defined in v1/helpers.go to pkg/api/v1/annotataion_key_constants.go and nonstandard_types.go 3. updated staging/copy.sh to copy pkg/api/helpers to client-go, it's otherwise removed from client-go because no other code in client-go depends on the package. Some test code in pkg/controller imports client-go/pkg/api/helpers. After moving api types to its own repo, we can remove these copies of utility function from client-go and ask users to use the ones in the main repo. (This PR breaks a cyclic import problem i met when I tried to move global variables pkg/api/Scheme and Registry to a subpackage)
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue bazel: delete deb that doesn't build cmd/kube-aggregator is long gone.
-
- 14 Apr, 2017 13 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add a few missing binaries to the Bazel SERVER_TARGETS list **What this PR does / why we need it**: catches up our Bazel build with #41413 and #40204. If you have clever ideas of how to keep the lists in `build/release-tars/BUILD` and `hack/lib/golang.sh` in sync I'd love hear them. **Release note**: ```release-note NONE ``` /assign @spxtr @mikedanese
-
Jeffrey Regan authored
**What this PR does / why we need it**: The User-Agent reported by clients (e.g. kubectl) in request headers should include the name of the client executable but not the full path to that executable. This PR changes how this name is determined by using the operating-system specific package "path/filepath" (meant for working with file system paths) instead of the "path" package (meant for URL paths). This fixes a problem on the Windows OS in the case where, if the user has not set their PATH to point to the location of their client executable, the User-Agent unnecessarily includes the full path. Fixes: #44419
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix failing cluster-autoscaler e2e Fix a panic in 2 CA e2e. ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue fix cross-build Fix https://github.com/kubernetes/kubernetes/pull/41543#issuecomment-294207870
-
Chao Xu authored
-
Matt Liggett authored
enisoc pointed out how ToLower can change (lengthen even!) the length of a string given arbitrary input.
-
Jeff Grafton authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40777, 43673) remove an unnecassary variable assignment in glusterfs_test **What this PR does / why we need it**: `path` is exactly the same variable as `volumePath`, which is defined in line 122 . So no needs to assign it. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40777, 43673) create multiple BUILD files in vendor. this should reduce the rebase misery that is vendor/BUILD.
-
Chao Xu authored
-
Mike Danese authored
-
Mike Danese authored
-
Mike Danese authored
-