- 20 Nov, 2017 34 commits
-
-
juanvallejo authored
This patch removes the use of printers.OutputOptions in favor of only having a single struct for setting / passing printer options set by user flags.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Stop using VersionedObject in resource.Builder, use unstructured Remove the need for kubectl callers to distinguish between unstructured and versioned / type aware builders. The factory should create a single builder than can be set to return unstructured objects. Callers can then use one of the new helpers on `resource.Info` to convert the objects into the desired form - `Internal()` for printers, `Typed()` for external versions, and `Unstructured()` to ensure the object is in the right state. Leverages the new scheme support for unstructured conversion so that higher level callers can perform best effort conversion (get typed versions if you have them, otherwise use default behavior). `get.go` demonstrates this by removing the previous logic that depended on the underlying scheme. Other commands are updated to be consistent. Includes #55650 and #55647.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Move of unreachable taint key out of alpha **What this PR does / why we need it**: Move of unreachable taint key out of alpha, which already happened in community doc. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #54198 **Special notes for your reviewer**: Please see #54198 for the context of this inconsistency. **Release note**: ```release-note Move unreachable taint key out of alpha. Please note the existing pods with the alpha toleration should be updated by user himself to tolerate the GA taint. ```
-
Joe Betz authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix potential unexpected object mutation that can lead to data races **What this PR does / why we need it**: In #51526 I introduced an optimization - do a deep copy instead of to and from JSON roundtrip to convert anything that implements `runtime.Unstructured`. I just discovered that the method that is used there `UnstructuredContent()` in both `Unstructured` and `UnstructuredList` may mutate the original object. https://github.com/kubernetes/kubernetes/blob/200875039812d1559555727da74596dc925cfa77/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured/unstructured.go#L87-L92 https://github.com/kubernetes/kubernetes/blob/7c10cbc642b47a8f11a74d5178ebbe76a9588cb6/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured/unstructured_list.go#L58-L75 This is problematic because previously (before #51526) there was no mutation and because this is unexpected and may lead to data races - it is bad behaviour to mutate original object when you just want a copy of it. This PR fixes the issue. Without the fix the tests I've added are failing because when comparison is done original object is not the same: ``` converter_test.go:154: Object changed, diff: object.Object[items]: a: []interface {}{} b: <nil> converter_test.go:154: Object changed, diff: object.Object[items]: a: []interface {}{map[string]interface {}{"kind":"Pod"}} b: <nil> ``` However the underlying issue is not fixed here - `UnstructuredContent()` is brittle and dangerous. Method name does not imply that it mutates data when you call it. And godoc does not mention that either: https://github.com/kubernetes/kubernetes/blob/509df603b18d356777176953e5d160b6f3d0bba9/staging/src/k8s.io/apimachinery/pkg/runtime/interfaces.go#L233-L249 Something needs to be done about it IMO. Also `UnstructuredContent()` implementation in `UnstructuredList` does not implement the behaviour required by godoc in `runtime.Unstructured`. **Release note**: ```release-note NONE ``` /kind bug /sig api-machinery /assign @sttts
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55974, 54701). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Refactor `reconcileAutoscaler` method in hpa **What this PR does / why we need it**: There have been a couple of recent bugs in the "normalizing" part of the `reconcileAutoscaler` method. This part of the code base is responsible for, among other things, taking the suggested desired replicas based on the metrics, ensuring it conforms to certain conditions, and updating it if it does not. Isolate the part that converts the desired replicas based on a given set of rules into its own function. We are refactoring this part of the code base to make the logic simpler and to make it easier to write unit tests. **Which issue this PR fixes**: Fixes #53728 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Allow constructing spdy executor from existing transports If you already have an existing transport, it is not always possible to reconstruct a client config from it. Allow constructing a spdy executor, given a connection/upgrade transport ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55963, 55790, 55670, 55931). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. add GRS, RAGRS storage account type support for azure disk **What this PR does / why we need it**: add Standard_GRS, Standard_RAGRS storage account type support for azure disk, and Standard_ZRS, Premium_GRS are not supported for azure disk now **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #55774 **Special notes for your reviewer**: **Release note**: ``` add Standard_GRS, Standard_RAGRS support for azure disk ``` /sig azure @rootfs @brendanburns
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55963, 55790, 55670, 55931). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. include error message for volumeManager during attach and mount **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #55609 **Special notes for your reviewer**: /assign @jsafrane @jingxu97 **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55963, 55790, 55670, 55931). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. admission/webhook: move webhook initializer into plugin Follow-up of https://github.com/kubernetes/kubernetes/pull/55132. Non-generic plugin intitializers should go into the admission plugin itself. No need leak that into the generic apiserver. Keeping them contained in the webhook package makes it easier (it was already possible) for extension apiservers to provide one, but we don't need to leak it into the generic plugin initializer.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. apiserver: remove unneeded scheme from registry tester Follow-up of https://github.com/kubernetes/kubernetes/pull/55622, removing an unused scheme.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55217, 54260). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Unit tests for Azure service session affinity **What this PR does / why we need it**: We added session affinity support in the Azure load balancer in commit https://github.com/kubernetes/kubernetes/commit/8b50b83067468b6ee75fdef8194ca76b00c326ec. This PR adds unit tests for this behaviour. **Which issue this PR fixes**: None **Special notes for your reviewer**: None **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55217, 54260). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Checking Cinder disk when tickers are delivered Cinder's WaitForAttach() runs probeAttachedVolume() 2 times per second(L243 and L247), that triggers SCSI rescan and generates many udev "change" events. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55615, 56010, 55990). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Master now supports staged upgrades. It will wait until specifically told to upgrade with an action unless the configuration option require-manual-upgrade is false and then master nodes will upgrade immediately. **What this PR does / why we need it**: This update alters the kubernetes-master upgrade path for juju charms. It makes the master act like the worker in that it blocks the upgrade until each unit is specifically requested to update. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: PR for tests coming momentarily to juju-solutions/kubernetes-jenkins **Release note**: ```release-note Upgrading the kubernetes-master units now results in staged upgrades just like the kubernetes-worker nodes. Use the upgrade action in order to continue the upgrade process on each unit such as `juju run-action kubernetes-master/0 upgrade` ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55615, 56010, 55990). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Unstructured cleanups **What this PR does / why we need it**: Cleanups for `Unstructured`/`UnstructuredList` extracted from #55297. **Release note**: ```release-note NONE ``` /sig api-machinery /kind enhancement /assign @sttts
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bump Heapster version to 1.5.0-beta.1 **What this PR does / why we need it**: Bumps Heapster version to 1.5.0-beta.1 **Which issue(s) this PR fixes**: Fixes #54962 **Special notes for your reviewer**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix representation of the pv's capacity which provisioned by glusterfs **What this PR does / why we need it**: This PR fixes representation of the pv's capacity which provisioned by glusterfs. Gluster's volume size is calculated in GB, and than this value is setted as GiB for pv's storage capacity. **Which issue(s) this PR fixes**: Fixes #55937 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Di Xu authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add kawych to cluster-monitoring deployment owners **What this PR does / why we need it**: Add kawych to cluster-monitoring deployment owners ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix a typo. **Release note**: ```release-note NONE ```
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Using ipset doing SNAT and packet filter in IPVS kube-proxy **What this PR does / why we need it**: Try ipset in ipvs proxy mode. **Which issue this PR fixes**: fixes #54203 xref: #53393, #53775 **Special notes for your reviewer**: **Release note**: ```release-note Using ipset doing SNAT and packet filtering in IPVS kube-proxy ``` /sig network /area kube-proxy
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. NetworkPolicy e2e: named port egress test **What this PR does / why we need it**: Add an e2e NetworkPolicy test that ensures that an egress rule that specifies a named port properly applies to egress traffic. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #52040 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Clayton Coleman authored
It needs both internal and versioned - use the new helpers to detect that
-
Clayton Coleman authored
Callers must take a dependency on one or the other set of conversions and default client behavior. Future changes may add a Versioned() type, but this is an accurate reflection of current code state.
-
Clayton Coleman authored
The unified RESTMapper and Typer follow the new rules, but on error will fallback to the legacy path (while still supporting Unstructured objects). This allows callers to handle the appropriate distinction themselves if necessary. Add a LocalParam() method to the resource.Builder that DRYs up a large chunk of complicated code in set commands.
-
Clayton Coleman authored
Also remove error messages that depended on ObjectKinds() - future changes will potentially remove this interface and the replacements here are equivalent.
-
Clayton Coleman authored
Delays the error until the first call and then preserves it for others. More closely matches the intent of the Object() calls. Loaders are now lazy and don't need to return errors directly. Sets the stage for collapsing unstructured and structured builders together.
-
Clayton Coleman authored
Latest always refreshes from the server, and the server will return the updated object. In this case, we want to only access the local file.
-
Clayton Coleman authored
Reduce all uses of Unstructured to the simpler form, and avoid asking for mapper or typer unless it is required. Use Typed() for places that previously used VersionedObject, and remove paths for versioned objects from code that is now using unstructured.
-
Clayton Coleman authored
Demonstrate its use with get.go by removing the need to call decode with a hardcoded scheme. Add tests to get_test.go to restore proving that unstructured conversion is possible.
-
Clayton Coleman authored
resource.Builder should be aware of both paths, and the caller is responsible for determining the different path via use.
-
Clayton Coleman authored
This reverts commit 06c5be98.
-
- 19 Nov, 2017 6 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add a new scheduling queue based on priority queue. **What this PR does / why we need it**: This PR is a part of solution to fix potential starvation of pods in pod preemption. It adds a different scheduling queue to the scheduler that allows highest priority pods to be scheduled before other pods. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: I tried enabling this queue and made sure that our existing tests pass with this queue enabled. **Release note**: ```release-note Add a new scheduling queue that helps schedule the highest priority pending pod first. ``` /sig scheduling ref/ #54501 ref/ #47604
-
Bobby (Babak) Salamat authored
-
Bobby (Babak) Salamat authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55939, 56007). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix bad return error text **What this PR does / why we need it**: fix bad return error text **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Improve documentation for kubeadm phases **What this PR does / why we need it**: This PR is part of the effort for improving kubeadm reference doc (CLI, website, manpages), and more specifically improves documentation for: - kubeadm alpha phase certs - kubeadm alpha phase kubeconfig - kubeadm alpha phase controlplane - kubeadm alpha phase etcd - kubeadm alpha phase uploadconfig - kubeadm alpha phase addons - kubeadm alpha phase selfhosting **Which issue(s) this PR fixes**: part of the effort for [#265](https://github.com/kubernetes/kubeadm/issues/265) **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Re-engineer the kubeadm join logic. **What this PR does / why we need it**: - wait for the kubelet to create `/etc/kubernetes/kubelet.conf` - use those credentials to PATCH the node **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: ref: https://github.com/kubernetes/kubeadm/issues/28#issuecomment-345502933 **Special notes for your reviewer**: /cc @kubernetes/sig-cluster-lifecycle-pr-reviews **Release note**: ```release-note NONE ```
-