1. 16 Sep, 2017 8 commits
  2. 15 Sep, 2017 32 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #52539 from piosz/metrics-v1alpha1 · c4f3017f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Do not install metrics/v1alpha1 by default
      
      We want to have `metrics/v1alpha1` in the repo in order to support the previous version of HPA, but we don't want to install them by default.
      
      ref https://github.com/kubernetes-incubator/metrics-server/pull/15
      c4f3017f
    • fabriziopandini's avatar
      fix addon error · d21040b8
      fabriziopandini authored
      d21040b8
    • Piotr Szczesniak's avatar
      cc072e86
    • Kubernetes Submit Queue's avatar
      Merge pull request #52518 from xiangpengzhao/move-out-1.3-release-notes · 98ed5dd8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Move 1.3.* release notes out of CHANGELOG.md
      
      **What this PR does / why we need it**:
      The latest CHANGELOG almost reach the size of 1M again. Move 1.3 release notes out of CHANGELOG.md
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      ref: #48985 #52174
      
      **Special notes for your reviewer**:
      I wish I could split all <1.7 releases in one PR, but it's a bit painful to do that way. So I just split each release at a time.
      
      /cc @jdumars @dchen1107 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      98ed5dd8
    • Kubernetes Submit Queue's avatar
      Merge pull request #52544 from shyamjvs/increase-window-of-prometheus-metric · 9ef9a1b8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Increase sliding window to 5hr for request_latencies metric
      
      We're seeing high latency values for a couple of types of api calls in our density test (ref https://github.com/kubernetes/kubernetes/issues/51899). And we're recording values from only the last 1 hour in the metric (as @wojtek-t told me offline) - so our test result is pretty much counting only the calls during the delete phase.
      
      cc @kubernetes/sig-scalability-misc @kubernetes/sig-api-machinery-misc @gmarek
      9ef9a1b8
    • Kubernetes Submit Queue's avatar
      Merge pull request #52536 from aleksandra-malinowska/revert-update-addon-resizer-version · d7770f9c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Revert "Update addon-resizer version"
      
      This reverts #46850 due to several issues with new version of addon resizer (#50599, #52535), as recommended by @piosz. 
      
      cc @fgrzadkowski @x13n
      d7770f9c
    • Kubernetes Submit Queue's avatar
      Merge pull request #52543 from shyamjvs/add-more-traces-to-delete-resource-handler · 9f954c14
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add extra steps to delete resource handler trace
      
      Based on https://github.com/kubernetes/kubernetes/issues/51899#issuecomment-329786131
      
      cc @kubernetes/sig-scalability-misc @kubernetes/sig-api-machinery-misc @gmarek
      9f954c14
    • Piotr Szczesniak's avatar
      Bumped Metrics Server to v0.2.0 · c632649e
      Piotr Szczesniak authored
      c632649e
    • Shyam Jeedigunta's avatar
      6089cada
    • Shyam Jeedigunta's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #52223 from bsalamat/approver · 9aef242a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 51796, 52223)
      
      Add bsalamat to sig-scheduling-maintainers
      
      **What this PR does / why we need it**:
      Adds bsalamat to sig-scheduling-maintainers.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # N/A
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      
      @kubernetes/sig-scheduling-pr-reviews @davidopp @timothysc @k82cn @wojtek-t
      9aef242a
    • Kubernetes Submit Queue's avatar
      Merge pull request #51796 from Dirbaio/fix/pod-node-switch · ea22affd
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 51796, 52223)
      
      Fix pod and node names switched around in error message.
      
      **What this PR does / why we need it**: This PR fixes a pod name and a node name switched around in an error message from the daemon controller.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: No issue that I know of
      
      **Special notes for your reviewer**: -
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      ea22affd
    • Aleksandra Malinowska's avatar
      Revert "Update addon-resizer version" · 68d3a9db
      Aleksandra Malinowska authored
      This reverts commit 63ccedcf.
      68d3a9db
    • Kubernetes Submit Queue's avatar
      Merge pull request #52476 from clamoriniere1A/bugfix/e2e_job_backoff_flaky · 87a1b5f6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Bugfix: Fix e2e Flaky Apps/Job BackoffLimit test
      
      This fix is linked to the PR #51153 that introduce the `JobSpec.BackoffLimit`.
      
      Previously the Timeout used in the test was too aggressive and generates flaky test execution. Now it used the default `framework.JobTimeout` used in others tests.
      
      
      
      **What this PR does / why we need it**:
      This PR should fix flaky "[sig-apps] Job should exceed backoffLimit" test, due to a too short timeout duration.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      fixes #51153 
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      87a1b5f6
    • Karol Wychowaniec's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #52290 from jiayingz/deviceplugin-failure · b5fbd71b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52452, 52115, 52260, 52290)
      
      Fixes device plugin re-registration handling logic to make sure:
      
      - If a device plugin exits, its exported resource will be removed.
      - No capacity change if a new device plugin instance comes up to replace the old instance.
      
      
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes https://github.com/kubernetes/kubernetes/issues/52510
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      b5fbd71b
    • Kubernetes Submit Queue's avatar
      Merge pull request #52260 from andyzhangx/azuremounter-issue · b7953a78
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52452, 52115, 52260, 52290)
      
      fix azure disk mounter issue
      
      **What this PR does / why we need it**:
      fix azure disk mounter issue, it's a P1 bug, it exists in 1.7, 1.8 release, should cherry pick to 1.7, 1.8
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      fixes #52261 
      
      consider following issue: 
      1) A pod mounting an azure disk in a k8s agent
      2) The kubelet is restarted in that k8s agent
      3) The pod could not start up, it always reports error as following:
      
        4d            1m              3065    kubelet, 14777acs9000                   Warning         FailedMount     MountVolume.SetUp failed for volume "pvc-7a0cdeb9-92c7-11e7-b86b-000d3a36d70c" : azureDisk - No
      t a mounting point for disk andykubewin175-dynamic-pvc-7a0cdeb9-92c7-11e7-b86b-000d3a36d70c on \var\lib\kubelet\pods\d146c023-92c7-11e7-b86b-000d3a36d70c\volumes\kubernetes.io~azure-disk\pvc-7a0cdeb9-92c7-11
      e7-b86b-000d3a36d70c
        4d            1m              3157    kubelet, 14777acs9000                   Warning         FailedMount     Error syncing pod
      
      **Special notes for your reviewer**:
      If you take a look at following implementation of vsphere or gce, it will return nil instead of error:
      https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/vsphere_volume/vsphere_volume.go#L217-L220
      https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/gce_pd/gce_pd.go#L273-L275
      
      The logic of return info parsing here, it's wrong to return error
      https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/util/operationexecutor/operation_generator.go#L469-L475
      
      **Release note**:
      
      ```release-note
      ```
      b7953a78
    • Kubernetes Submit Queue's avatar
      Merge pull request #52115 from jcbsmpsn/flag-enable-kubelet-certificate-rotation · 0c1dcb01
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52452, 52115, 52260, 52290)
      
      Add env var to enable kubelet rotation in kube-up.sh.
      
      Fixes https://github.com/kubernetes/kubernetes/issues/52114
      
      ```release-note
      Adds ROTATE_CERTIFICATES environment variable to kube-up.sh script for GCE
      clusters. When that var is set to true, the command line flag enabling kubelet
      client certificate rotation will be added to the kubelet command line.
      ```
      0c1dcb01
    • Kubernetes Submit Queue's avatar
      Merge pull request #52452 from gnufied/fix-quota-on-update · 935726f1
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52452, 52115, 52260, 52290)
      
      Fix support for updating quota on update
      
      This PR implements support for properly handling quota when resources are updated. We never take negative values and add them up.
      
      Fixes https://github.com/kubernetes/kubernetes/issues/51736 
      
      cc @derekwaynecarr 
      
      /sig storage
      
      ```release-note
      Make sure that resources being updated are handled correctly by Quota system
      ```
      935726f1
    • Kubernetes Submit Queue's avatar
      Merge pull request #52237 from smarterclayton/watch_metric · 93ddb7be
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 51824, 50476, 52451, 52009, 52237)
      
      Improve apiserver metrics reporting
      
      Normalize "WATCHLIST" to "WATCH", add "scope" to the other metrics (listing 50k pods is != listing pods in a namespace), and add a new scope "resource" to cover individual resource calls.
      
      This roughly aligns metrics with our ACL model (technically resource scope is GET, but POST to a subresource and POST to a namespace are not the same thing).
      
      ```release-note
      WATCHLIST calls are now reported as WATCH verbs in prometheus for the apiserver_request_* series.  A new "scope" label is added to all apiserver_request_* values that is either 'cluster', 'resource', or 'namespace' depending on which level the query is performed at.
      ```
      93ddb7be
    • Kubernetes Submit Queue's avatar
      Merge pull request #52009 from zjj2wry/export-svc · 6b546280
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 51824, 50476, 52451, 52009, 52237)
      
      fix issue(#47976)Invalid value error when creating service from expor…
      
      …ted config
      
      
      
      **What this PR does / why we need it**:
      close issue #47976
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      6b546280
    • Kubernetes Submit Queue's avatar
      Merge pull request #52451 from yujuhong/enable-cri-stats · 86dc5fce
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 51824, 50476, 52451, 52009, 52237)
      
      kubelet: enable CRI container metrics
      
      Fixes #46984
      86dc5fce
    • Kubernetes Submit Queue's avatar
      Merge pull request #50476 from caesarxuchao/plumb-proxy · 7181dd49
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 51824, 50476, 52451, 52009, 52237)
      
      Plumbing the proxy dialer to the webhook admission plugin
      
      * Fixing https://github.com/kubernetes/kubernetes/issues/49987. Plumb the `Dial` function to the `transport.Config`
      * Fixing https://github.com/kubernetes/kubernetes/issues/52366. Let the webhook admission plugin sets the `TLSConfg.ServerName`.
      
      I tested it in my gke setup. I don't have time to implement an e2e test before 1.8 release. I think it's ok to add the test later, because *i)* the change only affects the alpha webhook admission feature, and *ii)* the webhook feature is unusable without the fix. That said, it's up to my reviewer to decide.
      
      Filed https://github.com/kubernetes/kubernetes/issues/52368 for the missing e2e test.
      
      ( The second commit is https://github.com/kubernetes/kubernetes/pull/52372, which is just a cleanup of client configuration in e2e tests. It removed a function that marshalled the client config to json and then unmarshalled it. It is a prerequisite of this PR, because this PR added the `Dial` function to the config which is not json marshallable.)
      
      ```release-note
      Fixed the webhook admission plugin so that it works even if the apiserver and the nodes are in two networks (e.g., in GKE).
      Fixed the webhook admission plugin so that webhook author could use the DNS name of the service as the CommonName when generating the server cert for the webhook.
      
      Action required:
      Anyone who generated server cert for admission webhooks need to regenerate the cert. Previously, when generating server cert for the admission webhook, the CN value doesn't matter. Now you must set it to the DNS name of the webhook service, i.e., `<service.Name>.<service.Namespace>.svc`.
      ```
      7181dd49
    • Kubernetes Submit Queue's avatar
      Merge pull request #51824 from ihmccreery/oss-mdc · b3e641d7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 51824, 50476, 52451, 52009, 52237)
      
      Allow metadata firewall & proxy on in GCE, off by default
      
      **What this PR does / why we need it**: Add necessary variables in kube-env to allow a user to turn on metadata firewall and proxy for K8s on GCE.
      
      Ref #8867.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: 
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      GCE users can enable the metadata firewall and metadata proxy with KUBE_FIREWALL_METADATA_SERVER and ENABLE_METADATA_PROXY, respectively.
      ```
      b3e641d7
    • Kubernetes Submit Queue's avatar
      Merge pull request #51781 from bsalamat/preemption_tests · 9d8c1192
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52442, 52247, 46542, 52363, 51781)
      
      Add more tests for pod preemption
      
      **What this PR does / why we need it**:
      Adds more e2e and integration tests for pod preemption.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      This PR is based on #50949. Only the last commit is new.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      
      ref/ #47604
      
      @kubernetes/sig-scheduling-pr-reviews @davidopp
      9d8c1192
    • Kubernetes Submit Queue's avatar
      Merge pull request #52363 from balajismaniam/fix-cpuman-restartpol-never-bug · ce5c41ab
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52442, 52247, 46542, 52363, 51781)
      
      Make CPU manager release CPUs when Pod enters completed phase. 
      
      **What this PR does / why we need it**: When CPU manager is enabled, this PR releases allocated CPUs when container is not running and is non-restartable. 
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #52351
      
      **Special notes for your reviewer**:
      This bug is only reproduced for pods with `restartPolicy` = `Never` or `OnFailure`.  The following output is from a 4 CPU node. This bug can be reproduced as long >= half the cores are requested. 
      
      pod1.yaml:
      ```
      apiVersion: v1
      kind: Pod
      metadata:
        name: test-pod1
      spec:
        containers:
        - image: ubuntu
          command: ["/bin/bash"]
          args: ["-c", "sleep 5"]
          name: test-container1
          resources:
            requests:
              cpu: 2
              memory: 100Mi
            limits:
              cpu: 2
              memory: 100Mi
        restartPolicy: "Never"
      ```
      
      pod2.yaml:
      ```
      apiVersion: v1
      kind: Pod
      metadata:
        name: test-pod2
      spec:
        containers:
        - image: ubuntu
          command: ["/bin/bash"]
          args: ["-c", "sleep 5"]
          name: test-container1
          resources:
            requests:
              cpu: 2
              memory: 100Mi
            limits:
              cpu: 2
              memory: 100Mi
        restartPolicy: "Never"
      ```
      Run a local Kubernetes cluster with CPU manager enabled. 
      ```sh
      KUBELET_FLAGS='--feature-gates=CPUManager=true --cpu-manager-policy=static --cpu-manager-reconcile-period=1s --kube-reserved=cpu=500m' ./hack/local-up-cluster.sh
      ```
      _Before:_
      Create `test-pod1` using pod1.yaml. 
      ```
      ./cluster/kubectl.sh create -f pod1.yaml
      ```
      Wait for the pod to complete and wait another 90 seconds (give enough time for GC to kick-in). 
      
      Create `test-pod2` using pod2.yaml. 
      ```
      ./cluster/kubectl.sh create -f pod2.yaml
      ```
      
      Get all pods in the cluster. 
      ```
      ./cluster/kubectl.sh get pods -a
      NAME        READY     STATUS                                         RESTARTS   AGE
      test-pod1   0/1       Completed                                      0          1m
      test-pod2   0/1       not enough cpus available to satisfy request   0          9s
      ```
      
      _After:_
      Create `test-pod1` using pod1.yaml. 
      ```
      ./cluster/kubectl.sh create -f pod1.yaml
      ```
      Wait for the pod to complete and wait another 90 seconds (give enough time for GC to kick-in). 
      
      Create `test-pod2` using pod2.yaml. 
      ```
      ./cluster/kubectl.sh create -f pod2.yaml
      ```
      
      Get all pods in the cluster. 
      ```
      ./cluster/kubectl.sh get pods -a
      NAME        READY     STATUS      RESTARTS   AGE
      test-pod1   0/1       Completed    0          1m
      test-pod2   0/1       Completed    0          9s
      ```
      ce5c41ab
    • Kubernetes Submit Queue's avatar
      Merge pull request #46542 from derekwaynecarr/quota-ignore-pod-whose-node-lost · 20a4112e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52442, 52247, 46542, 52363, 51781)
      
      Ignore pods for quota marked for deletion whose node is unreachable
      
      **What this PR does / why we need it**:
      Traditionally, we charge to quota all pods that are in a non-terminal phase.  We have a user report that noted the behavior change in kube 1.5 for the node controller to no longer force delete pods whose nodes have been lost.  Instead, the pod is marked for deletion, and the reason is updated to state that the node is unreachable.  The user expected the quota to be released.  If the user was at their quota limit, their application may not be able to create a new replica given the current behavior.  As a result, this PR ignores pods marked for deletion that have exceeded their grace period.
      
      **Which issue this PR fixes**
      xref https://bugzilla.redhat.com/show_bug.cgi?id=1455743
      fixes https://github.com/kubernetes/kubernetes/issues/52436
      
      **Release note**:
      ```release-note
      Ignore pods marked for deletion that exceed their grace period in ResourceQuota
      ```
      20a4112e
    • Kubernetes Submit Queue's avatar
      Merge pull request #52247 from wackxu/atd · 1646db0b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52442, 52247, 46542, 52363, 51781)
      
      Add some test case in default_test.go
      
      **What this PR does / why we need it**:
      
      Add some test case in default_test.go
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      1646db0b
    • Kubernetes Submit Queue's avatar
      Merge pull request #52442 from crassirostris/sd-logging-e2e-fix-trimming · 2c81db53
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      [fluentd-gcp addon] Remove some e2e tests out of blocking suites
      
      Fixes https://github.com/kubernetes/kubernetes/issues/52433
      
      Some Stackdriver Logging e2e tests are broken in release-blocking suites:
      
      - Due to the change in Docker 1.13, on some systems logs are automatically split by 16K chunks. This PR removes an e2e test that assumes otherwise
      - In large clusters, it's not possible to ingest system logs from all nodes
      
      Since it's not a Kubernetes problem per se, mitigating this by removing these tests from blocking suites.
      2c81db53
    • Dong Liu's avatar
      a53b0c3f
    • Kubernetes Submit Queue's avatar
      Merge pull request #50012 from deads2k/cli-17-discovery · e190f391
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      use specified discovery information if possible
      
      Fixes https://github.com/kubernetes/kubernetes/issues/49948
      
      This uses the available discovery information if available, but it seems we never updated "normal" resources to show the singular name, so its often not available.  I've left this code compatible.
      
      @enisoc @ash2k 
      @kubernetes/sig-api-machinery-misc 
      
      ```release-note
      custom resources that use unconventional pluralization now work properly with kubectl and garbage collection
      ```
      e190f391
    • xiangpengzhao's avatar
      c2012fc5