1. 13 May, 2016 6 commits
    • k8s-merge-robot's avatar
      Merge pull request #22807 from eparis/godep-v57 · d2ef57a7
      k8s-merge-robot authored
      Automatic merge from submit-queue
      
      Update to support latest godep
      
      godep v53 and earlier included all subdirs of includes in ./...
      godep v54 and later only includes the exact packages required.
      
      So all of the 'extra' packages which were subdirs but were dead code are removed.
      
      That bit us because both codecgen and ginkgo are binaries which we got by chance in Godeps. When godep started tracking exactly what was needed instead of just grabbing entire subdirs we lost those binaries. To solve that problem godeps now have to be built with `godep save ginko codecgen ./...` so that that it explicitly pulls in those two packages. Because no one will ever remember that, I created a script in hack which lists those deps explicitly.
      
      The better import tacking also means that it lists every single package included (transitively) in Godeps.json. Which I believe makes the godep license concatenator from @karlkfi explode in size.
      
      But from an actual 'code that was built' PoV, and easy way to test is to see if a build with and without this PR have any difference. They should be identical.
      
      <!-- Reviewable:start -->
      ---
      This change is [<img src="http://reviewable.k8s.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](http://reviewable.k8s.io/reviews/kubernetes/kubernetes/22807)
      <!-- Reviewable:end -->
      d2ef57a7
    • k8s-merge-robot's avatar
      Merge pull request #25065 from derekwaynecarr/pod_worker_updates · a503bcd7
      k8s-merge-robot authored
      Automatic merge from submit-queue
      
      PodWorkers UpdatePod takes options struct
      
      First commit from https://github.com/kubernetes/kubernetes/pull/24843 
      
      Second commit:
      The `PodWorkers.UpdatePod` operation is updated as follows:
      * use options struct to pass arguments
      * add a pod status func to allow override status
      * add pod termination grace period if sync operation requires a kill pod
      * add a call-back that is error aware
      
      Third commit:
      Add a `killPodNow` to kubelet that does a blocking kill pod call that properly integrates with pod workers.
      
      The plan is to pass `killPodNow` as a function pointer into the out of resource killer.
      
      ```
      // KillPodFunc kills a pod.
      // The pod status is updated, and then it is killed with the specified grace period.
      // This function must block until either the pod is killed or an error is encountered.
      // Arguments:
      // pod - the pod to kill
      // status - the desired status to associate with the pod (i.e. why its killed)
      // gracePeriodOverride - the grace period override to use instead of what is on the pod spec
      type KillPodFunc func(pod *api.Pod, status api.PodStatus, gracePeriodOverride *int64) error
      ```
      
      You can see it being used here in the WIP out of resource killer PR.
      
      https://github.com/kubernetes/kubernetes/pull/21274/commits/1344f858fba956c285eba6c418a3008576cd3843#diff-92ff0f643237f29824b4929574f84609R277
      
      /cc @vishh @yujuhong @pmorie 
      a503bcd7
    • Tim Hockin's avatar
      Update docs re: godep · 0114eef8
      Tim Hockin authored
      0114eef8
    • Eric Paris's avatar
      b4f5108d
    • Eric Paris's avatar
      Stop pinning to version v53 · ad3e18d6
      Eric Paris authored
      ad3e18d6
    • Eric Paris's avatar
      Create a script to update godeps · 5543e2e3
      Eric Paris authored
      Since its hard for an individual to remember that we need codecgen and
      ginkgo in godeps but don't actually have that dependancy listed in a way
      that godep can automatically find.
      5543e2e3
  2. 12 May, 2016 34 commits