- 21 Feb, 2018 24 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59901, 59302, 59928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Reformat and update error strings. Signed-off-by:
Humble Chirammal <hchiramm@redhat.com> **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59901, 59302, 59928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add more tests for Azure routes. This builds off of #59165 Please only review https://github.com/kubernetes/kubernetes/pull/59302/commits/a8d0e73234f0dc047966b7c6c660ac5344113780
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59901, 59302, 59928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Rename StorageProtection to StorageObjectInUseProtection Rename StorageProtection to StorageObjectInUseProtection **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #59639 **Special notes for your reviewer**: **Release note**: ```release-note Rename StorageProtection to StorageObjectInUseProtection ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Make sure node pool is deleted in autoscaler e2e tests. Currently, if node pool creation succeeds, but we fail to get initial pool size, the node pool does not get deleted. **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add criSocket to kubeadm MasterConfiguration manifest **What this PR does / why we need it**: Adds a criSocket field to the MasterConfiguration manifest used by kubeadm. This field configures the cri socket that kubeadm uses during preflight checks. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # kubernetes/kubeadm#679 **Special notes for your reviewer**: kubeadm does not allow the use of --config and the --cri-socket flag together. When using kubeadm to create a cluster that will not be using docker, the preflight checks fail since this is not configurable. This PR adds the criSocket to the MasterConfiguration manifest and uses that value within the MasterConfiguration if it was provided. Storing the value of the criSocket within the MasterConfiguration manifest will also make joining additional masters with the proposed 'kubeadm join --master' command by not requiring operators to remember to include an additional flag. This may not be the case if we instead relaxed the constraint of using additional flags when using the --config flag is set. **Release note**: /area kubeadm /assign @luxas /cc @kubernetes/sig-cluster-lifecycle-pr-reviews ```release-note kubeadm: add criSocket field to MasterConfiguration manifiest ```
-
Beata Skiba authored
Currently, if node pool creation succeeds, but we fail to get initial pool size, the node pool does not get deleted.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix getting pool size in autoscaling e2e tests Command fails due to missing quotation marks, causing tests to fail: ```I0221 01:01:09.140] I0221 01:01:09.138464 1873 cluster_size_autoscaling.go:956] Executing: gcloud container node-pools describe extra-pool --quiet --cluster=e2e-5481 --format=value(initialNodeCount) --zone=us-central1-f --project=k8s-e2e-gci-gke-autoscaling I0221 01:01:09.842] I0221 01:01:09.842393 1873 cluster_size_autoscaling.go:1331] Node-pool initial size: I0221 01:01:09.843] [AfterEach] [sig-autoscaling] Cluster size autoscaling [Slow] ``` ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59292, 59600). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix some minor misspells using misspell **What this PR does / why we need it**: Fixes some misspells detected with misspell that might become handy when merging #59463 . I saw that other files were already taken care of in other PR. Added those I didn't see fixed here. **Special notes for your reviewer**: I'm not 100% sure if the files in the api dir are supposed to be updated manually. I can revert that part if not. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59292, 59600). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add criSocket to kubeadm NodeConfiguration manifest **What this PR does / why we need it**: Adds a criSocket field to the NodeConfiguration manifest used by kubeadm. This field configures the cri socket that kubeadm uses during preflight checks. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # kubernetes/kubeadm#679 **Special notes for your reviewer**: This is a follow up PR, as requested, to https://github.com/kubernetes/kubernetes/pull/59057. The NodeConfiguration manifest now has a criSocket field that can be used when using the config manifest to join a node to the cluster. **Release note**: /area kubeadm /assign @luxas /cc @kubernetes/sig-cluster-lifecycle-pr-reviews ```release-note kubeadm: add criSocket field to NodeConfiguration manifiest ```
-
Aleksandra Malinowska authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bump runc to latest and modify test cases for linux cgroup manager. **What this PR does / why we need it**: This PR has 2 commits - Bumps runc to latest and fixes trailing "/" problem in ExpandSlice of runc - Fixes the cgroup_manager_linux_tests.go test cases to have "/" as prefix. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #59993 **Special notes for your reviewer**: cc @sjenning @derekwaynecarr **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix typo in CHANGELOG-1.10.md. **What this PR does / why we need it**: Just a typo fix. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: None **Special notes for your reviewer**: **Release note**: Not needed
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Improve scheduling queue's logic **What this PR does / why we need it**: Improves scheduling queue's code based on some recent comments on [the original PR](https://github.com/kubernetes/kubernetes/pull/55109). This PR does not fix any bugs or make any change of behavior. **Release note**: ```release-note NONE ``` /sig scheduling
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix golint warnings in daemon controller This fixes the golint errors in the daemon controller package. The only on remaining asks to rename DaemonSetsController, which is a public interface and would need proper deprecation first. **Special notes for your reviewer**: **Release note**: I don't believe a release note is required. It only fixes code comments. ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59934, 60098, 60103, 60104, 60109). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. [e2e ingress-gce] Bump num of ingresses for scale test **What this PR does / why we need it**: Finally we got enough quota. Bumping num of ingresses for scale test accordingly. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #NONE **Special notes for your reviewer**: /assign @bowei @rramkumar1 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59934, 60098, 60103, 60104, 60109). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Returning an empty array instead of returning an array with empty string for kubemci get status This is required since the caller checks if `len(returnedArray) == 0` which fails for `[]string{""}` cc @madhusudancs @G-Harmon /assign @madhusudancs ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59934, 60098, 60103, 60104, 60109). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. cloud: don't require application default credentials to run unit tests Introduced in https://github.com/kubernetes/kubernetes/pull/59490 ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59934, 60098, 60103, 60104, 60109). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix running with no eviction thresholds **What this PR does / why we need it**: After https://github.com/kubernetes/kubernetes/pull/57802, [LocalStorageCapacityIsolationEviction tests](https://k8s-testgrid.appspot.com/sig-node-kubelet#kubelet-serial-gce-e2e&include-filter-by-regex=LocalStorageCapacityIsolationEviction) started failing. They failed because the eviction manager was not running its synchronization loops when we have no thresholds. We should still perform the eviction manager synchronization loop even when we have no thresholds if the LocalStorageCapacityIsolation feature gate is enabled. The reason we didn't see this before is that we added a threshold for node allocatable even when there was no corresponding eviction threshold. https://github.com/kubernetes/kubernetes/pull/57802 changed this to only add a memory allocatable threshold when we have a memory eviction threshold specified. **Release note**: ```release-note NONE ``` /kind bug /priority critical-urgent /sig node /assign @Random-Liu cc @kubernetes/sig-node-test-failures
-
NickrenREN authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. svcacct: make token authenticator fully generic so it can be used for both new and legacy svcacct tokens. Also move the legacy validator into legacy.go. part of https://github.com/kubernetes/kubernetes/issues/58790 ```release-note NONE ```
-
Bobby (Babak) Salamat authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove resources that were moved to kubernetes/examples repo **What this PR does / why we need it**: The Elasticsearch example was moved to kubernetes/example repo. This is a clean-up PR. **Which issue(s) this PR fixes**: Closes #53142 **Special notes for your reviewer**: /cc @mcandre @dims **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix device unmap for non-attachable plugin case **What this PR does / why we need it**: This PR fixes following problem. - If plugin is non-attachable, global unmap path isn't stored in asw, then plugin fails to unmap volume. To store the path, this PR moves MarkDeviceAsMounted operation from the `if volumeAttacher != nil` block. **Which issue(s) this PR fixes**: Fixes #60025 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /sig storage /cc @msau42 @jingxu97 @dhirajh @ianchakeres @mlmhl
-
Zihong Zheng authored
-
- 20 Feb, 2018 16 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Introduce PodSecurityPolicy in the policy/v1beta1 API group Types/constants are completely the same as in `extensions/v1beta1` except that they are located outside of the `extensions` API group. **What this PR does / why we need it**: This is the first step for migrating PSP-related stuff away of `extensions` group. See #43214 for more information. Also it related to https://github.com/kubernetes/features/issues/5 **Example**: ```console $ cat restricted2.yaml apiVersion: policy/v1beta1 kind: PodSecurityPolicy metadata: name: restricted2 ... $ kubectl create -f restricted.yaml podsecuritypolicy "restricted2" created $ kubectl get psp restricted2 -o yaml apiVersion: extensions/v1beta1 kind: PodSecurityPolicy ... ``` **Release note**: ```release-note The `PodSecurityPolicy` API has been moved to the `policy/v1beta1` API group. The `PodSecurityPolicy` API in the `extensions/v1beta1` API group is deprecated and will be removed in a future release. ```
-
Mike Danese authored
-
nikhiljindal authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Drop init container annotations during conversion https://github.com/kubernetes/kubernetes/pull/51816/files#diff-0fa94eafdf1c7cd2171c836b53fd6323 removed special handling of init container annotations in API conversion in 1.8 However, older clients (like 1.7 kubectl) still performed that handling in some paths, which would make an object round-tripped through kubectl show up with additional annotations. Those additions would get flagged as disallowed mutations in some objects. This change strips init-container annotations during conversion so that old clients sending init container annotations (which are inert in 1.8+) don't trigger validation errors around immutable fields. Fixes #54816 ```release-note Restores the ability of older clients to delete and scale jobs with initContainers ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Support for resource quota on extended resources **Which issue(s) this PR fixes** : Fixes #46639 #57300 for resource quota support **Special notes for your reviewer**: One thing to be determined is if it necessary to Explicitly prohibit defining limits for extended resources in quota, like we did for [hugepages](https://github.com/kubernetes/kubernetes/pull/54292#pullrequestreview-74982771), as the resource is not allowed to overcommit. **Release note**: ```release-note Support for resource quota on extended resources ``` /cc @jiayingz @vishh @derekwaynecarr
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59391, 58097, 60057, 60090). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. bzl: use --local_test_jobs We originally seperated build and test so that only 4 integration tests would be run at a time, but we didn't want to slow down build, however we didn't know --local_test_jobs existed. This achieves the same result but more efficiently. ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59391, 58097, 60057, 60090). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. cleanup printers some more This cleans up some more dead printer flags and unnecessary arguments for various methods. We're getting closer. Still need to clean up some ugly around `PrintSuccess` and then its time to start trimming layers. @kubernetes/sig-cli-maintainers ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59391, 58097, 60057, 60090). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add IPv6 to command options. **What this PR does / why we need it**: This PR adds IPv6 information to the descriptions for several command options. [Related PR in kubernetes/website](https://github.com/kubernetes/website/pull/6498) **Release note**: ```release-note NONE ```
-
David Ashpole authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Move volume scheduling and local storage to beta **What this PR does / why we need it**: * Move the feature gates and APIs for volume scheduling and local storage to beta * Update tests to use the beta fields @kubernetes/sig-storage-pr-reviews **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #59390 **Special notes for your reviewer**: **Release note**: ```release-note ACTION REQUIRED: VolumeScheduling and LocalPersistentVolume features are beta and enabled by default. The PersistentVolume NodeAffinity alpha annotation is deprecated and will be removed in a future release. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59634, 59821, 57850, 59916, 60032). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. AllowVolumeExpansion field to storageclass describe Signed-off-by:
Humble Chirammal <hchiramm@redhat.com> **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59634, 59821, 57850, 59916, 60032). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add cluster-location to GCE instance attributes **What this PR does / why we need it**: Exposes cluster location on GCP as instance attribute. In particular, this metadata is useful for exposing metrics to Stackdriver monitoring system and is necessary for some Stackdriver integration components, i.e. Stackdriver Metadata Agent **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59634, 59821, 57850, 59916, 60032). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Enable mutating and validating admission webhooks by default on clusters created via kube-up.sh cc @cheftako @lavalamp The deprecation [notice](https://github.com/caesarxuchao/kubernetes/tree/d46e01fe287994bfc5b36984f9f80fa5df19c931/cluster#deprecation-notice-this-directory-has-entered-maintenance-mode-and-will-not-be-accepting-new-providers-please-submit-new-automation-deployments-to-kube-deploy-deployments-in-this-directory-will-continue-to-be-maintained-and-supported-at-their-current-level-of-support) of the `/cluster` directory says "Deployments in this directory will continue to be maintained and supported at their current level of support.", so I think we still need to update the default configs to the latest recommended values.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59634, 59821, 57850, 59916, 60032). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update to latest gophercloud/gophercloud for 1.10 **What this PR does / why we need it**: Looks like we end up with just the following change: https://github.com/gophercloud/gophercloud/pull/730 (Prevent Recursive BuildRequestBody) The full set of changes between the old and new SHA are here: https://github.com/gophercloud/gophercloud/compare/8e59687aa4b27ab22a0bf3295f1e165ff7bd5f97...6da026c32e2d622cc242d32984259c77237aefe1 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Mike Danese authored
so it can be used for both new and legacy svcacct tokens. Also move the legacy validator into legacy.go.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove unused function in test file remove unused function in pkg/controller/replicaset/replica_set_test.go **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-