- 12 Feb, 2019 1 commit
-
-
Patrick Ohly authored
Whether the read test after writing was done on the same node was random for drivers that weren't locked onto a single node. Now it is deterministic: it always happens on the same node. The case with reading on another node is covered separately for test configurations that support it (not locked onto a single node, more than one node in the test cluster). As before, the TestConfig.ClientNodeSelector is ignored by the provisioning testsuite.
-
- 09 Feb, 2019 7 commits
-
-
Patrick Ohly authored
TestDynamicProvisioning had multiple ways of choosing additional checks: - the PvCheck callback - the builtin write/read check controlled by a boolean - the snapshot testing Complicating matters further, that builtin write/read test had been more customizable with new fields `NodeSelector` and `ExpectUnschedulable` which were only set by one particular test (see https://github.com/kubernetes/kubernetes/pull/70941). That is confusing and will only get more confusing when adding more checks in the future. Therefore the write/read check is now a separate function that must be enabled explicitly by tests that want to run it. The snapshot checking is also defined only for the snapshot test. The test that expects unschedulable pods now also checks for that particular situation itself. Instead of testing it with two pods (the behavior from the write/read check) that both fail to start, only a single unschedulable pod is created. Because node name, node selector and the `ExpectUnschedulable` were only used for checking, it is possible to simplify `StorageClassTest` by removing all of these fields. Expect(err).NotTo(HaveOccurred()) is an anti-pattern in Ginkgo testing because a test failure doesn't explain what failed (see https://github.com/kubernetes/kubernetes/issues/34059). We avoid it now by making the check function itself responsible for checking errors and including more information in those checks.
-
Patrick Ohly authored
When the provisioning test gets stuck, the log fills up with messages about waiting for a certain pod to run. Now the pod names are pvc-[volume-tester|snapshot]-[writer|reader] plus the random number appended by Kubernetes. This makes it easier to see where the test is stuck.
-
Patrick Ohly authored
There is no need to check for empty strings, we can also directly initialize structs with the value. The end result is the same when the value is empty (empty string in the struct).
-
Patrick Ohly authored
This addresses the two remaining change requests from https://github.com/kubernetes/kubernetes/pull/69036: - replace "csi-hostpath-v0" name check with capability check (cleaner that way) - add feature tag to "should create snapshot with defaults" because that is an alpha feature Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
Even if snapshots are supported by the driver interface, the driver or suite might still want to skip a particular test, so those checks still need to be executed.
-
Kubernetes Prow Robot authored
Fix linting in cmd/kubemark package
-
Kubernetes Prow Robot authored
Kubelet: add usageNanoCores from CRI stats provider
-
- 08 Feb, 2019 29 commits
-
-
Kubernetes Prow Robot authored
fix shellcheck in node-api
-
Kubernetes Prow Robot authored
fix typo "udp" -> "UDP"
-
Kubernetes Prow Robot authored
add e2e test for snapshot
-
Kubernetes Prow Robot authored
Fix fmt.Errorf messages
-
Kubernetes Prow Robot authored
Avoid going back in time in watchcache watchers
-
Kubernetes Prow Robot authored
Ensure controller manager and scheduler can perform delegated auth checks
-
Kubernetes Prow Robot authored
OWNERS: add label:sig/network to a bunch of places
-
Kubernetes Prow Robot authored
fix typos lable -> label
-
Kubernetes Prow Robot authored
Clarify hostname emptiness in CRI.
-
Kubernetes Prow Robot authored
AttachableVolumePlugin CanAttach() method for attachable check
-
Kubernetes Prow Robot authored
Update doc.go import for staging/src/k8s.io/api/storage/v1/doc.go
-
Kubernetes Prow Robot authored
Updated OWNERS files to include link to docs
-
Jordan Liggitt authored
-
Rajat Varyani authored
-
wojtekt authored
-
Kubernetes Prow Robot authored
kubeadm: refactor JoinConfigFileAndDefaultsToInternalConfig
-
Kubernetes Prow Robot authored
fix shellcheck in csi-api
-
Kubernetes Prow Robot authored
Reduce contention in cacher by eliminating sync.Pool
-
Vladimir Vivien authored
-
Rostislav M. Georgiev authored
Currently JoinConfigFileAndDefaultsToInternalConfig is doing a couple of different things depending on its parameters. It: - loads a versioned JoinConfiguration from an YAML file. - returns defaulted JoinConfiguration allowing for some overrides. In order to make code more manageable, the following steps are taken: - Introduce LoadJoinConfigurationFromFile, which loads a versioned JoinConfiguration from an YAML file, defaults it (both dynamically and statically), converts it to internal JoinConfiguration and validates it. - Introduce DefaultedJoinConfiguration, which returns defaulted (both dynamically and statically) and verified internal JoinConfiguration. The possibility of overwriting defaults via versioned JoinConfiguration is retained. - Re-implement JoinConfigFileAndDefaultsToInternalConfig to use LoadJoinConfigurationFromFile and DefaultedJoinConfiguration. - Replace some calls to JoinConfigFileAndDefaultsToInternalConfig with calls to either LoadJoinConfigurationFromFile or DefaultedJoinConfiguration where appropriate. - Rename JoinConfigFileAndDefaultsToInternalConfig to the more appropriate name LoadOrDefaultJoinConfiguration. Signed-off-by:Rostislav M. Georgiev <rostislavg@vmware.com>
-
wojtekt authored
-
Kubernetes Prow Robot authored
KUBE_JUNIT_REPORT_DIR fixes
-
Kubernetes Prow Robot authored
fix --local panic in set commands
-
Kubernetes Prow Robot authored
Bump debian-* base image versions to latest
-
Kubernetes Prow Robot authored
move pkg/kubelet/apis/well_known_labels.go to staging/src/k8s.io/api/core/v1/
-
Lantao Liu authored
-
Kubernetes Prow Robot authored
Add check-file-in-alphabetical-order for cleanup
-
Kubernetes Prow Robot authored
ControllerRef creation through factory function
-
Kubernetes Prow Robot authored
Fix #73479 AWS NLB target groups missing tags
-
- 07 Feb, 2019 3 commits
-
-
Kubernetes Prow Robot authored
Update CudaVectorAdd test image to be built with Cuda10 docker image.
-
Kubernetes Prow Robot authored
kubeadm: do not create etcd datastore if we are in dryrun mode
-
juanvallejo authored
-