1. 12 Feb, 2019 1 commit
    • Patrick Ohly's avatar
      e2e/storage: test provisioned volume on multiple nodes · ca42cf49
      Patrick Ohly authored
      Whether the read test after writing was done on the same node was
      random for drivers that weren't locked onto a single node. Now it is
      deterministic: it always happens on the same node.
      
      The case with reading on another node is covered separately for test
      configurations that support it (not locked onto a single node, more
      than one node in the test cluster).
      
      As before, the TestConfig.ClientNodeSelector is ignored by the
      provisioning testsuite.
      ca42cf49
  2. 09 Feb, 2019 7 commits
    • Patrick Ohly's avatar
      e2e/storage: improve PV checking · 54d8f164
      Patrick Ohly authored
      TestDynamicProvisioning had multiple ways of choosing additional
      checks:
      - the PvCheck callback
      - the builtin write/read check controlled by a boolean
      - the snapshot testing
      
      Complicating matters further, that builtin write/read test had been
      more customizable with new fields `NodeSelector` and
      `ExpectUnschedulable` which were only set by one particular test (see
      https://github.com/kubernetes/kubernetes/pull/70941).
      
      That is confusing and will only get more confusing when adding more
      checks in the future. Therefore the write/read check is now a separate
      function that must be enabled explicitly by tests that want to run it.
      The snapshot checking is also defined only for the snapshot test.
      
      The test that expects unschedulable pods now also checks for that
      particular situation itself. Instead of testing it with two pods (the
      behavior from the write/read check) that both fail to start, only a
      single unschedulable pod is created.
      
      Because node name, node selector and the `ExpectUnschedulable` were
      only used for checking, it is possible to simplify `StorageClassTest`
      by removing all of these fields.
      
      Expect(err).NotTo(HaveOccurred()) is an anti-pattern in Ginkgo testing
      because a test failure doesn't explain what failed (see
      https://github.com/kubernetes/kubernetes/issues/34059). We avoid it
      now by making the check function itself responsible for checking
      errors and including more information in those checks.
      54d8f164
    • Patrick Ohly's avatar
      e2e/storage: use different names for test pods · 5b8826b6
      Patrick Ohly authored
      When the provisioning test gets stuck, the log fills up with messages
      about waiting for a certain pod to run. Now the pod names are
      pvc-[volume-tester|snapshot]-[writer|reader] plus the random
      number appended by Kubernetes. This makes it easier to see where the
      test is stuck.
      5b8826b6
    • Patrick Ohly's avatar
      e2e/storage: remove unnecessary empty string checks · e92bdd14
      Patrick Ohly authored
      There is no need to check for empty strings, we can also directly
      initialize structs with the value. The end result is the same when the
      value is empty (empty string in the struct).
      e92bdd14
    • Patrick Ohly's avatar
      e2e: refine snapshot test · 315266b2
      Patrick Ohly authored
      This addresses the two remaining change requests from
      https://github.com/kubernetes/kubernetes/pull/69036:
      - replace "csi-hostpath-v0" name check with capability
        check (cleaner that way)
      - add feature tag to "should create snapshot with defaults" because
        that is an alpha feature
      Signed-off-by: 's avatarPatrick Ohly <patrick.ohly@intel.com>
      315266b2
    • Patrick Ohly's avatar
      e2e: fix snapshot skip test · f8536e8e
      Patrick Ohly authored
      Even if snapshots are supported by the driver interface, the driver or
      suite might still want to skip a particular test, so those checks
      still need to be executed.
      f8536e8e
    • Kubernetes Prow Robot's avatar
      Merge pull request #73854 from RajatVaryani/master · 40a4c1f7
      Kubernetes Prow Robot authored
      Fix linting in cmd/kubemark package
      40a4c1f7
    • Kubernetes Prow Robot's avatar
      Merge pull request #73659 from feiskyer/usage-nano-cores · ee44e24c
      Kubernetes Prow Robot authored
      Kubelet: add usageNanoCores from CRI stats provider
      ee44e24c
  3. 08 Feb, 2019 29 commits
  4. 07 Feb, 2019 3 commits