- 28 Jan, 2017 8 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40132, 39302, 40194, 40619, 40601) fix error message in TestGetAddonImage Signed-off-by:bruceauyeung <ouyang.qinhua@zte.com.cn> **What this PR does / why we need it**: 1. fix incorrect error message in TestGetAddonImage 2. rename some variables to make them more reasonable
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40132, 39302, 40194, 40619, 40601) fix nil check and typos **What this PR does / why we need it**: 1. nil error should be checked before defer statement. 2. fix some typos. Signed-off-by: bruceauyeung ouyang.qinhua@zte.com.cn
-
Kubernetes Submit Queue authored
Merge pull request #40132 from bruceauyeung/k8s-branch-add-invalid-and-valid-tokens-in-TestValidateToken-testcase Automatic merge from submit-queue add test tokens for TestValidateToken Signed-off-by:bruceauyeung <ouyang.qinhua@zte.com.cn> **What this PR does / why we need it**: 1. add invalid tokens which token ID and token secret contain special characters such as `*` 2. add valid tokens which token ID and token secret contain mixed lowercase characters and numeric numbers
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40497, 39769, 40554, 40569, 40597) Minor cleanup in getting from apiserver cache in kubelet
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40497, 39769, 40554, 40569, 40597) Switch io_kubernetes_build to repo-infra. This also picks up the `go_genrule`. cc @mikedanese **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40497, 39769, 40554, 40569, 40597) When calling chown, use : instead of . to separate the user and group for cross platform compatibility. **What this PR does / why we need it**: Makes it possible to build on a Mac, which was broken by #39515. **Special notes for your reviewer**: **Release note**: `NONE`
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40497, 39769, 40554, 40569, 40597) NetworkPolicy validation improvements I noticed while implementing NetworkPolicy that I we weren't validating the "Ports" field at all. The docs are actually completely silent about what a string-valued Port field is supposed to mean. I had guessed it meant to call `net.LookupPort()` on it (ie, map it from /etc/services) but in every other case where we have an IntOrString-valued Port field in an API struct, it refers to a named ContainerPort. But that would be extremely awkward to implement in this case; a policy specifying a named port could end up mapping to a different numeric port on every container in the namespace... Do other people actually implement string-valued ports that way? Or, for that matter, implement string-valued ports at all? (Related: I hadn't noticed until now that you can leave the Port value unspecified, allowing you to say "allow to all UDP ports, but no TCP ports" or "allow to all TCP ports, but no UDP ports". That seems like something that ended up in the spec just because it was possible, not because it was actually useful...) @kubernetes/sig-network-misc
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Make HandleError prevent hot-loops Add an error "handler" that just sleeps for a bit if errors happen more often than 500ms. Manually tested against #39816. This doesn't fix #39816 but it does keep it from crippling a cluster. ```release-note Prevent hotloops on error conditions, which could fill up the disk faster than log rotation can free space. ```
-
- 27 Jan, 2017 32 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue OWNERS for kubectl translations `pkg/kubectl` approvers and reviewers can also handle `translations/kubectl`. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue fix incorrect parameter passing Signed-off-by:bruceauyeung <ouyang.qinhua@zte.com.cn> **What this PR does / why we need it**: 1. fix incorrect parameter passing when creating error 2. fix ineffectual assignment to err variable.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue run unit tests with go, not just bazel Follow up to https://github.com/kubernetes/kubernetes/pull/40594, effectively reverts #39105. I think we should run our unit tests using the official golang infrastructure. I have no objection to also running them in bazel (or running a subset in bazel), but I don't think that bazel should be the primary unit test method. @smarterclayton @liggitt @ixdy @spxtr
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue DaemonSet controller actively kills failed pods (to recreate them) Ref #36482, @erictune @yujuhong @mikedanese @kargakis @lukaszo @piosz @kubernetes/sig-apps-bugs This also helps with DaemonSet update ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40600, 40548) remove storage dependency on api @sttts fyi
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40600, 40548) Test cascading delete without client-side reaper does not GET
-
deads2k authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 39469, 40557) Refactored kubemark code into provider-specific and provider-independent parts [Part-1] Applying part of the changes of PR https://github.com/kubernetes/kubernetes/pull/39033 (which refactored kubemark code completely). The changes included in this PR are: The following are the major changes as part of this refactoring: - Moved cluster-kubemark/config-default.sh -> cluster-kubemark/gce/config-default.sh (as the config is gce-specific) - Changed kubernetes/cluster/kubemark/util.sh to source the right scripts based on the cloud-provider - Added the file test/kubemark/cloud-provider-config.sh which sets the variable CLOUD_PROVIDER that is later picked up by various scripts (run-e2e-tests.sh, common.sh) - Removed useless code and restructured start-kubemark.sh and stop-kubemark.sh scripts. @kubernetes/sig-scalability-misc @wojtek-t @gmarek
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 39469, 40557) Forgiveness api changes **What this PR does / why we need it**: Splited from #34825 , contains api changes that are needed to implement forgiveness: 1. update toleration api types to support forgiveness, added a new field forgivenessSeconds to indicate the duration of time it tolerates a taint. 2. update taint api types, added a new field to indicate the time the taint is added. **Which issue this PR fixes** : Related issue: #1574 Related PR: #34825 **Special notes for your reviewer**: **Release note**: ```release-note forgiveness alpha version api definition ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue move packages to apimachinery and apiserver more no-dep dependencies. @sttts see commit names approved based on https://github.com/kubernetes/kubernetes/issues/40363
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue add OWNERS to cluster/images/kubemark cc @wojtek-t @shyamjvs @jbeda @zmerlynn @eparis @mikedanese @roberthbailey
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Temporary disable federation kubectl tests for secrets to unblock merge queue Fixes https://github.com/kubernetes/kubernetes/issues/40521 cc @kubernetes/sig-federation-misc @deads2k
-
Fabiano Franz authored
-
gmarek authored
-
deads2k authored
-
Wojciech Tyczynski authored
Restore unit testing for staging repos
-
Wojciech Tyczynski authored
Revert "Delay deletion of pod from the API server until volumes are deleted"
-
Wojciech Tyczynski authored
-
Jordan Liggitt authored
-
deads2k authored
-
deads2k authored
-
deads2k authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 39223, 40260, 40082, 40389) Use metav1.*Options in genericapiserver Treat DeleteOptions as unversioned in metainternalversion for decoding of bodies from older clients. Use the metav1 Options structs from generic api server and the appropriate codec. Completes the move to using generic server side code for API objects @sttts
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 39223, 40260, 40082, 40389) Update go-autorest library to v7.2.3 To include https://github.com/Azure/go-autorest/pull/107 Improves https://github.com/kubernetes/kubernetes/issues/35180 CC: @colemickens
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 39223, 40260, 40082, 40389) make kubectl generic commands work with unstructured objects part of making apply, edit, label, annotate, and patch work with third party resources fixes #35149 fixes #34413 prereq of: https://github.com/kubernetes/kubernetes/issues/35496 https://github.com/kubernetes/kubernetes/pull/40096 related to: https://github.com/kubernetes/kubernetes/issues/39906 https://github.com/kubernetes/kubernetes/issues/40119 kubectl is currently decoding any resource it doesn't have compiled-in to a ThirdPartyResourceData struct, which means it computes patches using that struct, and would try to send a ThirdPartyResourceData object to the API server when running `apply` This PR removes the behavior that decodes unknown objects into ThirdPartyResourceData structs internally, and fixes up the following generic commands to work with unstructured objects - [x] apply - [x] decode into runtime.Unstructured objects - [x] successfully use `--record` with unregistered objects - [x] patch - [x] decode into runtime.Unstructured objects - [x] successfully use `--record` with unregistered objects - [x] describe - [x] decode into runtime.Unstructured objects - [x] implement generic describer - [x] fix other generic kubectl commands to work with unstructured objects - [x] label - [x] annotate follow-ups for pre-existing issues: - [ ] `explain` doesn't work with unregistered resources - [ ] remove special casing of federation group in clientset lookups, etc - [ ] `patch` - [ ] doesn't honor output formats when persisting to server (`kubectl patch -f svc.json --type merge -p '{}' -o json` doesn't output json) - [ ] --local throws exception (`kubectl patch -f svc.json --type merge -p '{}' --local`) - [ ] `apply` - [ ] fall back to generic JSON patch computation if no go struct is registered for the target GVK (e.g. https://github.com/kubernetes/kubernetes/pull/40096) - [ ] ensure subkey deletion works in CreateThreeWayJSONMergePatch - [ ] ensure type stomping works in CreateThreeWayJSONMergePatch - [ ] lots of tests for generic json patch computation - [ ] prevent generic apply patch computation among different versions - [ ] reconcile treatment of nulls with https://github.com/kubernetes/kubernetes/pull/35496 - [ ] `edit` - [ ] decode into runtime.Unstructured objects - [ ] fall back to generic JSON patch computation if no go struct is registered for the target GVK
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 39223, 40260, 40082, 40389) Add a script to extract strings for translation and a sample of it's output @fabianofranz @deads2k @kubernetes/sig-cli-pr-reviews
-
deads2k authored
-
deads2k authored
-
Kevin authored
-
Kevin authored
-
Aleksandra Malinowska authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40126, 40565, 38777, 40564, 40572) docker-CRI: Remove legacy code for non-grpc integration A minor cleanup to remove the code that is no longer in use to simplify the logic.
-