- 09 Feb, 2017 14 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 41121, 40048, 40502, 41136, 40759) Remove deprecated kubelet flags that look safe to remove Removes: ``` --config --auth-path --resource-container --system-container ``` which have all been marked deprecated since at least 1.4 and look safe to remove. ```release-note The deprecated flags --config, --auth-path, --resource-container, and --system-container were removed. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 41121, 40048, 40502, 41136, 40759) [Federation] Wait after cleanup only if the cleanup succeeds. It is a waste of time to wait for the resources to cleanup if the cleanup fails. cc @kubernetes/sig-federation-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 41145, 38771, 41003, 41089, 40365) Add `kubectl attach` support for multiple types To address this issue: https://github.com/kubernetes/kubernetes/issues/24857 the new `kubectl attach` will contain three scenarios depend on args: 1. `kubectl attach POD` : if only one argument provided, we assume it's a pod name 2. `kubectl attach TYPE NAME` : if two arguments provided, we assume first one is resource we [supported](https://github.com/shiywang/kubernetes/blob/4770162fd3fd0d65ff95348c71683cf4c717141a/pkg/kubectl/cmd/util/factory_object_mapping.go#L285), the second resource's name. 3. `kubectl attach TYPE/NAME` : one argument provided and arg[0] must contain `/`, ditto Is there any other scenarios I haven't consider in ? for now the first scenario is compatible with changed before, also `make test` pass
✅ will write some unit test to test second and third scenario, if you guys think i'm doing the right way. @pwittrock @kargakis @fabianofranz @ymqytw @AdoHe -
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 41145, 38771, 41003, 41089, 40365) Use privileged containers for statefulset e2e tests Test containers need to run as spc_t in order to interact with the host filesystem under /tmp, as the tests for StatefulSet are doing. Docker will transition the container into this domain when running the container as privileged. Signed-off-by:Steve Kuznetsov <skuznets@redhat.com> **Release note**: ```release-note NONE ``` /cc @ncdc @soltysh @pmorie
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 41145, 38771, 41003, 41089, 40365) Remove useless param from kubectl create rolebinding The `force` param is not used in `kubectl create rolebinding` & `kubectl create clusterrolebinding` commands, removed it.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 41145, 38771, 41003, 41089, 40365) Fix typo in drain command
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Do not cleanup already deleted replica sets and add more logging around it For https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-kops-aws/3569 @ncdc will make the output of the test cleaner
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add janetkuo to approvers for controllers
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add OWNERS file for GCE cloud provider GCE cloud provider does not have OWNERS file and all PRs need to be approved by owner of pkg/cloudprovider, which is currently only @mikedanese. Adding more options would be helpful to speed up reviews. Feel free to add/remove some names, this first version is just my qualified guess. It's hard to distinguish generic Kubernetes refactoring from real cloud provider work in git log. ```release-note NONE ```
-
Jess Frazelle authored
Revert "[Kubelet] Delay deletion of pod from the API server until volumes are deleted"
-
David Ashpole authored
-
Michail Kargakis authored
-
Michail Kargakis authored
-
Jess Frazelle authored
lengthen pod deletion timeout to prevent flakes
-
- 08 Feb, 2017 26 commits
-
-
Janet Kuo authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40873, 40948, 39580, 41065, 40815) Make DeltaFIFO Resync atomic Make DeltaFIFO's Resync operation atomic, so it enqueues the entire queue before allowing adds/updates/deletes. I'm hoping to use this to help with custom resync periods for multiple event handlers against a single shared informer (see https://github.com/kubernetes/kubernetes/pull/40759#pullrequestreview-19598213 for the motivation). @lavalamp @smarterclayton @deads2k @liggitt @sttts @timothysc @wojtek-t @gmarek @kubernetes/sig-api-machinery-pr-reviews @kubernetes/sig-scalability-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40873, 40948, 39580, 41065, 40815) Default target storage in etcd To make etcd v2->v3 upgrade work correctly, we need to correctly set the "TARGET_STORAGE" env var. Since in head we are defaulting to etcd v3, this PR is defaulting also that env var to etcd3, so that by default upgrade works fine. @fgrzadkowski @gmarek
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40873, 40948, 39580, 41065, 40815) Upgrade Hazelcast example with the latest hazelcast-kubernetes-bootst… …rapper 0.8.0, using Deployments instead of Replication Controller. **What this PR does / why we need it**: This PR upgrade the Hazelcast example in storage folder. It would be great to be aligned with the latest version of hazelcast-kubernetes-bootstrapper
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40873, 40948, 39580, 41065, 40815) [CRI] Enable Hostport Feature for Dockershim Commits: 1. Refactor common hostport util logics and add more tests 2. Add HostportManager which can ADD/DEL hostports instead of a complete sync. 3. Add Interface for retreiving portMappings information of a pod in Network Host interface. Implement GetPodPortMappings interface in dockerService. 4. Teach kubenet to use HostportManager
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Remove 'get node' call during bootstrapping Kubelet bootstrapping should have minimal permissions until it obtains an approved client certificate. @luxas PTAL /cc @mikedanese @cjcullen https://github.com/kubernetes/kubernetes/pull/40760#issuecomment-276832957
-
David Ashpole authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue [Kubelet] Delay deletion of pod from the API server until volumes are deleted Previous PR that was reverted: #40239. To summarize the conclusion of the previous PR after reverting: - The status manager has the most up-to-date status, but the volume manager uses the status from the pod manager, which only is as up-to-date as the API server. - Because of this, the previous change required an additional round trip between the kubelet and API server. - When few pods are being added or deleted, this is only a minor issue. However, when under heavy load, the QPS limit to the API server causes this round trip to take ~60 seconds, which is an unacceptable increase in latency. Take a look at the graphs in #40239 to see the effect of QPS changes on timing. - To remedy this, the volume manager looks at the status from the status manager, which eliminates the round trip. cc: @vishh @derekwaynecarr @sjenning @jingxu97 @kubernetes/sig-storage-misc
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue add deads2k to approvers for controllers I've done significant maintenance on these for a while and introduced new patterns like shared informers and rate limited work queues.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue avoid repeated length calculation and some other code improvements **What this PR does / why we need it**: 1. in function `ParsePairs`, calculating `invalidBuf`'s length over and over again brings performance penalty. a `invalidBufNonEmpty` bool value can fix this. 2. pairArg is not a string template and also there is no other arguments for `fmt.Sprintf`, so i remove `fmt.Sprintf` 3. in function `DumpReaderToFile`, we must check nil error first before defer statement, otherwise there maybe a potential nil error on `f.Close()` 4. add nil checks into `GetWideFlag` function 5. some other minor code improvements for better readability. Signed-off-by:bruceauyeung <ouyang.qinhua@zte.com.cn>
-
Minhan Xia authored
-
Minhan Xia authored
-
Minhan Xia authored
-
Minhan Xia authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Removed a space in portforward.go. **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
David Ashpole authored
-
deads2k authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add more logs in the progress check path Follow-up to https://github.com/kubernetes/kubernetes/pull/41097 @mfojtik quick look here
-
Aleksandra Malinowska authored
Revert "remove second CA used for kubelet auth in favor of webhook auth"
-
Aleksandra Malinowska authored
-
Michail Kargakis authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40175, 41107, 41111, 40893, 40919) [Federation][e2e] Move Cluster Registration to federation-up.sh **What this PR does / why we need it**: Remove cluster register/unregister calls from test case BeforeEach/AfterEach blocks. Register clusters once in federation-up.sh **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #40768 **Special notes for your reviewer**: **Release note**: `NONE` cc: @madhusudancs @kubernetes/sig-federation-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40175, 41107, 41111, 40893, 40919) remove second CA used for kubelet auth in favor of webhook auth partial fixes upgrade test.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40175, 41107, 41111, 40893, 40919) Default the version to the information in federation versions file if $KUBERNETES_RELEASE isn't set. Also, slightly unrelated fix: copy the output from the build container to the host filesystem while building hyperkube image. The recent change in the build scripts has caused the binaries to be not copied to the required locations. It must be explicitly copied by calling the build copy function. cc @kubernetes/sig-federation-pr-reviews @perotinus @csbell @nikhiljindal
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40175, 41107, 41111, 40893, 40919) Node E2E: Remove angle brackets in the test name. Ref https://github.com/kubernetes/test-infra/issues/1827#issuecomment-278187834. Remove the angle brackets in the test name. /cc @krzyzacy @mtaufen
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40175, 41107, 41111, 40893, 40919) kubeadm: skip integration tests if kubeadm-cmd-skip flag passed Will skip integration tests for token generation if it can't find a file by the given --kubeadm-path or default value. **What this PR does / why we need it**: Tests would fail if just running `go test` in the dir because it expects to have more values. This won't change the behavior of `make test-cmd` which gets run here: https://github.com/kubernetes/kubernetes/blob/master/Makefile#L258 **Which issue this PR fixes**: fixes #40155 **Special notes for your reviewer**: /cc @pires @pipejakob @liggitt ```release-note NONE ```
-