1. 20 Mar, 2018 12 commits
  2. 19 Mar, 2018 10 commits
  3. 18 Mar, 2018 2 commits
  4. 16 Mar, 2018 16 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #61201 from jennybuckley/fix-gc-empty-map · f8f67da0
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61284, 61119, 61201). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Prevent garbage collector from attempting to sync with 0 resources
      
      **What this PR does / why we need it**:
      As of #55259 we enabled garbagecollector.GetDeletableResources to return partial discovery results (including an empty set of discovery results).
      This had the unintended consequence of allowing the garbage collector to enter a blocked state that can only be fixed by restarting.
      
      From [this comment](https://github.com/kubernetes/kubernetes/issues/60037#issuecomment-372801088):
      
      > 1. The Sync function periodically calls GetDeletableResources
      >
      > 2. According to the comment above GetDeletableResources, All discovery errors are considered temporary. Upon encountering any error, GetDeletableResources will log and return any discovered resources it was able to process (which may be none)., an error in discovery causes the discovery client to no longer discover resources in the cluster, but instead of failing and returning an error, it simply logs the error as garbagecollector.go:601] failed to discover preferred resources: %vthe server was unable to return a response in the time allotted, but may still be processing the request and returns an empty list of resources
      >
      > 3. The Sync function, upon recieving an empty resource list from discovery, detects that the resources have changed, and calls resyncMonitors, which calls dependencyGraphBuilder.syncMonitors with map[] as the argument as shown in the log as garbagecollector.go:189] syncing garbage collector with updated resources from discovery: map[], which sets the list of monitors to an empty list because it thinks there are no resources to monitor.
      >
      > 4. Lastly the Sync function calls controller.WaitForCacheSync, which calls cache.WaitForCacheSync, which will continually retry the garbagecollector.IsSynced function until it returns true, but it will always return false because len(gb.monitors) is 0.
      
      This PR prevents that specific race condition from arising.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #60037
      
      **Release note**:
      ```release-note
      Fix bug allowing garbage collector to enter a broken state that could only be fixed by restarting the controller-manager.
      ```
      f8f67da0
    • Kubernetes Submit Queue's avatar
      Merge pull request #61119 from mtaufen/fix-cluster-autoscaler · c6d77ee6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61284, 61119, 61201). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Add AUTOSCALER_ENV_VARS to kube-env to hotfix cluster autoscaler
      
      This provides a temporary way for the cluster autoscaler to get at
      values that were removed from kube-env in #60020. Ideally this
      information will eventually be available via e.g. the Cluster API,
      because kube-env is an internal interface that carries no stability
      guarantees.
      
      This is the first half of the fix; the other half is that cluster autoscaler
      needs to be modified to read from AUTOSCALER_ENV_VARS, if it is
      available.
      
      Since cluster autoscaler was also reading KUBELET_TEST_ARGS for the
      kube-reserved flag, and we don't want to resurrect KUBELET_TEST_ARGS in kube-env,
      we opted to create AUTOSCALER_ENV_VARS instead of just adding back
      the old env vars. This also makes it clear that we have an ugly dependency
      on kube-env.
      
      ```release-note
      NONE
      ```
      c6d77ee6
    • Kubernetes Submit Queue's avatar
      Merge pull request #61284 from jsafrane/fix-fsgroup-subpath · f1251522
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61284, 61119, 61201). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fix creation of subpath with SUID/SGID directories.
      
      SafeMakeDir() should apply SUID/SGID/sticky bits to the directory it creates.
      
      Fixes #61283 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      f1251522
    • Rohit Ramkumar's avatar
    • Derek Carr's avatar
      Fix cpu cfs quota flag with pod cgroups · f68f3ff7
      Derek Carr authored
      f68f3ff7
    • Brendan Burns's avatar
    • Hemant Kumar's avatar
      Fix e2e tests for emptydir · 0600f7ee
      Hemant Kumar authored
      0600f7ee
    • jennybuckley's avatar
    • Michael Taufen's avatar
      Add AUTOSCALER_ENV_VARS to kube-env to hotfix cluster autoscaler · 8cf3dc10
      Michael Taufen authored
      This provides a temporary way for the cluster autoscaler to get at
      values that were removed from kube-env in #60020. Ideally this
      information will eventually be available via e.g. the Cluster API,
      because kube-env is an internal interface that carries no stability
      guarantees.
      8cf3dc10
    • jennybuckley's avatar
      Add unit test TestGarbageCollectorSync · 68e2a960
      jennybuckley authored
      68e2a960
    • Kubernetes Submit Queue's avatar
      Merge pull request #61161 from k82cn/k8s_59194_4 · ca02c118
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Added unschedulable taint
      Signed-off-by: 's avatarDa K. Ma <klaus1982.cn@gmail.com>
      
      **What this PR does / why we need it**:
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      part of #59194; fixes #61050
      
      **Release note**:
      
      ```release-note
      When `TaintNodesByCondition` enabled, added `node.kubernetes.io/unschedulable:NoSchedule`
       taint to the node if `spec.Unschedulable` is true.
      
      When `ScheduleDaemonSetPods` enabled, `node.kubernetes.io/unschedulable:NoSchedule` 
      toleration is added automatically to DaemonSet Pods; so the `unschedulable` field of 
      a node is not respected by the DaemonSet controller.
      ```
      ca02c118
    • Jan Safranek's avatar
      Fix creation of subpath with SUID/SGID directories. · e55164c4
      Jan Safranek authored
      SafeMakeDir() should apply SUID/SGID/sticky bits to the directory it creates.
      e55164c4
    • Kubernetes Submit Queue's avatar
      Merge pull request #61269 from x13n/fluentd-gcp-scaler · ca06cc43
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 60722, 61269). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Bump fluentd-gcp-scaler version
      
      **What this PR does / why we need it**:
      This version fixes a bug in which scaler was setting resources for all containers in the pod, not only fluentd-gcp one.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #60763
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      ca06cc43
    • Kubernetes Submit Queue's avatar
      Merge pull request #60722 from filbranden/fluentd1 · 7e063329
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Remove mapping to /host/lib from fluentd-gcp container.
      
      **What this PR does / why we need it**:
      
      This mapping is no longer needed since fluentd-gcp v2.0.16, in which it started using a container image based on Debian Stretch, in which the systemd libraries already include support for all the supported
      compression algorithms.
      
      The `/run.sh` in the image no longer accesses `/host/lib` anyways, so let's stop mapping it here.
      
      Related changes:
      - fluentd-gcp on GoogleCloudPlatform/k8s-stackdriver#101
      - fluentd-es on GoogleCloudPlatform/google-fluentd#80
      
      /assign @timstclair 
      /cc @crassirostris @bmoyles0117 
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      N/A
      
      **Special notes for your reviewer**:
      N/A
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      7e063329
    • Daniel Kłobuszewski's avatar
      Bump fluentd-gcp-scaler version · e430520d
      Daniel Kłobuszewski authored
      Fixes #60763
      
      This version fixes a bug in which scaler was setting resources for all containers in the pod, not only fluentd-gcp one.
      e430520d
    • Kubernetes Submit Queue's avatar
      Merge pull request #61243 from verult/pd-multizone-cluster · feac98a1
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fixes 'Zone is empty' errors in PD upgrade tests; skips pd tests with inline volume in multizone clusters
      
      **What this PR does / why we need it**: Fixes regional cluster upgrade test failures.
      
      PV upgrade tests were failing because a "" zone is passed to the GCE PD create disk call. In a multizone setting the test must select from a managed zone.
      
      PD tests were failing because it uses inline GCE PD volumes, which should not be used in multizone clusters.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #61242 
      
      /release-note-none
      /assign @saad-ali 
      /cc @wojtek-t 
      /sig storage
      /sig gcp
      feac98a1