1. 11 May, 2017 3 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #44781 from wongma7/outervolumespec · aacc9729
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45382, 45384, 44781, 45333, 45543)
      
      Ensure desired state of world populator runs before volume reconstructor
      
      If the kubelet's volumemanager reconstructor for actual state of world runs before the desired state of world has been populated, the pods in the actual state of world will have some incorrect volume information: namely outerVolumeSpecName, which if incorrect leads to part of the issue here https://github.com/kubernetes/kubernetes/issues/43515, because WaitForVolumeAttachAndMount searches the actual state of world with the correct outerVolumeSpecName and won't find it so reports 'timeout waiting....', etc. forever for existing pods. The comments acknowledge that this is a known issue
      
      The all sources ready check doesn't work because the sources being ready doesn't necessarily mean the desired state of world populator added pods from the sources. So instead let's put the all sources ready check in the *populator*, and when the sources are ready, it will be able to populate the desired state of world and make "HasAddedPods()" return true. THEN, the reconstructor may run.
      
      @jingxu97 PTAL, you wrote all of the reconstruction stuff
      
      ```release-note
      NONE
      ```
      aacc9729
    • Kubernetes Submit Queue's avatar
      Merge pull request #45384 from caesarxuchao/copy-metrics-interanl · a48cfe9f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45382, 45384, 44781, 45333, 45543)
      
      Copy internal types to metrics
      
      Supersedes #45306. 
      
      #45306 removed the internal types and suggested whoever needs the internal types should define their own copy, and use the code-gen tools to generated the conversion functions. Per offline discussion with @DirectXMan12, we wanted to go that direction but it's not clear where to put the internal types yet. Hence, as a temporary solution, we decided copy the referred client-go/pkg/api types into metrics api to avoid the dependency.
      
      The commit "remove need of registry from custom_metrics/client.go" is similar to what I did to the fake client in an earlier PR. Let me know if you want to put the commit in another PR.
      a48cfe9f
    • Kubernetes Submit Queue's avatar
      Merge pull request #45382 from marun/fed-updater-timeout-per-instance · b8186966
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45382, 45384, 44781, 45333, 45543)
      
      [Federation] Provide updater timeout to instance rather than to Update()
      
      This PR changes the federated updater to receive its timeout at construction rather than on every call to Update().  This provides a slight decrease in coupling by removing the need for the deletion handler to be provided the timeout along with the updater.
      
      cc: @kubernetes/sig-federation-pr-reviews @perotinus
      b8186966
  2. 10 May, 2017 25 commits
  3. 09 May, 2017 12 commits