1. 23 Apr, 2018 5 commits
    • Bobby (Babak) Salamat's avatar
    • Bobby (Babak) Salamat's avatar
      Added test for scheduler informers · 719a56fa
      Bobby (Babak) Salamat authored
      719a56fa
    • Kubernetes Submit Queue's avatar
      Merge pull request #62909 from kawych/master · 9b7439d7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Manage Metadata Agent Config with Addon Manager
      
      **What this PR does / why we need it**:
      Fixes error where config map for Metadata Agent was not created by addon manager.
      
      **Release note**:
      ```release-note
      Fix error where config map for Metadata Agent was not created by addon manager.
      ```
      9b7439d7
    • Kubernetes Submit Queue's avatar
      Merge pull request #62856 from liggitt/node-authorizer-contention-benchmark · f0b207df
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62409, 62856). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Add node authorizer contention benchmark
      
      * Makes the node authorization benchmark run in parallel
      * Runs the tests a second time with a background goroutine pushing graph modifications at a rate of 100x per second (to test authorization performance with contention on the graph lock).
      
      Graph modifications come from the informers watching objects relevant to node authorization, and only fire when a relevant change is made (for example, most node updates do not trigger a graph modification, only ones which change the node's config source configmap reference; most pod updates do not trigger a graph modification, only ones that set the pod's nodeName or uid)
      
      The results do not indicate bottlenecks in the authorizer, even under higher-than-expected write contention.
      
      ```
      $ go test ./plugin/pkg/auth/authorizer/node/ -run foo -bench 'Authorization' -benchmem -v
      goos: darwin
      goarch: amd64
      pkg: k8s.io/kubernetes/plugin/pkg/auth/authorizer/node
      BenchmarkAuthorization/allowed_node_configmap-8                                 596 ns/op   529 B/op   11 allocs/op    3000000
      BenchmarkAuthorization/allowed_configmap-8                                      609 ns/op   529 B/op   11 allocs/op    3000000
      BenchmarkAuthorization/allowed_secret_via_pod-8                                 586 ns/op   529 B/op   11 allocs/op    3000000
      BenchmarkAuthorization/allowed_shared_secret_via_pod-8                        18202 ns/op   542 B/op   11 allocs/op     100000
      BenchmarkAuthorization/disallowed_node_configmap-8                              900 ns/op   691 B/op   17 allocs/op    2000000
      BenchmarkAuthorization/disallowed_configmap-8                                   868 ns/op   693 B/op   17 allocs/op    2000000
      BenchmarkAuthorization/disallowed_secret_via_pod-8                              875 ns/op   693 B/op   17 allocs/op    2000000
      BenchmarkAuthorization/disallowed_shared_secret_via_pvc-8                      1215 ns/op   948 B/op   22 allocs/op    1000000
      BenchmarkAuthorization/disallowed_pvc-8                                         912 ns/op   693 B/op   17 allocs/op    2000000
      BenchmarkAuthorization/disallowed_pv-8                                         1137 ns/op   834 B/op   19 allocs/op    2000000
      BenchmarkAuthorization/disallowed_attachment_-_no_relationship-8                892 ns/op   677 B/op   16 allocs/op    2000000
      BenchmarkAuthorization/disallowed_attachment_-_feature_disabled-8               236 ns/op   208 B/op    2 allocs/op   10000000
      BenchmarkAuthorization/allowed_attachment_-_feature_enabled-8                   723 ns/op   593 B/op   12 allocs/op    2000000
      
      BenchmarkAuthorization/contentious_allowed_node_configmap-8                     726 ns/op   529 B/op   11 allocs/op    2000000
      BenchmarkAuthorization/contentious_allowed_configmap-8                          698 ns/op   529 B/op   11 allocs/op    2000000
      BenchmarkAuthorization/contentious_allowed_secret_via_pod-8                     778 ns/op   529 B/op   11 allocs/op    2000000
      BenchmarkAuthorization/contentious_allowed_shared_secret_via_pod-8            21406 ns/op   638 B/op   13 allocs/op     100000
      BenchmarkAuthorization/contentious_disallowed_node_configmap-8                 1135 ns/op   692 B/op   17 allocs/op    1000000
      BenchmarkAuthorization/contentious_disallowed_configmap-8                      1239 ns/op   691 B/op   17 allocs/op    1000000
      BenchmarkAuthorization/contentious_disallowed_secret_via_pod-8                 1043 ns/op   692 B/op   17 allocs/op    1000000
      BenchmarkAuthorization/contentious_disallowed_shared_secret_via_pvc-8          1404 ns/op   950 B/op   22 allocs/op    1000000
      BenchmarkAuthorization/contentious_disallowed_pvc-8                            1177 ns/op   693 B/op   17 allocs/op    1000000
      BenchmarkAuthorization/contentious_disallowed_pv-8                             1295 ns/op   834 B/op   19 allocs/op    1000000
      BenchmarkAuthorization/contentious_disallowed_attachment_-_no_relationship-8   1170 ns/op   676 B/op   16 allocs/op    1000000
      BenchmarkAuthorization/contentious_disallowed_attachment_-_feature_disabled-8   262 ns/op   208 B/op    2 allocs/op   10000000
      BenchmarkAuthorization/contentious_allowed_attachment_-_feature_enabled-8       790 ns/op   593 B/op   12 allocs/op    2000000
      
      --- BENCH: BenchmarkAuthorization
         node_authorizer_test.go:592: graph modifications during non-contention test: 0
         node_authorizer_test.go:589: graph modifications during contention test: 6301
         node_authorizer_test.go:590: <1ms=5507, <10ms=128, <25ms=43, <50ms=65, <100ms=135, <250ms=328, <500ms=93, <1000ms=2, >1000ms=0
      PASS
      ok     k8s.io/kubernetes/plugin/pkg/auth/authorizer/node   112.616s
      ```
      
      ```release-note
      NONE
      ```
      f0b207df
    • Kubernetes Submit Queue's avatar
      Merge pull request #62409 from rajansandeep/corednsscaler · 77f53242
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62409, 62856). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      DNS-Autoscaler support for CoreDNS
      
      **What this PR does / why we need it**:
      This PR provides the dns-horizontal autoscaler for CoreDNS in kube-up, enabling the tests to pass once CoreDNS is the default. 
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #61176 
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      77f53242
  2. 22 Apr, 2018 1 commit
  3. 21 Apr, 2018 6 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #62886 from msau42/fix-localssd-fsgroup · afa68cc2
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62780, 62886). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Only count local mounts that are from other pods
      
      **What this PR does / why we need it**:
      In GCE, we mount the same local SSD in two different paths (for backwards compatability).  This makes the fsGroup conflict check fail because it thinks the 2nd mount is from another pod.  For the fsgroup check, we only want to detect if other pods are mounting the same volume, so this PR filters the mount list to only those mounts under "/var/lib/kubelet".
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #62867
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      afa68cc2
    • Kubernetes Submit Queue's avatar
      Merge pull request #62780 from RenaudWasTaken/master · 48243a9c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62780, 62886). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Change Capacity log verbosity in status update
      
      *What this PR does / why we need it:*
      
      While in production we noticed that the log verbosity for the Capacity field in the node status was to high.
      This log message is called for every device plugin resource at every update.
      
      A proposed solution is to tune it down from V(2) to V(5). In a normal setting you'll be able to see the effect by looking at the node status.
      
      Release note:
      ```
      NONE
      ```
      
      /sig node
      /area hw-accelerators
      /assign @vikaschoudhary16 @jiayingz @vishh
      48243a9c
    • Kubernetes Submit Queue's avatar
      Merge pull request #56525 from tianshapjq/testcase-helpers_linux.go · 4d6a6ced
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      new testcase to helpers_linux.go
      
      new testcase to helpers_linux.go, PTAL.
      
      ```release-note
      NONE
      ```
      4d6a6ced
    • Kubernetes Submit Queue's avatar
      Merge pull request #62765 from wgliang/master.pob-name-conflict · bdd6ff40
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61324, 62880, 62765). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      -Fix the name could cause a conflict if an object with the same name …
      
      …is created in a different namespace
      
      **What this PR does / why we need it**:
      /kind bug
      
      Using the name could cause a conflict if an object with the same name is created in a different namespace
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      #62750
      
      **Special notes for your reviewer**:
      /assign @bsalamat 
      
      **Release note**:
      ```
      NONE
      ```
      bdd6ff40
    • Kubernetes Submit Queue's avatar
      Merge pull request #62880 from deads2k/cli-35-io · 467ce8d8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61324, 62880, 62765). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      provide standard iostream struct for commands
      
      Commands usually need some kind of iostream.  For consistency, delegation, and testability this pull introduces a standard struct to embed in every set of command options.  It also starts the plumbing so that the benefits of standardization for all three of those cases become clear.
      
      @kubernetes/sig-cli-maintainers 
      @soltysh @juanvallejo 
      
      ```release-note
      NONE
      ```
      467ce8d8
    • Kubernetes Submit Queue's avatar
      Merge pull request #61324 from pospispa/60764-K8s-1.10-StorageObjectInUseProtection-downgrade-issue · 663c6edc
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61324, 62880, 62765). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Always Start pvc-protection-controller and pv-protection-controller
      
      **What this PR does / why we need it**:
      After K8s 1.10 is upgraded to K8s 1.11 finalizer `[kubernetes.io/pvc-protection]` is added to PVCs
      because `StorageObjectInUseProtection` feature will be GA in K8s 1.11.
      However, when K8s 1.11 is downgraded to K8s 1.10 and the `StorageObjectInUseProtection` feature is disabled the finalizers remain in the PVCs and as `pvc-protection-controller` is not started in K8s 1.10 finalizers are not removed automatically from deleted PVCs and that's why deleted PVC are not removed from the system but remain in `Terminating` phase.
      The same applies to `pv-protection-controller` and `[kubernetes.io/pvc-protection]` finalizer in PVs.
      
      That's why `pvc-protection-controller` is always started because the `pvc-protection-controller` removes finalizers from PVCs automatically when a PVC is not in active use by a pod.
      Also the `pv-protection-controller` is always started to remove finalizers from PVs automatically when a PV is not `Bound` to a PVC.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes N/A
      This issue https://github.com/kubernetes/kubernetes/issues/60764 is for downgrade from K8s 1.10 to K8s 1.9.
      This PR fixes the same problem but for downgrade from K8s 1.11 to K8s 1.10.
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      663c6edc
  4. 20 Apr, 2018 27 commits
  5. 19 Apr, 2018 1 commit