1. 25 Jul, 2017 25 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #49286 from kargakis/remote-myself-from-some-places · 9bdf464b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49286, 49550)
      
      Remove myself from a bunch of places
      
      I am assigned in reviews which I never get to do. I prefer drive-bys whenever I can do them rather than the bot choosing myself in random, ends up being mere spam.
      
      @smarterclayton please approve.
      9bdf464b
    • Kubernetes Submit Queue's avatar
      Merge pull request #49192 from mfojtik/unify-clientgen-tags · cce1c9b4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49498, 49192)
      
      Unify genclient tags and add more fine control on verbs generated
      
      This will change the syntax of the existing `genclient` tags be like this:
      
      ```
      // +genclient
      // +genclient:noStatus
      // +genclient:noVerbs
      // +genclient:nonNamespaced
      // +genclient:readonly
      ```
      
      The first one indicates the client will be generated from the struct below and the other tags are basically options to the genclient (which justify why they should be prefixed with `genclient:`)
      
      This also changes the `// +genclientstatus=false` to `// +genclient:noStatus` to follow the pattern and also changes the `// +noMethods=true` to `// +genclient:noVerbs` as we call the REST operations verbs so it will make it consistent with terminology.
      
      In addition to existing options this patch also add two more to allow more fine-grained control on which verbs are going to be generated. This is extra useful for third-party projects (like OpenShift) where some resources does not implement full CRUD, but for example just "create" verb or "create" and "delete"...
      To support that, you can use this syntax:
      
      ```
      // +genclient:onlyVerbs=create,delete
      // +genclient:skipVerbs=patch
      ```
      
      The first one will generate only create and delete functions and second one will generate full CRUD without "patch" actions. This somehow overlaps with the existing "readonly" tag, but I want to keep that tag in place as it reads better in some cases ;-)
      cce1c9b4
    • Kubernetes Submit Queue's avatar
      Merge pull request #49498 from luxas/kubeadm_fix_config_validation · c31a1379
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49498, 49192)
      
      kubeadm: Make sure --config can be mixed with --skip-* flags
      
      **What this PR does / why we need it**:
      
      fixes: https://github.com/kubernetes/kubeadm/issues/352
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      Should be a cherrypick candidate
      
      **Release note**:
      
      ```release-note
      kubeadm: Fixes a small bug where `--config` and `--skip-*` flags couldn't be passed at the same time in validation.
      ```
      @kubernetes/sig-cluster-lifecycle-pr-reviews @ericchiang @wojtek-t
      c31a1379
    • Kubernetes Submit Queue's avatar
      Merge pull request #49496 from rootfs/iscsi-fc-reviewer · 8d1b090d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49479, 49496)
      
      tune iscsi and fc volume owner
      
      **What this PR does / why we need it**:
      add @mtanino to iscsi and fc volume reviewer
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      @kubernetes/sig-storage-misc 
      **Release note**:
      
      ```release-note
      NONE
      ```
      8d1b090d
    • Kubernetes Submit Queue's avatar
      Merge pull request #49479 from sttts/sttts-no-staging-in-gopath · db7a47fe
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49479, 49496)
      
      hack/update-staging-godep.sh: check for staging repos in GOPATH
      db7a47fe
    • Kubernetes Submit Queue's avatar
      Merge pull request #49341 from nicksardo/ilb-e2e · c25a7e6a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48846, 49483, 49341)
      
      GCE: ILB E2E test
      
      /assign @bowei 
      
      **Release note**:
      ```release-note
      NONE
      ```
      c25a7e6a
    • Kubernetes Submit Queue's avatar
      Merge pull request #49483 from xiangpengzhao/e2e-sig-network · 05b8372e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48846, 49483, 49341)
      
      Add [sig-network] prefix to network e2e tests
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      Associated PR #48784
      Umbrella issue #49161
      
      **Special notes for your reviewer**:
      /assign @@wojtek-t @freehan 
      /cc @bowei 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      05b8372e
    • Kubernetes Submit Queue's avatar
      Merge pull request #48846 from dashpole/remove_ood · 7f1d9382
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Remove flags low-diskspace-threshold-mb and outofdisk-transition-frequency
      
      issue: #48843
      
      This removes two flags replaced by the eviction manager.  These have been depreciated for two releases, which I believe correctly follows the kubernetes depreciation guidelines.
      
      ```release-note
      Remove depreciated flags: --low-diskspace-threshold-mb and --outofdisk-transition-frequency, which are replaced by --eviction-hard
      ```
      
      cc @mtaufen since I am changing kubelet flags
      cc @vishh @derekwaynecarr 
      /sig node
      7f1d9382
    • Kubernetes Submit Queue's avatar
      Merge pull request #49357 from mbohlool/opid_fix · 72494353
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix Operation names for subresources
      
      Subresources may have their kind but in operationID and description we should use their parent kind not their own kind. The subresource name represents subresources and no need to repeat in with their kind. e.g. `Scale` has kind of `Scale` and subresource name of `Scale`. This creates names like `read scale of the specified Scale` or `readCoreV1NamespacedScaleScale` for scale on replication controller. This PR fixes description and operation ID for them to `read scale of the specified ReplicationController` and `readCoreV1NamespacedReplicationControllerScale`.
      
      @caesarxuchao I would like this to be patched in 1.7 too as it is useful for all clients and there is no need to wait for 1.8 for this documentation fix.
      
      ```release-note
      Fixed OpenAPI Description and Nickname of API objects with subresources
      ```
      
      fixes #49250
      72494353
    • Kubernetes Submit Queue's avatar
      Merge pull request #49253 from Quentin-M/no_host_pred_test · 3f887171
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49358, 49253)
      
      Remove hostname label condition in SchedulerPredicates
      
      **What this PR does / why we need it**:
      
      ```
      validates that NodeSelector is respected if matching [Conformance]
      validates that required NodeAffinity setting is respected if matching
      ```
      
      The two tests above make the assumption that the node names are equal to the `kubernetes.io/hostname` labels. Unfortunately, this is not necessarily true all the time. For instance, when using the AWS Cloud Provider + Container Linux:
      - The node name is set using the AWS SDK's `ec2.Instance.PrivateDnsName` and has the form `ip-10-0-35-57.ca-central-1.compute.internal` [[1](https://github.com/kubernetes/kubernetes/blob/v1.7.1/pkg/cloudprovider/providers/aws/aws.go#L3343-L3346)] [[2](https://raw.githubusercontent.com/aws/aws-sdk-go/master/service/ec2/api.go)]
      - The node's hostname, however, is a simple call to `os.Hostname()`, itself reading `/proc/sys/kernel/hostname`, which contains what the AWS DHCP assigned to the instance, typically the hostname short-form: `ip-10-0-16-137`.  [[1](https://github.com/kubernetes/kubernetes/blob/v1.7.1/pkg/util/node/node.go#L43-L54)]
      
      Consequently, we are trying to assign a pod to a node having the following label: `kubernetes.io/hostname=ip-10-0-35-57.ca-central-1.compute.internal` (in addition to the randomly generated label), whereas the actual label on the node is `kubernetes.io/hostname=ip-10-0-35-57`.
      
      Furthermore, this inaccurate `kubernetes.io/hostname=<nodename>` condition is actually useless given we already match over a random label, that was assigned to that node. Later, the test ensures that the scheduled pod was scheduled to the right node by comparing the pod's node name and the node name we expected the pod to be on:
      
      ```
      framework.ExpectNoError(framework.WaitForPodNotPending(cs, ns, labelPodName))
      labelPod, err := cs.Core().Pods(ns).Get(labelPodName, metav1.GetOptions{})
      framework.ExpectNoError(err)
      Expect(labelPod.Spec.NodeName).To(Equal(nodeName))
      ```
      
      The `k8s.io/apimachinery/pkg/types/nodename` data structure actually [warns](https://github.com/kubernetes/kubernetes/blob/55bee3ad21f025b1416a4e1f10de753f484b66d3/staging/src/k8s.io/apimachinery/pkg/types/nodename.go#L40-L43) about the fact that the node name might be different than the hostname on AWS.
      
      **Release note**:
      ```release-note
      NONE
      ```
      3f887171
    • Kubernetes Submit Queue's avatar
      Merge pull request #49358 from jianglingxia/jlx72113 · 144a4c2b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      [trival] fix typo
      
      **What this PR does / why we need it**:
      some file word spell error that amend correct
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      144a4c2b
    • Kubernetes Submit Queue's avatar
      Merge pull request #49274 from dixudx/add_const_for_rbd · ee7eb4a2
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48911, 49475, 49438, 49362, 49274)
      
      set RBD default values as constant vars
      
      **What this PR does / why we need it**:
      
      When working on #49225, I found some [default RBD parameters](https://kubernetes.io/docs/concepts/storage/persistent-volumes/#ceph-rbd) had not been declared as constant values, which will be error-prone.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      set RBD default values as constant vars
      ```
      ee7eb4a2
    • Kubernetes Submit Queue's avatar
      Merge pull request #49362 from zhangxiaoyu-zidif/fix-pdb-describer · f08e5302
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48911, 49475, 49438, 49362, 49274)
      
      Add namespace for describe pdb
      
      **What this PR does / why we need it**:
      add namespace for describe pdb
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      fixes https://github.com/kubernetes/kubernetes/issues/49363
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      f08e5302
    • Kubernetes Submit Queue's avatar
      Merge pull request #49438 from zhangxiaoyu-zidif/delete-err-def-for-drain · 0e94e943
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48911, 49475, 49438, 49362, 49274)
      
      Delete redundant err definition
      
      **What this PR does / why we need it**:
      Delete redundant err definition
      line 642 has its definition and initialization, so line 641 is redundant.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      NONE
      
      **Special notes for your reviewer**:
      NONE
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      0e94e943
    • Kubernetes Submit Queue's avatar
      Merge pull request #49475 from jsafrane/fix-gluster-make · 159dcbfb
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48911, 49475, 49438, 49362, 49274)
      
      Fixed glusterfs mount options
      
      Capacity of a slice is the third argument, not the second one.
      We use append() to fill the slice, so it should be empty at the beginning
      and with the right capacity.
      
      ```release-note
      NONE
      ```
      159dcbfb
    • Kubernetes Submit Queue's avatar
      Merge pull request #48911 from verult/StorageTests · 97eed3f7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Added sig-storage labels to upgrade tests and moved them to appropriate directory
      
      **What this PR does / why we need it**: Adding necessary sig identifier for storage upgrade tests.
      
      /release-note-none
      97eed3f7
    • Kubernetes Submit Queue's avatar
      Merge pull request #49494 from shyamjvs/kubemark-fix · 647c0033
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48636, 49088, 49251, 49417, 49494)
      
      Fix bug in command retrying in kubemark
      
      This should fix some of the flakes mentioned in https://github.com/kubernetes/kubernetes/issues/46195.
      It's showing that all subsequent retries have failed if the first one failed due to `ret_val` not being reassigned on success.
      
      @bskiba Thanks for noticing :)
      647c0033
    • Kubernetes Submit Queue's avatar
      Merge pull request #49417 from caesarxuchao/rename · 0dfc696d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48636, 49088, 49251, 49417, 49494)
      
      [nit] Rename pkg/api/v1/builder.go to register.go to be consistent with others
      0dfc696d
    • Kubernetes Submit Queue's avatar
      Merge pull request #49251 from enisoc/initialized-annotation · 7e5fd72a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48636, 49088, 49251, 49417, 49494)
      
      StatefulSet: Remove `pod.alpha.kubernetes.io/initialized` annotation.
      
      The `pod.alpha.kubernetes.io/initialized` annotation was originally a tool for validating StatefulSet's ordered Pod creation guarantees during the feature's alpha phase.
      
      If set to "false" on a given Pod, it would interrupt StatefulSet's normal behavior. In v1.5.0, the annotation was deprecated and the default became "true" as part of StatefulSet's graduation to beta.
      
      The annotation is now ignored, meaning it cannot be used to interrupt StatefulSet Pod management.
      
      ```release-note
      StatefulSet: The deprecated `pod.alpha.kubernetes.io/initialized` annotation for interrupting StatefulSet Pod management is now ignored. If you were setting it to `true` or leaving it unset, no action is required. However, if you were setting it to `false`, be aware that previously-dormant StatefulSets may become active after upgrading.
      ```
      
      ref #41605
      7e5fd72a
    • Kubernetes Submit Queue's avatar
      Merge pull request #49088 from xiangpengzhao/get-crd · 8c58bb6e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48636, 49088, 49251, 49417, 49494)
      
      Add customresourcedefinition and its shortcut in "kubectl get"
      
      **What this PR does / why we need it**:
      Add customresourcedefinition and its shortcut in "kubectl get" help info.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48927
      
      **Special notes for your reviewer**:
      /cc @orangedeng 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      8c58bb6e
    • Kubernetes Submit Queue's avatar
      Merge pull request #48636 from jingxu97/July/allocatable · e623fed7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48636, 49088, 49251, 49417, 49494)
      
      Fix issues for local storage allocatable feature
      
      This PR fixes the following issues:
      1. Use ResourceStorageScratch instead of ResourceStorage API to represent
      local storage capacity
      2. In eviction manager, use container manager instead of node provider
      (kubelet) to retrieve the node capacity and reserved resources. Node
      provider (kubelet) has a feature gate so that storagescratch information
      may not be exposed if feature gate is not set. On the other hand,
      container manager has all the capacity and allocatable resource
      information.
      
      This PR fixes issue #47809
      e623fed7
    • Kubernetes Submit Queue's avatar
      Merge pull request #48778 from juanvallejo/jvallejo/fix-jsonpath-negative-index-panic · dbcc199d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      stop jsonpath panicing on negative array length
      
      Related downstream issue: https://github.com/openshift/origin/issues/15075
      
      Returns error if provided jsonpath value results in a negative slice index after adding the length of the slice:
      
      ```go
      a := [0, 1, 2, 3]
      b := a[-1:] // 3
      c := a[-4:] // 0
      d := a[-5:] // out of range error
      e := a[4:]  // out of range error
      ```
      
      **Release note**:
      ```release-note
      NONE
      ```
      
      cc @fabianofranz
      dbcc199d
    • xiangpengzhao's avatar
      f2875794
    • mbohlool's avatar
      Update swagger and OpenAPI spec · 75c474d4
      mbohlool authored
      75c474d4
    • mbohlool's avatar
      Fix Operation names for subresources · 61ba8ca0
      mbohlool authored
      61ba8ca0
  2. 24 Jul, 2017 15 commits