- 11 Jul, 2018 16 commits
-
-
Haowei Cai authored
-
Haowei Cai authored
-
Anago GCB authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66076, 65792, 65649). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubernetes: fix printf format errors These are all flagged by Go 1.11's more accurate printf checking in go vet, which runs as part of go test. ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66076, 65792, 65649). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove DefaultingSerializer as it is not being used Keeping unused code around is confusing at least. The Serializer is not used as far as I can tell. If any external project is using it, they should just copy it in their code.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Don't delete pkg/generated/bindata.go in make clean **What this PR does / why we need it**: follow-up to #65985: `pkg/generated/bindata.go` has been re-added to the repo, so `make clean` shouldn't delete it, as doing so makes the tree dirty. This is mostly problematic for jobs which run `make clean` followed by `make quick-release` or `make release` (like our CI build job), since those won't regenerate `pkg/generated/bindata.go`, as they run builds inside the build container. **Release note**: ```release-note NONE ```
-
Jeff Grafton authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add region label to dynamic provisioned cinder PVs **What this PR does / why we need it**: This PR adds region label to dynamic provisioned Cinder PVs at the time of the PV creation. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #65977 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66051, 66049). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Always mark gke-exec-auth-plugin executable **What this PR does / why we need it**: mark gke-exec-auth-plugin executable after downloading **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66051, 66049). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix:Image garbage collection is always disabled in kubelet in 1.11 **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #66046 **Special notes for your reviewer**: @yujuhong @derekwaynecarr **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add local volume pod affinity tests. **What this PR does / why we need it**: Add local volume pod affinity tests. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #56100 (with already merged prs #59682, #60260) **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fixing comments in types.go to describe the changes for CSI driver default FS type override fix This PR fixes the comment in types.go which was made in the commit https://github.com/kubernetes/kubernetes/pull/65499/commits/5dfe7b5758141b24fa5899618003eb3f2a9289b4 In the above commit, the change that fixed the override of default FSType for CSI driver was made. However the comments in types.go were made for GCEPersistentDiskVolumeSource and RBDVolumeSource respectively. This commit fixes that comment to reflect the changes for CSI driver ```release-note none ```
-
jiaxuanzhou authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66038, 65992, 66008). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Convert TestServerRunWithSNI to subtests to isolate flake This test is flaking - make it easier to pin down where and why by converting to subtests and making cleanup logic simpler. Also turn an ignored listen error into a "fatal". Make the test run in parallel to speed up individual runs and hopefully flush out issues. Noticed and reported in OpenShift, https://github.com/openshift/origin/issues/20220 @deads2k / @sttts
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66038, 65992, 66008). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Stop sorting downward api file lines Fixes #65159 ```release-note fixes an issue with multi-line annotations injected via downward API files getting scrambled ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66038, 65992, 66008). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. ensure rs pod cleanup happens related to #65908 /assign juanvallejo ```release-note NONE ```
-
- 10 Jul, 2018 24 commits
-
-
Andrew Lytvynov authored
-
Krunal Jain authored
-
Krunal Jain authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65794, 65919). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Incremented the elasticsearch version **What this PR does / why we need it**: Applies changes implemented in: https://github.com/kubernetes/kubernetes/pull/65627 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65794, 65919). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove references to the Debian-based Container-VM image The image reached end-of-life in October 2017. Remove the associated references from the cluster setup script. **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Russ Cox authored
These are all flagged by Go 1.11's more accurate printf checking in go vet, which runs as part of go test. Lubomir I. Ivanov <neolit123@gmail.com> applied ammend for: pkg/cloudprovider/provivers/vsphere/nodemanager.go
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65931, 65705, 66033). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove unused x509 code We don't intend to use/support these user extraction methods ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65931, 65705, 66033). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Block volumes should have empty FSType FSType in block PVs has no meaning and it should be empty in provisioned PVs. **Which issue(s) this PR fixes** Fixes #65704 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65931, 65705, 66033). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubeadm: run kube-proxy on non-master tainted nodes **What this PR does / why we need it**: kube-proxy should be able to run on all nodes, independent on the taint of such nodes. This restriction was previously removed in bb28449e but then was brought back in d1949261. /cc @kubernetes/sig-cluster-lifecycle-pr-reviews /cc @luxas @detiber @dixudx @discordianfish @mxey /kind bug /area kube-proxy /area kubeadm **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes kubernetes/kubeadm#699 **Special notes for your reviewer**: we are removing the requirement again, but please have a look at all the implications here. hopefully we don't have to bring it again. **Release note**: ```release-note kubeadm: run kube-proxy on non-master tainted nodes ```
-
Clayton Coleman authored
This test is flaking - make it easier to pin down where and why by converting to subtests and making cleanup logic easier. Also turn an ignored listen error into a "fatal". Make the test run in parallel to speed up individual runs and hopefully flush out issues.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66030, 65997). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove unused io util writer & volume host GetWriter() Cleanup unused code. Fixes https://github.com/kubernetes/kubernetes/issues/16971 **Release note**: ```release-note NONE ``` /kind cleanup /sig storage
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66030, 65997). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. declare conversion dependencies fixes #65988 verified all packages regenerate cleanly individually with: ``` for x in $(find . -name *zz*conversion* | xargs -n 1 dirname); do touch $x; make generated_files; git status; done ``` ```release-note NONE ```
-
Jordan Liggitt authored
-
Jordan Liggitt authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55023, 65499). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bugfix/csi default fs type This PR address the issue mentioned in the following ticket https://github.com/kubernetes/kubernetes/issues/65122 The FSType string will now not be defaulted to ext4. Removes defaulting of CSI file system type to ext4. CSI plugins that depended on this default need to be updated as the fsType would remain an empty string if not provided and would not default to ext4. CSI spec allows for an empty fstype string. This is intended for non-block plugins like nfs and gluster where filesystems are not separately created on the volume. But currently the default file system is overridden to ext4 which makes the above case redundant. This commit prevents such an overridding. ```release-note ACTION REQUIRED: Removes defaulting of CSI file system type to ext4. All the production drivers listed under https://kubernetes-csi.github.io/docs/Drivers.html were tested and work as expected after this change. If you are using a driver not in that list, please test the drivers on an updated test cluster first. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55023, 65499). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove labels.yaml Update `labels.yaml` with latest labels. Came across this while removing all "thirdpartyresource" occurrences. Noticed that other labels also need update, so opened a new PR. :) Edit: updated to remove the file entirely. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 64695, 65982, 65908). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. switch delete strategy to background deletion **Release note**: ```release-note "kubectl delete" no longer waits for dependent objects to be deleted when removing parent resources ``` ### Before 1.11.0 - Resources that had client-side reapers in older versions of the client had all of their dependents deleted first. The parent resource itself was deleted *last*. This allowed the command to be re-entrant and was largely an artifact of it **having** to be done that way by a client-side reaper. ### After 1.11.0 (with this PR) - Resources that previously had client-side reapers are no longer deleted last (after their dependents). They are now instead deleted first. The garbage-collector server-side then deletes any dependents. - This means that the `delete` command can return, and the parent object can be deleted while child objects still exist. - This is okay because the child resources are eventually deleted by the garbage collector server-side. cc @liggitt @soltysh
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 64695, 65982, 65908). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. re-make print flags composeable for sophisticated callers Composers need to override all the pieces of logic independently. It also simplifies the determination logic. @kubernetes/sig-cli-maintainers /assign @juanvallejo ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 64695, 65982, 65908). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Collecting etcd metrics **What this PR does / why we need it**: Adding etcd metrics to performance test log. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: ref #64030 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Jordan Liggitt authored
-
David Eads authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 63793, 65989). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix wrong flexvolume dir on gce ubuntu **What this PR does / why we need it**: Fixes https://github.com/kubernetes/kubernetes/issues/65777 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes https://github.com/kubernetes/kubernetes/issues/65777 **Special notes for your reviewer**: everything is named for gci being the one exception but i assume ubuntu received the change at the same time `gciVolumePluginDirVersion = "1.10.0"` **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 63793, 65989). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Enable kubectl proxy to set tcp keepalive **What this PR does / why we need it**: Allows setting keepalive period for kubectl proxy. Fixes #63727 **Special notes for your reviewer**: /assign @brendandburns **Release note**: ```release-note Introduce a new flag `--keepalive` for kubectl proxy to allow setting keep-alive period for long-running request. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65902, 65781). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. if loadbalancer section is not defined in cloudconfig, do not init support **What this PR does / why we need it**: if LoadBalancer section is not defined in cloudconfig, we should not initialize loadbalancer support for openstack cloudprovider. **Which issue(s) this PR fixes**: Fixes #65775 **Special notes for your reviewer**: **Release note**: ```release-note If LoadBalancer is not defined in cloud config, the loadbalancer is not initialized anymore in openstack. All setups must have some setting under that section ```
-