1. 25 Mar, 2018 6 commits
  2. 24 Mar, 2018 9 commits
  3. 23 Mar, 2018 10 commits
  4. 22 Mar, 2018 15 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #60188 from jingax10/gce_owner_branch · 4dd4cbe8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Add jingax10 as both reviewer and approver in cluster/gce.
      
      **What this PR does / why we need it**:
      
      Want to become both reviewer and owner for cluster/gce.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      N/A
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      
      "NONE"
      ```
      4dd4cbe8
    • Kubernetes Submit Queue's avatar
      Merge pull request #61065 from freehan/fix-gcloud-dev · e81965d4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      fix validation for dev gcloud
      
      ```release-note
      NONE
      ```
      e81965d4
    • Zhen Wang's avatar
      d5c2cdcb
    • Kubernetes Submit Queue's avatar
      Merge pull request #60056 from crassirostris/audit-version-switch · 52ed0368
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Make audit output version configurable.
      
      This is a re-make of https://github.com/kubernetes/kubernetes/pull/51786, taken over form @soltysh 
      
      Copying from the previous PR:
      
      This is followup to https://github.com/kubernetes/kubernetes/pull/51719 to start the discussion how we want to solve the problem of users picking which version is being served them.
      
      We need to have an option for log and webhook, separately. Probably, for webhook backend with multiple destinations we'd like to send different version to each.
      
      This approach adds two flags (only the second commit matters), one for log and another for webhook (unfortunately global one). I've looked into kubeconfig types and although there are options to specify group and version they are meant for removal. @liggitt had some thoughts maybe he could share the ideas and we can pick it up here.
      
      @ericchiang @CaoShuFeng @sttts opinions, thoughts are more than welcome
      
      ```release-note
      Add apiserver configuration option to choose audit output version.
      ```
      52ed0368
    • David Eads's avatar
      456fd386
    • Daniel Kłobuszewski's avatar
      Add @x13n to fluentd-gcp OWNERS · 5503b3e9
      Daniel Kłobuszewski authored
      5503b3e9
    • Kubernetes Submit Queue's avatar
      Merge pull request #61478 from shyamjvs/capture-pod-startup-phases-as-metrics · 1b6b2ee7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61378, 60915, 61499, 61507, 61478). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Capture pod startup phases as metrics
      
      Learning from https://github.com/kubernetes/kubernetes/issues/60589, we should also start collecting and graphing sub-parts of pod-startup latency.
      
      /sig scalability
      /kind feature
      /priority important-soon
      /cc @wojtek-t 
      
      ```release-note
      NONE
      ```
      1b6b2ee7
    • Kubernetes Submit Queue's avatar
      Merge pull request #61507 from rramkumar1/patch-5 · 50cd3ede
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61378, 60915, 61499, 61507, 61478). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Bump image for ingress downgrade test
      
      **What this PR does / why we need it**:
      Bumps the image to the latest released version. This should also fix the failing test.
      
      /assign @bowei 
      
      **Release note**:
      
      ```release-note
      None
      ```
      50cd3ede
    • Kubernetes Submit Queue's avatar
      Merge pull request #61499 from jennybuckley/crd-test-flake · 2919818d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61378, 60915, 61499, 61507, 61478). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fix "Garbage collector should support cascading deletion of custom resources" flake
      
      **What this PR does / why we need it**:
      These webhook configuration objects were intended to have no effect on admission requests, and are just used to ensure that webhook configuration objects can always be deleted.
      
      However, I think they are causing an entirely separate test to flake (Garbage collector should support cascading deletion of custom resources) because of the interaction between these two webhooks, which are run on all admission requests, and #61355 (Unable to create/update CRD when mutating webhook configured) when the two tests are run at around the same time.
      
      This PR will make the effects of the webhook e2e test on other tests easier to reason about.
      
      The flakiness is being caused by a legitimate failure of the underlying code (That CRDs currently don't work with webhooks), but not a failure which either of "Garbage collector should support cascading deletion of custom resources" or "AdmissionWebhooks Should not be able to prevent deleting validating-webhook-configurations or mutating-webhook-configurations" is supposed to reliably catch.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #59997
      
      **Release note**:
      ```release-note
      NONE
      ```
      
      /sig api-machinery
      /kind flake
      2919818d
    • Kubernetes Submit Queue's avatar
      Merge pull request #60915 from CaoShuFeng/htpasswd · ac4caced
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61378, 60915, 61499, 61507, 61478). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      remove unused htpasswd
      
      This file is not used anywhere.
      Further more, this is an error in this file:
      ```
      $ flake8 third_party/htpasswd/htpasswd.py --select=F
      third_party/htpasswd/htpasswd.py:46:13: F821 undefined name 'time'
      ```
      **Release note**:
      ```release-note
      NONE
      ```
      ac4caced
    • Kubernetes Submit Queue's avatar
      Merge pull request #61378 from charrywanganthony/delete_force · 3798b1f8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61378, 60915, 61499, 61507, 61478). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      `--force` only takes effect when `--grace-period=0`
      
      `kubectl delete` should warn when `force` is specified without `--grace-period=0`
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #61374 
      
      
      **Release note**:
      ```release-note
      NONE
      ```
      3798b1f8
    • Kubernetes Submit Queue's avatar
      Merge pull request #61494 from rmmh/watch-flake · f4e71f1c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61453, 61393, 61379, 61373, 61494). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Increase API watch test timeout to avoid flakes.
      
      **What this PR does / why we need it**:
      This test has been [flaking repeatedly](https://storage.googleapis.com/k8s-gubernator/triage/index.html?pr=1#82a58388c2f346567b72), probably because 10 seconds it too short of a deadline. One minute should be more generous.
      
      **Release note**:
      ```release-note
      NONE
      ```
      f4e71f1c
    • Kubernetes Submit Queue's avatar
      Merge pull request #61373 from msau42/subpath-reconstruct · d23066e8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61453, 61393, 61379, 61373, 61494). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Use inner volume name instead of outer volume name for subpath directory
      
      **What this PR does / why we need it**:
      Fixes volume reconstruction for PVCs with subpath
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #61372
      
      **Special notes for your reviewer**:
      
      
      **Release note**:
      
      ```release-note
      ACTION REQUIRED: In-place node upgrades to this release from versions 1.7.14, 1.8.9, and 1.9.4 are not supported if using subpath volumes with PVCs.  Such pods should be drained from the node first.
      ```
      d23066e8
    • Kubernetes Submit Queue's avatar
      Merge pull request #61379 from nikhiljindal/kubemciTest · 85afad33
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61453, 61393, 61379, 61373, 61494). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fixing kubemci conformance tests
      
      Ref https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/issues/131
      
      Changes:
      * Add a static ip annotation while running the tests for kubemci. kubemci requires the IP to be preallocated.
      * Add a default backend service. I have added it in the spec directly, so the change will be for ingress controller as well which should be fine. kubemci requires users to specify a default backend service that they need to ensure exists in all clusters.
      * Disabled update SSL cert test for kubemci since it does not support that.
      * Minor logging fixes.
      
      
      Verified by running the tests locally that they now pass.
      
      ```
      $ KUBECONFIG=~/.kube/config KUBE_MASTER_IP="<IP>" go run hack/e2e.go -- --test --test_args="--ginkgo.focus=kubemci"
      
      • [SLOW TEST:629.179 seconds]
      Loadbalancing: L7
      /usr/local/google/home/nikhiljindal/code/src/github.com/kubernetes/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/network/framework.go:22
        GCE [Slow] [Feature:kubemci]
        /usr/local/google/home/nikhiljindal/code/src/github.com/kubernetes/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/network/ingress.go:604
          should conform to Ingress spec
          /usr/local/google/home/nikhiljindal/code/src/github.com/kubernetes/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/network/ingress.go:637
      ------------------------------
      SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSMar 19 19:45:59.242: INFO: Running AfterSuite actions on all node
      Mar 19 19:45:59.242: INFO: Running AfterSuite actions on node 1
      
      Ran 1 of 820 Specs in 631.245 seconds
      SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 819 Skipped PASS
      
      Ginkgo ran 1 suite in 10m32.602848558s
      Test Suite Passed
      ```
      
      cc @G-Harmon @MrHohn 
      
      
      ```release-note
      NONE
      ```
      85afad33
    • Kubernetes Submit Queue's avatar
      Merge pull request #61393 from totherme/fix-test-cmd-on-osx · 9f71d7f8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61453, 61393, 61379, 61373, 61494). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Make `test-cmd` work with OS-X tooling
      
      OS-X thips with the BSD versions of `date` and `grep`. Those don't have
      certain features the script relies on:
      - BSD date does not support nanoseconds (`%N`)
      - BSD grep does not support perl RegEx (`-P`)
      
      As we use `bash` specifically in the hashbang anyway it is probably fine
      to rely on the `$RANDOM` bashism here.
      
      **What this PR does / why we need it**:
      
      Currently `make test-cmd` doesn't work on OSX. This PR makes `make test-cmd` work on OSX.
      
      **Release note**:
      ```release-note
      `make test-cmd` now works on OSX.
      ```
      
      cc: @apelisse
      9f71d7f8