- 03 Nov, 2017 1 commit
-
-
David Eads authored
-
- 02 Nov, 2017 33 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. admission: wire through validating-only admission Based on https://github.com/kubernetes/kubernetes/pull/54232. This is important and required for beta because it affects the shape of the webhook admission plugins that are going to be produced and is needed to make sure that our existing chain continues to properly verify and protect the API objects based on their final state after webhook admission mutators run. We discussed this in the October 11 API machinery call with @erictune and @caesarxuchao and we agreed to do this as a requirement for beta. See this part of the recording: https://www.youtube.com/watch?v=mrgDPHyr4VY#t=325 .
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54800, 53898, 54812, 54921, 53558). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix error for strategic merge patch of custom resources Fixes #50037. We need the go struct tags `patchMergeKey` and `patchStrategy` for fields that support a strategic merge patch. For native resources, we can easily figure out these tags since we know the fields. Because custom resources are decoded as Unstructured and because we're missing the metadata about how to handle each field in a strategic merge patch, we can't find the go struct tags. Hence, we can't easily do a strategic merge for custom resources. So we should fail fast and return an error. **Release note**: ```release-note NONE ``` /cc @sttts @deads2k @ncdc
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54800, 53898, 54812, 54921, 53558). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. rename metric reflector_xx_last_resource_version **What this PR does / why we need it**: mv reflector name from metric name to metric label before: ``` reflector_k8s_io_kubernetes_pkg_client_informers_informers_generated_internalversion_factory_go:73_8664_last_resource_version{instance="104.154.20.21:443",job="kubernetes-apiservers"} ``` after ``` reflector_last_resource_version{instance="10.0.2.15:6443",job="kubernetes-apiservers",name="k8s_io_kubernetes_pkg_client_informers_informers_generated_internalversion_factory_go_73_8664"} ``` **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #52121 **Special notes for your reviewer**: None **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54800, 53898, 54812, 54921, 53558). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Allow override of cluster level (default, whitelist) tolerations by namespace level empty (default, whitelist) tolerations. Currently In PodTolerationRestriction admission plugin, if namespace level default and whitelist of tolerations are nil or empty, they do not override cluster level default and whitelist tolerations. This PR fixes the plugin to not override cluster level tolerations only when namespace level toleration are nil. IOW, if namespace level toleration are empty, they override cluster level tolerations. To be more clear, if following annotations are set to empty, they override cluster level tolerations. ``` scheduler.alpha.kubernetes.io/defaultTolerations : "" scheduler.alpha.kubernetes.io/tolerationsWhitelist: "" ``` This behavior is inline with PodNodeSelector admission plugin too. @sjenning @derekwaynecarr **Release Note**: ```release-note In PodTolerationRestriction admisson plugin, if namespace level tolerations are empty, now they override cluster level tolerations. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54800, 53898, 54812, 54921, 53558). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. NewProxierWithNoProxyCIDR: fix handling IPv6 URLs **What this PR does / why we need it**: Current logic of splitting hostname from URL does not work if URL is for IPv6 address and does not explicitly specify port number. Example: "https://[2001:db8::1]/". Use standard library function to get hostname out of URL string. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: **Special notes for your reviewer**: **Release note**: ```release-note - Fix handling of IPv6 URLs in NO_PROXY. ``` /area ipv6 /sig api-machinery
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubenet: yield lock while executing CNI plugin. The CNI plugin can take up to 3 seconds to execute. CNI plugins can safely be executed in parallel, so yield the lock to speed up pod creation. This caused problems with the pod latency tests - previously, CNI plugins executed in under 20ms. Now they must wait for DAD to finish and addresses to leave tentative state. Fixes: #54651 **What this PR does / why we need it**: After upgrading CNI plugins to v0.6 in #51250, the pod latency tests began failing. This is because the plugins, in order to support IPv6, need to wait for DAD to finish. Because this delay is while the kubenet lock is held, it significantly slows down the pod creation rate. **Special notes for your reviewer**: The CNI plugins also do locking for their critical paths, so it is safe to run them concurrently. **Release note**: ```release-note NONE ```
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Improve deleteOptions doc **What this PR does / why we need it**: This PR improves the doc of the 'PropagationPolicy' property of the DeleteOptions struct. The said field is a string. It is very important a field for people who invoke a delete API. For example, direct invocation of the deployment-delete API using the python client will have the replicaset and pods left behind. However, this field was not well documented. When people wanted to try different options, they have to dig into k8s source code to find out the acceptable values. **Which issue this PR fixes**: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
David Eads authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54787, 51940). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Useful helper functions for Unstructured **Which issue this PR fixes**: Fixes #40790 **Release note**: ```release-note NONE ``` /kind feature /sig api-machinery /area client-libraries /assign @sttts @liggitt
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54787, 51940). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Migrate netwrok partition test to sig apps **What this PR does / why we need it**: Migrate network partition relevant e2e test to sig-app. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Ref Umbrella issue #49161 **Special notes for your reviewer**: **Release note**: ```release-note none ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54895, 54449). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update the get command to follow more conventions of commands Pure code movement, builds on top of #54446 and only the last commit is new. Will make refactoring get easier.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54895, 54449). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix a bug checking DaemonSet pods are updated in e2e test **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #50586 **Special notes for your reviewer**: @kubernetes/sig-apps-bugs **Release note**: ```release-note NONE ```
-
tengqm authored
-
tengqm authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54042, 54185, 54880). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Inventory of kubectl dependency on main repository **What this PR does / why we need it**: Add an import-boss file to inventory what kubectl depends on, so we can prune this list over time and eventually get kubectl out of the main k/k repository. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Related to https://github.com/kubernetes/kubectl/issues/114 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54042, 54185, 54880). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. refactor ReplicaSet sync call tree **What this PR does / why we need it**: This PR refactors ReplicaSet sync call tree by refactoring `manageReplicas` and `syncReplicaSet` functions into smaller functions, and adding unit tests to each of the smaller functions. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: xref #52118 **Release note**: ```release-note NONE ``` **TODO**: - `manageReplicas` - [x] move both outer and inner `batchSize` loops to a helper function named `slowStartBatch`, and test the function - [x] add a helper function returning a list named `podsToDelete`, test the function, and refactor `DeletePod` loop to use the list - [x] refactor skipped pod handling such that it happens after `slowStartBatch` returns - `syncReplicaSet` - [x] add unit tests for `calculateStatus` - [x] move `canAdoptFunc` to a helper function
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add sig-storage prefix for common e2e tests **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # ref: #49161 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54875, 54813, 54595, 54947, 54766). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Make github hide generated files in diffs **What this PR does / why we need it**: https://github.com/github/linguist#generated-code says to add `linguist-generated=true` to any files that you don't want to see diffs in. IMO this will make PRs a little easier to review. e.g. the top half of https://github.com/kubernetes/kubernetes/pull/53988 should disappear **Which issue this PR fixes** **Special notes for your reviewer**: **Release note**: NONE
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54875, 54813, 54595, 54947, 54766). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. extra_sans option added to load balancer Also cleaned up kubernetes-master charm to use the new method of determining a certificate has changed. **What this PR does / why we need it**: Adds an option for the load balancer charm to add extra SAN entries to the generated certificate used by nginx. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note Added extra_sans config option to kubeapi-load-balancer charm. This allows the user to specify extra SAN entries on the certificate generated for the load balancer. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54875, 54813, 54595, 54947, 54766). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add bsalamat to milestone maintainers **Release note**: ```release-note NONE ``` @thockin @davidopp
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54875, 54813, 54595, 54947, 54766). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Do not clobber KUBERNETES_PROVIDER - fix kubeadm/gce log collection **What this PR does / why we need it**: This gets in the way of correct log collection for at least the kubeadm/gce jobs. Not sure if this piece of code is needed any more. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Optimize the suboptimal image locality algorithm **What this PR does / why we need it**: Cut loop depth from 3 to 2. **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54894, 54630, 54828, 54926, 54865). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. set leveled logging (v=4) for 'updating container' message **What this PR does / why we need it**: Currently cpu_manager.go logs a line for every pod at every reconcilePeriod (10 sec default) when it reconciles and updates the pod's cpuset setting. This creates a lot of logging information that is not very interesting and we should suppress that by default by increasing the logging level. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #54804 **Special notes for your reviewer**: I chose V(4) because that seems to be a popular level for messages at this detail. Happy to follow logging guideline if there is any. **Release note**: ``` kubelet: cpu_manager logs informative reconcile message at V(4) to reduce clutter ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54894, 54630, 54828, 54926, 54865). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix kubelet startup args **What this PR does / why we need it**: There should not be space between memory and disk. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54894, 54630, 54828, 54926, 54865). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. trigger endpoint update on pod deletion Fixes #54723 cc: @joelsmith ```release-note Fix a bug where pod address is not removed from endpoints object while pod is in graceful termination. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54894, 54630, 54828, 54926, 54865). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix a syntax error in a comment **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54894, 54630, 54828, 54926, 54865). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. DaemonSet e2e should wait for history creation **What this PR does / why we need it**: Found a potential test flake while debugging #54575. ControllerRevisions are created separately with DaemonSet pods by controller, so we should wait for its creation in e2e. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: **Special notes for your reviewer**: @kubernetes/sig-apps-bugs **Release note**: ```release-note NONE ```
-
- 01 Nov, 2017 6 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update volume OWNERS to reflect active sig-storage reviewers **What this PR does / why we need it**: Update sig-storage reviewers to add new members and remove those that don't have as much time to review storage PRs. Approvers are unchanged. **Special notes for your reviewer**: For all those that have been removed, please approve. If you want to remain as a reviewer, let me know and I will add you back. **Release note**: NONE
-
Jun Xiang Tee authored
-
Mike Kaplinskiy authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Move hardcoded constants to the beginning of configure.sh script. **What this PR does / why we need it**: Move hardcoded constants of component version and sha1 to the beginning of configure.sh to make it easier for GKE image preloader to parse. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
David Ashpole authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. ClusterAutoscaler 1.0.2-beta2
-