- 03 Mar, 2018 1 commit
-
-
Harry Zhang authored
Add verb and preemption for scheduler extender Update bazel Use simple preemption in extender Use node name instead of v1.Node Fix support method Fix preemption dup Remove uneeded logics Remove nodeInfo from param to extender Update bazel for scheduler types Mock extender cache with nodeInfo Add nodeInfo as extender cache Choose node name or node based on cache flag Always return meta victims in result
-
- 02 Mar, 2018 14 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add //test/e2e/... and //test/integration/... to //build/visible_to:COMMON_testing **What this PR does / why we need it**: adds the common test packages `//test/e2e/...` and `//test/integration/...` to the `COMMON_testing` package group. The immediate need for this is that #60580 unintentionally broke the integration tests under bazel since it added a new dependency on `//pkg/kubectl/cmd/util` without adding an appropriate entry to `//build/visible_to:COMMON_testing`, and the integration tests aren't currently run under bazel for PRs. This PR fixes this breakage and proactively fixes future breakages by adding all packages under `//test/e2e` or `//test/integration` to `COMMON_testing`. **Release note**: ```release-note NONE ``` /assign @BenTheElder @monopole /kind bug /priority important-soon /sig testing cc @kad
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60732, 60689, 60648, 60704). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix a grammatical error in a comment Fix a grammatical error in a comment in scheduler's code. We should use a word's plural form after "one of". **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60732, 60689, 60648, 60704). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Do not count failed pods as unready in HPA controller **What this PR does / why we need it**: Currently, when performing a scale up, any failed pods (which can be present for example in case of evictions performed by kubelet) will be treated as unready. Unready pods are treated as if they had 0% utilization which will slow down or even block scale up. After this change, failed pods are ignored in all calculations. This way they do not influence neither scale up nor scale down replica calculations. @MaciekPytel @DirectXMan12 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #55630 **Special notes for your reviewer**: **Release note**: ``` Stop counting failed pods as unready in HPA controller to avoid failed pods incorrectly affecting scale up replica count calculation. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60732, 60689, 60648, 60704). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. bump(6644d4): spf13/cobra: support bash completion for aliases Fixes kubernetes/kubectl#120 `spf13/cobra` was recently bumped in https://github.com/kubernetes/kubernetes/pull/60530. The changes between then and now are: - Fix generated bash completion for Bash 3 (OSX): https://github.com/spf13/cobra/commit/fd32f09af19efc9b1279c54e0d8ed23f66232a15 - Try out CircleCI: https://github.com/spf13/cobra/commit/be77323fc05148ef091e83b3866c0d47c8e74a8b (but we don't vendor this in anyway) - Do not add a space after a single flag completion: https://github.com/spf13/cobra/commit/1a618fb24b01a0f393ccd82d55c4d8058bdeaf5c - Bash completion aliases: https://github.com/spf13/cobra/commit/a1e4933ab784095895e33dbe9f001ba10cfe2060 (the commit that fixes kubernetes/kubectl#120) - Prefix bash functions with root command name: https://github.com/spf13/cobra/commit/6644d46b81fa1831979c4cded0106e774e0ef0ab (the commit that completely fixes https://github.com/kubernetes/kubernetes/issues/60517) No license changes. **Release note**: ```release-note NONE ``` /cc mengqiy cblecker sttts
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60732, 60689, 60648, 60704). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update gazelle to latest to fix vendoring issue **What this PR does / why we need it**: Fixes #60730 for the master branch. There are otherwise no functional differences. **Release note**: ```release-note NONE ``` /priority critical-urgent /milestone v1.10 /kind bug /sig testing
-
Jeff Grafton authored
-
Nikhita Raghunath authored
-
Shijun Qin authored
Fix a grammatical error in a comment in scheduler's code. We should use a word's plural form after "one of".
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60683, 60386). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Added unschedulabe predicate. Signed-off-by:
Da K. Ma <madaxa@cn.ibm.com> **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #60163 **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60683, 60386). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix PodTemplate validation **What this PR does / why we need it**: This is a bugfix for pod template validation, which can be reproduced by deleting with "foreground deletion" mode (`DeleteOptions.PropagationPolicy = metav1.DeletePropagationForeground`). Because of this bug GC will never delete a pod template with `foregroundDeletion` finalizer. **Special notes for your reviewer**: The issue was originally found and confirmed in the PR #59851, where switching to foreground deletion in `kubectl` broke a unit test revealing this bug. Extracted for easier backporting to releases as suggested in https://github.com/kubernetes/kubernetes/pull/59851#discussion_r171576397 /cc @liggitt @caesarxuchao /sig api-machinery ```release-note NONE ```
-
Nail Islamov authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60530, 60618). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add support for `make verify WHAT=typecheck` This will be used to make the typecheck job emit junit and avoids duplicating the rest of the verify logic. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix kubectl completion so that file names are listed **What this PR does / why we need it**: This PR fixes kubectl completion so that file names are listed with `--filename`. I tested in bash and zsh. This problem is caused by spf13/cobra#520, so I updates vendor github.com/spf13/cobra to just before that commit. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #60517 **Special notes for your reviewer**: @janetkuo @mengqiy @eparis **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Moves the DevicePlugin e2e_node test back to Serial I forgot the fact that the DevicePlugin test itself restarts Kubelet for testing purpose. Move that test back to Serial but constructs a smaller test without kubelet restart that we may run during presubmit. **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes https://github.com/kubernetes/kubernetes/issues/60604 **Special notes for your reviewer**: **Release note**: ```release-note ```
-
- 01 Mar, 2018 25 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52077, 60456, 60591). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. [e2e] Fix panicing ingress jobs **What this PR does / why we need it**: When a nil error is passed into IsProbableEOF(), test will panic. Ref https://github.com/kubernetes/kubernetes/issues/60381#issuecomment-369353511. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #60381 **Special notes for your reviewer**: /assign @shyamjvs cc @krzyzacy **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52077, 60456, 60591). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Adds daemonset conformance tests **What this PR does / why we need it**: Adds conformance tests for deamonset ```release-note Conformance tests are added for the DaemonSet kinds in the apps/v1 group version. Deprecated versions of DaemonSet will not be tested for conformance, and conformance is only applicable to release 1.10 and later. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52077, 60456, 60591). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. API Changes for RunAsGroup First set of api changes for feature https://github.com/kubernetes/community/pull/756 ```release-note Add ability to control primary GID of containers through pod Spec and PodSecurityPolicy ```
-
Ryan Hitchman authored
This will be used to make the typecheck job emit junit and avoids duplicating the rest of the verify logic.
-
Jeff Grafton authored
-
Jiaying Zhang authored
for testing purpose. Move that test back to Serial but constructs a smaller test without kubelet restart that we may run during presubmit.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60542, 60237). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Audit use buffered backend This is the next step after https://github.com/kubernetes/kubernetes/pull/60076 This PR fixes https://github.com/kubernetes/kubernetes/issues/53020, to address https://github.com/kubernetes/kubernetes/issues/53006 later In this PR buffered backend, introduced in https://github.com/kubernetes/kubernetes/pull/60076, is used to replace ad-hoc solution for webhook and add an ability to enable buffering for the log audit backend. ```release-note Log audit backend can now be configured to perform batching before writing events to disk. ``` /cc @sttts @tallclair @ericchiang @CaoShuFeng
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60542, 60237). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Allow update/patch of CRs while CRD is terminating Fixes #60538 Update/patch need to be allowed so finalizers can act on custom resources for terminating CRDs ```release-note Fixes potential deadlock when deleting CustomResourceDefinition for custom resources with finalizers ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60623, 60625, 60520). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add retries to resource deletions in testing framework Fix https://github.com/kubernetes/kubernetes/issues/55860 (last piece towards fixing it hopefully) /cc @wojtek-t ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60623, 60625, 60520). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix azure file plugin failure issue on Windows after node restart **What this PR does / why we need it**: azure file plugin on Windows does not work after node restart, this is due to New-SmbGlobalMapping powershell cmdlet has lost account name/key after reboot, we should remove the invalid link and do the mount again after kubelet restart. add remount logic for azure file plugin in this PR **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #60624 **Special notes for your reviewer**: **Release note**: ``` fix azure file plugin failure issue on Windows after node restart ``` /sig azure /sig windows /assign @karataliu @feiskyer pls mark this PR as v1.10 milestone, thanks
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60623, 60625, 60520). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Set default vmtype to standard if not set **What this PR does / why we need it**: When using IMDS, kubelet reports Failed to extract vmssVMName even when vmtype is not set: ``` E0301 05:30:57.515306 3124 azure_vmss_cache.go:52] Failed to extract vmssVMName "77890k8s9010" E0301 05:30:57.515306 3124 kubelet_node_status.go:79] Unable to construct v1.Node object for kubelet: failed to get external ID from cloud provider: not a vmss instance ``` azure cloud provider shouldn't call vmss logic in this case. It should assume stardard vmtype if it is not set. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #60622 **Special notes for your reviewer**: **Release note**: ```release-note Set Azure vmType to standard if it is not set in azure cloud config. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60362, 60629, 60572). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. improve get description ref: #60210 /assign @deads2k **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60362, 60629, 60572). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix warning info format Before this change: ``` $ kubectl exec -p nginx-aaaaaaaaaaaaa-67b58bf687-r68b9 ls -p POD_NAME is DEPRECATED and will be removed in a future version. Use exec POD_NAME instead.bin boot dev ... $ kubectl scale --replicas=2 job/pi kubectl scale job is DEPRECATED and will be removed in a future version.job.batch "pi" scaled ``` After this change: ``` $ kubectl exec -p nginx-aaaaaaaaaaaaa-67b58bf687-r68b9 ls -p POD_NAME is DEPRECATED and will be removed in a future version. Use exec POD_NAME instead. bin boot dev ... $ kubectl scale --replicas=2 job/pi kubectl scale job is DEPRECATED and will be removed in a future version. job.batch "pi" scaled ``` **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60362, 60629, 60572). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. add TestUpdateStatus for horizontalpodautoscaler **What this PR does / why we need it**: add `TestUpdateStatus` for horizontalpodautoscaler, and remove the relevant `TODO TestUpdateStatus ` **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Beata Skiba authored
Currently, when performing a scale up, any failed pods (which can be present for example in case of evictions performed by kubelet) will be treated as unready. Unready pods are treated as if they had 0% utilization which will slow down or even block scale up. After this change, failed pods are ignored in all calculations. This way they do not influence neither scale up nor scale down replica calculations.
-
Shyam Jeedigunta authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix todo:Get rid of this duplicate function IsRetryableAPIError in favour of the one in test/utils **What this PR does / why we need it**: fix todo:Get rid of this duplicate function IsRetryableAPIError in favour of the one in test/utils **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Mik Vyatskov authored
Signed-off-by:Mik Vyatskov <vmik@google.com>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add missing table converters for server side printing **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #60488 /assign @smarterclayton @juanvallejo /kind bug **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Relax time tolerance on KMS test, limit to platforms with unix sockets available Fixes #60613 Fixes #60614 ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubeadm 710 Switch to a dedicated CA for kubeadm etcd identities **What this PR does / why we need it**: On `kubeadm init`/`kubeadm upgrade`, this PR generates an etcd specific CA for signing the following certs: - etcd serving cert - etcd peer cert - apiserver etcd client cert These certs were previously signed by the kubernetes CA. The etcd static pod in `local.go` has also been updated to only mount the `/etcd` subdir of `cfg.CertificatesDir`. New phase command: ``` kubeadm alpha phase certs etcd-ca ``` See the linked issue for details on why this change is an important security feature. **Which issue(s) this PR fixes** Fixes https://github.com/kubernetes/kubeadm/issues/710 **Special notes for your reviewer**: #### on the master this should still fail: ```bash curl localhost:2379/v2/keys # no output curl --cacert /etc/kubernetes/pki/etcd/ca.crt https://localhost:2379/v2/keys # handshake error ``` this should now fail: (previously would succeed) ``` cd /etc/kubernetes/pki curl --cacert etcd/ca.crt --cert apiserver-kubelet-client.crt --key apiserver-kubelet-client.key https://localhost:2379/v2/keys # curl: (35) error:14094412:SSL routines:ssl3_read_bytes:sslv3 alert bad certificate ``` this should still succeed: ``` cd /etc/kubernetes/pki curl --cacert etcd/ca.crt --cert apiserver-etcd-client.crt --key apiserver-etcd-client.key https://localhost:2379/v2/keys ``` **Release note**: ```release-note On cluster provision or upgrade, kubeadm generates an etcd specific CA for all etcd related certificates. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Temporary fix for LeaderElect for kube-scheduler **What this PR does / why we need it**: kube-controller-manager defaults --leader-elect to true. We should do the same for kube-scheduler. kube-scheduler used to have this set to true, but it got lost during refactoring: efb2bb71 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #59729 **Special notes for your reviewer**: **Release note**: ```release-note kube-scheduler: restores default leader election behavior. leader-elect command line parameter should "true" ```
-
Anago GCB authored
-
Cao Shufeng authored
Before this change: ``` $ kubectl exec -p nginx-aaaaaaaaaaaaa-67b58bf687-r68b9 ls -p POD_NAME is DEPRECATED and will be removed in a future version. Use exec POD_NAME instead.bin boot dev ... $ kubectl scale --replicas=2 job/pi kubectl scale job is DEPRECATED and will be removed in a future version.job.batch "pi" scaled ``` After this change: ``` $ kubectl exec -p nginx-aaaaaaaaaaaaa-67b58bf687-r68b9 ls -p POD_NAME is DEPRECATED and will be removed in a future version. Use exec POD_NAME instead. bin boot dev ... $ kubectl scale --replicas=2 job/pi kubectl scale job is DEPRECATED and will be removed in a future version. job.batch "pi" scaled ```
-
caleb miles authored
-