1. 17 May, 2018 28 commits
  2. 16 May, 2018 12 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #63220 from dashpole/fix_memcg_format · c7bfc2a1
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fix formatting for kubelet memcg notification threshold
      
      /kind bug
      **What this PR does / why we need it**:
      This fixes the following errors (found in [this node_e2e serial test log](https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-node-kubelet-serial/4118/artifacts/tmp-node-e2e-49baaf8a-cos-stable-63-10032-71-0/kubelet.log)):
      `eviction_manager.go:256] eviction manager attempting to integrate with kernel memcg notification api`
      `threshold_notifier_linux.go:70] eviction: setting notification threshold to 4828488Ki`
      `eviction_manager.go:272] eviction manager: failed to create hard memory threshold notifier: invalid argument`
      
      **Special notes for your reviewer**:
      This needs to be cherrypicked back to 1.10.
      This regression was added in https://github.com/kubernetes/kubernetes/pull/60531, because the `quantity` being used was changed from a DecimalSI to BinarySI, which changes how it is printed out in the String() method.  To make it more explicit that we want the value, just convert Value() to a string.
      
      **Release note**:
      ```release-note
      Fix memory cgroup notifications, and reduce associated log spam.
      ```
      c7bfc2a1
    • Ashley Gau's avatar
      test clusterip · 2c73d99f
      Ashley Gau authored
      2c73d99f
    • Ashley Gau's avatar
      check for NEG healthcheck with correct name · 101dde0c
      Ashley Gau authored
      101dde0c
    • Kubernetes Submit Queue's avatar
      Merge pull request #61227 from apelisse/fix-diff · 7d9725e9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      diff: Fix broken `Local()` logic
      
      Local and Live functions where doing and returning the same thing,
      giving empty results by default. Fix the local function by copying the
      objects before fetching the live version.
      
      
      
      **What this PR does / why we need it**: Diff prints empty output by default. Fixes it.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes https://github.com/kubernetes/kubernetes/issues/61145
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      7d9725e9
    • liz's avatar
      Generated docs · 618a110c
      liz authored
      618a110c
    • liz's avatar
      Add a `kubeadm upgrade diff` command · 15bbc4db
      liz authored
      This command takes an upgrade version, and shows how the static pod manifests
      will be changed by a given upgrade.
      15bbc4db
    • Kubernetes Submit Queue's avatar
      Merge pull request #63866 from luxas/kubeadm_remove_cloudprovider · bef2ab3c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
       kubeadm: Remove the `.CloudProvider` and `.PrivilegedPods` configuration option
      
      **What this PR does / why we need it**:
      Removes the `.CloudProvider` option, it has been experimental for a long time. People should now use external cloud providers, which is beta in v1.11. Most importantly, you can get the exact same behavior in the API by utilizing the `.*ExtraArgs` and `.*ExtraVolumes` fields.
      Removes `.PrivilegedPods` as that serves a super small edge case with the legacy cloud provider, and only for openstack.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Part of https://github.com/kubernetes/community/pull/2131
      
      **Special notes for your reviewer**:
      Depends on PRs:
       - [x] #63799
       - [x] #63788
      
      **Release note**:
      
      ```release-note
      [action required] In the new v1alpha2 kubeadm Configuration API, the `.CloudProvider` and `.PrivilegedPods` fields don't exist anymore.
      Instead, you should use the out-of-tree cloud provider implementations which are beta in v1.11.
      If you have to use the legacy in-tree cloud providers, you can rearrange your config like the example below.
      If you need to use the `.PrivilegedPods` functionality, you can still edit the manifests in
      `/etc/kubernetes/manifests/`, and set `.SecurityContext.Privileged=true` for the apiserver
      and controller manager.
      ---
      kind: MasterConfiguration
      apiVersion: kubeadm.k8s.io/v1alpha2
      apiServerExtraArgs:
        cloud-provider: "{cloud}"
        cloud-config: "{path}"
      apiServerExtraVolumes:
      - name: cloud
        hostPath: "{path}"
        mountPath: "{path}"
      controllerManagerExtraArgs:
        cloud-provider: "{cloud}"
        cloud-config: "{path}"
      controllerManagerExtraVolumes:
      - name: cloud
        hostPath: "{path}"
        mountPath: "{path}"
      ---
      ```
      @kubernetes/sig-cluster-lifecycle-pr-reviews @dims @liztio
      bef2ab3c
    • Kubernetes Submit Queue's avatar
      Merge pull request #63833 from chuckha/image-puller · 82b355ed
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Adds a kubeadm config images pull command
      
      This command will use crictl or docker to pull images locally.
      
      The dockerfall back is needed because in some cases the kubelet is not
      yet running so there is no CRI dockershim socket available.
      
      Fixes kubernetes/kubeadm#812
      Signed-off-by: 's avatarChuck Ha <ha.chuck@gmail.com>
      
      **What this PR does / why we need it**:
      This PR adds a command to the `kubeadm config images` subcommand to pull images using either crictl or docker.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes kubernetes/kubeadm#812
      
      **Special notes for your reviewer**:
      
      **Release note**:
      ```release-note
      Adds a `kubeadm config images pull` command to pull container images used by kubeadm.
      ```
      
      /cc @kubernetes/sig-cluster-lifecycle-pr-reviews
      82b355ed
    • Andrew Lytvynov's avatar
      Extract connection rotating dialer into a package · 85a61ff3
      Andrew Lytvynov authored
      This will be re-used for exec auth plugin to rotate connections on
      credential change.
      85a61ff3
    • Antoine Pelisse's avatar
      diff: Fix broken `Local()` logic · f2b48a90
      Antoine Pelisse authored
      Local and Live functions where doing and returning the same thing,
      giving empty results by default. Fix the local function by copying the
      objects before fetching the live version.
      f2b48a90
    • Kubernetes Submit Queue's avatar
      Merge pull request #63416 from smarterclayton/retry_approve · 44dd0c24
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Retry certificate approval on conflict errors
      
      We already check preconditions. We were seeing a non-trivial number of conflicts when using the command from automation.
      
      Fixes openshift/origin#19430
      
      @mikedanese @mfojtik
      44dd0c24
    • Mike Danese's avatar
      e19fed33