- 25 Jul, 2017 40 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48976, 49474, 40050, 49426, 49430) apimachinery: fail early with deepcopy problems during roundtrip tests If deepcopy is broken for some type, it's easy to diagnose. This PR let's the roundtrip test to fail early in this case.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48976, 49474, 40050, 49426, 49430) Remove duplicated import and wrong alias name of api package **What this PR does / why we need it**: **Which issue this PR fixes**: fixes #48975 **Special notes for your reviewer**: /assign @caesarxuchao **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48224, 45431, 45946, 48775, 49396) Update cos-dev image in benchmark tests to cos-dev-61-9759-0-0 Ref: https://github.com/kubernetes/kubernetes/issues/42926 `cos-dev-61-9759-0-0` contains a fix in Linux utility `du` that would affect the measurement of docker performance in kubelet. I'd like to update the benchmark to use the new image. **Release note**: ``` None ``` /assign @tallclair /cc @kewu1992 @abgworrall
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48224, 45431, 45946, 48775, 49396) Enhance scheduler cache unit tests to cover OIR in pod spec /kind test **What this PR does / why we need it**: More code coverage. This PR covers the scenario when pod requests opaque-integer-resources and unit test the logic in scheduler which deals with parsing oirs in the pod object and stores the same in node info. Signed-off-by:vikaschoudhary16 <choudharyvikas16@gmail.com>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48224, 45431, 45946, 48775, 49396) Expose informer constructors **What this PR does / why we need it**: See #45939 **Which issue this PR fixes** Fixes #45939 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48224, 45431, 45946, 48775, 49396) [client-go] Fake Dynamic Client This commit converts `"k8s.io/client-go/dynamic".Client` to an interface, and implements fake versions of both `ClientPool` and `Client`. This allows components which make uses of these clients to be tested in the same way that clientset-based components can be tested, using the standard `testing.Fake` machinery. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48224, 45431, 45946, 48775, 49396) add reflector metrics This adds metrics (optionally prometheus) to reflectors so that you can see when one reflector is behaving poorly and just how poorly its doing. @eparis ```release-note Adds metrics for checking reflector health. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue remove deads2k from volume reviewer I don't know details of volume management well enough to give meaningful reviews.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49286, 49550) use demorgans to make startRouteController implementation more readable Signed-off-by:allencloud <allen.sun@daocloud.io> **What this PR does / why we need it**: When I was learning controller manager, I found that there is a `TODO` which is to use demorgans to make code more readable. So I try to make it work. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # NONE **Special notes for your reviewer**: NONE **Release note**: ```release-note NONE ``` ping @deads2k
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49286, 49550) Remove myself from a bunch of places I am assigned in reviews which I never get to do. I prefer drive-bys whenever I can do them rather than the bot choosing myself in random, ends up being mere spam. @smarterclayton please approve.
-
deads2k authored
-
deads2k authored
-
vikaschoudhary16 authored
Signed-off-by:vikaschoudhary16 <choudharyvikas16@gmail.com>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49498, 49192) Unify genclient tags and add more fine control on verbs generated This will change the syntax of the existing `genclient` tags be like this: ``` // +genclient // +genclient:noStatus // +genclient:noVerbs // +genclient:nonNamespaced // +genclient:readonly ``` The first one indicates the client will be generated from the struct below and the other tags are basically options to the genclient (which justify why they should be prefixed with `genclient:`) This also changes the `// +genclientstatus=false` to `// +genclient:noStatus` to follow the pattern and also changes the `// +noMethods=true` to `// +genclient:noVerbs` as we call the REST operations verbs so it will make it consistent with terminology. In addition to existing options this patch also add two more to allow more fine-grained control on which verbs are going to be generated. This is extra useful for third-party projects (like OpenShift) where some resources does not implement full CRUD, but for example just "create" verb or "create" and "delete"... To support that, you can use this syntax: ``` // +genclient:onlyVerbs=create,delete // +genclient:skipVerbs=patch ``` The first one will generate only create and delete functions and second one will generate full CRUD without "patch" actions. This somehow overlaps with the existing "readonly" tag, but I want to keep that tag in place as it reads better in some cases ;-)
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49498, 49192) kubeadm: Make sure --config can be mixed with --skip-* flags **What this PR does / why we need it**: fixes: https://github.com/kubernetes/kubeadm/issues/352 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: Should be a cherrypick candidate **Release note**: ```release-note kubeadm: Fixes a small bug where `--config` and `--skip-*` flags couldn't be passed at the same time in validation. ``` @kubernetes/sig-cluster-lifecycle-pr-reviews @ericchiang @wojtek-t
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49479, 49496) tune iscsi and fc volume owner **What this PR does / why we need it**: add @mtanino to iscsi and fc volume reviewer **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: @kubernetes/sig-storage-misc **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49479, 49496) hack/update-staging-godep.sh: check for staging repos in GOPATH
-
allencloud authored
Signed-off-by:allencloud <allen.sun@daocloud.io>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48846, 49483, 49341) GCE: ILB E2E test /assign @bowei **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48846, 49483, 49341) Add [sig-network] prefix to network e2e tests **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Associated PR #48784 Umbrella issue #49161 **Special notes for your reviewer**: /assign @@wojtek-t @freehan /cc @bowei **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Remove flags low-diskspace-threshold-mb and outofdisk-transition-frequency issue: #48843 This removes two flags replaced by the eviction manager. These have been depreciated for two releases, which I believe correctly follows the kubernetes depreciation guidelines. ```release-note Remove depreciated flags: --low-diskspace-threshold-mb and --outofdisk-transition-frequency, which are replaced by --eviction-hard ``` cc @mtaufen since I am changing kubelet flags cc @vishh @derekwaynecarr /sig node
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix Operation names for subresources Subresources may have their kind but in operationID and description we should use their parent kind not their own kind. The subresource name represents subresources and no need to repeat in with their kind. e.g. `Scale` has kind of `Scale` and subresource name of `Scale`. This creates names like `read scale of the specified Scale` or `readCoreV1NamespacedScaleScale` for scale on replication controller. This PR fixes description and operation ID for them to `read scale of the specified ReplicationController` and `readCoreV1NamespacedReplicationControllerScale`. @caesarxuchao I would like this to be patched in 1.7 too as it is useful for all clients and there is no need to wait for 1.8 for this documentation fix. ```release-note Fixed OpenAPI Description and Nickname of API objects with subresources ``` fixes #49250
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49358, 49253) Remove hostname label condition in SchedulerPredicates **What this PR does / why we need it**: ``` validates that NodeSelector is respected if matching [Conformance] validates that required NodeAffinity setting is respected if matching ``` The two tests above make the assumption that the node names are equal to the `kubernetes.io/hostname` labels. Unfortunately, this is not necessarily true all the time. For instance, when using the AWS Cloud Provider + Container Linux: - The node name is set using the AWS SDK's `ec2.Instance.PrivateDnsName` and has the form `ip-10-0-35-57.ca-central-1.compute.internal` [[1](https://github.com/kubernetes/kubernetes/blob/v1.7.1/pkg/cloudprovider/providers/aws/aws.go#L3343-L3346)] [[2](https://raw.githubusercontent.com/aws/aws-sdk-go/master/service/ec2/api.go)] - The node's hostname, however, is a simple call to `os.Hostname()`, itself reading `/proc/sys/kernel/hostname`, which contains what the AWS DHCP assigned to the instance, typically the hostname short-form: `ip-10-0-16-137`. [[1](https://github.com/kubernetes/kubernetes/blob/v1.7.1/pkg/util/node/node.go#L43-L54)] Consequently, we are trying to assign a pod to a node having the following label: `kubernetes.io/hostname=ip-10-0-35-57.ca-central-1.compute.internal` (in addition to the randomly generated label), whereas the actual label on the node is `kubernetes.io/hostname=ip-10-0-35-57`. Furthermore, this inaccurate `kubernetes.io/hostname=<nodename>` condition is actually useless given we already match over a random label, that was assigned to that node. Later, the test ensures that the scheduled pod was scheduled to the right node by comparing the pod's node name and the node name we expected the pod to be on: ``` framework.ExpectNoError(framework.WaitForPodNotPending(cs, ns, labelPodName)) labelPod, err := cs.Core().Pods(ns).Get(labelPodName, metav1.GetOptions{}) framework.ExpectNoError(err) Expect(labelPod.Spec.NodeName).To(Equal(nodeName)) ``` The `k8s.io/apimachinery/pkg/types/nodename` data structure actually [warns](https://github.com/kubernetes/kubernetes/blob/55bee3ad21f025b1416a4e1f10de753f484b66d3/staging/src/k8s.io/apimachinery/pkg/types/nodename.go#L40-L43) about the fact that the node name might be different than the hostname on AWS. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue [trival] fix typo **What this PR does / why we need it**: some file word spell error that amend correct **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48911, 49475, 49438, 49362, 49274) set RBD default values as constant vars **What this PR does / why we need it**: When working on #49225, I found some [default RBD parameters](https://kubernetes.io/docs/concepts/storage/persistent-volumes/#ceph-rbd) had not been declared as constant values, which will be error-prone. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note set RBD default values as constant vars ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48911, 49475, 49438, 49362, 49274) Add namespace for describe pdb **What this PR does / why we need it**: add namespace for describe pdb **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # fixes https://github.com/kubernetes/kubernetes/issues/49363 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48911, 49475, 49438, 49362, 49274) Delete redundant err definition **What this PR does / why we need it**: Delete redundant err definition line 642 has its definition and initialization, so line 641 is redundant. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # NONE **Special notes for your reviewer**: NONE **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48911, 49475, 49438, 49362, 49274) Fixed glusterfs mount options Capacity of a slice is the third argument, not the second one. We use append() to fill the slice, so it should be empty at the beginning and with the right capacity. ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Added sig-storage labels to upgrade tests and moved them to appropriate directory **What this PR does / why we need it**: Adding necessary sig identifier for storage upgrade tests. /release-note-none
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48636, 49088, 49251, 49417, 49494) Fix bug in command retrying in kubemark This should fix some of the flakes mentioned in https://github.com/kubernetes/kubernetes/issues/46195. It's showing that all subsequent retries have failed if the first one failed due to `ret_val` not being reassigned on success. @bskiba Thanks for noticing :)
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48636, 49088, 49251, 49417, 49494) [nit] Rename pkg/api/v1/builder.go to register.go to be consistent with others
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48636, 49088, 49251, 49417, 49494) StatefulSet: Remove `pod.alpha.kubernetes.io/initialized` annotation. The `pod.alpha.kubernetes.io/initialized` annotation was originally a tool for validating StatefulSet's ordered Pod creation guarantees during the feature's alpha phase. If set to "false" on a given Pod, it would interrupt StatefulSet's normal behavior. In v1.5.0, the annotation was deprecated and the default became "true" as part of StatefulSet's graduation to beta. The annotation is now ignored, meaning it cannot be used to interrupt StatefulSet Pod management. ```release-note StatefulSet: The deprecated `pod.alpha.kubernetes.io/initialized` annotation for interrupting StatefulSet Pod management is now ignored. If you were setting it to `true` or leaving it unset, no action is required. However, if you were setting it to `false`, be aware that previously-dormant StatefulSets may become active after upgrading. ``` ref #41605
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48636, 49088, 49251, 49417, 49494) Add customresourcedefinition and its shortcut in "kubectl get" **What this PR does / why we need it**: Add customresourcedefinition and its shortcut in "kubectl get" help info. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48927 **Special notes for your reviewer**: /cc @orangedeng **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48636, 49088, 49251, 49417, 49494) Fix issues for local storage allocatable feature This PR fixes the following issues: 1. Use ResourceStorageScratch instead of ResourceStorage API to represent local storage capacity 2. In eviction manager, use container manager instead of node provider (kubelet) to retrieve the node capacity and reserved resources. Node provider (kubelet) has a feature gate so that storagescratch information may not be exposed if feature gate is not set. On the other hand, container manager has all the capacity and allocatable resource information. This PR fixes issue #47809
-
Mikhail Mazurskiy authored
-
Mikhail Mazurskiy authored
-
supereagle authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue stop jsonpath panicing on negative array length Related downstream issue: https://github.com/openshift/origin/issues/15075 Returns error if provided jsonpath value results in a negative slice index after adding the length of the slice: ```go a := [0, 1, 2, 3] b := a[-1:] // 3 c := a[-4:] // 0 d := a[-5:] // out of range error e := a[4:] // out of range error ``` **Release note**: ```release-note NONE ``` cc @fabianofranz
-
xiangpengzhao authored
-
mbohlool authored
-