- 11 Sep, 2016 9 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add a check in ConfirmUsable() to validate the contextName **What this PR does / why we need it**: When a context name is provided, but can't be found (miss spelling), it currently uses the defaults. This PR will cause the command to fail, to prevent unexpected side effects of using the wrong configuration. **Which issue this PR fixes** fixes #21062 **Special notes for your reviewer**: None **Release note**: ```release-note Error if a contextName is provided but not found in the kubeconfig. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Delete empty value in the log When err isn't nil, it has printed log and returned, so it needn't to print err to the log later (it's nil).
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Improve style of kubelet node status test Report: man fails to idiomatically use `FakeClient`.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Teach create-kubeconfig() to deal with multi path KUBECONFIG When KUBECONFIG is in the form "A:B:C" make sure each file is created. fixes #17778
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Set Job's labels from PodTemplateSpec if none are specified Fixes #31009 and replaces #32033. @AdoHe I've picked your changes, added the additional ones for 'batch/v2alpha1' and most importantly added tests for job's defaulting. ptal
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Use a Deployment for kube-dns Attempt to fix #31554 Switching kube-dns from using Replication Controller to Deployment. The outdated kube-dns YAML file in coreos and juju dir is also updated. Most of the specific memory limit in the files remain unchanged because it seems like people were modifying it explicitly(c8d82fc2). Only the memory limit for healthz is increased due to this pending investigation(#29688). YAML files stay in *-rc.yaml format considering there are a lots of scripts in cluster and hack dirs are using this format. But it may be fine to changed them all. @bprashanth @girishkalele
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Vagrant fixups <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md 2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md 3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes --> **What this PR does / why we need it**: Vagrant 1.8.5 contains a bug where it does not insert a newly generated private key into the VM correctly. This prevents usage by both provisioners and the vagrant subsystem itself, essentially bricking the VM. See https://github.com/mitchellh/vagrant/issues/7760 for some more information. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # I honestly haven't searched; this is something I encountered setting it up. **Special notes for your reviewer**: I'm a new contributor so please be kind, happy to do anything that's required though! **Release note**: <!-- Steps to write your release note: 1. Use the release-note-* labels to set the release note state (if you have access) 2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. --> ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Automated Docker Validation: Change wrong name in perf config. The config key `containervm-density*` is improper, remove it. /cc @coufon
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix: Dynamic provisioning for vSphere This PR does the following, 1. Fixes an error 'A specified parameter was not correct:' occurs while dynamically provisioning the volumes. 2. Adds VSAN support for dynamic provisioning.
-
- 10 Sep, 2016 31 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix/centos docker download <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md 2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md 3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes --> **What this PR does / why we need it**: The CentOS cluster provider attempts to download docker from a location that 404's. **Which issue this PR fixes**: addresses https://github.com/kubernetes/kubernetes/issues/27572#issuecomment-226690177 **Special notes for your reviewer**: I don't know how Kubernetes decides docker compatibility, but it was previously pulling `latest` so I chose the most recent release. Is there any mechanism for keeping things like this up to date? What is the status of kubernetes rpm's? As far as I could tell there aren't any 1.3 rpm's published. Are those officially supported or a community project? **Release note**: <!-- Steps to write your release note: 1. Use the release-note-* labels to set the release note state (if you have access) 2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. --> ```release-note CentOS Cluster Provider: fix docker download location & use docker 1.12.0 ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Support graceful termination in kube-dns Fix #31807 kube-dns used to trap SIGINT and SIGTERM and call glog.Fatalf() when signal received. Let the program keep running when signal occur to support graceful termination. It will be terminated by SIGKILL when grace period ends. @thockin @girishkalele
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Update https-nginx example to use config map Fixes #30532
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue print Cinder volume source in kubectl describe with the patch, `kubectl describe` output is ```console # kubectl describe pv Name: pvc-34069100-6ec5-11e6-97f3-fa163e39e62e Labels: <none> Status: Bound Claim: default/claim1 Reclaim Policy: Delete Access Modes: RWO Capacity: 3Gi Message: Source: Type: Cinder (a Persistent Disk resource in OpenStack) VolumeID: a1bc727a-d1e6-4d6b-92d6-3e5e22bde3fa FSType: ext4 ReadOnly: false No events. ``` @kubernetes/sig-storage -
Kubernetes Submit Queue authored
Automatic merge from submit-queue When prompting for passwords, don't echo to the terminal @deads2k @kubernetes/kubectl
-
David McMahon authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue update taints e2e, restrict taints operation with key, effect Since taints are now unique by key, effect on a node, this PR is to restrict existing taints adding/removing/updating operations in taints e2e. Also fixes https://github.com/kubernetes/kubernetes/issues/31066#issuecomment-242870101 Related prior Issue/PR #29362 and #30590
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Use PV shared informer in PV controller Use the PV shared informer, addressing (partially) https://github.com/kubernetes/kubernetes/issues/26247 . Using the PVC shared informer is not so simple because sometimes the controller wants to `Requeue` and...
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue add suggestion to use `describe` to obtain container names **Release note**: ```release-note release-note-none ``` Commands with the `--container=` option provide no suggestions to a user on how to obtain a container's name from a pod. This patch adds a suggestion on the usage output to use the `describe` command on a pod to obtain the container value that is passed to the `--container=` flag. `$ kubectl exec -h` ``` Execute a command in a container. Examples: kubectl exec 123456-7890 date kubectl exec 123456-7890 -c ruby-container date kubectl exec 123456-7890 -c ruby-container -i -t -- bash -il Flags: -c, --container string Container name. If omitted, the first container in the pod will be chosen. Use the 'describe' command to find the list of containers on a pod. -p, --pod string Pod name -i, --stdin Pass stdin to the container -t, --tty Stdin is a TTY
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Return all the invalid flags for rollingupdate It had better to return all the invalid flags for the "validateArguments" function, so the user can modify them at once.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue It is better to add "\n" in printf <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md 2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md 3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes --> **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: <!-- Steps to write your release note: 1. Use the release-note-* labels to set the release note state (if you have access) 2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. --> ```release-note ```
-
Wojciech Tyczynski authored
Revert "Use scale subresource"
-
Wojciech Tyczynski authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Return all the invalid parameters for set_image Suggest returning all the invalid parameters for "ImageOptions.Validate()" in set_image.go.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Optimise the DefaultGenerators function It needn't define all the generators in the "DefaultGenerators" function, it just return the "cmdName" generator, the others is redundant.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue support storage class in Ceph RBD volume replace WIP PR #30959, using PV annotation idea from @jsafrane @kubernetes/sig-storage @johscheuer @elsonrodriguez
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Use scale subresource Fixes #29698 Use scale subresource for ReplicationController, ReplicaSet and Deployment. Couldn't do Jobs and PetSet since they live in a different group.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add client-server runtime support to local-up-cluster.sh <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md 2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md 3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes --> **What this PR does / why we need it**: It provides support for using `--container-runtime-endpoint` and `--image-service-endpoint` arguments for kubelet in `local-up-cluster.sh` script. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*: ref #28789 **Special notes for your reviewer**: **Release note**: <!-- Steps to write your release note: 1. Use the release-note-* labels to set the release note state (if you have access) 2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. --> ```release-note ``` Provide support for --container-runtime-endpoint and --image-service-endpoint in kubelet. Ref #28789
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Productionize the cockroachdb example a little more Includes: * A service for clients to use * Readiness/liveness probes * An extended graceful termination period * Automatic prometheus monitoring (when prometheus is configured to watch for annotations on services, as in [CoreOS's recent blog post](https://coreos.com/blog/prometheus-and-kubernetes-up-and-running.html), for example) I'm leaving the management of certs to future work, but if anyone that sees this needs help with them in the meantime, don't hesitate to reach out. Successor to #28446 @bprashanth - if you're still interested in / open to an e2e test (as mentioned in https://github.com/cockroachdb/cockroach/issues/5967#issuecomment-230188807), let me know and I'll put one together. If so, I assume you'd want it as part of the `petset` test group rather than the `examples` tests? cc @tschottdorf **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Example of unversioned pkg uses correct Config struct Currently this Doc has incorrect example - https://godoc.org/k8s.io/kubernetes/pkg/client/unversioned So when developers use it they are confused why `client` pkg has no `Config` struct, actually this is a struct from `restclient` pkg. Also pkg name and variable name should be equal: `client, err := client.New(config)` Thanks, Alex
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Update scheduler config file compatibility tests **What this PR does / why we need it**: Added missing compatibility tests for scheduler config file options. **Which issue this PR fixes** fixes #30099 **Special notes for your reviewer**: I came up with the options based on the contents of default.go in each branch. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Kubelet: add KillPod for new runtime API This PR adds implements of KillPod for new runtime API. CC @yujuhong @Random-Liu @kubernetes/sig-node @kubernetes/sig-rktnetes
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue add ClientSet to factory to remove non-generated client We should move to using generated clients in the `kubectl` client. We should really move to generated external clients, but this at least moves away from using manually created clients. @fabianofranz @mfojtik When I complete this work (move the other commands and eliminate the old API), this will ripple downstream.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Kubelet: rename CreatePodSandbox to RunPodSandbox in CRI As @yifan-gu pointed out in #31847, the name `CreatePodSandbox` doesn't reflect that the sandbox is running after the API succeeds. This PR renames it to `RunPodSandbox` to make this clear. CC @yujuhong @yifan-gu @kubernetes/sig-node
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue The first letter should be capitalized
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue add group prefix matching for kubectl usage Adds prefix matching for groups so that `kubectl get storageclass.storage` matches `storageclass.storage.k8s.io`. @kubernetes/kubectl
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue add logging for enabled/disabled API Groups Adds logging to the apiserver to indicate which API groups are enabled and disabled as go through. This will make it easier to identify what's gone wrong in cases where the API server is down during diagnoses and the config is inaccessible, like in GKE tests. For example https://github.com/kubernetes/kubernetes/issues/32185#issuecomment-245255700 . @wojtek-t This may have made the problem more obvious.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue make swaggerschema agnostic about which version to use `Factory.SwaggerSchema` was reliant on having a non-generated client bits filled in so that it could get the adapted client it wanted. There's no need since discovery ignores configured GroupVersions. This eliminates the unneeded dependency.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue rkt: Refactor host file mounts for host network. Do not mount /etc/hosts/ /etc/resolv.conf if they are already mounted. Ref https://github.com/coreos/rkt/issues/2430#issuecomment-244343576
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add validation rule to prevent adding finalizers if the object is being deleted To implement the behavior described in comments: https://github.com/kubernetes/kubernetes/blob/master/pkg/api/types.go#L149-L150 This purpose of this behavior is to disallow user manually changes from cascading deletion to orphaning after the deletion starts. Fix #32339
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Deprecate release infrastructure and doc - moved to kubernetes/release Part 2 of https://github.com/kubernetes/release/pull/1 This PR finalizes the split between the main kubernetes repo and the release tooling now under kubernetes/release. ref #16529
-