1. 23 Aug, 2018 2 commits
  2. 20 Aug, 2018 3 commits
  3. 16 Aug, 2018 16 commits
  4. 15 Aug, 2018 19 commits
    • Janet Kuo's avatar
      fd7a6944
    • Mike Danese's avatar
      test/integration: use correct import path · 45cfde85
      Mike Danese authored
      45cfde85
    • Kubernetes Submit Queue's avatar
      Merge pull request #65309 from tnozicka/add-ds-recreate-backoff · c1f7df2b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62441, 66702, 67254, 67421, 65309). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Add backoff for DS's pod deletion to limit fighting with kubelet failing the pod repeatedly
      
      **What this PR does / why we need it**:
      Limits consequences of DS controller on hot loop fighting with kubelet.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes https://github.com/kubernetes/kubernetes/issues/65240
      
      **Release note**:
      ```release-note
      DaemonSet controller is now using backoff algorithm to avoid hot loops fighting with kubelet on pod recreation when a particular DaemonSet is misconfigured.
      ```
      
      TODO:
       - [x] Export the backoff settings as args or constants
       - [x] Add test a case
      
      /cc @mfojtik 
      (Will add more folks when it's ready, to avoid spamming them.)
      c1f7df2b
    • Kubernetes Submit Queue's avatar
      Merge pull request #67421 from islinwb/minor-fix · f01be503
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62441, 66702, 67254, 67421, 65309). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      use glog.V().Infof() for formatting output; return nil when err's nil
      
      **What this PR does / why we need it**:
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      f01be503
    • Kubernetes Submit Queue's avatar
      Merge pull request #67254 from andrewsykim/doc-instance-stopped · 8f63f7b0
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62441, 66702, 67254, 67421, 65309). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      document expectations for stopped/shutdown instances in cloudprovider.Instances interface
      
      **What this PR does / why we need it**:
      Add comments which outline expectations for how cloud providers should handle nodes that are stopped/shutdown/sleeping. 
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      It doesn't fix https://github.com/kubernetes/kubernetes/issues/46442 since some providers still delete node resources for stopped instances (though there are PRs already open to fix this) but we've (mostly?) agreed that not deleting node resources for stopped instances is the correct behavior, or at least the behavior that we want consistent across providers at the moment. 
      
      **Special notes for your reviewer**:
      
      ```release-note
      NONE
      ```
      
      /sig cloud-provider
      8f63f7b0
    • Kubernetes Submit Queue's avatar
      Merge pull request #66702 from xlgao-zju/search-kubeconfig · 7f7a967f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62441, 66702, 67254, 67421, 65309). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      [kubeadm] Apply means to search for existing KubeConfig files in standard locations across kubeadm
      
      **What this PR does / why we need it**:
      Apply means to search for existing KubeConfig files in standard locations across kubeadm.
      
      Tasklist:
      
      - [x] Use the Join of Dir and File name instead of DefaultKubeConfig
      - [x] Refactor token.go::findExistingKubeConfig() into a utility in cmd/kubeadm/app/cmd/util
      - [x] Use the utility in config, upgrade and some of the phases commands that use --kubeconfig
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      ref [kubernetes/kubeadm/#805](https://github.com/kubernetes/kubeadm/issues/805)
      
      **Special notes for your reviewer**:
      /assign @neolit123 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      7f7a967f
    • Kubernetes Submit Queue's avatar
      Merge pull request #62441 from chentao1596/certificate_controller_utils_ut · 939f08a2
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      UT case of certificate_controller
      939f08a2
    • Kubernetes Submit Queue's avatar
      Merge pull request #67208 from liztio/cert-list · 68cfa7ef
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      First pass of cert list
      
      **What this PR does / why we need it**:
      Refactors the cert management code in kubeadm to be more extensible and resiliant.
      
      This initial change doesn't change anything on the surface, and in fact appears to add a bunch of complexity. The goal here is to reduce duplication in the certs codebase, which is started in this PR by gutting the New*CertAndKey. Eventually, those functions will be removed altogether. The declarative list will also allow us to build a more explicit renewal function and command line interface and reduce much more duplication in the cert package.
      
      
      **Special notes for your reviewer**:
      
      **Release note**:
      ```
      ```
      68cfa7ef
    • Wei Huang's avatar
      fix an issue in NodeInfo.Clone() · 976797c0
      Wei Huang authored
      - usedPorts is a map-in-map struct, add fix to ensure it's deep copied
      - updated unit test
      976797c0
    • SneakyFish5's avatar
      Better error message if etcd not installed · 861ab506
      SneakyFish5 authored
      861ab506
    • Ken'ichi Ohmichi's avatar
      Remove duplicated detect-master for local · 2bdae8f3
      Ken'ichi Ohmichi authored
      cluster/local/util.sh contains duplicated detect-master() and the
      first one is unused at all. This removes the first one for the code
      cleanup.
      2bdae8f3
    • Kubernetes Submit Queue's avatar
      Merge pull request #67182 from poothia/pathfix · 1da4c59e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fixing kubeadm.conf file path
      
      This patch fixed kubeadm.conf file path in this file.
      1da4c59e
    • Kubernetes Submit Queue's avatar
      Merge pull request #66666 from bertinatto/metrics_ad_controller · 4414ae3d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Add more metrics for A/D Controller:
      
      **What this PR does / why we need it**:
      
      This PR adds a few metrics described in the [Metrics Spec](https://docs.google.com/document/d/1Fh0T60T_y888LsRwC51CQHO75b2IZ3A34ZQS71s_F0g/edit#heading=h.ys6pjpbasqdu):
      
      * Number of Volumes in ActualStateOfWorld and DesiredStateOfWorld
      * Number of times A/D Controller performs force detach
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      4414ae3d
    • Casey Callendrello's avatar
      kubelet/dockershim/network: pass ipRange dynamically to the CNI plugin · 5d9ec20d
      Casey Callendrello authored
      CNI now supports passing ipRanges dynamically. Pass podCIDR so that
      plugins no longer have to look it up.
      5d9ec20d
    • Kubernetes Submit Queue's avatar
      Merge pull request #66115 from jasonrichardsmith/add-serviceAccount-fieldselector · c5d15cb0
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      added serviceAccountName to field selectors
      
      What this PR does / why we need it:
      
      Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #66114
      
      Special notes for your reviewer:
      
      ```release-note
      NONE
      ```
      c5d15cb0
    • liz's avatar
      Add certlist.go - a declarative list of all certs kubeadm requires · 742b258c
      liz authored
      * Sub out New*CertAndKey for functions using the new certlist
      742b258c
    • Kubernetes Submit Queue's avatar
      Merge pull request #67409 from stewart-yu/stewart-controller-manager-codeclean#03 · 6a12a280
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 66884, 67410, 67229, 67409). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      kubeadm:  coverage improvement about ValidateVersion function
      
      **What this PR does / why we need it**:
      In commit log :https://github.com/kubernetes/kubernetes/pull/63920/commits/2ef81576448c94b49546738aac94b70dc13b35d1, remove the `MinimumVersion support` for all featuregate, but the `MinimumVersion` still as a parameter in `Feature` struct for `future featuregate`.
      However,https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/features/features.go#L79-L87 still have judgement about `MinimumVersion` in `ValidateVersion` function, we also need test it. 
      This PR  make `test coverage` about `ValidateVersion` function from `20%` to `90%`. Details as below.
      
      Before changed, the `test coverage` are:
      ```
      root@shap000101123:/ycj/kubernetes-community/src/k8s.io/kubernetes/cmd/kubeadm/app/features# go tool cover -func=size_coverage.out
      k8s.io/kubernetes/cmd/kubeadm/app/features/features.go:71:	ValidateVersion			20.0%
      k8s.io/kubernetes/cmd/kubeadm/app/features/features.go:92:	Enabled				100.0%
      k8s.io/kubernetes/cmd/kubeadm/app/features/features.go:101:	Supports			100.0%
      k8s.io/kubernetes/cmd/kubeadm/app/features/features.go:111:	Keys				0.0%
      k8s.io/kubernetes/cmd/kubeadm/app/features/features.go:120:	KnownFeatures			90.0%
      k8s.io/kubernetes/cmd/kubeadm/app/features/features.go:139:	NewFeatureGate			94.1%
      k8s.io/kubernetes/cmd/kubeadm/app/features/features.go:171:	ResolveFeatureGateDependencies	100.0%
      total:								(statements)			73.1%
      ```
      After change, the `test coverage` are:
      ```
      root@shap000101123:/ycj/kubernetes-community/src/k8s.io/kubernetes/cmd/kubeadm/app/features# go tool cover -func=size_coverage.out
      k8s.io/kubernetes/cmd/kubeadm/app/features/features.go:71:	ValidateVersion			90.0%
      k8s.io/kubernetes/cmd/kubeadm/app/features/features.go:92:	Enabled				100.0%
      k8s.io/kubernetes/cmd/kubeadm/app/features/features.go:101:	Supports			100.0%
      k8s.io/kubernetes/cmd/kubeadm/app/features/features.go:111:	Keys				0.0%
      k8s.io/kubernetes/cmd/kubeadm/app/features/features.go:120:	KnownFeatures			90.0%
      k8s.io/kubernetes/cmd/kubeadm/app/features/features.go:139:	NewFeatureGate			94.1%
      k8s.io/kubernetes/cmd/kubeadm/app/features/features.go:171:	ResolveFeatureGateDependencies	100.0%
      total:								(statements)			86.5%
      ```
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      @luxas  @neolit123 @fabriziopandini @dixudx 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      6a12a280
    • Kubernetes Submit Queue's avatar
      Merge pull request #67229 from feiskyer/unzoned-disks · 2a81c37d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 66884, 67410, 67229, 67409). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Add node affinity for Azure unzoned managed disks
      
      **What this PR does / why we need it**:
      
      Continue of [Azure Availability Zone feature](https://github.com/kubernetes/features/issues/586).
      
      Add node affinity for Azure unzoned managed disks, so that unzoned disks only scheduled to unzoned nodes.
      
      This is required because Azure doesn't allow attaching unzoned disks to zoned VMs.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      Unzoned nodes would label `failure-domain.beta.kubernetes.io/zone=0` and the value is fault domain ( while availability zone is used for zoned nodes). So fault domain is used to populate unzoned disks.
      
      Since there are at most 3 fault domains in each region, the PR adds 3 terms for them:
      
      ```yaml
      kubectl describe pv pvc-bdf93a67-9c45-11e8-ba6f-000d3a07de8c
      Name:              pvc-bdf93a67-9c45-11e8-ba6f-000d3a07de8c
      Labels:            <none>
      Annotations:       pv.kubernetes.io/bound-by-controller=yes
                         pv.kubernetes.io/provisioned-by=kubernetes.io/azure-disk
                         volumehelper.VolumeDynamicallyCreatedByKey=azure-disk-dynamic-provisioner
      Finalizers:        [kubernetes.io/pv-protection]
      StorageClass:      azuredisk-unzoned
      Status:            Bound
      Claim:             default/unzoned-pvc
      Reclaim Policy:    Delete
      Access Modes:      RWO
      Capacity:          5Gi
      Node Affinity:     
        Required Terms:  
          Term 0:        failure-domain.beta.kubernetes.io/region in [southeastasia]
                         failure-domain.beta.kubernetes.io/zone in [0]
          Term 1:        failure-domain.beta.kubernetes.io/region in [southeastasia]
                         failure-domain.beta.kubernetes.io/zone in [1]
          Term 2:        failure-domain.beta.kubernetes.io/region in [southeastasia]
                         failure-domain.beta.kubernetes.io/zone in [2]
      Message:           
      Source:
          Type:         AzureDisk (an Azure Data Disk mount on the host and bind mount to the pod)
          DiskName:     k8s-5b3d7b8f-dynamic-pvc-bdf93a67-9c45-11e8-ba6f-000d3a07de8c
          DiskURI:      /subscriptions/<subscription>/resourceGroups/<rg-name>/providers/Microsoft.Compute/disks/k8s-5b3d7b8f-dynamic-pvc-bdf93a67-9c45-11e8-ba6f-000d3a07de8c
          Kind:         Managed
          FSType:       
          CachingMode:  None
          ReadOnly:     false
      Events:           <none>
      ```
      
      **Release note**:
      
      ```release-note
      Add node affinity for Azure unzoned managed disks
      ```
      
      /sig azure
      /kind feature
      
      /cc @brendandburns @khenidak @andyzhangx @msau42
      2a81c37d
    • Kubernetes Submit Queue's avatar
      Merge pull request #67410 from hanxiaoshuai/fix0815 · 660d1304
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 66884, 67410, 67229, 67409). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      modify a duplicate e2e test of DNS configMap
      
      **What this PR does / why we need it**:
      modify a duplicate e2e test of DNS configMap. It is duplicate with the case in https://github.com/kubernetes/kubernetes/blob/d655c9a87335498857a63d5fcefa7a6d7db1ce93/test/e2e/network/dns_configmap.go#L345
      I think it should run dnsFederationsConfigMapTest in original purpose.
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      660d1304