1. 12 Aug, 2017 12 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #50205 from dixudx/fix_kubectl_edit_panic_nil_list · 577fdf91
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 50537, 49699, 50160, 49025, 50205)
      
      not allowing "kubectl edit <resource>" when you got an empty list
      
      **What this PR does / why we need it**:
      `kubectl edit` will panic when adding an empty list.
      
      > panic: runtime error: index out of range
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #50147
      
      **Special notes for your reviewer**:
      /assign @errordeveloper @mengqiy @janetkuo @fabianofranz
      /cc @rootfs @soltysh @sttts
      
      **Release note**:
      
      ```release-note
      not allowing "kubectl edit <resource>" when you got an empty list
      ```
      577fdf91
    • Kubernetes Submit Queue's avatar
      Merge pull request #49025 from danwinship/non-cloud-node-ip · b91f1918
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 50537, 49699, 50160, 49025, 50205)
      
      When not using a CloudProvider, set both InternalIP and ExternalIP on Nodes
      
      #36095 changed all of the cloudproviders to set both InternalIP and ExternalIP on Nodes, but the non-cloudprovider fallback code now only sets InternalIP.
      
      This causes the test "should be able to create a functioning NodePort service" in test/e2e/service.go to fail on cloud-provider-less clusters, because (with LegacyHostIP gone), it now will only try to work with ExternalIPs, and will fail if the node has only an InternalIP.
      
      There isn't much other code that assumes that ExternalIP will always be set (there's something in pkg/master/master.go, but I don't know what it's doing, so maybe it's only useful in the case where InternalIP != ExternalIP anyway). But given that several of the cloudproviders (mesos, ovirt, rackspace) now explicitly set both InternalIP and ExternalIP to the same value always, it seemed right to do that in the fallback case too.
      
      @deads2k FYI
      
      **Release note**:
      ```release-note
      NONE
      ```
      b91f1918
    • Kubernetes Submit Queue's avatar
      Merge pull request #50160 from apelisse/openapi-validation · 937fc0d1
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 50537, 49699, 50160, 49025, 50205)
      
      openapi: Add validation logic
      
      This allows validation of a yaml/json object against an openapi schema.
      A lot more testing would be needed to validate the logic, and also this
      is not plumbed in, so it can't be used by kubectl yet.
      
      **What this PR does / why we need it**: This is implementing validation against the openapi swagger spec rather than the old swagger spec.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes https://github.com/kubernetes/kubectl/issues/49
      
      **Special notes for your reviewer**:
      
      **Release note**:
      ```release-note
      NONE
      ```
      937fc0d1
    • Kubernetes Submit Queue's avatar
      Merge pull request #49699 from xingzhou/kube-49384-bug · be1f1439
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 50537, 49699, 50160, 49025, 50205)
      
      AddOrUpdateTaint should ignore duplicate Taint.
      
      The parameter of AddOrUpdateTaint is Taint pointer, so should use
      Taint object itself to compare with the node's taint list to ignore
      duplicate taint.
      
      While doing #49384, found this issue and fixed.
      
      Fixed part of #49384, other test cases will be added in the following patch
      
      **Release note**:
      ```
      None
      ```
      be1f1439
    • Kubernetes Submit Queue's avatar
      Merge pull request #50537 from liggitt/kubefed-rbac · c207dd5a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 50537, 49699, 50160, 49025, 50205)
      
      select an RBAC version for kubefed it knows how to speak
      
      kubefed tries to speak whatever version of RBAC the server has, regardless of whether it knows about that version or not. the version discovery it does has to select a version both it and the server speak.
      
      related to https://github.com/kubernetes/kubernetes/issues/50534
      
      ```release-note
      fixes kubefed's ability to create RBAC roles in version-skewed clusters
      ```
      c207dd5a
    • Kubernetes Submit Queue's avatar
      Merge pull request #49618 from pavolloffay/cassandra-preStop-drain · bb67819e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47724, 49984, 49785, 49803, 49618)
      
      Cassandra example, use nodetool drain in preStop
      
      Related to https://github.com/kubernetes/kubernetes/pull/39199#discussion_r129506191
      bb67819e
    • Kubernetes Submit Queue's avatar
      Merge pull request #49803 from caesarxuchao/remove-unused-tags · b354c6f8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47724, 49984, 49785, 49803, 49618)
      
      Remove useless conversion-gen tags
      
      To generate cross group conversions, `+k8s:conversion-gen` should be added in the way https://github.com/kubernetes/kubernetes/pull/49751 did. This PR removes the useless tags in pkg/apis/extensions/v1beta1/doc.go
      b354c6f8
    • Kubernetes Submit Queue's avatar
      Merge pull request #49785 from FengyunPan/fix-getPortByIP · a7ce6913
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47724, 49984, 49785, 49803, 49618)
      
      Fix conflict about getPortByIp
      
      **What this PR does / why we need it**:
      Currently getPortByIp() get port of instance only based on IP.
      If there are two instances in diffent network and the CIDR of
      their subnet are same, getPortByIp() will be conflict.
      My PR gets port based on IP and Name of instance.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      Fix #43909
      
      **Special notes for your reviewer**:
      
      **Release note**:
      ```release-note
      NONE
      ```
      a7ce6913
    • Kubernetes Submit Queue's avatar
      Merge pull request #49984 from alexandercampbell/global-variables-are-an-antipattern · 366b6991
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47724, 49984, 49785, 49803, 49618)
      
      cmd/explain: make 'recursive' local var (not global)
      
      **What this PR does / why we need it**:
      Use a parameter instead of a global variable.
      Spotted this while I was looking for our recursive directory walker.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: no-issue
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      366b6991
    • Kubernetes Submit Queue's avatar
      Merge pull request #47724 from FengyunPan/update-admission-control-arg · 03ea3eef
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Update admission control args in imagepolicy comment
      
      Use '--admission-control-config-file' rather than
      '--admission-controller-config-file'
      
      **Release note**:
      ```release-note
      NONE
      ```
      03ea3eef
    • Kubernetes Submit Queue's avatar
      Merge pull request #49596 from jingxu97/July/checkVolumeSpecNil · 9c508f12
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Check volumespec is nil in FindPluginBySpec
      9c508f12
    • Antoine Pelisse's avatar
      openapi: Add validation logic · ba11c737
      Antoine Pelisse authored
      This allows validation of a yaml/json object against an openapi schema.
      A lot more testing would be needed to validate the logic, and also this
      is not plumbed in, so it can't be used by kubectl yet.
      ba11c737
  2. 11 Aug, 2017 28 commits
    • Jordan Liggitt's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #50535 from jdumars/azure-owners · 92d9e442
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Added jdumars to OWNERS file for Azure cloud provider
      
      **What this PR does / why we need it**:
      
      This PR adds GitHub user jdumars as an approver to pkg/cloudprovider/providers/azure 
      
      Jaice Singer DuMars (me) is the program manager at Microsoft tasked with shepherding all upstream contributions from Microsoft into Kubernetes.  With the volume of work, and the impending breakout of cloud provider code, this helps distribute the review and approval load more evenly.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      N/A
      
      **Special notes for your reviewer**:
      
      This was discussed with Brendan Burns prior to submitting the pre-approval.
      
      **Release note**:
      none
      92d9e442
    • Kubernetes Submit Queue's avatar
      Merge pull request #50429 from houjun41544/20170810 · 1bdf691f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Remove repeated reviewer's names
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      1bdf691f
    • Kubernetes Submit Queue's avatar
      Merge pull request #47017 from zhangxiaoyu-zidif/fix-name-print-type · cd4f6edf
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix print type of podname
      
      **What this PR does / why we need it**:
      It is better to change it to %s. According to context and other prints of this file, pod name's print type are all %s, except this one.
      Although it does not affect the result.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      cd4f6edf
    • Antoine Pelisse's avatar
      openapi: Move Fakes to testing package · eb735bfe
      Antoine Pelisse authored
      eb735bfe
    • Kubernetes Submit Queue's avatar
      Merge pull request #49406 from castrojo/new-support-template · 4e3d37c0
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add a SUPPORT.md file for github
      
      **What this PR does / why we need it**:
      
      Github has recently added the ability to support a SUPPORT.md file that allows a project to point to support resources, similar to CONTRIBUTING.md
      
      They support having SUPPORT.md in docs/ and .github but I figured it should be in root alongside CONTRIBUTING.md, but we can put it in one of those places if we want to keep the root clean. 
      
      See also: 
      
      https://help.github.com/articles/adding-support-resources-to-your-project/
      https://github.com/blog/2400-support-file-support
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      Fixes https://github.com/kubernetes/community/issues/830
      4e3d37c0
    • Kubernetes Submit Queue's avatar
      Merge pull request #50525 from mwielgus/ca-0.7.0-alpha1 · 8c63333f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Bump Cluster Autoscaler to 0.7.0-alpha1
      
      To use more recent CA built from HEAD.
      8c63333f
    • Kubernetes Submit Queue's avatar
      Merge pull request #50470 from nicksardo/gce-annotation-fixes · bbe93bb2
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      GCE: Fix lowercase value and alpha-missing annotation for ILB
      
      **What this PR does / why we need it**:
      Fixes #50426
      Also explicitly sets an annotation as 'alpha'.
      
      /assign @freehan @bowei 
      
      **Release note**:
      ```release-note
      NONE
      ```
      bbe93bb2
    • Kubernetes Submit Queue's avatar
      Merge pull request #50258 from liggitt/token-cache · 42adb9ef
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49488, 50407, 46105, 50456, 50258)
      
      Enable caching successful token authentication
      
      Resolves #50472
      
      To support revocation of service account tokens, an etcd lookup of the token and service account is done by the token authenticator. Controllers that make dozens or hundreds of API calls per second (like the endpoints controller) cause this lookup to be done very frequently on the same objects.
      
      This PR:
      * Implements a cached token authenticator that conforms to the authenticator.Token interface
      * Implements a union token authenticator (same approach as the union request authenticator, conforming to the authenticator.Token interface)
      * Cleans up the auth chain construction to group all token authenticators (means we only do bearer and websocket header parsing once)
      * Adds a 10-second TTL cache to successful token authentication
      
      ```release-note
      API server authentication now caches successful bearer token authentication results for a few seconds.
      ```
      42adb9ef
    • Kubernetes Submit Queue's avatar
      Merge pull request #50456 from liggitt/extra-steps · d8070bd4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49488, 50407, 46105, 50456, 50258)
      
      Detect missing steps in edit testcases
      
      If a testcase specifies extra steps that are not exercised, that should be a test failure
      d8070bd4
    • Kubernetes Submit Queue's avatar
      Merge pull request #46105 from sjenning/update-conatiner-resource-cri · b9b875f0
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49488, 50407, 46105, 50456, 50258)
      
      Add UpdateContainerResources method to CRI
      
      This is first step toward support for opinionated cpu pinning for certain guaranteed pods.
      
      In order to do this, the kubelet needs to be able to dynamically update the cpuset at the container level, which is managed by the container runtime.  Thus the kubelet needs a method to communicate over the CRI so the runtime can then modify the container cgroup.
      
      This is used in the situation where a core is added or removed from the shared pool to become a exclusive core for a new G pod.  The cpuset for all containers in the shared pool will need to be updated to add or remove that core.
      
      Opening this up now so we can start discussion.  The need for a change to the CRI might be unexpected.
      
      @derekwaynecarr @vishh @ConnorDoyle 
      
      ```release-note
      NONE
      ```
      b9b875f0
    • Kubernetes Submit Queue's avatar
      Merge pull request #50407 from ixdy/gazelle-and-kazel · 941ad016
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49488, 50407, 46105, 50456, 50258)
      
      Manage BUILD files using gazelle + kazel
      
      **What this PR does / why we need it**: uses the upstream `gazelle` tool to manage go rules in BUILD files.
      This is needed to support Bazel builds on Mac OS and Bazel cross compilation in general.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #47558
      
      **Special notes for your reviewer**:
      It's probably easiest to review this commit-by-commit:
      * bump to latest `rules_go` (for recent `cgo_library` and `gazelle` improvements)
      * update `kazel` with recent compatibility fixes (https://github.com/kubernetes/repo-infra/pull/28, https://github.com/kubernetes/repo-infra/pull/27), update `hack` scripts to download/build `gazelle`, and then run both `gazelle` and `kazel`. (Additionally make `gazelle` skip things it shouldn't touch.)
      * run `hack/update-bazel.sh` to autogenerate everything
      * remove the old `cgo_genrule` rules - these are now part of `go_library`
      * remove the `automanaged` tags from all go rules - `gazelle` doesn't use them, and it prevents an old version of `kazel/gazel` from messing with the rules
      * remove the `licenses()` rules from everywhere but `third_party/` - we don't need them, and `gazelle` won't add them on new `BUILD` files it generates.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      for review:
      /assign @mikedanese @spxtr 
      for approval:
      /assign @thockin
      941ad016
    • Kubernetes Submit Queue's avatar
      Merge pull request #49488 from k82cn/k8s_46935 · fcd2368d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49488, 50407, 46105, 50456, 50258)
      
      Requeue DaemonSets if non-daemon pods were deleted.
      
      **What this PR does / why we need it**:
      Requeue DaemonSets if no daemon pods were deleted.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #46935
      
      **Release note**:
      
      ```release-note
      None
      ```
      fcd2368d
    • Kubernetes Submit Queue's avatar
      Merge pull request #50308 from m1093782566/validate-apiserver · 984f1af5
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      validate kube-apiserver options
      
      **What this PR does / why we need it**:
      
      Create Validate() or add more checks in existing Validate() for the following files:
      
      * vendor/k8s.io/apiextensions-apiserver/pkg/cmd/server/start.go:80
      
      * vendor/k8s.io/kube-aggregator/pkg/cmd/server/start.go:104
      
      * vendor/k8s.io/sample-apiserver/pkg/cmd/server/start.go:82
      
      * cmd/kube-apiserver/app/options/validation.go:49
      
      **Which issue this PR fixes**: 
      
      fixes #50301
      
      **Special notes for your reviewer**:
      
      This PR follows #50135 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      984f1af5
    • Jason Singer DuMars's avatar
    • Jorge O. Castro's avatar
      Add a SUPPORT.md file for github · b09a813d
      Jorge O. Castro authored
      b09a813d
    • Jeff Grafton's avatar
    • Jeff Grafton's avatar
      33276f06
    • Jeff Grafton's avatar
      Remove deprecated cgo_genrules · 5f637116
      Jeff Grafton authored
      5f637116
    • Jeff Grafton's avatar
      Autogenerate BUILD files · cf55f9ed
      Jeff Grafton authored
      cf55f9ed
    • Jeff Grafton's avatar
      cce84c3e
    • Jeff Grafton's avatar
      Bump rules_go · 7717c0bb
      Jeff Grafton authored
      7717c0bb
    • Marcin Wielgus's avatar
      Bump Cluster Autoscaler to 0.7.0-alpha1 · b9fb0428
      Marcin Wielgus authored
      b9fb0428
    • Kubernetes Submit Queue's avatar
      Merge pull request #49752 from bsalamat/priority_scheduler · 868fef18
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add a heap to client-go. Heap orders items with heap invariant ordering.
      
      **What this PR does / why we need it**:
      Heap is useful in implementing priority queues. Some components may need such ordering to process their highest priority objects first. Scheduler is going to be the first user of the heap. It will store pending pods ordered by their priority, so that the highest priority pods are popped first to be scheduled.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      
      ref/ #47604
      ref/ #48646
      
      @kubernetes/api-reviewers @kubernetes/sig-scheduling-pr-reviews @davidopp 
      /assign @caesarxuchao
      868fef18
    • Kubernetes Submit Queue's avatar
      Merge pull request #50078 from php-coder/fix_useless_cat_usage · f37b3065
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Simplify a command for unmounting mounted directories
      
      **What this PR does / why we need it**:
      This PR simplifies a command for unmounting mounted directories. It replaces `cat | awk | grep` by a single `awk` expression.
      
      **Special notes for your reviewer**:
      Link about useless cat/grep usage: http://porkmail.org/era/unix/award.html#grep
      
      **Credit**:
      I saw this code fragment in the Julia Evans (@jvns) [write up](https://jvns.ca/blog/2017/07/30/a-couple-useful-ideas-from-google/).
      
      **Release note**:
      ```release-note
      NONE
      ```
      
      CC @simo5
      f37b3065
    • Kubernetes Submit Queue's avatar
      Merge pull request #50186 from k82cn/k8s_42001-4 · 6cbfac2c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Task 2: Added toleration to DaemonSet pods for node condition taints
      
      **What this PR does / why we need it**:
      If TaintByCondition was enabled, added toleration to DaemonSet pods for node condition taints.
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: part of #42001 
      
      **Release note**:
      ```release-note
      None
      ```
      6cbfac2c
    • Kubernetes Submit Queue's avatar
      Merge pull request #50430 from x1957/glusterfs · 68c4fd30
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      remove the duplicate address of glusterfs
      
      **What this PR does / why we need it**:
      remove the duplicate endpoint address of glusterfs.
      If there is no duplicate address of user config or the duplicate address is ok, we can remove the unused addr map.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      None
      ```
      68c4fd30
    • Kubernetes Submit Queue's avatar
      Merge pull request #49574 from liggitt/visitor-type · fc62da91
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Typedef visitor to document parameters
      
      adds a typedef to clarify the parameters of the visitor
      
      updates the unit test to verify each namespace/name pair
      fc62da91