- 04 Jun, 2018 22 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 63453, 64592, 64482, 64618, 64661). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Replace glog.Info{f,ln} with fmt.Print{f,ln} Please see commit message. Signed-off-by:
Chuck Ha <ha.chuck@gmail.com> **What this PR does / why we need it**: This PR makes kubeadm's logging output consistent for the regular case and offers verbosity with glog. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes kubernetes/kubeadm#852 **Special notes for your reviewer**: Unfortunately there is one call site in a dependency that uses a bare glog.Infof which we can't change without a bigger effort. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 63453, 64592, 64482, 64618, 64661). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. client-go: promote exec plugin support to beta /sig auth /kind feature Adds a "v1beta1" API group for client authentication. Because of a lack of usage with the input parameters, these have been dropped for the beta. Would like to re-introduce them as users feel they require them. updates https://github.com/kubernetes/kubernetes/issues/61796 ```release-note client-go: credential exec plugins have been promoted to beta ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 63453, 64592, 64482, 64618, 64661). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Revert "Remove rescheduler and corresponding tests from master" Reverts kubernetes/kubernetes#64364 After discussing with @bsalamat on how DS controllers(ref: https://github.com/kubernetes/kubernetes/pull/63223#discussion_r192277527) cannot create pods if the cluster is at capacity and they have to rely on rescheduler for making some space, we thought it is better to - Bring rescheduler back. - Make rescheduler priority aware. - If cluster is full and if **only** DS controller is not able to create pods, let rescheduler be run and let it evict some pods which have less priority. - The DS controller pods will be scheduled now. So, I am reverting this PR now. Step 2, 3 above are going to be in rescheduler. /cc @bsalamat @aveshagarwal @k82cn Please let me know your thoughts on this. ```release-note Revert #64364 to resurrect rescheduler. More info https://github.com/kubernetes/kubernetes/issues/64725 :) ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 63453, 64592, 64482, 64618, 64661). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add Makefile target to push fat manifest for multi-arch images Signed-off-by:
Nitesh Konkar <niteshkonkar@in.ibm.com> **What this PR does / why we need it**: This PR adds support to push fat manifest for multi-arch images. We need this so that we can seamlessly pull and run the test images on multiple platforms. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Introduce priority class in the resource quota **What this PR does / why we need it**: Implements https://github.com/kubernetes/community/pull/933 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #48648 **Special notes for your reviewer**: Test Cases are still to be covered. Opening this PR to make discussion convenient with code references. Will update test cases only after design PR has got merged. **Release note**: ```release-note Ability to quota resources by priority ``` /kind feature /priority important-soon /sig scheduling /sig node /cc @resouer @derekwaynecarr @sjenning @bsalamat @timstclair @aveshagarwal @ravisantoshgudimetla
-
vikaschoudhary16 authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 61610, 64591, 58143, 63929). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add parametrizable priority function mapping requested/capacity ratio to priority ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 61610, 64591, 58143, 63929). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add PodSecurityPolicy information to audit logs Depends on: https://github.com/kubernetes/kubernetes/pull/58806 Fix #56209 **Release note**: ```release-note PodSecurityPolicy admission information is added to audit logs ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 61610, 64591, 58143, 63929). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add netd as an addon for GCP **What this PR does / why we need it**: Add netd as an addon for GKE. The PR will add setup functions and var to help deploy netd daemon on GKE. Please checkout more detail for netd at https://github.com/GoogleCloudPlatform/netd **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 61610, 64591, 58143, 63929). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Create CoreDNS and kube-dns folders **What this PR does / why we need it**: Separate the CoreDNS and kube-dns manifests by creating their own folders (dns/coredns and dns/kube-dns) **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #61435 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` cc @MrHohn
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. apimachinery: do not fuzz ObjectMeta.{Labels/Annotation} with empty keys Fixes flaking `TestReplicationControllerConversion`.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubeadm: Set the kubelet `--resolv-conf` flag conditionally on init **What this PR does / why we need it**: `kubeadm init` detects if systemd-resolved is running and configures the kubelet to use a working resolv.conf. This patch also removes the warning message prompting manual user action for this configuration. /area kubeadm /area kubelet /area dns /kind bug /priority important-soon /sig cluster-lifecycle /assign @timothysc **Which issue(s) this PR fixes** Fixes https://github.com/kubernetes/kubeadm/issues/845 **Special notes for your reviewer**: See the difference in `KUBELET_KUBEADM_ARGS` when running with this build and enabling the resolved daemon on Ubuntu 17.10: ```bash root@vagrant:/vagrant/bin# bash << EOF systemctl start systemd-resolved ./845_kubeadm init |& tail -n5 cat /var/lib/kubelet/kubeadm-flags.env ./845_kubeadm reset --force |& tail -n2 systemctl stop systemd-resolved echo nameserver 8.8.8.8 > /etc/resolv.conf ./845_kubeadm init |& tail -n5 cat /var/lib/kubelet/kubeadm-flags.env EOF You can now join any number of machines by running the following on each node as root: kubeadm join 10.0.2.15:6443 --token 77q84j.0342evur7rrfrwwx --discovery-token-ca-cert-hash sha256:190040f9c3adf8410bc6766dac79f8679870190564e15e8f8d1704fafa03f678 KUBELET_KUBEADM_ARGS=--cgroup-driver=cgroupfs --cni-bin-dir=/opt/cni/bin --cni-conf-dir=/etc/cni/net.d --network-plugin=cni --resolv-conf=/run/systemd/resolve/resolv.conf I0603 06:49:16.592482 14106 reset.go:276] [reset] deleting contents of config directories: [/etc/kubernetes/manifests /etc/kubernetes/pki] I0603 06:49:16.592858 14106 reset.go:290] [reset] deleting files: [/etc/kubernetes/admin.conf /etc/kubernetes/kubelet.conf /etc/kubernetes/bootstrap-kubelet.conf /etc/kubernetes/controller-manager.conf /etc/kubernetes/scheduler.conf] You can now join any number of machines by running the following on each node as root: kubeadm join 10.0.2.15:6443 --token 8mdart.gp67vq3nh9urq4z5 --discovery-token-ca-cert-hash sha256:da6b2e5841546eae134524b045e782f0dd91a6b53becc8d69c15d9eab9c88758 KUBELET_KUBEADM_ARGS=--cgroup-driver=cgroupfs --cni-bin-dir=/opt/cni/bin --cni-conf-dir=/etc/cni/net.d --network-plugin=cni ``` **Release note**: ```release-note `kubeadm init` detects if systemd-resolved is running and configures the kubelet to use a working resolv.conf. ```
-
Dr. Stefan Schimanski authored
-
Chuck Ha authored
This follows the pattern `kubectl` uses for logging. There are two remaining glog.Infof call that cannot be removed easily. One glog call comes from kubelet validation which calls features.SetFromMap. The other comes from test/e2e during kernel validation. Mostly fixes kubernetes/kubeadm#852 Signed-off-by:Chuck Ha <ha.chuck@gmail.com>
-
Cao Shufeng authored
-
Cao Shufeng authored
WithAudit admission decorator log annotations to audit events set by the decorated admission controller
-
Cao Shufeng authored
-
Łukasz Osipiuk authored
-
Łukasz Osipiuk authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix data loss issue if using existing azure disk with partitions in disk mount **What this PR does / why we need it**: When use an existing azure disk(also called [static provisioning](https://github.com/andyzhangx/demo/tree/master/linux/azuredisk#static-provisioning-for-azure-disk)) in pod, if that disk has multiple partitions, the disk will be formatted in the pod mounting. This PR removes `formatIfNotFormatted` func in `WaitForAttach` which uses `lsblk` command to check whether disk is formatted or not https://github.com/kubernetes/kubernetes/blob/b87a392b1a7ece8335ad3ade410e5070e29f216e/pkg/volume/azure_dd/azure_common_linux.go#L213-L215 And finally the format disk operation will happen in `MountDevice` in which it uses common k8s code(`SafeFormatAndMount.GetDiskFormat`) using `blkid` to detect disk format, `blkid` could detect multiple partitions https://github.com/kubernetes/kubernetes/blob/b87a392b1a7ece8335ad3ade410e5070e29f216e/pkg/util/mount/mount_linux.go#L541-L543 - so if we use common k8s code(`SafeFormatAndMount.GetDiskFormat`), following error will be returned for mulitple partition disks, which is expected: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #63235 **Special notes for your reviewer**: This PR depends on https://github.com/kubernetes/kubernetes/pull/63248 **Release note**: ``` fix data loss issue if using existing azure disk with partitions in disk mount ``` /sig azure /assign @khenidak
-
Koonwah Chen authored
-
Koonwah Chen authored
-
- 03 Jun, 2018 8 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 64481, 64569). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add tallclair to milestone maintainers For sig-auth. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 64481, 64569). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Instrument envelop transformer. **What this PR does / why we need it**: Add metrics for envelope transformer: transformation_operation_count transformation_failures_count envelope_transformation_cache_misses_count data_key_generation_latencies_microseconds data_key_generation_failures_count **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Cinder Volume API changes for adding support for secrets in the future **What this PR does / why we need it**: Many of the in-tree volume sources support specification of secret(s) for specific volumes. This support is not present in cinder currently. This PR adds just the changes in the API, so work can be done in the future in the external openstack controller manager. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Address comments in #64006. Address comments in #64006 @tallclair @yujuhong @kubernetes/sig-node-pr-reviews Signed-off-by:
Lantao Liu <lantaol@google.com> **Release note**: ```release-note none ```
-
Koonwah Chen authored
-
leigh schrandt authored
Fixes https://github.com/kubernetes/kubeadm/issues/845
-
Davanum Srinivas authored
-
Davanum Srinivas authored
-
- 02 Jun, 2018 10 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. apiextensions: add ObjectMeta validation and pruning This is a critical pre-requisite for further multi-version support and especially for GA of CRDs: ObjectMeta must be schema-validated and pruned, like `json.Unmarshal` does this. This PR adds this in the incoming request serializer and the storage decoder. The former errors when schema validation fails, the later just drops invalid typed fields. Fixes #59451 ```release-note Meta data of CustomResources is now pruned and schema checked during deserialization of requests and when read from etcd. In the former case, invalid meta data is rejected, in the later it is dropped from the CustomResource objects. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 64641, 64532). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Validate that GitRepoVolumeSource parameters are not flags to git **What this PR does / why we need it**: Validate that GitRepoVolumeSource parameters are not flags to git, as a mitigation for vulnerabilities in git. See https://groups.google.com/d/msg/kubernetes-security-announce/ayqL4LiUcV4/09HL6e11AgAJ **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 64641, 64532). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. apimachinery: adapt ObjectConvertor invariant We avoid deepcopies in the codec/conversion stack by re-using data structures. This means that the out object of a conversion must be deepcopied before mutation in order to not mutate the in object as well. This guarantees that e.g. runtime.Encode (which uses conversion from internal -> versioned) does not mutate the input. This would be highly unexpected (and we do not mention possible mutation of the input for runtime.Encode).
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 64613, 64596, 64573, 64154, 64639). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. printers: fix json types – int64 is only allowed integer We have the invariant in apimachinery that all integers in JSON are int64. We panic on other types on deepcopy and possibly at other occasions.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 64613, 64596, 64573, 64154, 64639). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Implement dynamic volume limits Implement dynamic volume limits depending on node type. xref https://github.com/kubernetes/community/pull/2051 ```release-note Add Alpha support for dynamic volume limits based on node type ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 64613, 64596, 64573, 64154, 64639). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove extra "../" when copying from pod to local **Release note**: ```release-note NONE ``` Copying via `kubectl cp` from a pod to local will no longer panic if any received tar headers contain an extra "../". This can happen when specifying a remote location beyond "/" - for example: ``` # I am attempting to go backwards beyond "/" $ kubectl cp mypod:/one/two/../../../etc/hosts ./ ``` The above command results in a tar header containing an extra "../" in its name (../etc/hosts), causing a panic [here](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/cmd/cp.go#L388). Related downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1584555 cc @soltysh
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 64613, 64596, 64573, 64154, 64639). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Openapi some cleanup Clean-up some OpenAPI code, mostly test related (there are two implementations of "Fake"). This is going for master, but I'll probably also cherry-pick/create a similar PR for feature-serverside-apply branch since we'll need that to move some code around. **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Subpath env expansion alpha tests failing **What this PR does / why we need it**: The alpha tests which wait for events do not get events back in the wait time Increased timeout to set to the framework default **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #64578 **Special notes for your reviewer**: @kubernetes/sig-storage-bugs /cc @msau42 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. ccm: recognize InstanceNotFound from InstanceID Otherwise we won't actually delete Nodes in this code path. ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. CSI fix for gRPC conn leak **What this PR does / why we need it**: This PR is a bug fix for leaky gRPC connection that never closes (see issue #64341 for detail) **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #64341 This fix was originally started with PR https://github.com/kubernetes/kubernetes/pull/64380 ```release-note NONE ```
-