- 10 Aug, 2017 40 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50306, 49624) Add daemonset to all categories **What this PR does / why we need it**: We could get daemonset resource by running command `kubectl get all`. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # fix https://github.com/kubernetes/kubernetes/issues/49620
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50306, 49624) simplify logic around LB deletion for servicecontroller **What this PR does / why we need it**: simplify logic around LB deletio **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: discovered when aswering to #50299 **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50386, 50374, 50444, 50382) Add grabbing Cluster Autoscaler metrics in e2e tests This adds: - collecting metrics from Cluster Autoscaler before & after e2e test run - --include-cluster-autoscaler opt-in flag - passing external cluster client to MetricsGrabber (required for Kubemark setup, as Cluster Autoscaler doesn't run on master in this case)
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50386, 50374, 50444, 50382) jsonpath: fix comments Minor fix to the comments. And avoid a named return value. **Release note**: ```release-note NONE ``` /cc @sttts
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50386, 50374, 50444, 50382) wires ban flunder admission plugin to the sample server **What this PR does / why we need it**: this PR wires ban flunder admission plugin to the sample server. **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50386, 50374, 50444, 50382) Add explicit API kind and version to the audit policy file on GCE Adds an explicit API version and kind to the audit policy file in GCE configuration scripts. It's a prerequisite for https://github.com/kubernetes/kubernetes/pull/49115 /cc @tallclair @piosz
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Update mrubin to matchstick in OWNERS **What this PR does / why we need it**: per https://github.com/kubernetes/kubernetes/issues/50048#issuecomment-320000920 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # associated with #50048 **Special notes for your reviewer**: /assign @matchstick **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue [Federation] Implement leader election for controller-manager **What this PR does / why we need it**: - Add cluster-selector for namespace - Add support for creating federation-only objects. - Ref #44631 - Implements leader election for controller-manager. Ref: #44283 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #44490 **Special notes for your reviewer**: This PR also fixes the issue #44490, which is about delay in initializing controller-manager due to unavailability of api-server. **Release note**: ```release-note federation: Support for leader-election among federation controller-manager instances introduced. ``` /cc @kubernetes/sig-federation-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue fix error message for scale **What this PR does / why we need it**: ref: https://github.com/kubernetes/kubernetes/blob/master/cmd/genutils/genutils_test.go#L33 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Nikhita Raghunath authored
avoid named return errors fix compile error
-
Aleksandra Malinowska authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49725, 50367, 50391, 48857, 50181) Use 'Infof' instead of 'Errorf' for a debug log **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # #50167 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49725, 50367, 50391, 48857, 50181) Add e2e test for privileged containers **What this PR does / why we need it**: This PR adds node e2e test for privileged containers. **Which issue this PR fixes** Part of #44118. **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /assign @Random-Liu
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49725, 50367, 50391, 48857, 50181) New get-kube.sh option: KUBERNETES_SKIP_RELEASE_VALIDATION **What this PR does / why we need it**: This is an alternative solution to https://github.com/kubernetes/kubernetes/pull/49884. The goal is to be able to pull releases that were built by bazel jobs (both presubmit and postsubmit builds), which currently fail our regex validation against the version string. This implementation is a simple "I know what I'm doing" breakglass option to turn regex validation off, whereas https://github.com/kubernetes/kubernetes/pull/49884 was to extend our validation to support the new formats of bazel build jobs. I'm testing the waters to see if this is a more palatable solution. **Release note**: ```release-note New get-kube.sh option: KUBERNETES_SKIP_RELEASE_VALIDATION ``` CC @BenTheElder @fejta @ixdy
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49725, 50367, 50391, 48857, 50181) Don't call one of pointless conversions @kubernetes/sig-federation-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Azure: Allow VNet to be in a separate Resource Group **What this PR does / why we need it**: This PR allows Kubernetes in an Azure context to use a VNet which is not in the same Resource Group as Kubernetes. We need this because currently Azure Cloud Provider driver assumes that it should have a VNet for himself but if there is one thing that should be shared amongst Azure resources it's a VNet cause, well, things might want to talk to each other in a private network, don't you think ? I guess this should we backported down to 1.6 branch. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49577 **Release note**: ```release-note NONE ``` @kubernetes/sig-azure @kubernetes/sig-azure-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49642, 50335, 50390, 49283, 46582) fix iptables mode hard code in e2e test Fixes #46078
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49642, 50335, 50390, 49283, 46582) fix bug when azure cloud provider configuration file is not specified **What this PR does / why we need it**: Current [Azure cloud provider](https://github.com/kubernetes/kubernetes/blob/master/pkg/cloudprovider/providers/azure/azure.go#L203) failed to [parse empty config file](https://github.com/kubernetes/kubernetes/blob/master/pkg/cloudprovider/plugins.go#L110-L124) when `--cloud-config` is not specified. [GetServicePrincipalToken](https://github.com/kubernetes/kubernetes/blob/master/pkg/cloudprovider/providers/azure/azure.go#L157-L199) will raise an error if no valid secrets/tokens are found. So we just need to return empty config obj if `--cloud-config` is not set. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49228 **Special notes for your reviewer**: @githubvick **Release note**: ```release-note fix bug when azure cloud provider configuration file is not specified ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49642, 50335, 50390, 49283, 46582) Admit sysctls for other runtime. Fixes https://github.com/kubernetes/kubernetes/issues/50343. Admit sysctl for other runtimes. /cc @mikebrow @yujuhong @feiskyer @sttts
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49642, 50335, 50390, 49283, 46582) Improve GC discovery sync performance Improve GC discovery sync performance by only syncing when discovered resource diffs are detected. Before, the GC worker pool was shut down and monitors resynced unconditionally every sync period, leading to significant processing delays causing test flakes where otherwise reasonable GC timeouts were being exceeded. Related to https://github.com/kubernetes/kubernetes/issues/49966. /cc @kubernetes/sig-api-machinery-bugs ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49642, 50335, 50390, 49283, 46582) Add rbac.authorization.k8s.io/v1 xref https://github.com/kubernetes/features/issues/2 Promotes the rbac.authorization.k8s.io/v1beta1 API to v1 with no changes ```release-note The `rbac.authorization.k8s.io/v1beta1` API has been promoted to `rbac.authorization.k8s.io/v1` with no changes. The `rbac.authorization.k8s.io/v1alpha1` version is deprecated and will be removed in a future release. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49615, 49321, 49982, 49788, 50355) Simplify hack/verify-flags-underscore.py **What this PR does / why we need it**: This PR removes the need for `hack/verify-flags/known-flags.txt` and verify-flags-underscore.py will always parse the flags from go files to check if they have underscore. It is much faster compared to earlier checks and it does its job to check for underscore in flags. Now: ``` # time ./hack/verify-flags-underscore.py real 0m1.638s user 0m1.560s sys 0m0.076s ``` Before: ``` # time ./hack/verify-flags-underscore.py real 0m22.585s user 0m22.464s sys 0m0.112s ``` It has become a pain to keep adding new flag to `known-flags.txt` whenever a new flag is introduced. with this PR this is step is not required anymore. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #40329 #50319 **Special notes for your reviewer**: **Release note**: ``` NONE ``` /cc @fejta @mtaufen
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49615, 49321, 49982, 49788, 50355) csr: add resync to csr approver fixes https://github.com/kubernetes/kubernetes/issues/49787 ```release-note Fix an issue where if a CSR is not approved initially by the SAR approver is not retried. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49615, 49321, 49982, 49788, 50355) kubeadm: Move all node bootstrap token related code in one phase package **What this PR does / why we need it**: Part of the phases refactoring. Moves everything Node Bootstrap Token-related into its own package. In the future there will be a `phases/bootstraptoken/master` pkg as well. The generic bootstrap token client functions should be moved to client go eventually https://github.com/kubernetes/client-go/issues/114 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: I'll yet add the CLI interface for this tomorrow. Not sure if this compiles currently, but I'm uploading this now for initial review. **Release note**: ```release-note NONE ``` @kubernetes/sig-cluster-lifecycle-pr-reviews @mattmoyer
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49615, 49321, 49982, 49788, 50355) Fix unused Secret export logic. **What this PR does / why we need it**: The strategy used for the secret store defined custom export logic, and had accompanying unit tests. However the secret storage did not actually wire this up by setting an ExportStrategy and thus the code was never used in the real world. This change fixes the missing assignment and adds testing at a higher level to ensure any uses of the generic registry.Store that we expect to have an ExportStrategy do, and no others. Several other strategies in the RBAC package also appeared to have unwired Export logic, however their implementations were all empty leading me to believe that these are not considered exportable. The empty methods have now been removed. **Which issue this PR fixes**: fixes #49042 **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49615, 49321, 49982, 49788, 50355) remove redundant comment **What this PR does / why we need it**: there has redundant comment and delete it! **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50300, 50328, 50368, 50370, 50372) Bugfix: set resources only for fluentd-gcp container. There is more than one container in fluentd-gcp deployment. Previous implementation was setting resources for all containers, not just the fluent-gcp one. **What this PR does / why we need it**: Bugfix; https://github.com/kubernetes/kubernetes/pull/49009 without this is eating more resources. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #50366 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50300, 50328, 50368, 50370, 50372) correct the allocated element number of pod selectable field set a little fix to correct the allocated element number of pod selectable field set
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50300, 50328, 50368, 50370, 50372) Reduce hollow-kubelet cpu request Fixes https://github.com/kubernetes/kubernetes/issues/50366 This should make kubemark-500 fit in 6 nodes again. Checked that it should be enough. cc @kubernetes/sig-scalability-misc
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50300, 50328, 50368, 50370, 50372) Add unit tests for GenerateLink Fixes https://github.com/kubernetes/kubernetes/issues/48321 cc @lavalamp ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50300, 50328, 50368, 50370, 50372) Clean validation_test go file When i wrote test cases for feature gate of local storage quota, found some unused vars and useless code, remove them **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50418, 49830, 49206, 49061, 49912) add LocalZone into gce.conf and refactor gce cloud provider configura… The main goal of this PR is to make gce cloud provider able to run locally. 1. added a LocalZone parameter into gce.conf. 2. refactor `newGCECloud` to avoid contacting metadata server if configuration is already available. ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50418, 49830, 49206, 49061, 49912) Promotes TolerateUnreadyEndpoints annotation to a field (beta) This PR promotes add the v1.Service.PublishNotReadyAddresses field and adds a deprecation notice for The "service.alpha.kubernetes.io/tolerate-unready-endpoints". fixes #47880,#25283 ```release-note The v1.Service.PublishNotReadyAddresses field is added to notify DNS addons to publish the notReadyAddresses of Enpdoints. The "service.alpha.kubernetes.io/tolerate-unready-endpoints" annotation has been deprecated and will be removed when clients have sufficient time to consume the field. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50418, 49830, 49206, 49061, 49912) Add UT case for pdb printer **What this PR does / why we need it**: Add UT case for pdb printer **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # NONE **Special notes for your reviewer**: NONE **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50418, 49830, 49206, 49061, 49912) Renamed packge name to apiv1 **What this PR does / why we need it**: Renamed packge name from k8s_api_v1 to apiv1 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50418, 49830, 49206, 49061, 49912) Target godep script change verifications helps with #50319 `hack/verify-godeps.sh` takes ~15 minutes of the verify job time. We should not run it if not required, especially since the job is regularly timing out at 1 hour when this check is included. https://github.com/kubernetes/kubernetes/pull/48653 added a check to run it if *anything* under `hack` was changed. This targetes just changes to the godep scripts
-
Lucas Käldström authored
-
Lucas Käldström authored
-
Lucas Käldström authored
-
Jordan Liggitt authored
-