- 09 Jul, 2018 19 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65830, 65780, 65961). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. change field selector conversion registration to be strongly typed the signature of these methods is misleading... they require a group-version-kind ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65830, 65780, 65961). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. apiserver: get rid of ReadWritePort in config Executing removal TODO by making the read write port logic explicit, and not hidden deep in the secure serving code. Preparation for https://github.com/kubernetes/kubernetes/pull/65832
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 64664, 65836, 65917). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove stray comment from a merge Signed-off-by:
Davanum Srinivas <davanum@gmail.com> **What this PR does / why we need it**: Remove stray comment from a merge. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 64664, 65836, 65917). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubectl: Remove an extra character from rollout error message **What this PR does / why we need it**: Removes an extra character in a `kubectl rollout status` error message. **Special notes for your reviewer**: I thought this would be a good first contribution! **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Handle errors in generated client scheme **What this PR does / why we need it**: Adds missing error handling for schema construction code in generated clientsets. **Which issue(s) this PR fixes** Together with #64654 fixes #51457. **Release note**: ```release-note NONE ``` /kind bug /sig api-machinery
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65456, 65549). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix flexvolume in containerized kubelets Fixes flex volumes in containerized kubelets. cc @jsafrane @chakri-nelluri @verult Note to reviewers : e2e tests pass in local containarized cluster. ```release-note Fix flexvolume in containarized kubelets ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65456, 65549). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. add volume mode field to constructed volume spec for CSI plugin Add volume mode filed to constructed Volume Spec for CSI plugin ```release-note Add volume mode filed to constructed volume spec for CSI plugin ```
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix truncating and batch backends integration. Truncating backend was not starting batch thread that is responsible for reading events from the channel. Fixes https://github.com/kubernetes/kubernetes/pull/65819 ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Rename `MasterConfiguration` to `InitConfiguration` in the kubeadm v1alpha3 Config API **What this PR does / why we need it**: In v1alpha3, we have made the design decision that `MasterConfiguration` will be renamed `InitConfiguration`. This PR implements that change. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: ref: kubernetes/kubeadm#911 Depends on: - [x] https://github.com/kubernetes/kubernetes/pull/65776 - [x] https://github.com/kubernetes/kubernetes/pull/65628 - [x] https://github.com/kubernetes/kubernetes/pull/65629 - [x] https://github.com/kubernetes/kubernetes/pull/65631 - [x] https://github.com/kubernetes/kubernetes/pull/65940 - [x] https://github.com/kubernetes/kubernetes/pull/65787 **Special notes for your reviewer**: Most of the code is autogenerated, using just find and replace. Please only review commits: - `Automated rename from MasterConfiguration to InitConfiguration` - `Rename MasterConfiguration to InitConfiguration in v1alpha3, but support both names for this release of kubeadm` **Release note**: ```release-note [action required] The `MasterConfiguration` kind in the kubeadm v1alpha2 API has been renamed `InitConfiguration` in v1alpha3 ``` @kubernetes/sig-cluster-lifecycle-pr-reviews
-
Marian Lobur authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 63194, 65911). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove crappy fmt.Println Remove @gnufied's debug message https://github.com/kubernetes/kubernetes/pull/64527 ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Adding traffic shaping support for CNI network driver **What this PR does / why we need it**: Adding traffic shaping support for CNI network driver - it's also a sub-task of kubenet deprecation work. Design document is available here: https://github.com/kubernetes/community/pull/1893 **Which issue(s) this PR fixes**: Fixes # **Special notes for your reviewer**: /cc @freehan @jingax10 @caseydavenport @dcbw /sig network /sig node **Release note**: ```release-note Support traffic shaping for CNI network driver ```
-
Lucas Käldström authored
-
Lucas Käldström authored
Rename MasterConfiguration to InitConfiguration in v1alpha3, but support both names for this release of kubeadm
-
Lucas Käldström authored
-
liangwei authored
-
- 08 Jul, 2018 20 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubeadm: Use separate YAML docs for the kubelet and kube-proxy ComponentConfigs **What this PR does / why we need it**: This PR makes kubeadm load the ComponentConfig for the kubelet and kube-proxy from separate YAML documents in the `kubeadm init` config file. This is backwards-compatible with `v1alpha2`. The ComponentConfigs are stored internally in the internal kubeadm `MasterConfiguration` struct, but when marshalling the componentconfigs are written as separate YAML documents. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: ref: kubernetes/kubeadm#911 Depends on: - [x] https://github.com/kubernetes/kubernetes/pull/65776 - [x] https://github.com/kubernetes/kubernetes/pull/65628 - [x] https://github.com/kubernetes/kubernetes/pull/65629 - [x] https://github.com/kubernetes/kubernetes/pull/65631 - [x] https://github.com/kubernetes/kubernetes/pull/65940 **Special notes for your reviewer**: Only review the last five commits please. (The last commit is purely autogenerated, so can be skipped) **Release note**: ```release-note kubeadm: Use separate YAML documents for the kubelet and kube-proxy ComponentConfigs ``` @kubernetes/sig-cluster-lifecycle-pr-reviews /assign @timothysc
-
Lucas Käldström authored
-
Lucas Käldström authored
-
Lucas Käldström authored
-
Lucas Käldström authored
-
Lucas Käldström authored
Remove the ComponentConfig structs from the external v1alpha3 API. Use the new componentconfigs pkg for validation and conversion
-
Lucas Käldström authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubeadm: Start using internal versions for ComponentConfigs in the internal API **What this PR does / why we need it**: This PR changes kubeadm to store the internal API versions of the ComponentConfig APIs, in order to in the future be able to read multiple external versions with conversion. It also moves all the ComponentConfigs to a common struct instead of splitting them out in many. This makes it possible to more easily host more ComponentConfigs in the future. In v1alpha3, the ComponentConfigs will later be removed from the external version of the API (see: https://github.com/kubernetes/kubernetes/pull/65787), but for this PR no changes to the external API are made. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: ref: kubernetes/kubeadm#911 Depends on: - [x] https://github.com/kubernetes/kubernetes/pull/65776 - [x] https://github.com/kubernetes/kubernetes/pull/65628 - [x] https://github.com/kubernetes/kubernetes/pull/65629 - [x] https://github.com/kubernetes/kubernetes/pull/65631 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` @kubernetes/sig-cluster-lifecycle-pr-reviews
-
m1093782566 authored
-
Lucas Käldström authored
-
Lucas Käldström authored
-
Lucas Käldström authored
-
Lucas Käldström authored
-
Lucas Käldström authored
kubeadm: Embed the internal variants of the componentconfigs in the internal kubeadm API with conversions
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add a README in test/e2e/node with a warning **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65882, 65896, 65755, 60549, 65927). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix visibility of testdata for //test/cmd:legacy-script **What this PR does / why we need it**: fixes some BUILD visibility, albeit for a relatively unused target **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65882, 65896, 65755, 60549, 65927). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Adding details to Conformance Tests using RFC 2119 standards. This PR is part of the conformance documentation. This is to provide more formal specification using RFC 2119 keywords to describe the test so that who ever is running conformance tests do not have to go through the code to understand why and what is tested. The documentation information added here into each of the tests eventually result into a document which is currently checked in at location https://github.com/cncf/k8s-conformance/blob/master/docs/KubeConformance-1.9.md I would like to have this PR reviewed for v1.10 as I consider it important to strengthen the conformance documents.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65882, 65896, 65755, 60549, 65927). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Avoid printing some service comments in iptables rules According to some profiles, with large number of endpoints in the system, comments mentioning the service in appropriate iptables rules may be responsible for 40% of all iptables contents. Given that ~70% of memory usage of kube-proxy seems to be because of generated iptables rules, the overall saving may be at the level of 30% or so. OTOH, we sacrifise a bit understandability of iptables, but this PR only changes some of iptables that contribute to the most painful rules. @thockin @danwinship @dcbw - thoughts? Ref #65441
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65882, 65896, 65755, 60549, 65927). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fail update-godep-licenses if bash version lower than 4 **What this PR does / why we need it**: trying to update godeps on mac OSX fails without any information, this patch exits the script with a return error code just after printing the cause of the failure in the screen to the user **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #65784 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65882, 65896, 65755, 60549, 65927). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add script to verify generated files **What this PR does / why we need it**: This is probably *really* heavy handed fix to this, but it will catch issues in presubmit. Basically, takes a copy of the repo, clears out anything that is ignored from the git tree, runs `make generated_files`, and looks for a git diff. If there is one, error. Anything that is properly gitignored won't cause a diff, but anything that is *supposed* to be checked in, but is different, this will catch. **Special notes for your reviewer**: I'm open to more elegant answers, but this will at least stop it from happening for now. **Release note**: ```release-note NONE ```
-
- 07 Jul, 2018 1 commit
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65946, 65904, 65913, 65906, 65920). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubeadm: pause image should be arch agnostic, as it is a manifest list Signed-off-by:
Davanum Srinivas <davanum@gmail.com> **What this PR does / why we need it**: `pause` image is backed by a manifest list. so we should not use the arch image when reporting using say `kubeadm config image list` **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes https://github.com/kubernetes/kubeadm/issues/962 **Special notes for your reviewer**: **Release note**: ```release-note kubeadm: Fix pause image to not use architecture, as it is a manifest list ```
-