1. 31 Jan, 2018 8 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #59086 from feiskyer/typo · 494664a7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fix typo and comments
      
      **What this PR does / why we need it**:
      
      Fix typo across the azure package.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      494664a7
    • Kubernetes Submit Queue's avatar
      Merge pull request #58799 from lichuqiang/cleanup · b3115df4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      remove unused func in FakeConfigurator of scheduler
      
      **What this PR does / why we need it**:
      Current scheduler `Configurator` interface looks like this:
      ```
      type Configurator interface {
      	GetPriorityFunctionConfigs(priorityKeys sets.String) ([]algorithm.PriorityConfig, error)
      	GetPriorityMetadataProducer() (algorithm.PriorityMetadataProducer, error)
      	GetPredicateMetadataProducer() (algorithm.PredicateMetadataProducer, error)
      	GetPredicates(predicateKeys sets.String) (map[string]algorithm.FitPredicate, error)
      	GetHardPodAffinitySymmetricWeight() int32
      	GetSchedulerName() string
      	MakeDefaultErrorFunc(backoff *util.PodBackoff, podQueue core.SchedulingQueue) func(pod *v1.Pod, err error)
      
      	// Needs to be exposed for things like integration tests where we want to make fake nodes.
      	GetNodeLister() corelisters.NodeLister
      	GetClient() clientset.Interface
      	GetScheduledPodLister() corelisters.PodLister
      
      	Create() (*Config, error)
      	CreateFromProvider(providerName string) (*Config, error)
      	CreateFromConfig(policy schedulerapi.Policy) (*Config, error)
      	CreateFromKeys(predicateKeys, priorityKeys sets.String, extenders []algorithm.SchedulerExtender) (*Config, error)
      }
      ```
      Funcs `ResponsibleForPod` and  `Run` once existed have been removed, so the funcs in `FakeConfigurator` should be removed accordingly.
      
      **Special notes for your reviewer**:
      /kind cleanup
      /sig scheduling
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      b3115df4
    • Kubernetes Submit Queue's avatar
      Merge pull request #58445 from hanxiaoshuai/typo · c817765b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      fix some typos in comments
      
      **What this PR does / why we need it**:
      
      Fixes # fix some typos in comments
      c817765b
    • Pengfei Ni's avatar
      Fix typo and comments · 6e453d7d
      Pengfei Ni authored
      6e453d7d
    • Kubernetes Submit Queue's avatar
      Merge pull request #59077 from rramkumar1/ingress-upgrade-test-patch · 7595560a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fixes ci-ingress-gce-upgrade-e2e
      
      **What this PR does / why we need it**:
      This PR fixes the broken ci-ingress-gce-upgrade-e2e job. The issue was that the ingress was being deleted by the test framework before the upgraded ingress could properly sync. Therefore, the resources were never cleaned up, which caused test failure. 
      
      ```release-note
      None
      ```
      
      cc @MrHohn 
      /assign @bowei
      7595560a
    • Kubernetes Submit Queue's avatar
      Merge pull request #58174 from filbranden/ipcs1 · 84408378
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fixes for HostIPC tests to work when Docker has SELinux support enabled.
      
      **What this PR does / why we need it**:
      
      Fixes for HostIPC tests to work when Docker has SELinux support enabled.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      
      N/A
      
      **Special notes for your reviewer**:
      
      The core of the matter is to use `ipcs` from util-linux rather than the one from busybox. The typical SELinux policy has enough to allow Docker containers (running under svirt_lxc_net_t SELinux type) to access IPC information by reading the contents of the files under /proc/sysvipc/, but not by using the shmctl etc. syscalls.
      
      The `ipcs` implementation in busybox will use `shmctl(0, SHM_INFO, ...)` to detect whether it can read IPC info (see source code [here](https://git.busybox.net/busybox/tree/util-linux/ipcs.c?h=1_28_0#n138)), while the one in util-linux will prefer to read from the /proc files directly if they are available (see source code [here](https://github.com/karelzak/util-linux/blob/v2.27.1/sys-utils/ipcutils.c#L108)).
      
      It turns out the SELinux policy doesn't allow the shmctl syscalls in an unprivileged container, while access to it through the /proc interface is fine. (One could argue this is a bug in the SELinux policy, but getting it fixed on stable OSs is hard, and it's not that hard for us to test it with an util-linux `ipcs`, so I propose we do so.)
      
      This PR also contains a refactor of the code setting IpcMode, since setting it in the "common options" function is misleading, as on containers other than the sandbox, it ends up always getting overwritten, so let's only set it to "host" in the Sandbox.
      
      It also has a minor fix for the `ipcmk` call, since support for size suffix was only introduced in recent versions of it.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      84408378
    • Rohit Ramkumar's avatar
      Fixes ci-ingress-gce-upgrade-e2e · 4976cb92
      Rohit Ramkumar authored
      4976cb92
    • Kubernetes Submit Queue's avatar
      Merge pull request #59070 from jaxxstorm/u/jaxxstorm/manifest_perms · 8b9aa35d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Change manifest file perms to remove execute
      
      **What this PR does / why we need it**:
      
      Currently, the manifests generated by kubeadm have permission 0700. The kubernetes CIS benchmarks state the perms should be 0644 or better, so this change sets the file permissions to 0600, as they are static files, and don't need to be executable.
      
      **Which issue(s) this PR fixes** *: Fixes # https://github.com/kubernetes/kubeadm/issues/678
      
      **Special notes for your reviewer**:
      None
      
      **Release note**:
      ```release-note
      NONE
      ```
      8b9aa35d
  2. 30 Jan, 2018 32 commits