1. 29 Mar, 2018 4 commits
  2. 28 Mar, 2018 33 commits
  3. 27 Mar, 2018 3 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #60592 from xmudrii/crd-tests · c8841cea
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61402, 61143, 61427, 60592). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      apiextensions-apiserver: TestFinaliazationAndDeletion integration test
      
      **What this PR does / why we need it**: This PR adds an integration test for [behavior described in the issue #60538 (comment)](https://github.com/kubernetes/kubernetes/issues/60538#issuecomment-369182483).
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Partially addresses #60538 -- tests
      
      **Special notes for your reviewer**: This is based of the PR #60542, so this shouldn't be merged before that one. Tests are failing on the line 155, due to the timeout/non-nil error. I've tried to debug it furtherly, and found out that the CRD is still terminating. 
      
      Actually, the CRD gets deleted, but it takes some time. For example, if you add `time.Sleep(x * time.Second)` on the line 152, the test would pass. The problem is this isn't predictable. With `x` of 6-10 seconds, I manage to get this test passing, but there's zero guarantees the CRD will get deleted for that 10 seconds.
      
      I have found the `wait.Poll` function in some tests, but I'm not sure can it fix the problem I have.
      
      This is my first PR to the Kubernetes project, so I could be missing something. Any idea is appreciated. :)
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      
      /sig api-machinery
      /area custom-resources
      /cc nikhita sttts liggitt
      c8841cea
    • Kubernetes Submit Queue's avatar
      Merge pull request #61427 from hyperbolic2346/mwilson/admission · f9c9a25e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61402, 61143, 61427, 60592). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Changing admission controller settings
      
      **What this PR does / why we need it**:
      By default, the admission controller settings in a CDK cluster didn't match the set recommended here:
      https://kubernetes.io/docs/admin/admission-controllers/#is-there-a-recommended-set-of-admission-controllers-to-use
      
      Now they do.
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/517
      **Special notes for your reviewer**:
      
      **Release note**:
      ```release-note
      Updated admission controller settings for Juju deployed Kubernetes clusters
      ```
      f9c9a25e
    • Kubernetes Submit Queue's avatar
      Merge pull request #61143 from satyasm/ipam-perf-cloud-mock · 2bc231eb
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61402, 61143, 61427, 60592). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Performance tests and fix for IPAM controller.
      
      Tests the four modes of allocations. Can be run using
      ./test-performance.sh under tests/integration/ipamperf
      directory. See ./test-performance.sh -h for supported flags.
      
      
      
      **What this PR does / why we need it**:
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      Please see the implementation  notes comment block in cloud.go for core details of how 
      the mocking works. README.md has details on how the tests can be run on the 
      command line.
      
      **Release note**:
      
      ```release-note
      Performance test framework and basic tests for the IPAM controller, to simulate behavior
      of the four supported modes under lightly loaded and loaded conditions, where load is 
      defined as the number of operations to perform as against the configured kubernetes
      API server QPS.
      ```
      2bc231eb