Automatic merge from submit-queue

Fix kibana e2e test

Thanks @Random-Liu for noticing a problem in kibana e2e test!

Fix https://github.com/kubernetes/kubernetes/issues/36402

@piosz

Automatic merge from submit-queue

fix bug when compare version

Fix a small bug when compare version in `patch` which is introduced by my PR #35647 today.

This blocks #36672.

cc: @janetkuo

Automatic merge from submit-queue

Fix watching from resourceVersion=0 in etcd3 watcher

Fixes https://github.com/kubernetes/kubernetes/issues/36545

* Makes etcd3 consistent with watch cache behavior (all synthetic events sent for the initial list of items result in ADDED events)
* Fixes errors if previous values of initial items had been compacted away
* Removes fan-out Get() for previous values of initial items

Should be fixed before making etcd3 the default (https://github.com/kubernetes/kubernetes/pull/36229)

Automatic merge from submit-queue

Bump GCI version to gci-dev-56-8977-0-0

@vishh @saad
``` release-note
Updating GCI base image to gci-dev-56-8977-0-0. Changelog as follows:
    * runc: Eliminate redundant parsing of mountinfo
    * Updated kubernetes to v1.4.5
```

Automatic merge from submit-queue

Add back e2e tests for disruption budget

The tests were temporarily removed due to problems with api versions in client-go. The test is almost exactly the same as it used to be before api version change.

cc: @caesarxuchao @davidopp

Automatic merge from submit-queue

Restore event messages for replica sets in the deployment controller

Needed to unblock release upgrade tests (see https://github.com/kubernetes/kubernetes/issues/36453)

@kubernetes/deployment ptal

Automatic merge from submit-queue

README: Link to the real links

A majority of the links in the README tell you to go to another link on
kubernetes.io. Fix up all of the ones I could find.

Automatic merge from submit-queue

Fix strategic patch for list of primitive type with merge sementic

Fix strategic patch for list of primitive type when the patch strategy is `merge`.
Before: we cannot replace or delete an item in a list of primitive, e.g. string, when the patch strategy is `merge`. It will always append new items to the list.
This patch will generate a map to update the list of primitive type.
The server with this patch will accept either a new patch or an old patch.
The client will found out the APIserver version before generate the patch.

Fixes #35163, #32398

cc: @pwittrock @fabianofranz 

``` release-note
Fix strategic patch for list of primitive type when patch strategy is `merge` to remove deleted objects.
```

Automatic merge from submit-queue

Fixing spark e2e test failures.

**What this PR does / why we need it**: Fixes e2e test failures in the spark tests. These failures were caused by an update to the examples in https://github.com/kubernetes/kubernetes/pull/33604

**Which issue this PR fixes** : fixes https://github.com/kubernetes/kubernetes/issues/36102

**Release note**:
```release-note
NONE
```

cc @calebamiles @elsonrodriguez @saad-ali

Automatic merge from submit-queue

Switch pod eviction client from v1alpha1 to v1beta

Generated client 1.5 has a function to evict a pod. The function uses v1alpha1.Eviction object instead of v1beta1. This pr changes the api version that is being used.

cc: @davidopp @caesarxuchao

Automatic merge from submit-queue

Set version and job-version in started.json/metadata.json

Ref https://github.com/kubernetes/test-infra/issues/1032

We can delete version once all CI jobs are migrated to bootstrap

Automatic merge from submit-queue

fix issue in reconstruct volume data when kubelet restarts

During state reconstruction when kubelet restarts, outerVolueSpecName
cannot be recovered by scanning the disk directories. But this
information is used by volume manager to check whether pod's volume is
mounted or not. There are two possible cases:
1. pod is not deleted during kubelet restarts so that desired state
should have the information. reconciler.updateState() will use this
inforamtion to update.
2. pod is deleted during this period, reconciler has to use
InnerVolumeSpecName, but it should be ok since this information will not
be used for volume cleanup (umount)

Automatic merge from submit-queue

More unittests for HPA.

Automatic merge from submit-queue

Federation test util fix - 1

* Make nil and empty map equivalent when testing ObjectMeta equivalence
* Add a function that waits for a particular content inside federated store

cc: @nikhiljindal @madhusudancs

Automatic merge from submit-queue

Improve quota performance for pvc by using shared informer

This avoids a list call for each namespace in the resource quota controller when syncing quota.

Automatic merge from submit-queue

Do not emit event for AlreadyExists errors

Fixes https://github.com/kubernetes/kubernetes/issues/36598 also reduced the clutter of events since the AlreadyExists error is a common error (may be a slow rs cache or a fast resync of the deployment that causes it apart from hash collisions)

@kubernetes/deployment

Automatic merge from submit-queue

Ensure health check exists before creating target pool

We already couple health check deletion with target pool deletion in deleteTargetPools, do the inverse in createTargetPools. See https://github.com/kubernetes/kubernetes/issues/35282#issuecomment-259317589 for why this is necessary. Fixes https://github.com/kubernetes/kubernetes/issues/35282, but the test won't go green till I relieve quota on the project.

Automatic merge from submit-queue

Node Conformance & E2E: Get node name from node object.

This PR changes the node e2e test framework to get node name from apiserver instead of test flags.

When a user tried out the node conformance test, he found that node conformance test will not work properly if kubelet is started with `hostname-override`.

The reason is that node conformance test is using [the default node name - `os.Hostname`](https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/e2e_node_suite_test.go#L124), which may be different from `hostname-override`. This will cause test pods not scheduled, and eventually test timeout.

We can expose a flag from node conformance test, and let user set node name themselves if they are using `hostname-override` on kubelet. However, let the framework automatically detect it from apiserver is more user friendly.

/cc @kubernetes/sig-node 
This PR 1) only changes node e2e test framework; 2) fixes a problem in node conformance test which is a 1.5 feature. @saad-ali Can we have this in 1.5?

Automatic merge from submit-queue

README: stop linking to a 18 month old version

We are proud of the v1.0 release but lets give users context on the date
it was released and not drive them to the actual release since
they should be using the latest release instead.

Automatic merge from submit-queue

Expand documentation and TODOs in a few packages

I was reading through unfamiliar code and mostly added TODOs and expanded and clarified documentations.

There are a couple of things that are real code changes:
- Removed some unused constants
- Changed `workqueue.Parallize` to clamp the number of worker goroutines to the number of items to be processed.
- Added another unit test to `workqueue.queue`.  I thought I found a bug (I was wrong) and wrote a unit test to isolate.  I figure the extra test is worth keeping.

Automatic merge from submit-queue

CRI: general grammar/spelling/consistency cleanup

No semantic changes, but a lot of shuffling of docstrings to make things
more consistent. In particular, standardise on the zeroth-article (i.e.
prefer `// Version` to `// The version`) and ending all docstrings with
periods.


(This knowingly conflicts with #36446 and intentionally omits changing the
Annotations field - I'll rebase this or that respectively as necessary.)

Automatic merge from submit-queue

Ensure proper serialization of updates and creates in federation test watcher

Fix for finalizer test problems. The issue there was that the updates were coming out of order. It was caused by firing updates in new goroutines in test watcher. The proper solution is to order them in a queue and fire in order on a single goroutine.

Ref: https://github.com/kubernetes/kubernetes/issues/36473#issuecomment-259605870

cc: @nikhiljindal @madhusudancs

During state reconstruction when kubelet restarts, outerVolueSpecName
cannot be recovered by scanning the disk directories. But this
information is used by volume manager to check whether pod's volume is
mounted or not. There are two possible cases:
1. pod is not deleted during kubelet restarts so that desired state
should have the information. reconciler.updateState() will use this
inforamtion to update.
2. pod is deleted during this period, reconciler has to use
InnerVolumeSpecName, but it should be ok since this information will not
be used for volume cleanup (umount)