- 17 May, 2017 9 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45247, 45810, 45034, 45898, 45899) Add MrHohn to couple e2e tests /assign @bowei **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45247, 45810, 45034, 45898, 45899) [Federation] Segregate DNS related code to separate controller **What this PR does / why we need it**: This is the continuation of service controller re-factor work as outlined in #41253 This PR segregates DNS related code from service controller to another controller `service-dns controller` which manages the DNS records on the configured DNS provider. `service-dns controller` monitors the federated services for the ingress annotations and create/update/delete DNS records accordingly. `service-dns controller` can be optionally disabled and DNS record management could be done by third party components by monitoring the ingress annotations on federated services. (This would enable something like federation middleware for CoreDNS where federation api server could be used as a backend to CoreDNS eliminating the need for etcd storage.) **Special notes for your reviewer**: **Release note**: ``` Federation: A new controller for managing DNS records is introduced which can be optionally disabled to enable third party components to manage DNS records for federated services. ``` cc @kubernetes/sig-federation-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45247, 45810, 45034, 45898, 45899) kubectl plugin: Expand environment variables in the command of plugin.yaml **What this PR does / why we need it**: This commit improves kubectl plugins to expand environment variables in the command of plugin.yaml. I'd like to use environment variables in the command of plugin.yaml as follows: ```yaml name: hello shortDesc: "The hello plugin" longDesc: > The hello plugin is a new plugin used by test-cmd to test multiple plugin locations. command: $HOME/path/to/plugins/hello.sh ``` **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45247, 45810, 45034, 45898, 45899) Apiregistration v1alpha1→v1beta1 Promoting apiregistration api from v1alpha1 to v1beta1. API Registration is responsible for registering an API `Group`/`Version` with another kubernetes like API server. The `APIService` holds information about the other API server in `APIServiceSpec` type as well as general `TypeMeta` and `ObjectMeta`. The `APIServiceSpec` type have the main configuration needed to do the aggregation. Any request coming for specified `Group`/`Version` will be directed to the service defined by `ServiceReference` (on port 443) after validating the target using provided `CABundle` or skipping validation if development flag `InsecureSkipTLSVerify` is set. `Priority` is controlling the order of this API group in the overall discovery document. The return status is a set of conditions for this aggregation. Currently there is only one condition named "Available", if true, it means the api/server requests will be redirected to specified API server. ```release-note API Registration is now in beta. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45374, 44537, 45739, 44474, 45888) fix typo **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45374, 44537, 45739, 44474, 45888) Update 'More info' links on API types and fields > **Please just review the first commit, the rest is generated files.** Recent docs website shuffling during 1.6 caused majority of links in the API types and fields to break. Since we do not have server-side 301 redirects, user has to click an extra link, and the #target fragment in the URL will be lost. (This is because GitHub’s redirect_from feature is not ideal.) For the time being, I have manually gone through all of them to bring them up to date and add HTTPS to those missing it. This is a docs-only change and impacts generated code, generated swaggers, API reference docs etc. cc: @steveperry-53 @devin-donnelly @chenopis fyi, docs links changes (even small title changes) easily breaks links in API reference, Swagger, kubectl explain, and many other places. Signed-off-by:Ahmet Alp Balkan <ahmetb@google.com>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45374, 44537, 45739, 44474, 45888) Allow kcm and scheduler to lock on ConfigMaps. **What this PR does / why we need it**: Plumbs through the ability to lock on ConfigMaps through the kcm and scheduler. **Which issue this PR fixes** Fixes: #44857 Addresses issues with: #45415 **Special notes for your reviewer**: **Release note**: ``` Add leader-election-resource-lock support to kcm and scheduler to allow for locking on ConfigMaps as well as Endpoints(default) ``` /cc @kubernetes/sig-cluster-lifecycle-pr-reviews @jamiehannaford @bsalamat @mikedanese
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45374, 44537, 45739, 44474, 45888) Fix attach volume to instance repeatedly 1.When volume's status is 'attaching', controllermanager will attach it again and return err. So it is necessary to check volume's status before attach/detach volume. 2. When volume's status is 'attaching', its attachments will be None, controllermanager can't get device path and make some failed event. But it is normal, so don't return err when attachments is None Fix bug: #44536 -
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45374, 44537, 45739, 44474, 45888) [Federation] Refactor sync controller's reconcile method for maintainability This PR refactors the sync controllers reconcile method for maintainability with the goal of eliminating the need for type-specific controller unit tests. The unit test coverage for reconcile is not complete, but I think it's a good start. cc: @kubernetes/sig-federation-pr-reviews
-
- 16 May, 2017 31 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45860, 45119, 44525, 45625, 44403) coredns: support IPv6 record set Added support for AAAA record for coredns and included unit test. Refactored common test code to reduce duplication from added test and existing tests. Fixed function names in comments for Google and AWS tests to match actual test name in this area. **What this PR does / why we need it**: Adding IPv6 support to kubernetes, once piece at a time. :) **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #44351 **Special notes for your reviewer**: In addition to the change and unit test method, I did some minor refactoring (since the UT was a near clone of an existing test). Fixed typos in related test methods' comment lines. Please let me know if this is OK (I was thinking it was a small change, but don't know the protocol here), or if I need to break it into multiple commits. **Release note**: ```NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45860, 45119, 44525, 45625, 44403) Make a log line more clear in kuberuntime_manager.go. Make a log in `podSandboxChanged` more clear. @yujuhong @feiskyer
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45860, 45119, 44525, 45625, 44403) [Federation] Move annotations and related parsing code as common code This PR moves some code, which was duplicate, around as common code. Changes the names of structures used for annotations to common names. s/FederatedReplicaSetPreferences/ReplicaAllocationPreferences/ s/ClusterReplicaSetPreferences/PerClusterPreferences/ This can be reused in job controller and hpa controller code. **Special notes for your reviewer**: @kubernetes/sig-federation-misc **Release note**: ```NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45860, 45119, 44525, 45625, 44403) Support running StatefulSetBasic e2e tests with local-up-cluster **What this PR does / why we need it**: Currently StatefulSet(s) fail when you use local-up-cluster without setting a cloud provider. In this PR, we use set the kubernetes.io/host-path provisioner as the default provisioner when there CLOUD_PROVIDER is not specified. This enables e2e test(s) (specifically StatefulSetBasic) to work. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add --quiet to instance-templates delete.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Update PR template links **What this PR does / why we need it**: Updates PR template with new links. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: https://github.com/kubernetes/community/pull/622 is a prerequisite for this. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Update instructions for client staging copy Following the existing instructions results in: ``` % ./staging/copy.sh Do not run this script directly, but via hack/update-staging-client-go.sh. ``` Also format README.md as markdown. **What this PR does / why we need it**: Updates docs to match reality **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Added coffeepac to ElasticSearch owners @coffeepac @fgrzadkowski, could you please add @coffeepac to Kubernetes org?
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue kubelet: use the base filename to check if the filename starts with a dot **What this PR does / why we need it**: Fixes a bug in https://github.com/kubernetes/kubernetes/pull/39196. The goal was to ignore files that start with a dot but the value used is the full absolute filename including path. **Which issue this PR fixes**: fixes #44450 @yujuhong **Release note**: ```release-note kubelet config should actually ignore files starting with dots ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 44326, 45768) custom resource De-Registration testcase @deads2k as discussed via IRC Built on top of #45732 To reproduce #45767 Uncomment code in `TestDeRegistrationAndReRegistration` to reproduce `panic`
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 44326, 45768) [CRI] Forcibly remove container Forcibly remove the running containers in `RemoveContainer`. Since we should forcibly remove the running containers in `RemovePodSandbox`. See [here](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/api/v1alpha1/runtime/api.proto#L35). cc @feiskyer @Random-Liu Signed-off-by:
Xianglin Gao <xlgao@zju.edu.cn>
-
David Radcliffe authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45408, 45355, 45528) Make createEndpointService() and deleteEndpointService() plugin interface methods. Why this change? In some setups, after creation of dynamic PVs and before mounting/using these PVs in a pod, the endpoint/service got mistakenly deleted by the user/developer. By making these methods 'plugin' specific, we can call it from mounter if there are scenarios where the endpoint and service got wiped in between accidentally. Signed-off-by:Humble Chirammal <hchiramm@redhat.com>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45408, 45355, 45528) Admission options spits out admission control **What this PR does / why we need it**: This PR adds ApplyTo method to AdmissionOptions struct. The method creates and initialises admission control to the server configuration. **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue fix typo in docker_container.go Signed-off-by:Carlory <fanbaofa@gmail.com> **What this PR does / why we need it**: fix typo in docker_container.go **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # NONE **Special notes for your reviewer**: NONE **Release note**: ```release-note NONE ```
-
Paul Michali authored
Added support for AAAA record for coredns and included unit test. Fixed function names in comments for Google and AWS tests to match actual test name in this area.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue describe pod: add unit test for Node **What this PR does / why we need it**: Add unit test for "describe pod" in order to get node info. **Release note**: ```release-note NONE ```
-
Salvatore Dario Minonne authored
-
Humble Chirammal authored
In some setups, after creation of dynamic PVs and before mounting/using these PVs in a pod, the endpoint/service got mistakenly deleted by the user/developer. By making these methods 'plugin' specific, we can call it from mounter if there are scenarios where the endpoint and service got wiped in between accidentally. Signed-off-by: Humble Chirammal hchiramm@redhat.com
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 43696, 45823) Handle self links on customresources Fixes https://github.com/kubernetes/kubernetes/issues/45776 I started from https://github.com/kubernetes/kubernetes/pull/45777 and wrote the code to make it work properly. @sdminonne ptal
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue add --as-group option to cli The usecase of this change: When a super user grant some RBAC permissions to a group, he can use --as--group to test whether the group get the permissions. Note that now we support as-groups, as-user-extra in kubeconfig file after this change. **Release note**: ```NONE ``` @liggitt
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Parallelize creation/deletion of services in load test
-
deads2k authored
-
Salvatore Dario Minonne authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Make fake iptables' Save operation more realistic Ref https://github.com/kubernetes/kubernetes/pull/45622#issuecomment-301624384 (2nd point) This would make fake IPtables actually return the iptable contents it stores. cc @kubernetes/sig-scalability-misc @wojtek-t
-
Wojciech Tyczynski authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue fix missing argument for Errorf(%v): format reads arg 1, have only 0 args Signed-off-by:yupengzte <yu.peng36@zte.com.cn> **What this PR does / why we need it**: add the missing code of "len(res.Items)" **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Shyam Jeedigunta authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue delete the code after "return" Signed-off-by:yupengzte <yu.peng36@zte.com.cn> **What this PR does / why we need it**: After return, the code is unreachable, delete it. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix kube-apiserver crash when patching TPR data **What this PR does / why we need it**: While trying to do a strategic merge patch, kube-apiserver crashes with a nil pointer dereference because `UnsafeConvertor` is `nil` for TPR data resources here: https://github.com/kubernetes/kubernetes/blob/master/pkg/master/thirdparty/thirdparty.go#L314-L337. This PR does not make strategic merge patch work on TPR data but makes sure that the kube-api server does not crash while trying to do so. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #44587 **Special notes for your reviewer**: **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Internal audit API Forked from https://github.com/kubernetes/kubernetes/pull/45315 I pulled out only the internal audit API types and would like to merge this to unblock the audit implementation work while we figure out the versioned types and code generation. I will continue to iterate on https://github.com/kubernetes/kubernetes/pull/45315, but lets get this internal type submitted. /cc @ericchiang @ihmccreery
-