- 13 Apr, 2018 14 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62467, 62482, 62211). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Ensure resources created by `run --rm` are cleaned up **Release note**: ```release-note NONE ``` Resources created by `kubectl run --rm ...` are now cleaned up, even in the event of an error. Relevant downstream issue: https://github.com/openshift/origin/issues/13276 cc @soltysh
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62467, 62482, 62211). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix nsenter GetFileType issue in containerized kubelet **What this PR does / why we need it**: UnmountDevice would fail in containerized kubelet in v1.9.x, and in the end, pod with volume mount could not be scheduled from one node to another since the original volume will never be released. This PR fixed this issue. In [nsenter_mount.GetFileType func](https://github.com/kubernetes/kubernetes/blob/master/pkg/util/mount/nsenter_mount.go#L238), return error of following code will be different than [mount_linux.GetFileType func](https://github.com/kubernetes/kubernetes/blob/master/pkg/util/mount/mount.go#L347) ``` outputBytes, err := mounter.ne.Exec("stat", []string{"-L", `--printf "%F"`, pathname}).CombinedOutput() ``` Return error and output would be like following in nsenter_mount.GetFileType func: error: `exit status 1` output: `/usr/bin/stat: cannot stat '2': No such file or directory` This PR makes the return error consistent as mount_linux.GetFileType func, and finally makes [isDeviceOpened func](https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/util/operationexecutor/operation_generator.go#L1340) work. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #62282 **Special notes for your reviewer**: /assign @dixudx **Release note**: ``` fix nsenter GetFileType issue in containerized kubelet ``` /sig node
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add msau42 to approvers for volume scheduling **What this PR does / why we need it**: Add me as an approver for the volume scheduling code **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. The err has checked in TearDownAt func/kind bug **What this PR does / why we need it**: The err has checked in TearDownAt func/kind bug **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 61608, 62304). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove isNotDir error check **What this PR does / why we need it**: This check was supposed to handle the "subpath file" scenario, but: 1. It's wrong (should have been !) 2. It's not needed anymore. `IsLikelyNotMountPoint` was fixed to handle file mounts via https://github.com/kubernetes/kubernetes/pull/58433 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. PSP: move internal types to policy API group **What this PR does / why we need it**: This is a part of the PSP migration from extensions to policy API group. This PR moves internal types to the its final destination. **Which issue(s) this PR fixes**: Addressed to https://github.com/kubernetes/features/issues/5
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62146, 62450). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Ensure expected load balancer is selected for Azure **What this PR does / why we need it**: Azure cloud provider is always selecting the last element of LB list. The reason is: getServiceLoadBalancer() refers the pointer of an local variable within for loop: https://github.com/kubernetes/kubernetes/blob/e7ed9b408adaaec1e5ddfc167fc18b6aaeca425f/pkg/cloudprovider/providers/azure/azure_loadbalancer.go#L202-L206 This is a common mistake as golang is actually reusing same variable within the loop. This PR fixes this issue. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #62449 **Special notes for your reviewer**: **Release note**: ```release-note Ensure expected load balancer is selected for Azure ``` /sig azure /kind bug
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix daemon-set-controller bootstrap RBAC policy **What this PR does / why we need it**: Adds a `get` permission for the `controllerrevisions` resource to the `daemon-set-controller` cluster role. **Which issue(s) this PR fixes** : Fixes #62145 **Special notes for your reviewer**: The daemon-sets controller [constructs the history](https://github.com/kubernetes/kubernetes/blob/release-1.9/pkg/controller/daemon/daemon_controller.go#L1116) of the daemon-set, so it needs to [check the controller revisions](https://github.com/kubernetes/kubernetes/blob/release-1.9/pkg/controller/daemon/update.go#L265) for the daemon-set app. See issue above. **Release note**: ```release-note Resolves forbidden error when the `daemon-set-controller` cluster role access `controllerrevisions` resources. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Move all create subcommands to its own subdirectory **What this PR does / why we need it**: Similarly to `kubectl set` subcommands move al `create` subcommands to its own subdirectory given that there are that many of them. /assign @juanvallejo **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62503, 62502). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix ingress util for setting TLS spec **What this PR does / why we need it**: Fixes an issue with ingress TLS testing. For most tests, we want to only provide one certificate and verify it's being served. In some tests (including a conformance test), a new certificate was added; but only the first certificate was asserted. This is because the multi-TLS test uses `WaitForIngressWithCert()` while the other tests use `WaitForGivenIngressWithTimeout`. **Special notes for your reviewer**: /assign rramkumar1 /cc rramkumar1 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62503, 62502). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Node E2E: Remove the simple mount test There are EmptyDir volume tests in test/e2e/common already. The test does not add any more coverage. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Use OWNERS filters to give approval to ixdy for Bazel build changes **What this PR does / why we need it**: Bazel updates tend to affect a bunch of `BUILD` files throughout the tree. Rather than getting @thockin to rubber-stamp these all the time, give me the power to approve? I already have appoval over `build/` and `hack/`, which is related to these files. Happy to add other owners here too, though I don't know who else wants to own. Previously: https://github.com/kubernetes/kubernetes/pull/45245, https://github.com/kubernetes/kubernetes/pull/45855 **Release note**: ```release-note NONE ``` /assign @cjwagner @thockin /cc @fejta @mikedanese @BenTheElder
-
Nick Sardo authored
-
Yu-Ju Hong authored
There are EmptyDir volume tests in test/e2e/common already. The test does not add any more coverage.
-
- 12 Apr, 2018 26 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62466, 62494). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix failed e2e tests for dns configmap **What this PR does / why we need it**: Fix DNS configMap e2e tests. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #62490 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix parsing timestamp in test Go 1.9 changed the default string format, see https://github.com/golang/go/issues/20876 As discussed there, default format is intended to be readable for humans and can change without warning, so we should probably set the format explicitly when writing status configmap. ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 58178, 62491, 60852). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. [kubeadm] Add support for clusterName in config file. **What this PR does / why we need it**: Adds a `--cluster-name` arg to kubeadm init. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: See https://github.com/kubernetes/kube-deploy/issues/636 Code inspired by #52470 **Special notes for your reviewer**: **Release note**: ```release-note Adds --cluster-name to kubeadm init for specifying the cluster name in kubeconfig. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 58178, 62491, 60852). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. use standard interface functions for printers Updates the printObj funcs to be the standard resource printer interface we have. @kubernetes/sig-cli-misc
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. enable token authentication for kubelets in GCE ```release-note NONE ```
-
yankaiz authored
-
Maciej Szulik authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62324, 61459, 62475, 62476, 61914). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Return error in mount_unsupported for unsupported platforms **What this PR does / why we need it**: Presently, `util/mount_unsupported.go` does not return any errors. For unsupported platforms, this hides failures. This PR returns errors, thereby properly informing users attempting to run on an unsupported platform. **Which issue(s) this PR fixes** : Fixes https://github.com/kubernetes/kubernetes/issues/61919 **Special notes for your reviewer**: There are a few methods that simply call through to other methods. I did not return errors from those methods. I've also updated an error check and message in `volume/fc/fc_test.go`, since it was ignoring an error on unsupported platforms. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62324, 61459, 62475, 62476, 61914). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove unnecessary code in ingress upgrade logic Now that 1.1 is released, fix the TODO. /assign @nicksardo **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62324, 61459, 62475, 62476, 61914). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bump image in ingress downgrade test **Release note**: ```release-note None ``` /assign @nicksardo
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62324, 61459, 62475, 62476, 61914). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. etcdv3 client: add dial timeout dial timeout is necessary for a reliable system, this pr add it for establishing an etcd connection. **Release note**: ```release-note NONE ```
-
David Eads authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. unused function clean **What this PR does / why we need it**: clean unused function in file pkg/controller/volume/persistentvolume/scheduler_binder_test.go **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Jeff Grafton authored
-
Michelle Au authored
-
juanvallejo authored
-
Anago GCB authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update default etcd server to 3.2 for kubernetes 1.11 Repply #59836 but with latest etcd 3.2 patch version (3.2.18 which includes mvcc fix and leader election timeout fix) and default `--snapshot-count` to 10k to resolve performance regression in previous etcd 3.2 server upgrade attempt (https://github.com/kubernetes/kubernetes/issues/60589#issuecomment-372458578). See https://github.com/kubernetes/kubernetes/issues/60589#issuecomment-372458578 for details on the root cause of the performance regression and scalability test results of setting `--snapshot-count` to 10k. ```release-note Upgrade the default etcd server version to 3.2.18 ``` @gyuho @shyamjvs @jdumars @timothysc
-
Karan Goel authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62430, 62470). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. make mikedanese owner of CertRotation features I've taken these features over from @jcbsmpsn ```release-note NONE ``` @kubernetes/sig-auth-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62430, 62470). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Increase CPU limit to 1000 millicores to support 100kb/s throughput. **What this PR does / why we need it**: The e2e tests for fluentd in gke are failing due to conservative CPU limits for the logging agent. After doing some research we have determined that 1 core is necessary to achieve 100kb/s throughput. **Release note:** ```release-note [fluentd-gcp addon] Increase CPU limit for fluentd to 1 core to achieve 100kb/s throughput. ```
-
Mike Danese authored
-
Rohit Ramkumar authored
-
Rohit Ramkumar authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62455, 62465, 62427, 62416, 62411). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Set slave mount propagation for local provisioner **What this PR does / why we need it**: Explicitly set slave mount propagation instead of assuming it's the default mode. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62455, 62465, 62427, 62416, 62411). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kuberuntime: logs: reduce logging level on waitLogs msg Lots of occurrences of this msg coming from `waitLogs()`: ``` E0411 13:17:04.589338 7645 logs.go:383] Container "4fbf541ed1900c4670216a6a1ecf752cd07ac430f5547c5497fbc4b78e564b78" is not running (state="CONTAINER_EXITED") E0411 14:02:18.168502 7645 logs.go:383] Container "dba4c535666d05310889965418592727047320743a233e226e2266b399836150" is not running (state="CONTAINER_EXITED") E0411 14:02:41.342645 7645 logs.go:383] Container "a946289b36fe3c375c29dce020005424f3b980237892253d42b8bd8bfb595756" is not running (state="CONTAINER_EXITED") E0411 14:02:49.907317 7645 logs.go:383] Container "e1d6014330e7422c03ae6db501d4fb296a4501355517cb60e2f910f54741361d" is not running (state="CONTAINER_EXITED") ``` Added in https://github.com/kubernetes/kubernetes/pull/55140 This message prints whenever something is watching the log when the container dies. The comment right after the error msg say "this is normal" and thus should not be logged at Error level. @derekwaynecarr @feiskyer @Random-Liu
-