1. 14 Dec, 2016 6 commits
  2. 13 Dec, 2016 34 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #36518 from apelisse/owners-pkg-runtime · 64165483
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Curating Owners: pkg/runtime
      
      cc @lavalamp @smarterclayton @deads2k @caesarxuchao
      
      In an effort to expand the existing pool of reviewers and establish a
      two-tiered review process (first someone lgtms and then someone
      experienced in the project approves), we are adding new reviewers to
      existing owners files.
      
      
      If You Care About the Process:
      ------------------------------
      
      We did this by algorithmically figuring out who’s contributed code to
      the project and in what directories.  Unfortunately, that doesn’t work
      well: people that have made mechanical code changes (e.g change the
      copyright header across all directories) end up as reviewers in lots of
      places.
      
      Instead of using pure commit data, we generated an excessively large
      list of reviewers and pruned based on all time commit data, recent
      commit data and review data (number of PRs commented on).
      
      At this point we have a decent list of reviewers, but it needs one last
      pass for fine tuning.
      
      Also, see https://github.com/kubernetes/contrib/issues/1389.
      
      TLDR:
      -----
      
      As an owner of a sig/directory and a leader of the project, here’s what
      we need from you:
      
      1. Use PR https://github.com/kubernetes/kubernetes/pull/35715 as an example.
      
      2. The pull-request is made editable, please edit the `OWNERS` file to
      remove the names of people that shouldn't be reviewing code in the
      future in the **reviewers** section. You probably do NOT need to modify
      the **approvers** section. Names asre sorted by relevance, using some
      secret statistics.
      
      3. Notify me if you want some OWNERS file to be removed.  Being an
      approver or reviewer of a parent directory makes you a reviewer/approver
      of the subdirectories too, so not all OWNERS files may be necessary.
      
      4. Please use ALIAS if you want to use the same list of people over and
      over again (don't hesitate to ask me for help, or use the pull-request
      above as an example)
      64165483
    • Kubernetes Submit Queue's avatar
      Merge pull request #38668 from bprashanth/glbc_version · a9c5f675
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Bump glbc version, cleanup test
      
      Matches https://github.com/kubernetes/ingress/pull/55
      a9c5f675
    • Kubernetes Submit Queue's avatar
      Merge pull request #38700 from sttts/sttts-speed-up-make · 3cc2625c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 35436, 37090, 38700)
      
      Significantly speed-up make
      
      - do not call `dirname` for every go file => gives **>8 seconds** on each make run
      - do not preserve time during rsync from `_output/local/go/bin` to `_output/local/bin/<os>/<arch>`:
        
        We do a touch after our rebuild heuristic triggers.
        
        If in `_output/local/go/bin` you have an older binary and go decides that it's good enough, the following rsync will "preserve the timestamp" of the binary copy in `_output/local/bin/<os>/<arch>`. This reverts the effect of any previous `touch` (compare `Makefile.generated_files`).
      
        We do a complete rsync of binaries for each go target, not only the one which is rebuilt. This means that later go targets will overwrite the timestamps of freshly touched binaries. Hence, our rebuild heuristic will trigger again and again when running `make`.
      
        This PR remove the "preserve mtime" from the rsync call. Hence, the effect of touch is not reverted anymore by later rsyncs.
      3cc2625c
    • Kubernetes Submit Queue's avatar
      Merge pull request #37090 from humblec/iscsi-nodiskconf · f8c5d2c4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 35436, 37090, 38700)
      
      Make iscsi pv/pvc aware of nodiskconflict feature
      
      Being iscsi a `RWO, ROX` volume we should conflict if more than one pod is using same iscsi LUN.  
      Signed-off-by: 's avatarHumble Chirammal <hchiramm@redhat.com>
      f8c5d2c4
    • Kubernetes Submit Queue's avatar
      Merge pull request #35436 from danwinship/utilversion · 4505224c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add a package for handling version numbers (including non-"Semantic" versions)
      
      As noted in #32401, we are using Semantic Version-parsing libraries to parse version numbers that aren't necessarily "Semantic". Although, contrary to what I'd said there, it turns out that this wasn't actually currently a problem for the iptables code, because the regexp used to extract the version number out of the "iptables --version" output only pulled out three components, so given "iptables v1.4.19.1", it would have extracted just "1.4.19". Still, it could be a problem if they later release "1.5" rather than "1.5.0", or if we eventually need to _compare_ against a 4-digit version number.
      
      Also, as noted in #23854, we were also using two different semver libraries in different parts of the code (plus a wrapper around one of them in pkg/version).
      
      This PR adds pkg/util/version, with code to parse and compare both semver and non-semver version strings, and then updates kubernetes to use it everywhere (including getting rid of a bunch of code duplication in kubelet by making utilversion.Version implement the kubecontainer.Version interface directly).
      
      Ironically, this does not actually allow us to get rid of either of the vendored semver libraries, because we still have other dependencies that depend on each of them. (cadvisor uses blang/semver and etcd uses coreos/go-semver)
      
      fixes #32401, #23854
      4505224c
    • Kubernetes Submit Queue's avatar
      Merge pull request #37968 from sjenning/qos-pod-status-field · 702f545a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 38171, 37968)
      
      add QoS pod status field
      
      Right now, applications retrieving pod information must reimplement the QoS classification logic on the client side if they wish to know the QoS class of the pod.
      
      The PR adds the QoS class to the pod status so it can be used directly by clients.
      
      This is a step toward addressing #33255
      
      @ConnorDoyle @derekwaynecarr @vishh
      702f545a
    • Kubernetes Submit Queue's avatar
      Merge pull request #38171 from xingzhou/kube-typo · 0175399d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fixed a typo of wildcard DNS regex variable name.
      
      Happened to see the typo while reading code, fixed the typo and refined the code.
      0175399d
    • Kubernetes Submit Queue's avatar
      Merge pull request #38538 from juanvallejo/jvallejo/dont-report-success-if-obj-not-patched · 085f0d74
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Prevent "patched" output on obj not patched
      
      **Release note**:
      ```release-note
      release-note-none
      ```
      
      This patch compares an original object against a patched object returned
      from the server and only announces that the object was successfully
      patched if the object returned from the server does not equal the
      original object.
      
      @fabianofranz @kubernetes/cli-review
      085f0d74
    • Kubernetes Submit Queue's avatar
      Merge pull request #38640 from mtaufen/gci-version-env · 18d05c7d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Allow GCI_VERSION to come from env
      
      This is to facilitate GCI tip vs. K8s tip testing; we need to
      dynamically set the version of GCI to stay current with their
      latest canary (latest of the "gci-base" prefixed images).
      18d05c7d
    • Kubernetes Submit Queue's avatar
      Merge pull request #38709 from luxas/fix_auth_kubeadm · a092d8e0
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Set --anonymous-auth to false on v1.5 clusters to preserve the locked-down v1.4 behaviour
      
      From discussions with sig-auth-people.
      
      Without this patch, anyone can do basically anything, because the apiserver in v1.5 mode is unprotected due to that kubeadm doesn't have any ABAC/RBAC-authorizers.
      
      @mikedanese @justinsb @deads2k @kubernetes/sig-cluster-lifecycle
      a092d8e0
    • Lucas Käldström's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #38661 from calebamiles/wip-remove-karlkfi · 765700da
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      cluster/mesos lives in the incubator now
      
      **What this PR does / why we need it**:
      
      Removes `cluster/mesos` which has been subsumed by https://github.com/kubernetes-incubator/kube-mesos-framework. As `@karlkfi` is the only maintainer listed in an `OWNERS` file and taking into account https://github.com/kubernetes/kubernetes/issues/38392, this code is dead and should be removed.
      
      **Release note**:
      
       `NONE`
      765700da
    • Kubernetes Submit Queue's avatar
      Merge pull request #38507 from gmarek/res-gat-kubemark · d13067ed
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 38695, 38507)
      
      Fix resource gatherer for kubemark
      
      Not working yet...
      d13067ed
    • Kubernetes Submit Queue's avatar
      Merge pull request #38695 from jszczepkowski/ha-validation-fix · bb41d770
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fixed validation of multizone cluster for GCE.
      
      ```release-note
      Fixed validation of multizone cluster for GCE
      ```
      
      Fixed validation of multizone cluster for GCE: taking actual number of worker nodes.
      bb41d770
    • Dr. Stefan Schimanski's avatar
    • gmarek's avatar
      Fix resource gatherer for kubemark · 1b1a4aef
      gmarek authored
      1b1a4aef
    • Kubernetes Submit Queue's avatar
      Merge pull request #38461 from gmarek/job · 380ad617
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add an option to run Job in Density/Load config
      
      cc @timothysc @jeremyeder 
      
      @erictune @soltysh - I run this test and it seems to me that Job has noticeably worse performance than Deployment. I'll create an issue for this, but this PR is for easy repro.
      380ad617
    • Dan Winship's avatar
      Port remaining code to pkg/util/version · c7887938
      Dan Winship authored
      c7887938
    • Dan Winship's avatar
      Drop version-parsing from pkg/version · f369372d
      Dan Winship authored
      pkg/version is now just version constants, etc, not version parsing
      f369372d
    • Dan Winship's avatar
      d95181fa
    • Dan Winship's avatar
    • Jerzy Szczepkowski's avatar
      Fixed validation of multizone cluster for GCE. · 0f60aba7
      Jerzy Szczepkowski authored
      Fixed validation of multizone cluster for GCE: taking actual number of worker nodes.
      0f60aba7
    • Kubernetes Submit Queue's avatar
      Merge pull request #38613 from kargakis/do-not-adopt-when-deleted · 15f9572b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      controller: adopt pods only when controller is not deleted
      
      When a replica set is deleted it will continue adopting pods thus driving the worker that handles it in erroring out because the adoption is [always cancelled](https://github.com/kubernetes/kubernetes/blob/59c313730c4fbe543bb9268631b2ac4cb6c91400/pkg/controller/controller_ref_manager.go#L110) in the controller reference manager.
      ```
      E1212 14:40:31.245773    7964 replica_set.go:616] cancel the adopt attempt for pod e2e-tests-deployment-2rr3m_test-rollover-deployment-1981456318-73c3m_791e16cb-c070-11e6-a234-68f72840e7df because the controlller is being deleted
      E1212 14:40:31.258462    7964 replica_set.go:616] cancel the adopt attempt for pod e2e-tests-deployment-2rr3m_test-rollover-deployment-1981456318-73c3m_791e16cb-c070-11e6-a234-68f72840e7df because the controlller is being deleted
      E1212 14:40:31.259131    7964 replica_set.go:616] cancel the adopt attempt for pod e2e-tests-deployment-2rr3m_test-rollover-deployment-1981456318-73c3m_791e16cb-c070-11e6-a234-68f72840e7df because the controlller is being deleted
      E1212 14:40:31.259149    7964 replica_set.go:616] cancel the adopt attempt for pod e2e-tests-deployment-2rr3m_test-rollover-deployment-1981456318-wrmt8_791e3d46-c070-11e6-a234-68f72840e7df because the controlller is being deleted
      I1212 14:40:31.268012    7964 deployment_controller.go:314] Error syncing deployment e2e-tests-deployment-2rr3m/test-rollover-deployment: Operation cannot be fulfilled on deployments.extensions "test-rollover-deployment": the object has been modified; please apply your changes to the latest version and try again
      E1212 14:40:31.277252    7964 replica_set.go:616] cancel the adopt attempt for pod e2e-tests-deployment-2rr3m_test-rollover-deployment-1981456318-73c3m_791e16cb-c070-11e6-a234-68f72840e7df because the controlller is being deleted
      E1212 14:40:31.277276    7964 replica_set.go:616] cancel the adopt attempt for pod e2e-tests-deployment-2rr3m_test-rollover-deployment-1981456318-wrmt8_791e3d46-c070-11e6-a234-68f72840e7df because the controlller is being deleted
      E1212 14:40:31.277287    7964 replica_set.go:616] cancel the adopt attempt for pod e2e-tests-deployment-2rr3m_test-rollover-deployment-1981456318-bmqpn_81482114-c070-11e6-a234-68f72840e7df because the controlller is being deleted
      E1212 14:40:31.289148    7964 replica_set.go:616] cancel the adopt attempt for pod e2e-tests-deployment-2rr3m_test-rollover-deployment-1981456318-b6s4x_82fa8343-c070-11e6-a234-68f72840e7df because the controlller is being deleted
      E1212 14:40:31.289169    7964 replica_set.go:616] cancel the adopt attempt for pod e2e-tests-deployment-2rr3m_test-rollover-deployment-1981456318-73c3m_791e16cb-c070-11e6-a234-68f72840e7df because the controlller is being deleted
      E1212 14:40:31.289176    7964 replica_set.go:616] cancel the adopt attempt for pod e2e-tests-deployment-2rr3m_test-rollover-deployment-1981456318-wrmt8_791e3d46-c070-11e6-a234-68f72840e7df because the controlller is being deleted
      E1212 14:40:31.289181    7964 replica_set.go:616] cancel the adopt attempt for pod e2e-tests-deployment-2rr3m_test-rollover-deployment-1981456318-bmqpn_81482114-c070-11e6-a234-68f72840e7df because the controlller is being deleted
      ```
      
      @kubernetes/deployment @caesarxuchao
      15f9572b
    • Dr. Stefan Schimanski's avatar
      399da6d1
    • gmarek's avatar
      Add an option to run Job in Density/Load config · c9e78f1c
      gmarek authored
      c9e78f1c
    • Kubernetes Submit Queue's avatar
      Merge pull request #38620 from wojtek-t/increase_wait_for_nodes_timeout · b14f57ca
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 38617, 38620)
      
      Increase timeout for waiting for nodes
      b14f57ca
    • Kubernetes Submit Queue's avatar
      Merge pull request #38617 from jszczepkowski/multizone-fix · 527d502b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fixed detection of master during creation of multizone nodes cluster.
      
      ```release-note
      Fixed detection of master during creation of multizone nodes cluster by kube-up.
      ```
      
      Fixed detection of master during creation of multizone nodes cluster by kube-up.
      527d502b
    • Kubernetes Submit Queue's avatar
      Merge pull request #38227 from shyamjvs/kubemark-master-migrate · 0a0294ca
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 38609, 38227)
      
      On kubemark master, kubelet now runs as a supervisord process and all master components as pods
      
      This PR fixes issue #37485
      On kubemark, previously we had a custom setup that runs master components as top-level processes under supervisord, which is lighter than running kubelet and docker.
      This PR makes kubelet run as a process under supervisord and the master components (apiserver, controller-manager, scheduler, etcd) as pods, making testing on kubemark mimic real clusters better.
      Also, start-kubemark-master.sh now closely resembles cluster/gce/gci/configure-helper.sh, allowing easy integration in future.
      
      cc @kubernetes/sig-scalability @wojtek-t @gmarek
      0a0294ca
    • Kubernetes Submit Queue's avatar
      Merge pull request #38609 from wojtek-t/cleanup_annoying_test_logs · 99f876bb
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Reduce amount of annoing logs in large clusters
      99f876bb
    • Saad Ali's avatar
      Merge pull request #38675 from erictune/relnotefix · ad1c60da
      Saad Ali authored
      Update CHANGELOG.md to warn about anon auth flag
      ad1c60da
    • Wojciech Tyczynski's avatar
      6051870a
    • Kubernetes Submit Queue's avatar
      Merge pull request #38672 from zmerlynn/restrict-kops-admin-access · 30c64be3
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      hack/e2e.go / kops: Add --kops-admin-access to restrict API access
      
      **What this PR does / why we need it**: Allow `--admin-access` to be set in `kops`
      **Release note**:
      ```release-note
      NONE
      ```
      30c64be3
    • Kubernetes Submit Queue's avatar
      Merge pull request #38669 from caesarxuchao/fix-cacher · f02c8e47
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix leaking goroutines in watch cache
      
      Fixes #38670 which causes leaked goroutines in the API server. The root cause is: if the WatchServer timeout [fires](https://github.com/kubernetes/kubernetes/blob/master/pkg/apiserver/watch.go#L187-L188) when the `result` channel is full, `sendWatchCacheEvent` will be blocked on the write to the `result` even though `cacheWatch.Stop()` is [called](https://github.com/kubernetes/kubernetes/blob/master/pkg/apiserver/watch.go#L171), because WatchServer stops consuming the `result` channel after the timeout.
      Thanks to @krousey for identifying the problem. cc @mml @yujuhong
      f02c8e47
    • Eric Tune's avatar
      60c5b09c