1. 25 Aug, 2017 1 commit
  2. 20 May, 2017 11 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #45975 from php-coder/psp_and_projected_volume · 9f5849a0
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45346, 45903, 45958, 46042, 45975)
      
      examples/podsecuritypolicy/rbac: allow to use projected volumes in restricted PSP
      
      **What this PR does / why we need it**:
      This PR modifies `restricted` PSP to allow `projected` volume type. No need to modify `privileged` PSP because it already allows all volume types.
      
      It should not add any harm because `projected` uses configmaps, downward API, and secrets that are already permitted.
      
      **Special notes for your reviewer**:
      This was inspired by similar change in the OpenShift: https://github.com/openshift/origin/pull/14147
      
      **Release note**:
      ```release-note
      NONE
      ```
      
      PTAL @pweil- @derekwaynecarr 
      CC @mfojtik
      9f5849a0
    • Kubernetes Submit Queue's avatar
      Merge pull request #46042 from derekwaynecarr/quota-admission-registry · 4f55f490
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45346, 45903, 45958, 46042, 45975)
      
      ResourceQuota admission control injects registry
      
      **What this PR does / why we need it**:
      The `ResourceQuota` admission controller works with a registry that maps a GroupKind to an Evaluator.  The registry used in the existing plug-in is not injectable, which makes usage of the ResourceQuota plug-in in other API server contexts difficult.  This PR updates the code to support late injection of the registry via a plug-in initializer.
      4f55f490
    • Kubernetes Submit Queue's avatar
      Merge pull request #45958 from k82cn/k8s_45925 · 46a38b0e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45346, 45903, 45958, 46042, 45975)
      
      Ignored mirror pods in PodPreset admission plugin
      
      **What this PR does / why we need it**:
      Ignored mirror pods in PodPreset admission plugin.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #45925 
      
      **Release note**:
      
      ```release-note
      Ignored mirror pods in PodPreset admission plugin.
      ```
      46a38b0e
    • Kubernetes Submit Queue's avatar
      Merge pull request #45903 from brendandburns/azure-disk-api · 113cf856
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45346, 45903, 45958, 46042, 45975)
      
      Azure disk api
      
      This is to update the AzureDiskApi and split it from the implementation which is caught in rebase hell...
      
      Once this is merged, we'll get the implementation in.
      
      @smarterclayton suggested this as a way to break the rebase hell logjam. request for a quick review.
      
      Thanks!
      113cf856
    • Kubernetes Submit Queue's avatar
      Merge pull request #45346 from codablock/fix_double_attach · f499606b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Don't try to attach volumes which are already attached to other nodes
      
      This PR is a replacement for https://github.com/kubernetes/kubernetes/pull/40148. I was not able to push fixes and rebases to the original branch as I don't have access to the Github organization anymore.
      
      CC @saad-ali You probably have to update the PR link in [Q2 2017 (v1.7)](https://docs.google.com/spreadsheets/d/1t4z5DYKjX2ZDlkTpCnp18icRAQqOE85C1T1r2gqJVck/edit#gid=14624465)
      
      I assume the PR will need a new "ok to test" 
      
      **ORIGINAL PR DESCRIPTION**
      
      This PR fixes an issue with the attach/detach volume controller. There are cases where the `desiredStateOfWorld` contains the same volume for multiple nodes, resulting in the attach/detach controller attaching this volume to multiple nodes. This of course fails for volumes like AWS EBS, Azure Disks, ...
      
      I observed this situation on Azure when using Azure Disks and replication controllers which start to reschedule PODs. When you delete a POD that belongs to a RC, the RC will immediately schedule a new POD on another node. This results in a short time (max a few seconds) where you have 2 PODs which try to attach/mount the same volume on different nodes. As the old POD is still alive, the attach/detach controller does not try to detach the volume and starts to attach the volume to the new POD immediately.
      
      This behavior was probably not noticed before on other clouds as the bogus attempt to attach probably fails pretty fast and thus is unnoticed. As the situation with the 2 PODs disappears after a few seconds, a detach for the old POD is initiated and thus the new POD can attach successfully.
      
      On Azure however, attaching and detaching takes quite long, resulting in the first bogus attach attempt to already eat up much time.
      When attaching fails on Azure and reports that it is already attached somewhere else, the cloud provider immediately does a detach call for the same volume+node it tried to attach to. This is done to make sure the failed attach request is aborted immediately. You can find this here: https://github.com/kubernetes/kubernetes/blob/master/pkg/cloudprovider/providers/azure/azure_storage.go#L74
      
      The complete flow of attach->fail->abort eats up valuable time and the attach/detach controller can not proceed with other work while this is happening. This means, if the old POD disappears in the meantime, the controller can't even start the detach for the volume which delays the whole process of rescheduling and reattaching.
      
      Also, I and other people have observed very strange behavior where disks ended up being "attached" to multiple VMs at the same time as reported by Azure Portal. This results in the controller to fail reattaching forever. It's hard to figure out why and when this happens and there is no reproducer known yet. I can imagine however that the described behavior correlates with what I described above.
      
      I was not sure if there are actually cases where it is perfectly fine to have a volume mounted to multiple PODs/nodes. At least technically, this should be possible with network based volumes, e.g. nfs. Can someone with more knowledge about volumes help me here? I may need to add a check before skipping attaching in `reconcile`.
      
      CC @colemickens @rootfs
      
      -->
      ```release-note
      Don't try to attach volume to new node if it is already attached to another node and the volume does not support multi-attach.
      ```
      f499606b
    • Kubernetes Submit Queue's avatar
      Merge pull request #45979 from bowei/owners · 2473c24f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add bowei to OWNERS: e2e/test dns,network; cloud route, node, service…
      2473c24f
    • Kubernetes Submit Queue's avatar
      Merge pull request #38169 from caseydavenport/calico-daemonset · a9d04038
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Update Calico add-on
      
      **What this PR does / why we need it:**
      
      Updates Calico to the latest version using self-hosted install as a DaemonSet, removes Calico's dependency on etcd.
      
      - [x] Remove [last bits of Calico salt](https://github.com/caseydavenport/kubernetes/blob/175fe62720a47ed062a8e29452f80f08fe86de40/cluster/saltbase/salt/calico/master.sls#L3)
      - [x] Failing on the master since no kube-proxy to access API.
      - [x] Fix outgoing NAT
      - [x] Tweak to work on both debian / GCI (not just GCI)
      - [x] Add the portmap plugin for host port support
      
      Maybe:
      - [ ] Add integration test
      
      **Which issue this PR fixes:**
      
      https://github.com/kubernetes/kubernetes/issues/32625
      
      **Try it out**
      
      Clone the PR, then:
      
      ```
      make quick-release
      export NETWORK_POLICY_PROVIDER=calico
      export NODE_OS_DISTRIBUTION=gci
      export MASTER_SIZE=n1-standard-4
      ./cluster/kube-up.sh 
      ```
      
      **Release note:**
      
      ```release-note
      The Calico version included in kube-up for GCE has been updated to v2.2.
      ```
      a9d04038
    • Kubernetes Submit Queue's avatar
      Merge pull request #45564 from whitlockjc/admission-api-group · 83a1a863
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45996, 46121, 45707, 46011, 45564)
      
      add "admission" API group
      
      This commit is an initial pass at providing an admission API group.
      The API group is required by the webhook admission controller being
      developed as part of https://github.com/kubernetes/community/pull/132
      and could be used more as that proposal comes to fruition.
      
      **Note:** This PR was created by following the [Adding an API Group](https://github.com/kubernetes/community/blob/master/contributors/devel/adding-an-APIGroup.md) documentation.
      
      cc @smarterclayton
      83a1a863
    • Kubernetes Submit Queue's avatar
      Merge pull request #46011 from MrHohn/e2e-fix-return-podnames · 73e7ef1f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45996, 46121, 45707, 46011, 45564)
      
      Fix waitForNPods in restart.go
      
      From https://github.com/kubernetes/kubernetes/issues/45991#issuecomment-302292404.
      
      Don't redefine `pods` so we can return real pod names instead of empty array.
      
      /assign @dchen1107 @bowei 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      73e7ef1f
    • Kubernetes Submit Queue's avatar
      Merge pull request #45707 from Crazykev/cri-experimental · e2a93279
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45996, 46121, 45707, 46011, 45564)
      
      Remove flag `experimental-cri` in e2e-node test
      Signed-off-by: 's avatarCrazykev <crazykev@zju.edu.cn>
      
      
      
      **What this PR does / why we need it**: 
      This patch remove deprecated flag in node e2e test script, cause kubelet already remove this. Leave this will make kubelet start failed.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**: /cc @feiskyer 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      e2a93279
    • Kubernetes Submit Queue's avatar
      Merge pull request #46121 from Random-Liu/fix-kuberuntime-getpods · 1c8d2558
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45996, 46121, 45707, 46011, 45564)
      
      Fix kuberuntime GetPods.
      
      The `ImageID` is not populated from `GetPods` in kuberuntime.
      
      Image garbage collector is using this field, https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/images/image_gc_manager.go#L204.
      
      Without this fix, image garbage collector will try to garbage collect all images every time. Because docker will not allow that, it should be fine. However, I'm not sure whether the unnecessary remove will cause any problem, e.g. overload docker image management system and make docker hang.
      
      @dchen1107 @yujuhong @feiskyer Do you think we should cherry-pick this?
      1c8d2558
  3. 19 May, 2017 28 commits