1. 21 Mar, 2018 16 commits
  2. 20 Mar, 2018 24 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #60927 from islinwb/ipset_ut · f3539784
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      fix TODO: test more SetType
      
      **What this PR does / why we need it**:
      fix TODO in pkg/util/ipset/ipset_test.go: test more SetType
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      f3539784
    • Kubernetes Submit Queue's avatar
      Merge pull request #58717 from resouer/extender-interface · 14e3efe2
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 60759, 60531, 60923, 60851, 58717). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Implement preemption for extender with a verb and new interface
      
      **What this PR does / why we need it**:
      
      This is an alternative way of implementing #51656
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #51656
      
      **Special notes for your reviewer**:
      
      We will also want to compare with #56296 to see which one is the best solution. See: https://github.com/kubernetes/kubernetes/pull/56296#discussion_r163381235
      
      cc @ravigadde @bsalamat 
      
      **Release note**:
      
      ```release-note
      Implement preemption for extender with a verb and new interface
      ```
      14e3efe2
    • Kubernetes Submit Queue's avatar
      Merge pull request #60851 from aveshagarwal/master-rhbz-1548987 · 502c99f2
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 60759, 60531, 60923, 60851, 58717). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Do not create dangling legacy symlink
      
      Do not create dangling legacy symlink if the new symlink to container logs does not exist.
      These dangling legacy symlink are later removed by kube runtime gc, so it's better if we do not
      create them in the first place to avoid unnecessary work from kube runtime gc. This situation occurs when docker uses journald logging driver.  
      
      **What this PR does / why we need it**:
      This PR fixes an issue where dangling symlink are being created.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      None.
      ```
      @derekwaynecarr @sjenning @dashpole @kubernetes/sig-node-pr-reviews
      502c99f2
    • Kubernetes Submit Queue's avatar
      Merge pull request #60923 from ipuustin/shell-bugfix5 · 9b8323f1
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 60759, 60531, 60923, 60851, 58717). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fix build scripts to work in case there are spaces in directory names.
      
      **What this PR does / why we need it**:
      
      Fix kubernetes build scripts to work in case the source directory is in a directory path which contains a space.
      
      You can prepare such a directory like this:
      ```
      $ mkdir '/tmp/test dir/'
      $ cd '/tmp/test dir/'
      $ git clone https://github.com/kubernetes/kubernetes.git
      $ cd kubernetes
      ```
      Then, without the fix:
      ```
      $ KUBE_FASTBUILD=true KUBE_RELEASE_RUN_TESTS=n build/release.sh
      cat: /tmp/test: No such file or directory
      cat: dir/kubernetes/build/build-image/cross/VERSION: No such file or directory
      cat: /tmp/test: No such file or directory
      cat: dír/kubernetes/build/build-image/VERSION: No such file or directory
      +++ [0307 18:10:33] Verifying Prerequisites....
      cp: target '/tmp/test dir/kubernetes/_output/images/kube-build:build-7c7cd10a18--/Dockerfile' is not a directory
      !!! [0307 18:10:33] Call tree:
      !!! [0307 18:10:33]  1: build/release.sh:35
      kube::build::build_image(...)
      !!! Error in build/../build/common.sh:454
        Error in build/../build/common.sh:454. '((i<3-1))' exited with status 1
      Call stack:
        1: build/../build/common.sh:454 kube::build::build_image(...)
        2: build/release.sh:35 main(...)
      Exiting with status 1
      ```
      With the fix the compilation succeeds. The fix is done adding double quotes to required places (and also just in case to other places where shellcheck recommended adding them).
      
      Note that this fix doesn't as such help with the official make-based build: it's tricky to make makefiles work with targets with spaces in their names.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      
      **Special notes for your reviewer**:
      
      This PR needs pretty thorough review since this touches the core build scripts. 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      9b8323f1
    • Kubernetes Submit Queue's avatar
      Merge pull request #60531 from dashpole/memcg_update · a2f1c242
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 60759, 60531, 60923, 60851, 58717). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Subtract inactive_file from usage when setting memcg threshold
      
      **What this PR does / why we need it**:
      Implements solution for #51745, proposed in  https://github.com/kubernetes/community/pull/1451.
      This is a prerequisite to fixing https://github.com/kubernetes/kubernetes/issues/57901.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #51745
      
      **Special notes for your reviewer**:
      
      **Release note**:
      ```release-note
      NONE
      ```
      /sig node
      /priority important-longterm
      /kind bug
      
      /assign @sjenning @derekwaynecarr @dchen1107
      a2f1c242
    • Kubernetes Submit Queue's avatar
      Merge pull request #60759 from hzxuzhonghu/etcd-flag-validate · 691a7d43
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 60759, 60531, 60923, 60851, 58717). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      validate EtcdOptions.EtcdServersOverrides in EtcdOptions.Validate
      
      move `EtcdOptions.EtcdServersOverrides` validation from `BuildStorageFactory` to `EtcdOptions.Validate`, which fails fast in kube-apiserver startup.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      691a7d43
    • Kubernetes Submit Queue's avatar
      Merge pull request #60875 from charrywanganthony/rm_ServiceAcountKeyFile · d9008e08
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      remove --service-account-private-key-file in v1.11
      
      `kube-cloud-controller-manager` flag `--service-account-private-key-file` is removed in v1.11
      
      ref: #50289
      
      
      **Release note**:
      
      ```release-note
      `kube-cloud-controller-manager` flag `--service-account-private-key-file` is removed in v1.11
      ```
      d9008e08
    • Kubernetes Submit Queue's avatar
      Merge pull request #60428 from rosti/kubeadm-readOnly-opt · ab639118
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 60696, 60876, 60901, 60925, 60428). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      kubeadm: Add writable option to *ExtraVolumes init config
      
      **What this PR does / why we need it**:
      This PR adds `writable` boolean option for each volume under the `apiServerExtraVolumes`, `controllerManagerExtraVolumes` and `schedulerExtraVolumes` kubeadm init config keys. The option controls write access on a per-volume basis. It is inverted and transferred to the corresponding static pod YAML file as the `readOnly` option of kubelet.
      
      The default value for `writable` is `false`, which does not change the current kubeadm behavior.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Partial fix for #58587
      
      **Special notes for your reviewer**:
      
      /cc @kubernetes/sig-cluster-lifecycle-pr-reviews
      /area kubeadm
      /assign @luxas
      /assign @timothysc
      
      **Release note**:
      ```release-note
      kubeadm: Add the writable boolean option to kubeadm config. The option works on a per-volume basis for *ExtraVolumes config keys.
      ```
      ab639118
    • Kubernetes Submit Queue's avatar
      Merge pull request #60925 from aleksandra-malinowska/debug-curl-fix · de1a0e32
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 60696, 60876, 60901, 60925, 60428). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Improve debug curl command
      
      When logging debug curl command, add single quotes around URL and headers. This prevents quietly removing any parameters after '&' when running resulting command and improves formatting.
      
      ```release-note
      NONE
      ```
      de1a0e32
    • Kubernetes Submit Queue's avatar
      Merge pull request #60901 from ixdy/client-go-bazel · 7543ddde
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 60696, 60876, 60901, 60925, 60428). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      client-go/util/cert go_library shouldn't depend on testdata
      
      **What this PR does / why we need it**: https://github.com/kubernetes/kubernetes/commit/981dd8dc6615f397a9b85c5b965998dc8a0b1338#diff-eb996d3ca3a215d7d93faaaffb77dbd7 accidentally added a testdata dependency on the go_library rule, rather than the go_test. This breaks vendoring of this rule into other bazel projects that prune out tests and testdata.
      
      Only the unit test depends on testdata, so the BUILD file should reflect that, too.
      
      x-ref https://github.com/kubernetes/test-infra/pull/6835#discussion_r173010769
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      
      cc @BenTheElder @krzyzacy
      7543ddde
    • Kubernetes Submit Queue's avatar
      Merge pull request #60876 from CaoShuFeng/lookup_pull · 5aa40c60
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 60696, 60876, 60901, 60925, 60428). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      remove unused hack/lookup_pull.py
      
      This script is not used anywhere.
      
      
      
      **What this PR does / why we need it**:
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      5aa40c60
    • Kubernetes Submit Queue's avatar
      Merge pull request #60696 from wrfly/patch-1 · f44f7dff
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 60696, 60876, 60901, 60925, 60428). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      fix non-nil ptr in struct convert
      
      **What this PR does / why we need it**:
      Fix an issue.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #35335
      
      **Special notes for your reviewer**:
      Thanks for other contributer's debug.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      f44f7dff
    • Kubernetes Submit Queue's avatar
      Merge pull request #61281 from soltysh/sig-cli-approvers · df0518d0
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Add myself for sig-cli related stuff as approver
      
      This is adding me as an approver for sig-cli related things.
      
      /assign @pwittrock 
      
      **Release note**:
      ```release-note
      None
      ```
      df0518d0
    • Kubernetes Submit Queue's avatar
      Merge pull request #61411 from liggitt/remove-ds-scheduling · a64a11d7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      disable DaemonSet scheduling feature for 1.10
      
      The DaemonSet scheduling feature has blocked the alpha CI job being green and is preventing getting good CI signal for v1.10
      
      It still contains pod scheduling races (#61050) and fundamental issues with the affinity terms it creates (#61410)
      
      As such, there is not significant value in having the feature available in 1.10 in the current state
      
      This PR disables the feature in order to regain green signal on the alpha CI job (reverting commits is likely to be more disruptive at this point)
      
      related to https://github.com/kubernetes/kubernetes/issues/61050
      
      ```release-note
      DaemonSet scheduling associated with the alpha ScheduleDaemonSetPods feature flag has been removed from the 1.10 release. See https://github.com/kubernetes/features/issues/548 for feature status.
      ```
      a64a11d7
    • Kubernetes Submit Queue's avatar
      Merge pull request #60547 from brahmaroutu/conf_kubectl · c5d4a032
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Adding details to Conformance Tests using RFC 2119 standards.
      
      This PR is part of the conformance documentation. This is to provide more formal specification using RFC 2119 keywords to describe the test so that who ever is running conformance tests do not have to go through the code to understand why and what is tested.
      The documentation information added here into each of the tests eventually result into a document which is currently checked in at location https://github.com/cncf/k8s-conformance/blob/master/docs/KubeConformance-1.9.md
      
      I would like to have this PR reviewed for v1.10 as I consider it important to strengthen the conformance documents.
      c5d4a032
    • Kubernetes Submit Queue's avatar
      Merge pull request #60862 from seans3/owners · e61b9b44
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 60710, 60855, 60873, 60895, 60862). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      pwittrock requested removal
      
      **What this PR does / why we need it**:
      
      Phil Wittrock requests removal from OWNERS_ALIAS
      
      Added members of Phil's team to sig-cli-maintainers
      e61b9b44
    • Kubernetes Submit Queue's avatar
      Merge pull request #60895 from BenTheElder/translate-verbose-kubetest · 17839216
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 60710, 60855, 60873, 60895, 60862). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      translate hack/e2e.go -v to --verbose-commands
      
      **What this PR does / why we need it**: translates the old `go run hack/e2e.go` `-v` flag to `--verbose-commands` for kubetest. kubetest now imports client-go, which imports `glog`, which registers an incompatible `-v level` flag so kubetest now uses `--verbose-commands` instead.
      
      This should fix existing workflows.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**: See also: https://github.com/kubernetes/community/pull/1901
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      17839216
    • Kubernetes Submit Queue's avatar
      Merge pull request #60873 from wwwtyro/rye/upgrade-needed-bugfix · 95d1fb7c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 60710, 60855, 60873, 60895, 60862). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Bugfix for erroneous upgrade needed messaging in kubernetes worker charm.
      
      **What this PR does / why we need it**: Bugfix for erroneous upgrade needed messaging in kubernetes worker charm.
      
      **Release note**:
      ```release-note
      Bugfix for erroneous upgrade needed messaging in kubernetes worker charm.
      ```
      95d1fb7c
    • Kubernetes Submit Queue's avatar
      Merge pull request #60855 from cheftako/local-up · e6ba628b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 60710, 60855, 60873, 60895, 60862). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fix local cluster leaking memory.
      
      **What this PR does / why we need it**:
      Local cluster is leaking memory due to mutation detector being enabled.
      In addition there is no warning in the logs that this could be the
      issue.
      Added a log warning when this feature is enabled to make debugging this
      issue easier for other cases of this.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #60854 
      
      **Special notes for your reviewer**:
      
      **Release note**:
      ```release-note
      None
      ```
      e6ba628b
    • Kubernetes Submit Queue's avatar
      Merge pull request #60710 from NickrenREN/admission-pv-dir-change · ca566289
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 60710, 60855, 60873, 60895, 60862). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Move `persistentvolume` into `storage` package under `plugin/pkg/admission` 
      
      Sorry for omitting this in the previous PR #60367
      
      **What this PR does / why we need it**:
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Following #60367
      
      **Special notes for your reviewer**:
      
      **Release note**:
      ```release-note
      NONE
      ```
      
      /assign @jsafrane @thockin
      ca566289
    • Kubernetes Submit Queue's avatar
      Merge pull request #60357 from dixudx/kubectl_a2e_flags_bind · e8388e03
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 60574, 60666, 60831, 60877, 60357). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      flag value bindings for kubectl attach/convert/delete/drain/edit/exec commands
      
      **What this PR does / why we need it**:
      xxxOptions did not get bound as default value for flags.
      This PR cleans those flag bindings for `kubectl  attach/convert/delete/drain/edit/exec` commands.
      
      /kind cleanup
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      xref #60366
      
      **Special notes for your reviewer**:
      /assign @deads2k 
      
      **Release note**:
      
      ```release-note
      None
      ```
      e8388e03
    • Kubernetes Submit Queue's avatar
      Merge pull request #60877 from CaoShuFeng/import_pyton · 69401b08
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 60574, 60666, 60831, 60877, 60357). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      remove some not used imports from python codes
      
      remove some not used imports from python codes
      /assign @sttts 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      69401b08
    • Kubernetes Submit Queue's avatar
      Merge pull request #60831 from resouer/fix-race · 8c00efe6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 60574, 60666, 60831, 60877, 60357). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fix data race in node lifecycle controller
      
      **What this PR does / why we need it**:
      Encountered this bug during fixing: https://github.com/kubernetes/kubernetes/pull/60753
      
      There's a data race for `zoneNoExecuteTainter `.
      
      ```
      --- PASS: TestTaintNodeByCondition (5.72s)
      PASS
      ==================
      WARNING: DATA RACE
      Write at 0x00c421a8d2f0 by goroutine 1472:
        runtime.mapassign_faststr()
            /usr/local/go/src/runtime/hashmap_fast.go:598 +0x0
        k8s.io/kubernetes/pkg/controller/nodelifecycle.(*Controller).addPodEvictorForNewZone()
            /root/code/kubernetes/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/controller/nodelifecycle/node_lifecycle_controller.go:1053 +0x37d
        k8s.io/kubernetes/pkg/controller/nodelifecycle.(*Controller).monitorNodeStatus()
            
      
      Previous read at 0x00c421a8d2f0 by goroutine 1471:
        runtime.mapiterinit()
            /usr/local/go/src/runtime/hashmap.go:709 +0x0
        k8s.io/kubernetes/pkg/controller/nodelifecycle.(*Controller).doNoExecuteTaintingPass()
            /root/code/kubernetes/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/controller/nodelifecycle/node_lifecycle_controller.go:459 +0xec
        k8s.io/kubernetes/pkg/controller/nodelifecycle.(*Controller).(k8s.io/kubernetes/pkg/controller/nodelifecycle.doNoExecuteTaintingPass)-fm()
      ```
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      Fix data race in node lifecycle controller
      ```
      8c00efe6
    • Kubernetes Submit Queue's avatar
      Merge pull request #60666 from immutableT/kms_mock_flake_issue · 7ab554ce
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 60574, 60666, 60831, 60877, 60357). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Remove potential sources of flakes for kms_transformation_test.go.
      
      **What this PR does / why we need it**:
      Remove potential sources for flakes in TestKMSPlugin test.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      #60614
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      7ab554ce