- 03 Aug, 2018 30 commits
-
-
Manjunath A Kumatagi authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix some test images - update version and arch - gb-frontend and gb-redisslave are now *REALLY* multi-arch manifest lists. - Fix bad merge from #66066 for AdmissionWebhook Change-Id: I0995394d638ab00b0d1d30ad7099351b806dfd9d **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66933, 66925). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Rework multi-volume test to use StatefulSet **What this PR does / why we need it**: The e2e test that got added as part of https://github.com/kubernetes/kubernetes/pull/66832 fails in a multi-zone environment because the volumes get provisioned in random zones. This PR reworks the test to use StatefulSet instead, which handles provisioning multiple PVCs in the same zone. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. switching rolling update to external clients Switches rolling update to use external clients. This is a pretty strange looking command. @kubernetes/sig-cli-maintainers /assign @soltysh ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Removed unused functions. Signed-off-by:
Da K. Ma <klaus1982.cn@gmail.com> **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note None ```
-
David Eads authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. stop adding internal types to external schemes at some point someone starting internal types to external schemes in kubectl tests. This fixes that mistake. @kubernetes/sig-cli-maintainers /assign @soltysh ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 61389, 66817, 66903, 66675, 66965). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove internal client factory method remove final uses of the internal client factory method. https://github.com/kubernetes/kubernetes/pull/66933 does the rolling updater, so this just snips it off and prevents anyone else from ever relying on it. @kubernetes/sig-cli-maintainers /assign @soltysh ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 61389, 66817, 66903, 66675, 66965). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Provide an option to supply log-file mount option for gluster plugin. At present, `log-file` location of glusterfs client mount is decided by the plugin, however at times, users/admin want to configure log-file of gluster fuse client process on their own in some setups. Even though they can pass log-file mount option through storage class, before this patch glusterfs plugin always discard it. This patch enable/give preference to admin supplied log-file mount option if specified in storage class. If the log-file mount option is incomplete or wrong, plugin fallback to the location which is carved out by the combination of pvc and pod name. Signed-off-by:
Humble Chirammal <hchiramm@redhat.com> **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 61389, 66817, 66903, 66675, 66965). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Scalability tests: Increase sample size for pod startup latency measurement **What this PR does / why we need it**: This PR adds a way to increase a sample size used in pod startup latency measurement. We found that this phase is flaky and want to check if increasing a number of samples will help reducing a flakiness. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 61389, 66817, 66903, 66675, 66965). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove deprecated shorthand flag **Release note**: ```release-note remove deprecated shorthand flag `-c` from `kubectl version (--client)` ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. csiAttacher: check deviceMountPath before hasStageUnstageCapability csiAttacher#MountDevice: it is better to check `deviceMountPath` before `hasStageUnstageCapability` **Release note**: ``` NONE ``` /release-note-none /kind cleanup /sig storage
-
David Eads authored
-
David Eads authored
-
Maciej Borsz authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66822, 65983). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. apiextensions-apiserver: enable etcd_object_count metrics for CustomResources ~~This leaks one go routine per CRD that is deleted~~ The stop channel is wired already. We should not have the leak of the go routine: https://github.com/kubernetes/kubernetes/blob/d10e08fc897f6b5e60ce2aa8420bd2ea536e18b8/staging/src/k8s.io/apiserver/pkg/registry/generic/registry/store.go#L1379 ```release-note Added etcd_object_count metrics for CustomResources. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubeadm: fix runtime.ImageExists API **What this PR does / why we need it**: runtime.ImageExists returns error when underlying 'inspect' command fails. This makes ImagePullCheck to fail as it doesn't expect runtime.ImageExists to return an error even if image doesn't exist. **Which issue(s) this PR fixes**: Fixes [kubeadm issue 1024](https://github.com/kubernetes/kubeadm/issues/1024) **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kernel_validator: amend kernel config check paths **What this PR does / why we need it**: Clear Linux Project for Intel Architecture uses its own path to store kernel build artifacts. This PR amends the path to kernel validator's config check paths. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ``` e2e_node: add new kernel config check paths ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66911, 66841). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Make kubectl describe more tolerant of newlines Newlines in the `command`, `args`, `env.value`, or `annotations` fields are not uncommon. Wrap and indent these fields so that describe is more readable. Before: ``` Host Port: <none> Command: /bin/bash -c #!/bin/bash set -euo pipefail # set by the node image unset KUBECONFIG trap 'kill $(jobs -p); exit 0' TERM # track the current state of the config ``` After: ``` Host Port: <none> Command: /bin/bash -c #!/bin/bash set -euo pipefail # set by the node image unset KUBECONFIG trap 'kill $(jobs -p); exit 0' TERM # track the current state of the config ``` Annotations when wrapping: ``` Annotations: kubectl.kubernetes.io/desired-replicas: 1 openshift.io/deployer-pod.completed-at: 2018-07-31 22:47:15 +0000 UTC openshift.io/deployer-pod.created-at: 2018-07-31 22:37:11 +0000 UTC openshift.io/deployer-pod.name: test-3-deploy openshift.io/deployment-config.latest-version: 3 openshift.io/deployment-config.name: test openshift.io/deployment.phase: Failed openshift.io/deployment.replicas: 0 openshift.io/deployment.status-reason: manual change openshift.io/encoded-deployment-config: {"kind":"DeploymentConfig","apiVersion":"apps.openshift.io/v1","metadata":{"name":"test","namespace":"clayton-dev","selfLink":"/apis/apps.op... ``` ```release-note Handle newlines for `command`, `args`, `env`, and `annotations` in `kubectl describe` wrapping ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add e2e tests to test scope selectors with non-priorityclass scopes xref: https://github.com/kubernetes/kubernetes/issues/66673 **Release note**: ```release-note None ``` /cc @kubernetes/sig-scheduling-pr-reviews @derekwaynecarr @ravisantoshgudimetla @aveshagarwal @sjenning /sig scheduling
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62901, 66562, 66938, 66927, 66926). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. snip legacy scheme uses we don't need the legacy scheme covers the kubectl scheme. This pull converts many of the "simple" ones we can clear. I also cleared out create entirely. @kubernetes/sig-cli-maintainers /assign @soltysh @juanvallejo ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62901, 66562, 66938, 66927, 66926). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. snip links to internal clients This is just an example of snipping links to the internal client from k/k. There are four more direct links to the factory method to create the internal and order of a dozen imports. @kubernetes/sig-cli-maintainers /assign @soltysh @juanvallejo ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62901, 66562, 66938, 66927, 66926). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubelet: volumemanager: poll immediate when waiting for volume attachment Currently, `WaitForAttachAndMount()` introduces a 300ms minimum delay by using `wait.Poll()` rather than `wait.PollImmediate()`. This wait constitutes >99% of the total processing time for `syncPod()`. Changing this reduced `syncPod()` processing time for a simple busybox pod with one emptyDir volume from 302ms to 2ms. @derekwaynecarr @pmorie @smarterclayton @jsafrane /sig node /release-note-none
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62901, 66562, 66938, 66927, 66926). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Sets higher memory limit for init_container tests **What this PR does / why we need it**: /sig testing Currently, the limit set in the tests is 30 MB, which will cause the Docker service on the Windows nodes to hang and be no longer responsive. This will cause the Kubelet service to enter a NotReady state. Setting a higher memory limit (50 MB) will avoid this issue. **Which issue(s) this PR fixes**: Fixes #37429 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62901, 66562, 66938, 66927, 66926). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Eventratelimit aggregates all reject errors Previously, Eventratelimit validates event by each limiter but only returns the last reject error. Which is not accurate, so here I aggregate each error. **Release note**: ```release-note NONE ```
-
Michelle Au authored
-
Anago GCB authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66870, 66929, 66837). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix panic fake SAR client expansion if the object is nil, the type assertion fails. @kubernetes/sig-api-machinery-bugs ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66870, 66929, 66837). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. add logging to find offending transports When a transport can't be cancelled, we're notified, but we don't which transport is missing the ability. This adds logging to give us a target type. @kubernetes/sig-api-machinery-bugs /assign @juanvallejo since you hit it. ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. dry-run: Update DynamicClient to pass Create/Update options Change dynamic client to accept Create and Update options on Create/Update/Patch methods. **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
- 02 Aug, 2018 10 commits
-
-
Davanum Srinivas authored
gb-frontend and gb-redisslave are now *REALLY* multi-arch manifest lists. Fix bad merge from 66066 Change-Id: I0995394d638ab00b0d1d30ad7099351b806dfd9d
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66190, 66871, 66617, 66293, 66891). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Change the expected error message in webhook e2e test Fix #66776. The timeout error message sent by the apiserver was changed by #66616, which affects 1.12+ apiservers. The expected error message in e2e test in 1.11 and 1.12 should only contain the common part of the pre-1.12 error message and post-1.12 message, because the upgrade&downgrade tests will run the 1.11 e2e test against 1.12 apiserver, and vice versa. /sig api-machinery /release-note-none
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66190, 66871, 66617, 66293, 66891). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Unset CDPATH in build scripts **What this PR does / why we need it**: Currently trying to build k8s fails if you have CDPATH set in your env. This is a minor change that allows building k8s without manually unsetting the variable. ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66190, 66871, 66617, 66293, 66891). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Do not set cgroup parent when --cgroups-per-qos is disabled When --cgroups-per-qos=false (default is true), kubelet sets pod container management to podContainerManagerNoop implementation and GetPodContainerName() returns '/' as cgroup parent (default cgroup root). (1) In case of 'systemd' cgroup driver, '/' is invalid parent as docker daemon expects '.slice' suffix and throws this error: 'cgroup-parent for systemd cgroup should be a valid slice named as \"xxx.slice\"' (https://github.com/moby/moby/blob/5fc12449d830ae9005138fb3d3782728fa8d137a/daemon/daemon_unix.go#L618) '/' corresponds to '-.slice' (root slice) in systemd but I don't think we want to assign root slice instead of runtime specific default value. In case of docker runtime, this will be 'system.slice' (https://github.com/moby/moby/blob/e2593239d949eee454935daea7a5fe025477322f/daemon/oci_linux.go#L698) (2) In case of 'cgroupfs' cgroup driver, '/' is valid parent but I don't think we want to assign root instead of runtime specific default value. In case of docker runtime, this will be '/docker' (https://github.com/moby/moby/blob/e2593239d949eee454935daea7a5fe025477322f/daemon/oci_linux.go#L695) Current fix will not set the cgroup parent when --cgroups-per-qos is disabled. ```release-note Fix pod launch by kubelet when --cgroups-per-qos=false and --cgroup-driver="systemd" ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66190, 66871, 66617, 66293, 66891). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Part 2: Promoting Atomic Writer testcases for Conformance This PR is the result (part 2) of splitting [this PR](https://github.com/kubernetes/kubernetes/pull/65793) into 2 sections: 1) [This PR](https://github.com/kubernetes/kubernetes/pull/66786), addressing the refactor so eligible-test-for-conformance can use get rid of privileged security context. 2) This specific PR, that addresses the promotion of the Atomic Writer testcases to be in conformance suite. Changes: a) promoting Atomic writer volumes tests to be conformance tests. b) added those tests to appear on golden list (conformance master file)
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66190, 66871, 66617, 66293, 66891). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix nil pointer dereference in node_container_manager#enforceExisting **What this PR does / why we need it**: fix nil pointer dereference in node_container_manager#enforceExisting **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #66189 **Special notes for your reviewer**: NONE **Release note**: ```release-note kubelet: fix nil pointer dereference while enforce-node-allocatable flag is not config properly ```
-
Seth Jennings authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Skip checking when failSwapOn=false **What this PR does / why we need it**: Skip checking when failSwapOn=false **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: NONE **Release note**: ``` NONE ```
-
David Eads authored
-
David Eads authored
-