- 26 Mar, 2018 13 commits
-
-
p0lyn0mial authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add e2e test for Custom Metrics API with new Stackdriver resource model and External Metrics API. **What this PR does / why we need it**: Add e2e test for Custom Metrics API with new Stackdriver resource model and External Metrics API. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. [GCE] Remove validation of Alpha Feature Gates **What this PR does / why we need it**: As per discussion with @bowei, @freehan, and @nicksardo , remove validation on Alpha Feature Gates so we can be more flexible with adding or removing new features. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Removing the always pull policy on ingress image for CDK. **What this PR does / why we need it**: Removing the always pull policy. This caused some trouble when a registry was down and is unnecessary. Kubernetes will default to IfNotPresent. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # None, but I could make an issue if desired. **Special notes for your reviewer**: **Release note**: ```release-note Removed always pull policy from the template for ingress on CDK. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix comments and small fixes **What this PR does / why we need it**: Fix some comments, and remove trivial duplicates. **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fixes permissions error for Local SSD when created with NODE_LOCAL_SSDS flag **What this PR does / why we need it**: The PR fixes a permissions error introduced in 1.9 whereby users are unable to write to their Local SSD if it is created with the `NODE_LOCAL_SSDS` flag. This will need to be cherrypicked to 1.9 and 1.10. /sig storage /kind bug /assign @msau42 ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. escape literal percent sign when formatting **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #61503 **Special notes for your reviewer**: /assign @janetkuo @liggitt /cc @kubernetes/sig-cli-bugs **Release note**: ```release-note escape literal percent sign when formatting ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix error message about DeleteOptions Before this change: ```shell $ curl -k -XDELETE -H "Accept: application/json" -H "Content-Type: application/json" -H "User-Agent: kubectl/v1.10.0 (linux/amd64) kubernetes/d7e5bd19" http://172.16.29.130:8080/apis/extensions/v1beta1/namespaces/default/deployments/nginx --data '{"propagationPolicy":"Background11111"}' {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":" \"\" is invalid: []: Invalid value: v1.DeleteOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, GracePeriodSeconds:(*int64)(nil), Preconditions:(*v1.Preconditions)(nil), OrphanDependents:(*bool)(nil), PropagationPolicy:(*v1.DeletionPropagation)(0xc429aa9ed0)}: DeletionPropagation need to be one of \"Foreground\", \"Background\", \"Orphan\" or nil","reason":"Invalid","details":{"causes":[{"reason":"FieldValueInvalid","message":"Invalid value: v1.DeleteOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, GracePeriodSeconds:(*int64)(nil), Preconditions:(*v1.Preconditions)(nil), OrphanDependents:(*bool)(nil), PropagationPolicy:(*v1.DeletionPropagation)(0xc429aa9ed0)}: DeletionPropagation need to be one of \"Foreground\", \"Background\", \"Orphan\" or nil","field":"[]"}]},"code":422} ``` After this change: ```shell $ curl -k -XDELETE -H "Accept: application/json" -H "Content-Type: application/json" -H "User-Agent: kubectl/v1.10.0 (linux/amd64) kubernetes/d7e5bd19" http://172.16.29.130:8080/apis/extensions/v1beta1/namespaces/default/deployments/nginx --data '{"propagationPolicy":"Background11111"}' {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"DeleteOptions.meta.k8s.io \"\" is invalid: propagationPolicy: Unsupported value: \"Foreground1111\": supported values: \"Foreground\", \"Background\", \"Orphan\", \"nil\"","reason":"Invalid","details":{"group":"meta.k8s.io","kind":"DeleteOptions","causes":[{"reason":"FieldValueNotSupported","message":"Unsupported value: \"Foreground1111\": supported values: \"Foreground\", \"Background\", \"Orphan\", \"nil\"","field":"propagationPolicy"}]},"code":422} ``` **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove duplicated validation from podsecuritypolicy **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Cluster Autoscaler 1.2.0 ```release-note Cluster Autoscaler 1.2.0 - release notes available here: https://github.com/kubernetes/autoscaler/releases ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. cluster/update-storage-objects.sh: Fix to ignore deleted objects **What this PR does / why we need it**: This PR fixes to ignore deleted objects in `cluster/update-storage-objects.sh`. If it failed to fetch the object at [here](https://github.com/kubernetes/kubernetes/blob/master/cluster/update-storage-objects.sh#L101), it must ignore the object, but currently this script exits as follows after 5 tries: ``` $ ./cluster/update-storage-objects.sh Error from server (NotFound): events "minikube.151d894772669d981" not found Looks like minikube.151d894772669d98 got deleted. Ignoring it Error from server (NotFound): events "minikube.151d894772669d981" not found Looks like minikube.151d894772669d98 got deleted. Ignoring it Error from server (NotFound): events "minikube.151d894772669d981" not found Looks like minikube.151d894772669d98 got deleted. Ignoring it Error from server (NotFound): events "minikube.151d894772669d981" not found Looks like minikube.151d894772669d98 got deleted. Ignoring it Error from server (NotFound): events "minikube.151d894772669d981" not found Looks like minikube.151d894772669d98 got deleted. Ignoring it Error: failed to update events/minikube.151d894772669d98 in default namespace after 5 tries ``` **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. meta/v1: check error from json.Unmarshal() Release note: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix unix socket subpath mount Fixes https://github.com/kubernetes/kubernetes/issues/61377 ```release-note Fix mounting of UNIX sockets(and other special files) in subpaths ```
-
- 25 Mar, 2018 14 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. wire through json/yaml print flags **Release note**: ```release-note NONE ``` Begin implementing pieces needed to retrieve json, yaml printers from a set of flags. Proposal: https://docs.google.com/document/d/19ZZFVe9oD1KQmk5uExggRWtRl_hKGfYnBXvHZJlgEro/edit#heading=h.pnvbfi14v4zz cc @deads2k @soltysh @pwittrock
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. e2e:Enable CSI tests **What this PR does / why we need it**: Enable CSI e2e tests now that CSI objects in Kubernetes are Beta.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Do not consider pods being deleted in the same namespace for spreading purposes for service anti-affinity priority similar to selectorspread priority. **What this PR does / why we need it**: Currently for service anti-affinity priority, pods being deleted in the same namespace are being considered in computation for spreading purposes, which should not happen. This PR aligns it with selectorspread priority, which also does spreading and does not consider pods being deleted in the same namespace. @bsalamat @timothysc @kubernetes/sig-scheduling-bugs **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add support for --dry-run to kubectl patch. **What this PR does / why we need it**: Add support for the `--dry-run` flag to `kubectl patch`. This is helpful to be able to preview patches prior to applying them. **Which issue(s) this PR fixes**: Refs #11488 **Special notes for your reviewer**: This PR carries #45712. **Release note**: ```release-note `kubectl patch` now supports `--dry-run`. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Increase fluentd rolling-upgrade maxUnavailable to large value ~For testing wrt https://github.com/kubernetes/kubernetes/issues/61190#issuecomment-374899752~ Fixes issue https://github.com/kubernetes/kubernetes/issues/61190 wrt slow rolling-upgrade /cc @x13n @wojtek-t /sig instrumentation /kind bug /priority critical-urgent ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. move the const to the place it should be **What this PR does / why we need it**: move the const to the place it should be **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix e2e test lifecycle/ha_master.go Minor fixes for gce-ha-master e2e test https://k8s-testgrid.appspot.com/google-gce#gce-ha-master ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. add myself for sig-cli reviewer **What this PR does / why we need it**: This is adding myself as sig-cli reviewer. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: /assign @soltysh **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix sorting taints in case the sorting keys are equal **What this PR does / why we need it**: /kind bug /sig cli When describing node taints, the similar issue mentioned in #61250 also exists. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: xref #61250 **Special notes for your reviewer**: /cc @kubernetes/sig-cli-bugs @kubernetes/sig-cli-api-reviews **Release note**: ```release-note fix sorting taints in case the sorting keys are equal ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove max-pods param from config-test.sh This is set to default value anyway.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. update metrics to true like it is for kube-apiserver The kube-apiserver always hardcoded to true, but nothing else knew too. I changed the default to true (I can't think of why you wouldn't want it even if you don't often use it). @kubernetes/sig-api-machinery-bugs @MikeSpreitzer see if this fixes you?
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Suppress error message from grep when checking whether a subnet has a secondary range or not. **What this PR does / why we need it**: Get rid of stdrr caused by grep command when running cluster/kube-up.sh for GCE. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # N/A **Special notes for your reviewer**: No behavior change. **Release note**: ```release-note "NONE" ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update GCP fluentd configmap for COS audit logging on GKE node **What this PR does / why we need it**: This PR adds a placeholder in fluentd configmap for COS audit logging on GKE node. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: NONE **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Revert "equivalence class hash calculation in scheduler" Reverts kubernetes/kubernetes#60753 ref/ #61512 /sig scheduling Let's wait and see how the tests go. ```release-note NONE ```
-
- 24 Mar, 2018 9 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Allow including both podSelector and namespaceSelector in a NetworkPolicyPeer Updates NetworkPolicy API docs and validation to allow podSelector and namespaceSelector to be specified together in a NetworkPolicyPeer Fixes #58637 **Release note**: ```release-note NetworkPolicies can now target specific pods in other namespaces by including both a namespaceSelector and a podSelector in the same peer element. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix `PodScheduled` bug for static pod. Fixes https://github.com/kubernetes/kubernetes/issues/60589. This is an implementation of option 2 in https://github.com/kubernetes/kubernetes/issues/60589#issuecomment-375103979. I've validated this in my own cluster, and there won't be continuously status update for static pod any more. Signed-off-by:
Lantao Liu <lantaol@google.com> **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note none ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. add unit test for function ParseKindArg and ParseGroupKind **What this PR does / why we need it**: add unit test for function ParseKindArg and ParseGroupKind **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. include node internal ip as additional information for kubectl **What this PR does / why we need it**: Node external ip is only available for cloud-based cluster. This PR does extend showing node internal ip for baremental clusters, where external ip is always shown as `<none>`. Before the change, ``` $ kubectl get node -o wide NAME STATUS AGE VERSION EXTERNAL-IP OS-IMAGE KERNEL-VERSION server-01 Ready 21d v1.9.0 <none> Ubuntu 16.04.2 LTS 4.4.0-83-generic server-02 Ready 21d v1.9.0 <none> Ubuntu 16.04.2 LTS 4.4.0-83-generic ``` After the change, ``` $ kubectl get node -o wide NAME STATUS ROLES AGE VERSION INTERNAL-IP EXTERNAL-IP OS-IMAGE KERNEL-VERSION CONTAINER-RUNTIME server-01 Ready master 21d v1.9.0 192.168.31.100 <none> Ubuntu 16.04.2 LTS 4.4.0-83-generic docker://1.13.1 server-02 Ready <none> 21d v1.9.0 192.168.31.101 <none> Ubuntu 16.04.2 LTS 4.4.0-83-generic docker://1.13.1 ``` **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: /cc @kubernetes/sig-cli-pr-reviews **Release note**: ```release-note include node internal ip as additional information for kubectl ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Revert "add rolling update daemonset existing pod adoption integration test" Reverts kubernetes/kubernetes#59013
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Make sh2ju use awk instead of bc. awk is available in all of our test runners (as part of busybox or debian base packages), bc is not. This will fix spurious errors in the typecheck job. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix todo: use the ServiceTestJig replace of service in e2e/network/service.go **What this PR does / why we need it**: fix todo: use the ServiceTestJig replace of service in e2e/network/service.go **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix various bash scripts to make them more robust and uniform **What this PR does / why we need it**: The shellcheck tool (https://github.com/koalaman/shellcheck) finds a bunch of issues in kubernetes bash scripts. I started fixing the issues to make the scripts more robust and correct. This PR fixes some "low-hanging fruit" and also cleans up file `hack/update-godep-licenses.sh` in a more complete fashion. **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Bobby (Babak) Salamat authored
-
- 23 Mar, 2018 4 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Replace package "golang.org/x/net/context" with "context" **What this PR does / why we need it**: Replace package "golang.org/x/net/context" with "context" **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #60560 **Special notes for your reviewer**: As of Go 1.7 this package(golang.org/x/net/context) is available in the standard library under the name context. see (https://godoc.org/golang.org/x/net/context) It is almost machinery replace. **Release note**: ```release-note NONE ```
-
Ashley Gau authored
-
Mike Wilson authored
-
Ismo Puustinen authored
The file was analyzed with shellcheck, and various issues fixed. Most of the problems were just cleanups, but also potential bugs were fixed. Many variables were quoted with double quotes to prevent globbing. The local_files array expansion was quoted so that any file names with potential spaces in the filename would not be re-split. The empty default value was removed from the list processing. POSIX standard "grep -E" was used instead of egrep.
-