- 10 Sep, 2016 29 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Use PV shared informer in PV controller Use the PV shared informer, addressing (partially) https://github.com/kubernetes/kubernetes/issues/26247 . Using the PVC shared informer is not so simple because sometimes the controller wants to `Requeue` and...
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue add suggestion to use `describe` to obtain container names **Release note**: ```release-note release-note-none ``` Commands with the `--container=` option provide no suggestions to a user on how to obtain a container's name from a pod. This patch adds a suggestion on the usage output to use the `describe` command on a pod to obtain the container value that is passed to the `--container=` flag. `$ kubectl exec -h` ``` Execute a command in a container. Examples: kubectl exec 123456-7890 date kubectl exec 123456-7890 -c ruby-container date kubectl exec 123456-7890 -c ruby-container -i -t -- bash -il Flags: -c, --container string Container name. If omitted, the first container in the pod will be chosen. Use the 'describe' command to find the list of containers on a pod. -p, --pod string Pod name -i, --stdin Pass stdin to the container -t, --tty Stdin is a TTY
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Return all the invalid flags for rollingupdate It had better to return all the invalid flags for the "validateArguments" function, so the user can modify them at once.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue It is better to add "\n" in printf <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md 2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md 3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes --> **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: <!-- Steps to write your release note: 1. Use the release-note-* labels to set the release note state (if you have access) 2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. --> ```release-note ```
-
Wojciech Tyczynski authored
Revert "Use scale subresource"
-
Wojciech Tyczynski authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Return all the invalid parameters for set_image Suggest returning all the invalid parameters for "ImageOptions.Validate()" in set_image.go.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Optimise the DefaultGenerators function It needn't define all the generators in the "DefaultGenerators" function, it just return the "cmdName" generator, the others is redundant.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue support storage class in Ceph RBD volume replace WIP PR #30959, using PV annotation idea from @jsafrane @kubernetes/sig-storage @johscheuer @elsonrodriguez
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Use scale subresource Fixes #29698 Use scale subresource for ReplicationController, ReplicaSet and Deployment. Couldn't do Jobs and PetSet since they live in a different group.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add client-server runtime support to local-up-cluster.sh <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md 2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md 3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes --> **What this PR does / why we need it**: It provides support for using `--container-runtime-endpoint` and `--image-service-endpoint` arguments for kubelet in `local-up-cluster.sh` script. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*: ref #28789 **Special notes for your reviewer**: **Release note**: <!-- Steps to write your release note: 1. Use the release-note-* labels to set the release note state (if you have access) 2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. --> ```release-note ``` Provide support for --container-runtime-endpoint and --image-service-endpoint in kubelet. Ref #28789
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Productionize the cockroachdb example a little more Includes: * A service for clients to use * Readiness/liveness probes * An extended graceful termination period * Automatic prometheus monitoring (when prometheus is configured to watch for annotations on services, as in [CoreOS's recent blog post](https://coreos.com/blog/prometheus-and-kubernetes-up-and-running.html), for example) I'm leaving the management of certs to future work, but if anyone that sees this needs help with them in the meantime, don't hesitate to reach out. Successor to #28446 @bprashanth - if you're still interested in / open to an e2e test (as mentioned in https://github.com/cockroachdb/cockroach/issues/5967#issuecomment-230188807), let me know and I'll put one together. If so, I assume you'd want it as part of the `petset` test group rather than the `examples` tests? cc @tschottdorf **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Example of unversioned pkg uses correct Config struct Currently this Doc has incorrect example - https://godoc.org/k8s.io/kubernetes/pkg/client/unversioned So when developers use it they are confused why `client` pkg has no `Config` struct, actually this is a struct from `restclient` pkg. Also pkg name and variable name should be equal: `client, err := client.New(config)` Thanks, Alex
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Update scheduler config file compatibility tests **What this PR does / why we need it**: Added missing compatibility tests for scheduler config file options. **Which issue this PR fixes** fixes #30099 **Special notes for your reviewer**: I came up with the options based on the contents of default.go in each branch. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Kubelet: add KillPod for new runtime API This PR adds implements of KillPod for new runtime API. CC @yujuhong @Random-Liu @kubernetes/sig-node @kubernetes/sig-rktnetes
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue add ClientSet to factory to remove non-generated client We should move to using generated clients in the `kubectl` client. We should really move to generated external clients, but this at least moves away from using manually created clients. @fabianofranz @mfojtik When I complete this work (move the other commands and eliminate the old API), this will ripple downstream.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Kubelet: rename CreatePodSandbox to RunPodSandbox in CRI As @yifan-gu pointed out in #31847, the name `CreatePodSandbox` doesn't reflect that the sandbox is running after the API succeeds. This PR renames it to `RunPodSandbox` to make this clear. CC @yujuhong @yifan-gu @kubernetes/sig-node
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue The first letter should be capitalized
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue add group prefix matching for kubectl usage Adds prefix matching for groups so that `kubectl get storageclass.storage` matches `storageclass.storage.k8s.io`. @kubernetes/kubectl
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue add logging for enabled/disabled API Groups Adds logging to the apiserver to indicate which API groups are enabled and disabled as go through. This will make it easier to identify what's gone wrong in cases where the API server is down during diagnoses and the config is inaccessible, like in GKE tests. For example https://github.com/kubernetes/kubernetes/issues/32185#issuecomment-245255700 . @wojtek-t This may have made the problem more obvious.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue make swaggerschema agnostic about which version to use `Factory.SwaggerSchema` was reliant on having a non-generated client bits filled in so that it could get the adapted client it wanted. There's no need since discovery ignores configured GroupVersions. This eliminates the unneeded dependency.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue rkt: Refactor host file mounts for host network. Do not mount /etc/hosts/ /etc/resolv.conf if they are already mounted. Ref https://github.com/coreos/rkt/issues/2430#issuecomment-244343576
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add validation rule to prevent adding finalizers if the object is being deleted To implement the behavior described in comments: https://github.com/kubernetes/kubernetes/blob/master/pkg/api/types.go#L149-L150 This purpose of this behavior is to disallow user manually changes from cascading deletion to orphaning after the deletion starts. Fix #32339
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Deprecate release infrastructure and doc - moved to kubernetes/release Part 2 of https://github.com/kubernetes/release/pull/1 This PR finalizes the split between the main kubernetes repo and the release tooling now under kubernetes/release. ref #16529
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Log pressure condition, memory usage, events in memory eviction test I want to log this to help us debug some of the latest memory eviction test flakes, where we are seeing burstable "fail" before the besteffort. I saw (in the logs) attempts by the eviction manager to evict besteffort a while before burstable phase changed to "Failed", but the besteffort's phase appeared to remain "Running". I want to see the pressure condition interleaved with the pod phases to get a sense of the eviction manager's knowledge vs. pod phase.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix etcd2 cross-build in the Makefile fixes https://github.com/kubernetes/kubernetes/issues/32328 Make it possible to compile both etcd2 and etcd3 in the Makefile and compile attachlease for multiple arches as well. @lavalamp The etcd build-from-source semantics changed between etcd2 and etcd3. I updated it to etcd3 in my last PR, and didn't think we were gonna build etcd2 more. However, I've now fixed it to build for both versions. Thanks!
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Stick to 2.2.1 etcd Fixes #32253. See https://github.com/kubernetes/kubernetes/issues/32253#issuecomment-245974746. We are sticking with etcd 2.2.1 until we have a recommended rollforward/rollback process for etcd. See https://github.com/kubernetes/kubernetes/issues/32253#issuecomment-245735209 for etcd roadmap. I guess I also need to build the image like https://github.com/kubernetes/kubernetes/issues/32253#issuecomment-245744295, and update build/build-image/cross/VERSION? @lavalamp @timothysc
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix glbc name to match image version Risk is low, we should get it into 1.4 to avoid confusion. Image is 0.7.1 (bumped in 1.3.6) so name and label should match.
-
David McMahon authored
-
- 09 Sep, 2016 11 commits
-
-
Chao Xu authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue e2e: only tear down existing cluster if it exists Jenkins won't actually test this change, since `e2e.go` is now sourced from `kubekins-e2e`. :( Probably fixes https://github.com/kubernetes/test-infra/issues/539, once a new `kubekins-e2e` is pushed. cc @maisem @davidopp
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix a bug in kubelet hostport logic which flushes KUBE-MARK-MASQ iptables chain Fixes #32415
-
bprashanth authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix service health check node port leaks Fixed #31757
-
Chao Xu authored
-
Jeff Grafton authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue [Pet Set] Clean up code <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md 2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md 3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes --> **What this PR does / why we need it**: Clean code of petset, from: ``` func (p *apiServerPetClient) getPVC(pvcName, pvcNamespace string) (*api.PersistentVolumeClaim, bool, error) ``` to: ``` func (p *apiServerPetClient) getPVC(pvcName, pvcNamespace string) (*api.PersistentVolumeClaim, error) ``` I think the 2nd(bool type) return value of [getPVC](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/petset/pet.go#L228) is unnecessary, as the caller can be responsible for checking the error type and tell if it exists via the [error type](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/petset/pet.go#L231-L233). So, I remove the 2nd return value of `getPVC()`. The benefit of this change is that we can simplify the code of `getPVC()` while don't increase the caller's code.
-
Minhan Xia authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue POC: MapReduce-like scheduler priority functions Ref #24246
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Make sure finalizers prevent deletion on storage that supports graceful deletion Fixing bug: Non-empty Finalizers fails to prevent a pod from being deleted, if deleteOptions.GracefulPeriod=0. See https://github.com/kubernetes/kubernetes/issues/32157#issuecomment-245778483 We didn't hit any issue with orphan finalizer because all our tests set finalizers on RC or RS, whose storage doesn't support graceful deletion. cc @thockin @lavalamp
-