- 27 May, 2018 1 commit
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. bump(github.com/evanphx/json-patch): 94e38aa1586e8a6c8a75770bddf5ff84c48a106b update package github.com/evanphx/json-patch fixes #64291 /cc wgliang cblecker ```release-note fixes a panic applying json patches containing out of bounds operations ```
-
- 26 May, 2018 10 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Adding tests for ImageLocalityPriority **What this PR does / why we need it**: This PR adds tests for ImageLocalityPriority scheduling policy, as follow-ups of [#63842](https://github.com/kubernetes/kubernetes/issues/63842) and [#63345](https://github.com/kubernetes/kubernetes/issues/63345). It includes the unit test for ImageSizes function of NodeInfo in the scheduler cache. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: @resouer **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62984, 64304). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove alpha feature warning for log rotation flags. CRI container log rotation is beta now. @yujuhong /cc @mtaufen @kubernetes/sig-node-pr-reviews Signed-off-by:
Lantao Liu <lantaol@google.com> **Release note**: ```release-note none ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Validate cgroups-per-qos for Windows **What this PR does / why we need it**: cgroups-per-qos and enforce-node-allocatable is not supported on Windows, but kubelet allows it on Windows. And then Pods may stuck in terminating state because of it. Refer #61716. This PR adds validation for them and make kubelet refusing to start in this case. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #61716 **Special notes for your reviewer**: **Release note**: ```release-note Fail fast if cgroups-per-qos is set on Windows ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 64288, 64343). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. [gce provider] Add more wrappers for security policy **What this PR does / why we need it**: Adding more wrappers for security policy, mostly for implementing the e2e test. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #NONE **Special notes for your reviewer**: /assign @nicksardo **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Move volume resize feature to beta Move volume resizing feature to beta. xref https://github.com/kubernetes/features/issues/284 ```release-note Move Volume expansion to Beta ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 63859, 63979). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Drop reapers /assign @deads2k @juanvallejo **Release note**: ```release-note kubectl delete does not use reapers for removing objects anymore, but relies on server-side GC entirely ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 63859, 63979). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove signal handler registration from pkg/kubelet **What this PR does / why we need it**: The goal of this change is to remove the registration of signal handling from pkg/kubelet (i.e., library code). If you register a signal handler in `main()` to aid in a controlled and deliberate exit then the handler registered in `pkg/kubelet` often wins and the process exits immediately. This means all other signal handler registrations are currently racy if `DockerServer.Start()` is directly or indirectly invoked. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: This change also removes another signal handler registration from `NewAPIServerCommand()`; a stop channel is now passed to this function. **Release note**:
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Adding a shutdown script that would enable handling preemptible VM terminations gracefully in GCP environment This PR adds a shutdown script to COS nodes in GCP k8s clusters that will make preemptible nodes sleep for however long they can between the time they receive an ACPI shutdown request and get's terminated. https://cloud.google.com/compute/docs/instances/preemptible#preemption_process This will then allow for catching termination signals via GCE metadata APIs and gracefully evict pods in k8s. xref https://github.com/kubernetes/release/pull/560/
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix DsFromManifest() after we switch from extensions/v1beta1 to apps/v1 in cluster/addons/device-plugins/nvidia-gpu/daemonset.yaml. **What this PR does / why we need it**: Fixes broken node e2e jobs caused by https://github.com/kubernetes/kubernetes/pull/64296. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Jordan Liggitt authored
-
- 25 May, 2018 29 commits
-
-
Zihong Zheng authored
-
Zihong Zheng authored
-
Vishnu kannan authored
Adding a shutdown script that would enable handling preemptible VM terminations gracefully in GCP environment Signed-off-by:Vishnu kannan <vishnuk@google.com>
-
Jiaying Zhang authored
in cluster/addons/device-plugins/nvidia-gpu/daemonset.yaml.
-
Maciej Szulik authored
Initializers are alpha, broken and a subject for removal. They don't work well with finalizers and the previous hack present in deployment and replicaset reapers was just hiding this problem.
-
Maciej Szulik authored
-
Maciej Szulik authored
-
Hemant Kumar authored
-
Hemant Kumar authored
-
Hemant Kumar authored
Update bootstrap policies
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update nvidia-gpu-device-plugin to apps/v1 and use RollingUpdate updateStrategy. Even though RollingUpdate is the default updateStrategy, we need to specify it explicitly here because otherwise updating from extensions/v1beta1 to apps/v1 doesn't change the updateStrategy. Related to #57125 and #63634 ```release-note NONE ``` /assign @vishh @jiayingz /cc @janetkuo
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update function hasClusterTag to fix issue #64230 **What this PR does / why we need it**: Fixes issue #64230, by changing function hasClusterTag, in aws/tags.go, to ensure that, when called with a list of tags containing a tag with a key which matches clusterTagKey, function will return true even if a tag with key TagNameKubernetesClusterLegacy also exists in the list with a value other than the ClusterID. **Which issue(s) this PR fixes**: Fixes #64230 **Special notes for your reviewer**: Notes are in issue **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 63232, 64257, 64183, 64266, 64134). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Move SuggestedPodTemplateResources from factory to set_resources **What this PR does / why we need it**: Move SuggestedPodTemplateResources from factory to set_resources **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #64106 **Special notes for your reviewer**: /cc @juanvallejo **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 63232, 64257, 64183, 64266, 64134). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Measure scheduler throughput in density test This is a step towards exposing scheduler-related metrics on [perf-dash](http://perf-dash.k8s.io/). This particular PR adds scheduler throughput computation and makes the results available in our test artifacts. So if you do some experiments, you'll have some historical baseline data to compare against. xref https://github.com/kubernetes/kubernetes/issues/63493 fyi - @wojtek-t @davidopp @bsalamat @misterikkit cc @kubernetes/sig-scheduling-misc @kubernetes/sig-scalability-misc ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 63232, 64257, 64183, 64266, 64134). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix kubectl set subject --all option invalid bug **What this PR does / why we need it**: Fix the kubectl set subject --all option invalid bug and add test cases for it **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #64182 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 63232, 64257, 64183, 64266, 64134). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Trigger function for secrets
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Volume topology aware dynamic provisioning: basic plumbing **What this PR does / why we need it**: Split PR https://github.com/kubernetes/kubernetes/pull/63193 for better review part 1: basic scheduler and controller plumbing Next: https://github.com/kubernetes/kubernetes/pull/63233 **Which issue(s) this PR fixes** Feature: https://github.com/kubernetes/features/issues/561 Design: https://github.com/kubernetes/community/issues/2168 **Special notes for your reviewer**: /sig storage /sig scheduling /assign @msau42 @jsafrane @saad-ali @bsalamat **Release note**: ```release-note Basic plumbing for volume topology aware dynamic provisioning ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add conversion to properly parse query parameter propagationPolicy **What this PR does / why we need it**: This delete request query parameter has been broken for a year. I'm not sure if we want to deprecate the non-standard DeleteOptions body on delete request eventually. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #43329 **Special notes for your reviewer**: **Release note**: ```release-note API server properly parses propagationPolicy as a query parameter sent with a delete request ``` /sig api-machinery
-
Shyam Jeedigunta authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 64204, 64302). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. simplify logic and remove else blocks ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. apiextensions: unify mono- and multi-versioned test helpers The mono-versioned helpers are a special case of the multi-versioned ones. Fixes part of https://github.com/kubernetes/kubernetes/issues/64136.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 64175, 63893). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Expose openapi schema to handlers **What this PR does / why we need it**: Build an openapi spec for each api resource handler. This spec will be able to be consumed by server-side apply and server-side openapi validation. The reason for putting it into master is so we can work on implementing server side validation against the openapi spec as well as server side apply, and it will make merging the server side apply feature branch a smaller, less risky PR /sig api-machinery /kind feature cc @liggitt @lavalamp @seans3 @mbohlool @apelisse **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 64175, 63893). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. add colon separators to improve readability of test names ```release-note NONE ```
-
Lantao Liu authored
Signed-off-by:Lantao Liu <lantaol@google.com>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 61963, 64279, 64130, 64125, 64049). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix TestSchedulerWithVolumeBinding to avoid setting predicate ordering. It is causing data race condition as predicate ordering is changing global variable `predicatesOrdering`. Infact this test does not require any special predicate order and should work on default predicate ordering as far as VolumeScheduling feature is enabled. See these logs: ``` ================== ================== WARNING: DATA RACE Read at 0x00c420894180 by goroutine 156: k8s.io/kubernetes/pkg/scheduler/core.podFitsOnNode() /home/avagarwa/upstream-code/gocode/src/k8s.io/kubernetes/pkg/scheduler/core/generic_scheduler.go:503 +0xbb k8s.io/kubernetes/pkg/scheduler/core.(*genericScheduler).findNodesThatFit.func1() /home/avagarwa/upstream-code/gocode/src/k8s.io/kubernetes/pkg/scheduler/core/generic_scheduler.go:353 +0x2f0 k8s.io/kubernetes/vendor/k8s.io/client-go/util/workqueue.Parallelize.func1() /home/avagarwa/upstream-code/gocode/src/k8s.io/kubernetes/vendor/k8s.io/client-go/util/workqueue/parallelizer.go:47 +0xa3 Previous write at 0x00c420894180 by goroutine 186: k8s.io/kubernetes/pkg/scheduler.TestSchedulerWithVolumeBinding() /home/avagarwa/upstream-code/gocode/src/k8s.io/kubernetes/pkg/scheduler/scheduler_test.go:663 +0x71 testing.tRunner() /usr/lib/golang/src/testing/testing.go:777 +0x16d Goroutine 156 (running) created at: k8s.io/kubernetes/vendor/k8s.io/client-go/util/workqueue.Parallelize() /home/avagarwa/upstream-code/gocode/src/k8s.io/kubernetes/vendor/k8s.io/client-go/util/workqueue/parallelizer.go:43 +0x139 k8s.io/kubernetes/pkg/scheduler/core.(*genericScheduler).findNodesThatFit() /home/avagarwa/upstream-code/gocode/src/k8s.io/kubernetes/pkg/scheduler/core/generic_scheduler.go:378 +0xe8a k8s.io/kubernetes/pkg/scheduler/core.(*genericScheduler).Schedule() /home/avagarwa/upstream-code/gocode/src/k8s.io/kubernetes/pkg/scheduler/core/generic_scheduler.go:131 +0x385 k8s.io/kubernetes/pkg/scheduler.(*Scheduler).schedule() /home/avagarwa/upstream-code/gocode/src/k8s.io/kubernetes/pkg/scheduler/scheduler.go:192 +0xcd k8s.io/kubernetes/pkg/scheduler.(*Scheduler).scheduleOne() /home/avagarwa/upstream-code/gocode/src/k8s.io/kubernetes/pkg/scheduler/scheduler.go:447 +0x598 k8s.io/kubernetes/pkg/scheduler.(*Scheduler).(k8s.io/kubernetes/pkg/scheduler.scheduleOne)-fm() /home/avagarwa/upstream-code/gocode/src/k8s.io/kubernetes/pkg/scheduler/scheduler.go:182 +0x41 k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1() /home/avagarwa/upstream-code/gocode/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133 +0x61 k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil() /home/avagarwa/upstream-code/gocode/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:134 +0xcd k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait.Until() /home/avagarwa/upstream-code/gocode/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88 +0x5a Goroutine 186 (running) created at: testing.(*T).Run() /usr/lib/golang/src/testing/testing.go:824 +0x564 testing.runTests.func1() /usr/lib/golang/src/testing/testing.go:1063 +0xa4 testing.tRunner() /usr/lib/golang/src/testing/testing.go:777 +0x16d testing.runTests() /usr/lib/golang/src/testing/testing.go:1061 +0x4e1 testing.(*M).Run() /usr/lib/golang/src/testing/testing.go:978 +0x2cd main.main() _testmain.go:52 +0x22a ================== --- FAIL: TestSchedulerWithVolumeBinding (18.04s) testing.go:730: race detected during execution of test FAIL ``` It is pretty easy to reproduce this race by following these steps: ``` cd pkg/scheduler go test -c -race stress -p 100 ./scheduler.test ``` Predicate ordering to this unit test was added here: https://github.com/kubernetes/kubernetes/pull/57168 Since the whole scheduler instance uses just one ordering at time, not sure what is the advantage. @kubernetes/sig-scheduling-bugs @bsalamat @k82cn @frobware @smarterclayton @sjenning ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 61963, 64279, 64130, 64125, 64049). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add node-exclusive tags to tests in test/e2e_node Original issue: #59001 Depends on: #64128 Add node-exclusive tags based on the [proposal](https://docs.google.com/document/d/1BdNVUGtYO6NDx10x_fueRh_DLT-SVdlPC_SsXjYCHOE/edit#) Follow-up PRs will: - Tag the tests in `test/e2e/common` - Change the test job configurations to use the new tests - Remove the unused, non-node-exclusive tags in `test/e2e_node` **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 61963, 64279, 64130, 64125, 64049). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add Node-exclusive tags to tests in test/e2e/common Original issue: #59001 Add node-exclusive tags based on the [proposal](https://docs.google.com/document/d/1BdNVUGtYO6NDx10x_fueRh_DLT-SVdlPC_SsXjYCHOE/edit#) Previous PR: #64125 Depends on: #64128 Follow-up PRs will: - Change the test job configurations to use the new tests - Remove the unused, non-node-exclusive tags in `test/e2e_node` **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 61963, 64279, 64130, 64125, 64049). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Use default seccomp profile for DNS addons. **What this PR does / why we need it**: This PR sets the default seccomp profile of DNS addons to 'docker/default'. This PR is a followup of #62662. We are using 'docker/default' instead of 'runtime/default' in addons in order to handle node version skew. When seccomp profile is applied automatically by default later, we can remove those annotations. This is PR is part of #39845. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 61963, 64279, 64130, 64125, 64049). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Make serverAddressByClientCIDRs in discovery API optional **What this PR does / why we need it**: See https://github.com/kubernetes/kubernetes/issues/61868 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #61868 **Special notes for your reviewer**: WIP: I'm having trouble updating swagger-spec using our update scripts. Thinking about removing swagger-spec from our code base as it has long passed deprecation. Sending this PR now to see the test results. **Release note**: ```release-note Property `serverAddressByClientCIDRs` in `metav1.APIGroup` (discovery API) now become optional instead of required ``` /sig api-machinery
-