1. 14 Mar, 2017 18 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #43066 from foxish/fix-statefulset-apps · 0ea3e9a2
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43034, 43066)
      
      Fix StatefulSet apps e2e tests
      
      Fixes https://github.com/kubernetes/kubernetes/issues/42490
      
      ```release-note
      NONE
      ```
      
      cc @kubernetes/sig-apps-bugs
      0ea3e9a2
    • Kubernetes Submit Queue's avatar
      Merge pull request #43034 from enisoc/statefulset-patch · dc2b0ee2
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43034, 43066)
      
      Allow StatefulSet controller to PATCH Pods.
      
      **What this PR does / why we need it**:
      
      StatefulSet now needs the PATCH permission on Pods since it calls into ControllerRefManager to adopt and release. This adds the permission and the missing e2e test that should have caught this.
      
      **Which issue this PR fixes**:
      
      **Special notes for your reviewer**:
      
      This is based on #42925.
      
      **Release note**:
      ```release-note
      ```
      cc @kubernetes/sig-apps-pr-reviews
      dc2b0ee2
    • Kubernetes Submit Queue's avatar
      Merge pull request #43080 from foxish/foxish-patch-2 · f53ba558
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add rest of workloads team to test/OWNERS
      
      ```release-note
      NONE
      ```
      
      cc @kubernetes/sig-apps-misc
      f53ba558
    • Kubernetes Submit Queue's avatar
      Merge pull request #42935 from yifan-gu/fix_flock · 70b3848b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42942, 42935)
      
      pkg/util/flock: Fix the flock so it actually locks.
      
      With this PR, the second call to `Acquire()` will block unless the lock is released (process exits).
      Also removed the memory mutex in the previous code since we don't need `Release()` here so no need to save and protect the local fd.
      
      Fix #42929.
      70b3848b
    • Kubernetes Submit Queue's avatar
      Merge pull request #42942 from vishh/gpu-cont-fix · 6de28fab
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42942, 42935)
      
      [Bug] Handle container restarts and avoid using runtime pod cache while allocating GPUs
      
      Fixes #42412
      
      **Background**
      Support for multiple GPUs is an experimental feature in v1.6. 
      Container restarts were handled incorrectly which resulted in stranding of GPUs
      Kubelet is incorrectly using runtime cache to track running pods which can result in race conditions (as it did in other parts of kubelet). This can result in same GPU being assigned to multiple pods.
      
      **What does this PR do**
      This PR tracks assignment of GPUs to containers and returns pre-allocated GPUs instead of (incorrectly) allocating new GPUs.
      GPU manager is updated to consume a list of active pods derived from apiserver cache instead of runtime cache.
      Node e2e has been extended to validate this failure scenario.
      
      **Risk**
      Minimal/None since support for GPUs is an experimental feature that is turned off by default. The code is also isolated to GPU manager in kubelet.
      
      **Workarounds**
      In the absence of this PR, users can mitigate the original issue by setting `RestartPolicyNever`  in their pods.
      There is no workaround for the race condition caused by using the runtime cache though.
      Hence it is worth including this fix in v1.6.0.
      
      cc @jianzhangbjz @seelam @kubernetes/sig-node-pr-reviews 
      
      Replaces #42560
      6de28fab
    • Anthony Yeh's avatar
      Allow StatefulSet controller to PATCH Pods. · 53a6f440
      Anthony Yeh authored
      Also add an e2e test that should have caught this.
      53a6f440
    • Anirudh Ramanathan's avatar
      Add people to test/OWNERS · 5267f05b
      Anirudh Ramanathan authored
      5267f05b
    • Kubernetes Submit Queue's avatar
      Merge pull request #41429 from mikedanese/kubeadm-owners · 08e351ac
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      remove dgoodwin and dmmcquay to kubeadm reviewers
      
      @dgoodwin says he needs to work on other stuff right now. @dmmcquay says he wants to help with reviews.
      08e351ac
    • Kubernetes Submit Queue's avatar
      Merge pull request #43078 from jbeda/constant-token-compare · 204540e3
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43022, 43078)
      
      Use constant time compare for bootstrap tokens
      
      This is a subtle security issue that should go in for 1.6 on a new feature (bootstrap tokens).
      
      ```release-note
      NONE
      ```
      204540e3
    • Kubernetes Submit Queue's avatar
      Merge pull request #43022 from jbeda/kubeadm-message · c425b4ed
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43022, 43078)
      
      Dumb typo in kubeadm instructions
      
      I typo'd chown as chmod in kubeadm instructions.  Ugh.
      
      ```release-note
      NONE
      ```
      c425b4ed
    • Kubernetes Submit Queue's avatar
      Merge pull request #43012 from marun/fed-fix-ingress-unit-test · f2caa9a1
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42802, 42927, 42669, 42988, 43012)
      
      [Federation] Fix flakey ingress unit test
      
      The unit test for the ingress controller was previously adding a cluster twice, which resulted in a cluster being deleted and added back.  The deletion was racing the controller shutdown to close
      informer channels, sometimes resulting in closing an already closed channel.  This change ensures that the federated informer clears its map of informers when ``Stop()`` is called to insure against a double close, and fixes the test to no longer add the cluster twice.
      
      Targets #43009
      
      cc: @csbell @kubernetes/sig-federation-bugs
      f2caa9a1
    • Kubernetes Submit Queue's avatar
      Merge pull request #42988 from MaciekPytel/update_ca_manifest · ffb071be
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42802, 42927, 42669, 42988, 43012)
      
      Update Cluster Autoscaler entrypoint
      
      **What this PR does / why we need it**:
      Update Cluster Autoscaler manifest file to use new shell wrapper instead of directly calling CA binary (the wrapper is already included in current CA image). 
      Add params to improve logging.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      ffb071be
    • Kubernetes Submit Queue's avatar
      Merge pull request #42669 from curtisallen/update_dep_go-oidc · f5114ffa
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42802, 42927, 42669, 42988, 43012)
      
      update to latest version of coreos/go-oidc
      
      Includes updates that enable OIDC with OKTA as a IDP
      
      
      
      **What this PR does / why we need it**:
      Updates to the latest version of coreos/go-oidc
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # TBD
      
      **Special notes for your reviewer**:
      Updates coreos/go-oidc module to include fixes for https://github.com/coreos/go-oidc/issues/137 which prevent OKTA being used as an IDP
      **Release note**:
      
      ```release-note
      NONE
      ```
      
      cc:/ @ericchiang
      f5114ffa
    • Kubernetes Submit Queue's avatar
      Merge pull request #42927 from Random-Liu/fix-kubelet-panic · f1e9004d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42802, 42927, 42669, 42988, 43012)
      
      Fix kubelet panic in cgroup manager.
      
      Fixes https://github.com/kubernetes/kubernetes/issues/42920.
      Fixes https://github.com/kubernetes/kubernetes/issues/42875
      Fixes #42927 
      Fixes #43059
      
      Check the error in walk function, so that we don't use info when there is an error.
      
      @yujuhong @dchen1107 @derekwaynecarr @vishh /cc @kubernetes/sig-node-bugs
      f1e9004d
    • Kubernetes Submit Queue's avatar
      Merge pull request #42802 from lukaszo/typo · bebfdbb2
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42802, 42927, 42669, 42988, 43012)
      
      Fix typo in kubedns-controller.yaml.sed
      
      cc @MrHohn
      bebfdbb2
    • Joe Beda's avatar
      Use constant time compare for bootstrap tokens · c46d6bb8
      Joe Beda authored
      Signed-off-by: 's avatarJoe Beda <joe.github@bedafamily.com>
      c46d6bb8
    • Mike Danese's avatar
      33d0c483
    • Anirudh's avatar
      Fix StatefulSet apps flakes · bcc73dbe
      Anirudh authored
      bcc73dbe
  2. 13 Mar, 2017 22 commits