1. 03 Jun, 2017 10 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #46462 from vmware/vsphere-storage-metrics · 0d4fda77
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 41563, 45251, 46265, 46462, 46721)
      
      Add metric collections for vSphere cloud provider operations
      
      **What this PR does / why we need it**:
      This PR adds metric collections for vSphere Cloud Provider Operations.
      
      **Which issue this PR fixes** 
      fixes #
      
      **Special notes for your reviewer**:
      Verified Prometheus pod is able to scrape vSphere metrics from Kubernetes Controller’s URL.
      
      `providers/vsphere/vsphere.go` file is intentionally kept not formatted with gofmt, to keep diff review-able.
      
      After review is complete, I will apply the formatting. 
      
      **Release note**:
      
      ```release-note
      None
      ```
      
      @BaluDontu @tusharnt
      
      @gnufied Verified with executing various operations on the Kubernetes Cluster deployed using this change.
      
      ```
      $ curl -s 10.160.18.128:10252/metrics | grep "cloudprovider_vsphere"
      # HELP cloudprovider_vsphere_api_request_duration_seconds Latency of vsphere api call
      # TYPE cloudprovider_vsphere_api_request_duration_seconds histogram
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="AttachVolume",le="0.005"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="AttachVolume",le="0.01"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="AttachVolume",le="0.025"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="AttachVolume",le="0.05"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="AttachVolume",le="0.1"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="AttachVolume",le="0.25"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="AttachVolume",le="0.5"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="AttachVolume",le="1"} 1
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="AttachVolume",le="2.5"} 3
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="AttachVolume",le="5"} 3
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="AttachVolume",le="10"} 3
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="AttachVolume",le="+Inf"} 3
      cloudprovider_vsphere_api_request_duration_seconds_sum{request="AttachVolume"} 3.9742241939999996
      cloudprovider_vsphere_api_request_duration_seconds_count{request="AttachVolume"} 3
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="CreateVolume",le="0.005"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="CreateVolume",le="0.01"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="CreateVolume",le="0.025"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="CreateVolume",le="0.05"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="CreateVolume",le="0.1"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="CreateVolume",le="0.25"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="CreateVolume",le="0.5"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="CreateVolume",le="1"} 1
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="CreateVolume",le="2.5"} 1
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="CreateVolume",le="5"} 1
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="CreateVolume",le="10"} 1
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="CreateVolume",le="+Inf"} 1
      cloudprovider_vsphere_api_request_duration_seconds_sum{request="CreateVolume"} 0.920856776
      cloudprovider_vsphere_api_request_duration_seconds_count{request="CreateVolume"} 1
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DeleteVolume",le="0.005"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DeleteVolume",le="0.01"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DeleteVolume",le="0.025"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DeleteVolume",le="0.05"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DeleteVolume",le="0.1"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DeleteVolume",le="0.25"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DeleteVolume",le="0.5"} 2
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DeleteVolume",le="1"} 3
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DeleteVolume",le="2.5"} 3
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DeleteVolume",le="5"} 3
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DeleteVolume",le="10"} 3
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DeleteVolume",le="+Inf"} 3
      cloudprovider_vsphere_api_request_duration_seconds_sum{request="DeleteVolume"} 1.3301585450000002
      cloudprovider_vsphere_api_request_duration_seconds_count{request="DeleteVolume"} 3
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DetachVolume",le="0.005"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DetachVolume",le="0.01"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DetachVolume",le="0.025"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DetachVolume",le="0.05"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DetachVolume",le="0.1"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DetachVolume",le="0.25"} 0
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DetachVolume",le="0.5"} 1
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DetachVolume",le="1"} 4
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DetachVolume",le="2.5"} 6
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DetachVolume",le="5"} 6
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DetachVolume",le="10"} 6
      cloudprovider_vsphere_api_request_duration_seconds_bucket{request="DetachVolume",le="+Inf"} 6
      cloudprovider_vsphere_api_request_duration_seconds_sum{request="DetachVolume"} 5.350829375
      cloudprovider_vsphere_api_request_duration_seconds_count{request="DetachVolume"} 6
      # HELP cloudprovider_vsphere_api_request_errors vsphere Api errors
      # TYPE cloudprovider_vsphere_api_request_errors counter
      cloudprovider_vsphere_api_request_errors{request="DeleteVolume"} 4
      # HELP cloudprovider_vsphere_operation_duration_seconds Latency of vsphere operation call
      # TYPE cloudprovider_vsphere_operation_duration_seconds histogram
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="AttachVolumeOperation",le="0.005"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="AttachVolumeOperation",le="0.01"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="AttachVolumeOperation",le="0.025"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="AttachVolumeOperation",le="0.05"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="AttachVolumeOperation",le="0.1"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="AttachVolumeOperation",le="0.25"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="AttachVolumeOperation",le="0.5"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="AttachVolumeOperation",le="1"} 1
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="AttachVolumeOperation",le="2.5"} 3
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="AttachVolumeOperation",le="5"} 3
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="AttachVolumeOperation",le="10"} 3
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="AttachVolumeOperation",le="+Inf"} 3
      cloudprovider_vsphere_operation_duration_seconds_sum{operation="AttachVolumeOperation"} 4.732579923
      cloudprovider_vsphere_operation_duration_seconds_count{operation="AttachVolumeOperation"} 3
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeOperation",le="0.005"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeOperation",le="0.01"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeOperation",le="0.025"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeOperation",le="0.05"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeOperation",le="0.1"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeOperation",le="0.25"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeOperation",le="0.5"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeOperation",le="1"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeOperation",le="2.5"} 1
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeOperation",le="5"} 1
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeOperation",le="10"} 1
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeOperation",le="+Inf"} 1
      cloudprovider_vsphere_operation_duration_seconds_sum{operation="CreateVolumeOperation"} 1.2753096990000001
      cloudprovider_vsphere_operation_duration_seconds_count{operation="CreateVolumeOperation"} 1
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithPolicyOperation",le="0.005"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithPolicyOperation",le="0.01"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithPolicyOperation",le="0.025"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithPolicyOperation",le="0.05"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithPolicyOperation",le="0.1"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithPolicyOperation",le="0.25"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithPolicyOperation",le="0.5"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithPolicyOperation",le="1"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithPolicyOperation",le="2.5"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithPolicyOperation",le="5"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithPolicyOperation",le="10"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithPolicyOperation",le="+Inf"} 1
      cloudprovider_vsphere_operation_duration_seconds_sum{operation="CreateVolumeWithPolicyOperation"} 15.066558008
      cloudprovider_vsphere_operation_duration_seconds_count{operation="CreateVolumeWithPolicyOperation"} 1
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithRawVSANPolicyOperation",le="0.005"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithRawVSANPolicyOperation",le="0.01"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithRawVSANPolicyOperation",le="0.025"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithRawVSANPolicyOperation",le="0.05"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithRawVSANPolicyOperation",le="0.1"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithRawVSANPolicyOperation",le="0.25"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithRawVSANPolicyOperation",le="0.5"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithRawVSANPolicyOperation",le="1"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithRawVSANPolicyOperation",le="2.5"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithRawVSANPolicyOperation",le="5"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithRawVSANPolicyOperation",le="10"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="CreateVolumeWithRawVSANPolicyOperation",le="+Inf"} 2
      cloudprovider_vsphere_operation_duration_seconds_sum{operation="CreateVolumeWithRawVSANPolicyOperation"} 21.805354686
      cloudprovider_vsphere_operation_duration_seconds_count{operation="CreateVolumeWithRawVSANPolicyOperation"} 2
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DeleteVolumeOperation",le="0.005"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DeleteVolumeOperation",le="0.01"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DeleteVolumeOperation",le="0.025"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DeleteVolumeOperation",le="0.05"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DeleteVolumeOperation",le="0.1"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DeleteVolumeOperation",le="0.25"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DeleteVolumeOperation",le="0.5"} 1
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DeleteVolumeOperation",le="1"} 3
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DeleteVolumeOperation",le="2.5"} 3
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DeleteVolumeOperation",le="5"} 3
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DeleteVolumeOperation",le="10"} 3
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DeleteVolumeOperation",le="+Inf"} 3
      cloudprovider_vsphere_operation_duration_seconds_sum{operation="DeleteVolumeOperation"} 1.4869503179999999
      cloudprovider_vsphere_operation_duration_seconds_count{operation="DeleteVolumeOperation"} 3
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DetachVolumeOperation",le="0.005"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DetachVolumeOperation",le="0.01"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DetachVolumeOperation",le="0.025"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DetachVolumeOperation",le="0.05"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DetachVolumeOperation",le="0.1"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DetachVolumeOperation",le="0.25"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DetachVolumeOperation",le="0.5"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DetachVolumeOperation",le="1"} 2
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DetachVolumeOperation",le="2.5"} 6
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DetachVolumeOperation",le="5"} 6
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DetachVolumeOperation",le="10"} 6
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DetachVolumeOperation",le="+Inf"} 6
      cloudprovider_vsphere_operation_duration_seconds_sum{operation="DetachVolumeOperation"} 7.15601343
      cloudprovider_vsphere_operation_duration_seconds_count{operation="DetachVolumeOperation"} 6
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DiskIsAttachedOperation",le="0.005"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DiskIsAttachedOperation",le="0.01"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DiskIsAttachedOperation",le="0.025"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DiskIsAttachedOperation",le="0.05"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DiskIsAttachedOperation",le="0.1"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DiskIsAttachedOperation",le="0.25"} 1
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DiskIsAttachedOperation",le="0.5"} 2
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DiskIsAttachedOperation",le="1"} 3
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DiskIsAttachedOperation",le="2.5"} 3
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DiskIsAttachedOperation",le="5"} 3
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DiskIsAttachedOperation",le="10"} 3
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DiskIsAttachedOperation",le="+Inf"} 3
      cloudprovider_vsphere_operation_duration_seconds_sum{operation="DiskIsAttachedOperation"} 1.0603705730000001
      cloudprovider_vsphere_operation_duration_seconds_count{operation="DiskIsAttachedOperation"} 3
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DisksAreAttachedOperation",le="0.005"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DisksAreAttachedOperation",le="0.01"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DisksAreAttachedOperation",le="0.025"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DisksAreAttachedOperation",le="0.05"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DisksAreAttachedOperation",le="0.1"} 0
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DisksAreAttachedOperation",le="0.25"} 4
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DisksAreAttachedOperation",le="0.5"} 12
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DisksAreAttachedOperation",le="1"} 12
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DisksAreAttachedOperation",le="2.5"} 12
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DisksAreAttachedOperation",le="5"} 12
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DisksAreAttachedOperation",le="10"} 12
      cloudprovider_vsphere_operation_duration_seconds_bucket{operation="DisksAreAttachedOperation",le="+Inf"} 12
      cloudprovider_vsphere_operation_duration_seconds_sum{operation="DisksAreAttachedOperation"} 3.282661207
      cloudprovider_vsphere_operation_duration_seconds_count{operation="DisksAreAttachedOperation"} 12
      # HELP cloudprovider_vsphere_operation_errors vsphere operation errors
      # TYPE cloudprovider_vsphere_operation_errors counter
      cloudprovider_vsphere_operation_errors{operation="DeleteVolumeOperation"} 4
      ```
      0d4fda77
    • Kubernetes Submit Queue's avatar
      Merge pull request #46265 from waseem/printers-genericity · 2629bf79
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 41563, 45251, 46265, 46462, 46721)
      
      Denote if a printer is generic.
      
      This fixes #38779.
      
      This allows us to avoid case in which printers.GetStandardPrinter
      returns nil for both printer and err removing any potential panics that
      may arise throughout kubectl commands.
      
      Please see #38779 and #38112 for complete context.
      2629bf79
    • Kubernetes Submit Queue's avatar
      Merge pull request #45251 from gyliu513/taint-typo · 284132ee
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 41563, 45251, 46265, 46462, 46721)
      
      Toleration should be `notReady:NoExecute` in defaulttolerationseconds…
      
      … test.
      
      
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      284132ee
    • Kubernetes Submit Queue's avatar
      Merge pull request #41563 from gyliu513/kubelet-util · b68b4aeb
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Improved code coverage for pkg/kubelet/util.
      
      The test coverage for pkg/kubelet/util.go increased from 45.1%
      to 84.3%.
      
      
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      b68b4aeb
    • Kubernetes Submit Queue's avatar
      Merge pull request #46649 from monopole/addToOwnersForBuildFiles · abe63a18
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add jregan to OWNERS for kubectl isolation work.
      
      The kubectl decoupling project (#598) requires many BUILD edits.
      
      Even relatively simple PR's involve many OWNER files, e.g. #46317 involves five.
      
      We plan to script-generate some PRs, and those may involve _hundreds_ of BUILD files.
      
      This project will take many PRs, and collecting all approvals for each will be very time consuming.
      
      **Release note**:
      ```release-note
      NONE
      ```
      abe63a18
    • Kubernetes Submit Queue's avatar
      Merge pull request #45563 from perotinus/rssyncconversion · 77710c41
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46801, 45184, 45930, 46192, 45563)
      
      [Federation] Add a SchedulingAdapter that can extend the FederatedTypeAdapter and that provides hooks for scheduling objects into clusters.
      
      **Release note**:
      ```release-note
      NONE
      ```
      77710c41
    • Kubernetes Submit Queue's avatar
      Merge pull request #46192 from cblecker/verify-dockerized · 5bf5d45c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46801, 45184, 45930, 46192, 45563)
      
      Exclude dockerized verify patterns
      
      **What this PR does / why we need it**:
      Change some of the `make verify` logic to allow excluding based on a pattern. Add the `verify-*-dockerized.sh` pattern to the excluded list.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      5bf5d45c
    • Kubernetes Submit Queue's avatar
      Merge pull request #45930 from x1957/addlog · f294b535
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46801, 45184, 45930, 46192, 45563)
      
      adds log  when --kubeconfig with wrong config
      
      **What this PR does / why we need it**:
      easy for troubleshooting
      I have set --kubeconfig==/etc/kubernetes/kubelet.conf when copy & paste(the file path is wrong “==/etc/kubernetes/kubelet.conf”), but kubelet start with no error log. I don't know what happend.
      **Release note**:
      
      ```release-note
      NONE
      ```
      f294b535
    • Kubernetes Submit Queue's avatar
      Merge pull request #45184 from DirectXMan12/feature/metrics-client-gen-tweaks · caead741
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46801, 45184, 45930, 46192, 45563)
      
      Tweak client-gen to support metrics API
      
      This PR adds support to client-gen for readonly APIs as well as for customizing the resource name used for a given type.
      
      This is required to support the clients generated for `k8s.io/metrics/pkg/apis/metrics`.
      
      cc @caesarxuchao 
      
      Currently based on #45180
      
      **Release note**:
      ```release-note
      NONE
      ```
      caead741
    • Kubernetes Submit Queue's avatar
      Merge pull request #46801 from dashpole/summary_container_restart · d063ce21
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      [Flaky PR Test] Fix summary test
      
      fixes issue: #46797 
      
      As we can see in the [example failure build log](https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-node-kubelet/4319/build-log.txt), the summary containers are pinging google 100s of times a second.  This causes the summary container to be killed occasionally, and fail the test.  The summary containers are only supposed to ping every 10 seconds according to the current test.  As it turns out, we were missing a semicolon, and were not sleeping between pings.  For background, we ping google to generate network traffic, so that the summary test can validate network metrics.
      
      This PR adds the semicolon to make the container sleep between calls, and decreases the sleep time from 10 seconds to 1 second, as 1 call / 10 seconds did not produce enough activity.
      
      cc @kubernetes/kubernetes-build-cops @dchen1107
      d063ce21
  2. 02 Jun, 2017 14 commits
  3. 01 Jun, 2017 16 commits