- 25 Apr, 2017 33 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Cleanup: replace some hardcoded vars and remove unused functions Replace some hardcoded vars and remove unused functions **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue fix kubeadm init when certdir changed If --cert-dir specified, `kubeadm init` failed.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 42477, 44462) fix cluster scoped self-link Might fix #37622, definitely fixes the cluster-scoped resource problem. Looks like it was just a typo when compared against https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/endpoints/installer.go#L451 @adohe @DirectXMan12
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 42477, 44462) Use storage.v1 instead of v1beta1 storage.v1beta1 was used to work around GKE which did not expose v1. Now that GKE is updated, we can switch everything to v1. This is simple sed v1beta1 -> v1 + enabled a new test + changed preference of exposed interfaces in `storage/install/install.go`. @msau42, PTAL and let me know when GKE is updated with storage v1 API and this PR can be actually merged. @kubernetes/sig-storage-pr-reviews ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fixed a tiny issue for ShortHumanDuration printer. Fixed a tiny issue for ShortHumanDuration printer to avoid "0y" message. Fixed #44599
-
deads2k authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue remove resourcename validation in create role @liggitt Since #44659 is not correct. I think we should fix the validation in create role command.
-
Jan Safranek authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add namespace-{list, create, delete} actions to the kubernetes-master layer **What this PR does / why we need it**: This PR adds namespace-{list,create,delete} actions to the juju kubernetes-master layer. **Which issue this PR fixes**: fixes #43712 **Special notes for your reviewer**: Original PR https://github.com/juju-solutions/kubernetes/pull/109 **Release note**: ``` Add namespace-{list,create,delete} actions to the juju kubernetes-master layer ``` -
Kubernetes Submit Queue authored
Automatic merge from submit-queue Increase code coverage for pkg/api/resource Increases coverage to 81.3% of statements as part of issue #39559 Not particularly happy with the tests in quantity_proto_test.go so am happy to remove them if they aren't up to scratch. Signed-off-by:Liam White <liamwhite@uk.ibm.com>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 44853, 44572, 44797, 44439, 44902) Revert "[Federation] Build a simple hyperkube image on-the-fly only containing the hyperkube binary for development and testing purposes." Reverts kubernetes/kubernetes#43181 Federation CI and PR tests are completely broken. No time to root cause this, but the merge time of PR #43181 and failures match. So we are going to try by reverting this.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 44741, 44853, 44572, 44797, 44439) controller: fix saturation check in Deployments Fixes https://github.com/kubernetes/kubernetes/issues/44436 @kubernetes/sig-apps-bugs I'll cherry-pick this back to 1.6 and 1.5
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 44741, 44853, 44572, 44797, 44439) Check errors before logging providers The logProviders() should check errors firstly, and do not log providers when providers is null.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 44741, 44853, 44572, 44797, 44439) add tests for managed hosts file content **What this PR does / why we need it**: a tiny refactor to separate concerns host file content from the logic ensuring that the file exists, and also adds unit test. This is to prepare extending the host file logic to include customized entries described in https://github.com/kubernetes/kubernetes/issues/43632. I'm wary of changing that logic in absence of any unit tests. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 44741, 44853, 44572, 44797, 44439) Print executed cmd in cluster autoscaler e2e tests cc: @MaciekPytel @fgrzadkowski
-
Jan Safranek authored
storage.v1beta1 was used to work around GKE which does not expose v1. Now that GKE is updated, we can switch everything to v1.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Refine ESIPP validation logic in validation.go Separated from #41162. The previous ESIPP validation logic in validation.go has a huge overlap with [function healthCheckNodePortUpdate in service/rest.go](https://github.com/kubernetes/kubernetes/blob/870585e8e1ca1133a67d4d44bfd4a9722b2b93c7/pkg/registry/core/service/rest.go#L283-L373), in which we reject any invalid modifications on ESIPP annotations. This PR removes the overlap, and make validation.go only check if values are legal and whether user mixes different API versions (alpha & beta). We are indeed removing the alpha annotation support, but it is kept in the codes for the ease of transiting the same logic onto beta/GA. /assign @thockin @freehan **Release note**: ```release-note NONE ```
-
Liam White authored
Signed-off-by:Liam White <liamwhite@uk.ibm.com>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Move remain ESIPP tests to the slow suite Continue PR of #38149. It moves the remain ESIPP tests to the slow suite to help capture breaking changes. /assign @thockin @freehan **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40060, 44860, 44865, 44825, 44162) Clarify kubelet cert flag usage
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40060, 44860, 44865, 44825, 44162) Remove unused chmod/chown abstractions **What this PR does / why we need it**: Simplifies the code **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40060, 44860, 44865, 44825, 44162) Validate etcd only when expecting to run etcd If running kubelet only, there is no need to validate etcd as the script will not attempt to start etcd. In fact, validating etcd here may cause the script to fail when one wants to run "nokubelet" right before "kubeletonly" because etcd will definitely be running ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40060, 44860, 44865, 44825, 44162) Bump Cluster Autoscaler to 0.5.2 Fixes PVC issue in Cluster Autoscaler (kubernetes/contrib#2507). cc: @MaciekPytel @fgrzadkowski
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40060, 44860, 44865, 44825, 44162) servicecontroller: remove unused zone field The zone field was unused, and this complicated e.g. #39996 ```release-note NONE ```
-
Madhusudan.C.S authored
Revert "[Federation] Build a simple hyperkube image on-the-fly only containing the hyperkube binary for development and testing purposes."
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add --all support for view-last-applied Fixes https://github.com/kubernetes/kubernetes/issues/44195 sorry for my careless, and thanks for the review, @ymqytw ptal
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 44862, 42241, 42101, 43181, 44147) Update limitedByDefault() which does not return error The limitedByDefault() just get the set of resources names, no error.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 44862, 42241, 42101, 43181, 44147) [Federation] Build a simple hyperkube image on-the-fly only containing the hyperkube binary for development and testing purposes. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 44862, 42241, 42101, 43181, 44147) Feature/hpa upscale downscale delay configurable **What this PR does / why we need it**: Makes "upscale forbidden window" and "downscale forbidden window" duration configurable in arguments of kube-controller-manager. Those are options of horizontal pod autoscaler. **Special notes for your reviewer**: Please have a look @DirectXMan12 , the PR as discussed in Slack. **Release note**: ``` Make "upscale forbidden window" and "downscale forbidden window" duration configurable in arguments of kube-controller-manager. Those are options of horizontal pod autoscaler. Right now are hardcoded 3 minutes for upscale, and 5 minutes to downscale. But sometimes cluster administrator might want to change this for his own needs. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 44862, 42241, 42101, 43181, 44147) Add short name "netpol" for networkpolicies **What this PR does / why we need it**: Add short name for `networkpolicies` in kubectl command for good user experience. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # None **Special notes for your reviewer**: None **Release note**: ```release-note Add short name "netpol" for networkpolicies ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Stop treating in-cluster-config namespace as an override Fixes #44835 The namespace of an in-cluster config should behave like the namespace specified in a kubeconfig file... it should be used as the default namespace, but be able to be overridden by namespaces specified in yaml files passed to `kubectl create -f`. ```release-note Restored the ability of kubectl running inside a pod to consume resource files specifying a different namespace than the one the pod is running in. ```
-
NickrenREN authored
-
xilabao authored
-
- 24 Apr, 2017 7 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue add EditOptions to make edit reusable FYI. Added `EditOptions` to decouple edit implementation from cobra command, thus make edit reusable. Once this get merged, we can refactor `create` commands to put them in their own package. @kubernetes/sig-cli-misc please give a quick review, and I would like to get this merged asap.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 44788, 44859) e2e: handle nil ReplicaSet in checkDeploymentRevision
-
Ricky Pai authored
add tests to assert the output of `ensureHostsFile`
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue PATCH: Fix erroneous meaningful conflict for numeric values. The wrong json package was used, resulting in patches being unmarshaled with numbers as float64 rather than int64. This in turn confused `HasConflicts()` which expects numeric types to match. The end result was false positives of meaningful conflicts, such as: ``` there is a meaningful conflict (firstResourceVersion: "8517", currentResourceVersion: "8519"): diff1={"metadata":{"resourceVersion":"8519"},"spec":{"replicas":0},"status":"conditions":null,"fullyLabeledReplicas":null,"replicas":0}} , diff2={"spec":{"replicas":0}} ``` This is branched from a discussion on https://github.com/kubernetes/kubernetes/pull/43469. ```release-note Fix false positive "meaningful conflict" detection for strategic merge patch with integer values. ``` -
Jordan Liggitt authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Document the NodePort workflow for kubernetes-worker closes https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/259 NodePort networking model has no daemon listening to lend a hand so any NodePort services will need to be manually declared and exposed. **What this PR does / why we need it**: Updates the documentation around using NodePort networking with the kubernetes-worker charm. **Special notes for your reviewer**: This is a working fix for using NodePort style networking with kubernetes-workers in the juju ecosystem. Declaring a simple workload as type NodePort, then following the updated documentation will make it reachable via the open-world network connection. **Release note**: ```release-note Documented NodePort networking for CDK. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 43575, 44672) Update deployment and daemonset completeness checks maxUnavailable being taken into account for deployment completeness has caused a lot of confusion (https://github.com/kubernetes/kubernetes/issues/44395, https://github.com/kubernetes/kubernetes/issues/44657, https://github.com/kubernetes/kubernetes/issues/40496, others as well I am sure) so I am willing to just stop using it and require all of the new Pods for a Deployment to be available for the Deployment to be considered complete (hence both `rollout status` and ProgressDeadlineSeconds will not be successful in cases where a 1-pod Deployment never becomes successful because its Pod never transitions to ready). @kubernetes/sig-apps-api-reviews thoughts? ```release-note Deployments and DaemonSets are now considered complete once all of the new pods are up and running - affects `kubectl rollout status` (and ProgressDeadlineSeconds for Deployments) ``` Fixes https://github.com/kubernetes/kubernetes/issues/44395
-