1. 08 Sep, 2017 15 commits
    • Seth Jennings's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #51505 from atlassian/fix-unstructured-converter · a4165347
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix pointer receivers handling in unstructured converter
      
      **What this PR does / why we need it**:
      Fixes unstructured converter to properly handle types that have `MarshalJSON()` implemented with a pointer receiver. In particular the converter now can roundtrip `*Unstructured` type.
      
      **Which issue this PR fixes**:
      Fixes #47889. Similar to #43346.
      
      **Special notes for your reviewer**:
      Without the fix the tests are failing:
      ```console
      make test WHAT=./vendor/k8s.io/apimachinery/pkg/conversion/unstructured
      
      Running tests for APIVersion: v1,admissionregistration.k8s.io/v1alpha1,admission.k8s.io/v1alpha1,apps/v1beta1,apps/v1beta2,authentication.k8s.io/v1,authentication.k8s.io/v1beta1,authorization.k8s.io/v1,authorization.k8s.io/v1beta1,autoscaling/v1,autoscaling/v2alpha1,batch/v1,batch/v1beta1,batch/v2alpha1,certificates.k8s.io/v1beta1,extensions/v1beta1,imagepolicy.k8s.io/v1alpha1,networking.k8s.io/v1,policy/v1beta1,rbac.authorization.k8s.io/v1,rbac.authorization.k8s.io/v1beta1,rbac.authorization.k8s.io/v1alpha1,scheduling.k8s.io/v1alpha1,settings.k8s.io/v1alpha1,storage.k8s.io/v1beta1,storage.k8s.io/v1,,federation/v1beta1
      +++ [0829 16:39:36] Running tests without code coverage
      --- FAIL: TestCustomToUnstructured (0.00s)
          --- FAIL: TestCustomToUnstructured/false (0.00s)
              Error Trace:    converter_test.go:500
              Error:          Not equal:
                              expected: bool(false)
                              actual: map[string]interface {}(map[string]interface {}{"data":"ZmFsc2U="})
              Messages:       customPointer1
          --- FAIL: TestCustomToUnstructured/[1] (0.00s)
              Error Trace:    converter_test.go:500
              Error:          Not equal:
                              expected: []interface {}([]interface {}{1})
                              actual: map[string]interface {}(map[string]interface {}{"data":"WzFd"})
              Messages:       customPointer1
          --- FAIL: TestCustomToUnstructured/true (0.00s)
              Error Trace:    converter_test.go:500
              Error:          Not equal:
                              expected: bool(true)
                              actual: map[string]interface {}(map[string]interface {}{"data":"dHJ1ZQ=="})
              Messages:       customPointer1
          --- FAIL: TestCustomToUnstructured/0 (0.00s)
              Error Trace:    converter_test.go:500
              Error:          Not equal:
                              expected: int64(0)
                              actual: map[string]interface {}(map[string]interface {}{"data":"MA=="})
              Messages:       customPointer1
          --- FAIL: TestCustomToUnstructured/null (0.00s)
              Error Trace:    converter_test.go:500
              Error:          Not equal:
                              expected: <nil>(<nil>)
                              actual: map[string]interface {}(map[string]interface {}{"data":"bnVsbA=="})
              Messages:       customPointer1
          --- FAIL: TestCustomToUnstructured/[] (0.00s)
              Error Trace:    converter_test.go:500
              Error:          Not equal:
                              expected: []interface {}([]interface {}{})
                              actual: map[string]interface {}(map[string]interface {}{"data":"W10="})
              Messages:       customPointer1
          --- FAIL: TestCustomToUnstructured/{"a":1} (0.00s)
              Error Trace:    converter_test.go:500
              Error:          Not equal:
                              expected: map[string]interface {}{"a":1}
                              actual: map[string]interface {}{"data":"eyJhIjoxfQ=="}
      
                              Diff:
                              --- Expected
                              +++ Actual
                              @@ -1,3 +1,3 @@
                               (map[string]interface {}) (len=1) {
                              - (string) (len=1) "a": (int64) 1
                              + (string) (len=4) "data": (string) (len=12) "eyJhIjoxfQ=="
                               }
              Messages:       customPointer1
          --- FAIL: TestCustomToUnstructured/0.0 (0.00s)
              Error Trace:    converter_test.go:500
              Error:          Not equal:
                              expected: float64(0)
                              actual: map[string]interface {}(map[string]interface {}{"data":"MC4w"})
              Messages:       customPointer1
          --- FAIL: TestCustomToUnstructured/{} (0.00s)
              Error Trace:    converter_test.go:500
              Error:          Not equal:
                              expected: map[string]interface {}{}
                              actual: map[string]interface {}{"data":"e30="}
      
                              Diff:
                              --- Expected
                              +++ Actual
                              @@ -1,2 +1,3 @@
                              -(map[string]interface {}) {
                              +(map[string]interface {}) (len=1) {
                              + (string) (len=4) "data": (string) (len=4) "e30="
                               }
              Messages:       customPointer1
      --- FAIL: TestCustomToUnstructuredTopLevel (0.00s)
          --- FAIL: TestCustomToUnstructuredTopLevel/1 (0.00s)
              Error Trace:    converter_test.go:519
              Error:          Not equal:
                              expected: map[string]interface {}{"a":1}
                              actual: map[string]interface {}{"data":"eyJhIjoxfQ=="}
      
                              Diff:
                              --- Expected
                              +++ Actual
                              @@ -1,3 +1,3 @@
                               (map[string]interface {}) (len=1) {
                              - (string) (len=1) "a": (int64) 1
                              + (string) (len=4) "data": (string) (len=12) "eyJhIjoxfQ=="
                               }
      FAIL
      FAIL    k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/conversion/unstructured    0.047s
      make: *** [test] Error 1
      ```
      
      ```console
      make test WHAT=./vendor/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured
      
      Running tests for APIVersion: v1,admissionregistration.k8s.io/v1alpha1,admission.k8s.io/v1alpha1,apps/v1beta1,apps/v1beta2,authentication.k8s.io/v1,authentication.k8s.io/v1beta1,authorization.k8s.io/v1,authorization.k8s.io/v1beta1,autoscaling/v1,autoscaling/v2alpha1,batch/v1,batch/v1beta1,batch/v2alpha1,certificates.k8s.io/v1beta1,extensions/v1beta1,imagepolicy.k8s.io/v1alpha1,networking.k8s.io/v1,policy/v1beta1,rbac.authorization.k8s.io/v1,rbac.authorization.k8s.io/v1beta1,rbac.authorization.k8s.io/v1alpha1,scheduling.k8s.io/v1alpha1,settings.k8s.io/v1alpha1,storage.k8s.io/v1beta1,storage.k8s.io/v1,,federation/v1beta1
      +++ [0829 16:40:38] Running tests without code coverage
      --- FAIL: TestConversionRoundtrip (0.00s)
          unstructured_test.go:111: FromUnstructured failed: Object 'Kind' is missing in '{"object":{"apiVersion":"v1","kind":"Foo","metadata":{"name":"foo1"}}}'
      FAIL
      FAIL    k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured  0.046s
      make: *** [test] Error 1
      ```
      
      **Release note**:
      ```release-note
      NONE
      ```
      /kind bug
      /sig api-machinery
      a4165347
    • Kubernetes Submit Queue's avatar
      Merge pull request #52071 from CaoShuFeng/warning · 50064260
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52091, 52071)
      
      Log a warning when --audit-policy-file not passed to apiserver
      
      When audit backend provided, but --audit-policy-file is not passed, leave a info in log.
      **Release note**:
      ```
      Log a warning when --audit-policy-file not passed to apiserver
      ```
      50064260
    • Kubernetes Submit Queue's avatar
      Merge pull request #52091 from clamoriniere1A/bugfix/jobcontroller_backoff · 26d72847
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52091, 52071)
      
      Bugfix: Improve how JobController use queue for backoff
      
      **What this PR does / why we need it**:
      
      In some cases,  the backoff delay for a given Job is reset unnecessarily. 
      
      the PR improves how JobController uses queue for backoff:
      - Centralize the key "forget" and "re-queue" process in only on method.
      - Change the signature of the syncJob method in order to return the
      information if it is necessary to forget the backoff delay for a given
      key.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      Links to #51153
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      26d72847
    • Mikhail Mazurskiy's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #51932 from dixudx/fix_forbidden_messages · 45fe0a9e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      fix format of forbidden messages
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #51813
      
      **Special notes for your reviewer**:
      /assign @deads2k @liggitt 
      
      **Release note**:
      
      ```release-note
      None
      ```
      45fe0a9e
    • Kubernetes Submit Queue's avatar
      Merge pull request #51876 from smarterclayton/disable_client_paging · eda3db55
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48552, 51876)
      
      Disable default paging in list watches
      
      For 1.8 this will be off by default. In 1.9 it will be on by default.
      Add tests and rename some fields to use the `chunking` terminology.
      
      Note that the pager may be used for other things besides chunking.
      
      Follow on to #48921, we left the field on to get some exercise in the normal code paths, but needs to be disabled for 1.8.
      
      @liggitt let's merge on wednesday.
      eda3db55
    • Cao Shufeng's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #48552 from mkumatag/pets · 0103ed33
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Multiarch support for pets images
      
      **What this PR does / why we need it**:
      This PR is for multiarch support for pets image
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #52133
      
      **Special notes for your reviewer**:
      Copied over the `contrib/pets/peer-finder` as this one is heavily used in many docker images under `test/images`. After this PR I'll submit the PR in contrib project to remove it.
      
      **Release note**:
      
      ```NONE
      ```
      0103ed33
    • Kubernetes Submit Queue's avatar
      Merge pull request #52104 from nicksardo/gce-ilb-capture-err-msg · 409dc44c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      GCE: Bubble IP reservation error to the user when the address is specified.
      
      This PR improves the debug-ability of internal load balancers when an IP fails to be reserved. I'm mostly worried about the case when the subnetwork URL is wrong or referencing a shared network from another project which isn't yet supported. As you can see from line 160, I had originally planned to surface the reservation error, but printed the wrong error. 
      
      **Special notes for your reviewer**:
      /assign @yujuhong 
      
      Please apply 1.8 milestone.
      
      **Release note**:
      ```release-note
      NONE
      ```
      409dc44c
    • Kubernetes Submit Queue's avatar
      Merge pull request #52111 from MrHohn/kube-proxy-upgrade-image · ad0d36f0
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Pipe in upgrade image target for kube-proxy migration tests
      
      **What this PR does / why we need it**:
      https://k8s-testgrid.appspot.com/sig-network#gci-gce-latest-upgrade-kube-proxy-ds&width=20
      and
      https://k8s-testgrid.appspot.com/sig-network#gci-gce-latest-downgrade-kube-proxy-ds&width=20
      are still failing.
      
      Reproduced it locally and found node image is being default to debian during upgrade (it was gci before upgrade) because we don't pass in `gci` via `--upgrade--target`. And for some reasons (haven't figured out yet), the upgraded node uses debian image with gci startupscripts...
      
      This PR pipes in `--upgrade-target` for kube-proxy migration tests, hopefully in conjunction with https://github.com/kubernetes/test-infra/pull/4447 it will bring the tests back to normal.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #NONE 
      
      **Special notes for your reviewer**:
      Sorry for bothering again.
      /assign @krousey 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      ad0d36f0
    • Kubernetes Submit Queue's avatar
      Merge pull request #52042 from mengqiy/revert_update_vendor · c16ff84e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Revert update vendor kube-openapi
      
      Revert https://github.com/kubernetes/kubernetes/pull/51762 since https://github.com/kubernetes/kubernetes/pull/51321 are not going to get in this release.
      
      Will revert https://github.com/kubernetes/kube-openapi/pull/10 after this PR merged.
      
      fixes: #52135
      
      ```release-note
      NONE
      ```
      
      /assign @apelisse @liggitt
      c16ff84e
    • Adam Worrall's avatar
      Update CHANGELOG.md for v1.8.0-beta.1. · 92e1f446
      Adam Worrall authored
      92e1f446
    • Di Xu's avatar
      fix format of forbidden messages · 95738d5a
      Di Xu authored
      95738d5a
    • Kubernetes Submit Queue's avatar
      Merge pull request #52116 from ixdy/gcloud-regexp-flag-fix · 8ed63636
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Convert deprecated gcloud --regexp flag into --filter
      
      **What this PR does / why we need it**: #49673 missed a flag in hiding:
      ```console
      WARNING: Flag --regexp is deprecated. Use --filter="name~'REGEXP'" instead.
      ERROR: gcloud crashed (TypeError): 'NoneType' object is not iterable
      
      If you would like to report this issue, please run the following command:
        gcloud feedback
      
      To check gcloud for common problems, please run the following command:
        gcloud info --run-diagnostics
      ```
      
      (Also it's great how gcloud crashes, rather than handling the deprecation gracefully.)
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49673
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      
      cc @pci
      8ed63636
  2. 07 Sep, 2017 25 commits