- 08 Sep, 2017 15 commits
-
-
Seth Jennings authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix pointer receivers handling in unstructured converter **What this PR does / why we need it**: Fixes unstructured converter to properly handle types that have `MarshalJSON()` implemented with a pointer receiver. In particular the converter now can roundtrip `*Unstructured` type. **Which issue this PR fixes**: Fixes #47889. Similar to #43346. **Special notes for your reviewer**: Without the fix the tests are failing: ```console make test WHAT=./vendor/k8s.io/apimachinery/pkg/conversion/unstructured Running tests for APIVersion: v1,admissionregistration.k8s.io/v1alpha1,admission.k8s.io/v1alpha1,apps/v1beta1,apps/v1beta2,authentication.k8s.io/v1,authentication.k8s.io/v1beta1,authorization.k8s.io/v1,authorization.k8s.io/v1beta1,autoscaling/v1,autoscaling/v2alpha1,batch/v1,batch/v1beta1,batch/v2alpha1,certificates.k8s.io/v1beta1,extensions/v1beta1,imagepolicy.k8s.io/v1alpha1,networking.k8s.io/v1,policy/v1beta1,rbac.authorization.k8s.io/v1,rbac.authorization.k8s.io/v1beta1,rbac.authorization.k8s.io/v1alpha1,scheduling.k8s.io/v1alpha1,settings.k8s.io/v1alpha1,storage.k8s.io/v1beta1,storage.k8s.io/v1,,federation/v1beta1 +++ [0829 16:39:36] Running tests without code coverage --- FAIL: TestCustomToUnstructured (0.00s) --- FAIL: TestCustomToUnstructured/false (0.00s) Error Trace: converter_test.go:500 Error: Not equal: expected: bool(false) actual: map[string]interface {}(map[string]interface {}{"data":"ZmFsc2U="}) Messages: customPointer1 --- FAIL: TestCustomToUnstructured/[1] (0.00s) Error Trace: converter_test.go:500 Error: Not equal: expected: []interface {}([]interface {}{1}) actual: map[string]interface {}(map[string]interface {}{"data":"WzFd"}) Messages: customPointer1 --- FAIL: TestCustomToUnstructured/true (0.00s) Error Trace: converter_test.go:500 Error: Not equal: expected: bool(true) actual: map[string]interface {}(map[string]interface {}{"data":"dHJ1ZQ=="}) Messages: customPointer1 --- FAIL: TestCustomToUnstructured/0 (0.00s) Error Trace: converter_test.go:500 Error: Not equal: expected: int64(0) actual: map[string]interface {}(map[string]interface {}{"data":"MA=="}) Messages: customPointer1 --- FAIL: TestCustomToUnstructured/null (0.00s) Error Trace: converter_test.go:500 Error: Not equal: expected: <nil>(<nil>) actual: map[string]interface {}(map[string]interface {}{"data":"bnVsbA=="}) Messages: customPointer1 --- FAIL: TestCustomToUnstructured/[] (0.00s) Error Trace: converter_test.go:500 Error: Not equal: expected: []interface {}([]interface {}{}) actual: map[string]interface {}(map[string]interface {}{"data":"W10="}) Messages: customPointer1 --- FAIL: TestCustomToUnstructured/{"a":1} (0.00s) Error Trace: converter_test.go:500 Error: Not equal: expected: map[string]interface {}{"a":1} actual: map[string]interface {}{"data":"eyJhIjoxfQ=="} Diff: --- Expected +++ Actual @@ -1,3 +1,3 @@ (map[string]interface {}) (len=1) { - (string) (len=1) "a": (int64) 1 + (string) (len=4) "data": (string) (len=12) "eyJhIjoxfQ==" } Messages: customPointer1 --- FAIL: TestCustomToUnstructured/0.0 (0.00s) Error Trace: converter_test.go:500 Error: Not equal: expected: float64(0) actual: map[string]interface {}(map[string]interface {}{"data":"MC4w"}) Messages: customPointer1 --- FAIL: TestCustomToUnstructured/{} (0.00s) Error Trace: converter_test.go:500 Error: Not equal: expected: map[string]interface {}{} actual: map[string]interface {}{"data":"e30="} Diff: --- Expected +++ Actual @@ -1,2 +1,3 @@ -(map[string]interface {}) { +(map[string]interface {}) (len=1) { + (string) (len=4) "data": (string) (len=4) "e30=" } Messages: customPointer1 --- FAIL: TestCustomToUnstructuredTopLevel (0.00s) --- FAIL: TestCustomToUnstructuredTopLevel/1 (0.00s) Error Trace: converter_test.go:519 Error: Not equal: expected: map[string]interface {}{"a":1} actual: map[string]interface {}{"data":"eyJhIjoxfQ=="} Diff: --- Expected +++ Actual @@ -1,3 +1,3 @@ (map[string]interface {}) (len=1) { - (string) (len=1) "a": (int64) 1 + (string) (len=4) "data": (string) (len=12) "eyJhIjoxfQ==" } FAIL FAIL k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/conversion/unstructured 0.047s make: *** [test] Error 1 ``` ```console make test WHAT=./vendor/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured Running tests for APIVersion: v1,admissionregistration.k8s.io/v1alpha1,admission.k8s.io/v1alpha1,apps/v1beta1,apps/v1beta2,authentication.k8s.io/v1,authentication.k8s.io/v1beta1,authorization.k8s.io/v1,authorization.k8s.io/v1beta1,autoscaling/v1,autoscaling/v2alpha1,batch/v1,batch/v1beta1,batch/v2alpha1,certificates.k8s.io/v1beta1,extensions/v1beta1,imagepolicy.k8s.io/v1alpha1,networking.k8s.io/v1,policy/v1beta1,rbac.authorization.k8s.io/v1,rbac.authorization.k8s.io/v1beta1,rbac.authorization.k8s.io/v1alpha1,scheduling.k8s.io/v1alpha1,settings.k8s.io/v1alpha1,storage.k8s.io/v1beta1,storage.k8s.io/v1,,federation/v1beta1 +++ [0829 16:40:38] Running tests without code coverage --- FAIL: TestConversionRoundtrip (0.00s) unstructured_test.go:111: FromUnstructured failed: Object 'Kind' is missing in '{"object":{"apiVersion":"v1","kind":"Foo","metadata":{"name":"foo1"}}}' FAIL FAIL k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured 0.046s make: *** [test] Error 1 ``` **Release note**: ```release-note NONE ``` /kind bug /sig api-machinery -
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52091, 52071) Log a warning when --audit-policy-file not passed to apiserver When audit backend provided, but --audit-policy-file is not passed, leave a info in log. **Release note**: ``` Log a warning when --audit-policy-file not passed to apiserver ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52091, 52071) Bugfix: Improve how JobController use queue for backoff **What this PR does / why we need it**: In some cases, the backoff delay for a given Job is reset unnecessarily. the PR improves how JobController uses queue for backoff: - Centralize the key "forget" and "re-queue" process in only on method. - Change the signature of the syncJob method in order to return the information if it is necessary to forget the backoff delay for a given key. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Links to #51153 **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Mikhail Mazurskiy authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue fix format of forbidden messages **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #51813 **Special notes for your reviewer**: /assign @deads2k @liggitt **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48552, 51876) Disable default paging in list watches For 1.8 this will be off by default. In 1.9 it will be on by default. Add tests and rename some fields to use the `chunking` terminology. Note that the pager may be used for other things besides chunking. Follow on to #48921, we left the field on to get some exercise in the normal code paths, but needs to be disabled for 1.8. @liggitt let's merge on wednesday.
-
Cao Shufeng authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Multiarch support for pets images **What this PR does / why we need it**: This PR is for multiarch support for pets image **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #52133 **Special notes for your reviewer**: Copied over the `contrib/pets/peer-finder` as this one is heavily used in many docker images under `test/images`. After this PR I'll submit the PR in contrib project to remove it. **Release note**: ```NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue GCE: Bubble IP reservation error to the user when the address is specified. This PR improves the debug-ability of internal load balancers when an IP fails to be reserved. I'm mostly worried about the case when the subnetwork URL is wrong or referencing a shared network from another project which isn't yet supported. As you can see from line 160, I had originally planned to surface the reservation error, but printed the wrong error. **Special notes for your reviewer**: /assign @yujuhong Please apply 1.8 milestone. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Pipe in upgrade image target for kube-proxy migration tests **What this PR does / why we need it**: https://k8s-testgrid.appspot.com/sig-network#gci-gce-latest-upgrade-kube-proxy-ds&width=20 and https://k8s-testgrid.appspot.com/sig-network#gci-gce-latest-downgrade-kube-proxy-ds&width=20 are still failing. Reproduced it locally and found node image is being default to debian during upgrade (it was gci before upgrade) because we don't pass in `gci` via `--upgrade--target`. And for some reasons (haven't figured out yet), the upgraded node uses debian image with gci startupscripts... This PR pipes in `--upgrade-target` for kube-proxy migration tests, hopefully in conjunction with https://github.com/kubernetes/test-infra/pull/4447 it will bring the tests back to normal. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #NONE **Special notes for your reviewer**: Sorry for bothering again. /assign @krousey **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Revert update vendor kube-openapi Revert https://github.com/kubernetes/kubernetes/pull/51762 since https://github.com/kubernetes/kubernetes/pull/51321 are not going to get in this release. Will revert https://github.com/kubernetes/kube-openapi/pull/10 after this PR merged. fixes: #52135 ```release-note NONE ``` /assign @apelisse @liggitt
-
Adam Worrall authored
-
Di Xu authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Convert deprecated gcloud --regexp flag into --filter **What this PR does / why we need it**: #49673 missed a flag in hiding: ```console WARNING: Flag --regexp is deprecated. Use --filter="name~'REGEXP'" instead. ERROR: gcloud crashed (TypeError): 'NoneType' object is not iterable If you would like to report this issue, please run the following command: gcloud feedback To check gcloud for common problems, please run the following command: gcloud info --run-diagnostics ``` (Also it's great how gcloud crashes, rather than handling the deprecation gracefully.) **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49673 **Release note**: ```release-note NONE ``` cc @pci
-
- 07 Sep, 2017 25 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52097, 52054) Move paused deployment e2e tests to integration **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: xref #52113 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52097, 52054) Provide field info in storage configuration Makes debugging how storage was configured difficult @kubernetes/sig-api-machinery-bugs
-
Jeff Grafton authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 51239, 51644, 52076) code-generator/protobuf: cut-off kubernetes specifics The package list moved to hack/update-generated-protobuf-dockerized.sh. This make the protobuf generator usable outside of kube.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 51239, 51644, 52076) do not update init containers status if terminated fixes #29972 #41580 This fixes an issue where, if a completed init container is removed while the pod or subsequent init containers are still running, the status for that init container will be reset to `Waiting` with `PodInitializing`. This can manifest in a number of ways. If the init container is removed why the main pod containers are running, the status will be reset with no functional problem but the status will be reported incorrectly in `kubectl get pod` for example If the init container is removed why a subsequent init container is running, the init container will be **re-executed** leading to all manner of badness. @derekwaynecarr @bparees
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 51239, 51644, 52076) Fix swallowed error in registrytest **What this PR does / why we need it**: Fixes a swallowed error in the registrytest package. ```release-note NONE ```
-
Zihong Zheng authored
-
Janet Kuo authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix proxied request-uri to be valid HTTP requests Fixes #52022, introduced in 1.7. Stringifying/re-parsing the URL masked that the path was not constructed with a leading `/` in the first place. This makes upgrade requests proxied to pods/services via the API server proxy subresources be valid HTTP requests ```release-note Fixes an issue with upgrade requests made via pod/service/node proxy subresources sending a non-absolute HTTP request-uri to backends ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue StatefulSet: Deflake e2e RunHostCmd. The initial retry up to 20s was giving up too soon. I'm seeing this test flake because the Node rebooted and it takes ~2min to recover. Now StatefulSet RunHostCmd calls will use the same 5min timeout as with other Pod state checks. ref #48031
-
Nick Sardo authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52073, 52079) client-gen: avoid panic for empty groups
-
Jordan Liggitt authored
-
Manjunath A Kumatagi authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix cross-build **What this PR does / why we need it**: The cross-build was broken by the following PRs: https://github.com/kubernetes/kubernetes/pull/51728 https://github.com/kubernetes/kubernetes/pull/51557 This PR fixes the cross-build rather than revert them. Fixes https://github.com/kubernetes/kubernetes/issues/52074 **Release note**: ```release-note NONE ```
-
Dr. Stefan Schimanski authored
-
Clayton Coleman authored
-
cedric lamoriniere authored
Centralize the key "forget" and "requeue" process in only on method. Change the signature of the syncJob method in order to return the information if it is necessary to forget the backoff delay for a given key.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue kubeadm: Set the new BT auth group on the init token **What this PR does / why we need it**: What I forgot to do in https://github.com/kubernetes/kubernetes/pull/51956
😅 When we now have the new group, we should also set it on the token, otherwise nodes can't be joined On the good side, our CI testing broke https://k8s-testgrid.appspot.com/sig-cluster-lifecycle#kubeadm-gce Great to see that it actually works :) **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` @kubernetes/sig-cluster-lifecycle-pr-reviews -
Derek Carr authored
-
Lucas Käldström authored
-
Dr. Stefan Schimanski authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue kubeadm: add `kubeadm phase addons` command **What this PR does / why we need it**: Adds the `addons` phase command to `kubeadm` fixes: https://github.com/kubernetes/kubeadm/issues/418 /cc @luxas
-
Clayton Coleman authored
For 1.8 this will be off by default. In 1.9 it will be on by default. Add tests and rename some fields to use the `chunking` terminology. Note that the pager may be used for other things besides chunking.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 51728, 49202) Fix setNodeAddress when a node IP and a cloud provider are set **What this PR does / why we need it**: When a node IP is set and a cloud provider returns the same address with several types, only the first address was accepted. With the changes made in PR #45201, the vSphere cloud provider returned the ExternalIP first, which led to a node without any InternalIP. The behaviour is modified to return all the address types for the specified node IP. **Which issue this PR fixes**: fixes #48760 **Special notes for your reviewer**: * I'm not a golang expert, is it possible to mock `kubelet.validateNodeIP()` to avoid the need of real host interface addresses in the test ? * It would be great to have it backported for a next 1.6.8 release. **Release note**: ```release-note NONE ```
-