- 23 May, 2016 14 commits
-
-
Wojciech Tyczynski authored
-
Piotr Szczesniak authored
Fix reflector test
-
Wojciech Tyczynski authored
-
k8s-merge-robot authored
Automatic merge from submit-queue Add few log lines to NodeController
-
Piotr Szczesniak authored
cache: fix flaky resync test
-
gmarek authored
-
k8s-merge-robot authored
Automatic merge from submit-queue Rolling updater should allow progress to be logged / detected
-
k8s-merge-robot authored
Automatic merge from submit-queue Support sort-by timestamp in kubectl get ## Pull Request Guidelines 1. Please read our [contributor guidelines](https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md). 1. See our [developer guide](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md). 1. Follow the instructions for [labeling and writing a release note for this PR](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes) in the block below. ```release-note ``` **Before:** ```console $ kubectl get svc --sort-by='{.metadata.creationTimestamp}' proto: no encoder for TypeMeta unversioned.TypeMeta [GetProperties] proto: tag has too few fields: "-" proto: no coders for struct *reflect.rtype proto: no encoder for sec int64 [GetProperties] proto: no encoder for nsec int32 [GetProperties] proto: no encoder for loc *time.Location [GetProperties] proto: no encoder for Time time.Time [GetProperties] proto: no coders for intstr.Type proto: no encoder for Type intstr.Type [GetProperties] F0513 16:46:49.499894 29562 sorting_printer.go:182] Field {.metadata.creationTimestamp} in TypeMeta:<kind:"Service" apiVersion:"v1" > metadata:<name:"kubernetes" generateName:"" namespace:"default" selfLink:"/api/v1/namespaces/default/services/kubernetes" uid:"b88b4739-1964-11e6-9ac3-64510658e388" resourceVersion:"8" generation:0 creationTimestamp:<2016-05-13T16:45:06-07:00> labels:<key:"component" value:"apiserver" > labels:<key:"provider" value:"kubernetes" > > spec:<ports:<name:"https" protocol:"TCP" port:443 targetPort:<type:0 intVal:443 strVal:"" > nodePort:0 > clusterIP:"10.0.0.1" type:"ClusterIP" sessionAffinity:"ClientIP" loadBalancerIP:"" > status:<loadBalancer:<> > is an unsortable type: struct, err: unsortable type: struct ``` **After:** ```console $ kubectl get svc --sort-by='{.metadata.creationTimestamp}' NAME CLUSTER-IP EXTERNAL-IP PORT(S) AGE kubernetes 10.0.0.1 <none> 443/TCP 48s frontend 10.0.0.108 <none> 80/TCP 10s ``` @kubernetes/kubectl []()
-
k8s-merge-robot authored
Automatic merge from submit-queue cache: reflector should never stop watching A recent change tries to separate resync and relist. The motivation was to avoid triggering relist when a resync is required. However, the change is not effective since it stops the watcher. As hongchao mentioned in the original comment, today's storage interface will not deliever any progress notification to the watch chan. So any watcher that does not receive events for the last few seconds will not be able to catch up from the previous index after a hard close since the index of the last received event is out of the cache window inside etcd2. This pull request tries to fix this issue by not stoping watcher when a resync is required. /cc @hongchaodeng @wojtek-t @timothysc @rrati @smarterclayton
-
k8s-merge-robot authored
Automatic merge from submit-queue vSphere Volume Plugin Implementation This PR implements vSphere Volume plugin support in Kubernetes (ref. issue #23932).
-
k8s-merge-robot authored
Automatic merge from submit-queue A optimization for “RegisterCustomFitPredicate” function, avoiding redundancy
-
k8s-merge-robot authored
Automatic merge from submit-queue Lower ginkgo parallelism and move same image rolling-update test out of flaky Tentative fix for #25140.
-
Xiang Li authored
A recent change tries to separate resync and relist. The motivation was to avoid triggering relist when a resync is required. However, the change is not effective since it stops the watcher. As hongchao mentioned in the original comment, today's storage interface will not deliever any progress notification to the watch chan. So any watcher that does not receive events for the last few seconds will not be able to catch up from the previous index after a hard close since the index of the last received event is out of the cache window inside etcd2. This pull request tries to fix this issue by not stoping watcher when a resync is required.
-
k8s-merge-robot authored
Automatic merge from submit-queue Add a basic e2e test for 3rd party objects. Depends on https://github.com/kubernetes/kubernetes/pull/25365 []()
-
- 22 May, 2016 26 commits
-
-
k8s-merge-robot authored
Automatic merge from submit-queue SplitHostPort is needed since Request.RemoteAddr has the host:port format @smarterclayton ptal []()
-
k8s-merge-robot authored
Automatic merge from submit-queue ResourceQuota controller uses rate limiter to prevent hot-loops in error situations Have resource quota controller use a rate limited queue to prevent hot-looping in error situations.
-
k8s-merge-robot authored
Automatic merge from submit-queue Use Metrics API in HPA
-
k8s-merge-robot authored
Automatic merge from submit-queue E2e tests for GKE cluster with local SSD. The test cover node pool with local SSD creation and scheduling a pod that writes and reads from it. Pod access local disk via hostPath. ```release-note E2e tests for GKE cluster with local SSD. -OR- ```
-
k8s-merge-robot authored
Automatic merge from submit-queue Fix hyperkube flag parsing Hyperkube flag parsing was not playing nicely with kubectl command and sub-commands. This PR addresses that problem, and adds some tests which exercise hyperkube dispatching to nested cobra commands. \cc @aaronlevy @kbrwn @mumoshu fixes #24088 []()
-
Xiang Li authored
-
k8s-merge-robot authored
Automatic merge from submit-queue Improve the speed of do-nothing build. As @thockin found out here https://github.com/kubernetes/kubernetes/issues/24518, vast majority of the do-nothing build time is spent in rebuilding the test binaries. There is no staleness check support for test binaries. This commit implements the staleness checks for test binaries and uses them while building packages. On my workstation, do-nothing hack/build-go.sh time goes from ~20 secs to ~4 secs, of which only ~1 sec is from doing test binary staleness check now (as opposed to ~17 secs it took to build the test binaries before). I did some experiments to bring this time down to <1 sec. I measured using go test -bench, but it was not very useful in this case. I believe, a vast majority of that ~1 second is being spent in fork/exec and piping the results back to the staleness check program along with the ser-deser involved, but it needs to be validated. Not a proof, but to provide some supporting evidence to this claim, running `go list -f format packages` in the shell takes about 600ms irrespective of what's in the format. Tests are TBD. I am still trying to figure out how to test this, but I would like to get early feedback cc @mikedanese @mml
-
k8s-merge-robot authored
Automatic merge from submit-queue Add a kubectl create secret tls command A somewhat hasty implementation that enables progress along: https://github.com/kubernetes/kubernetes/issues/20176#issuecomment-177409516, https://github.com/kubernetes/kubernetes/issues/24669, https://github.com/kubernetes/kubernetes/issues/20176#issuecomment-198142836 if associated parties have spare cycles. @kubernetes/kubectl <!-- Reviewable:start --> --- This change is [<img src="http://reviewable.k8s.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](http://reviewable.k8s.io/reviews/kubernetes/kubernetes/24719) <!-- Reviewable:end -->
-
k8s-merge-robot authored
Automatic merge from submit-queue hack: allow devel builds of go This is issue https://github.com/kubernetes/kubernetes/issues/6913. It seems reasonable that someone running a devel build is responsible for making sure it's a sane version. <!-- Reviewable:start --> --- This change is [<img src="http://reviewable.k8s.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](http://reviewable.k8s.io/reviews/kubernetes/kubernetes/24653) <!-- Reviewable:end -->
-
k8s-merge-robot authored
Automatic merge from submit-queue Detangle attach detach from gce This detangles attach and detach operations from the GCE PD plugin and implements the new Attacher/Detacher interface. @markturansky @saad-ali What do you guys think ? <!-- Reviewable:start --> --- This change is [<img src="http://reviewable.k8s.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](http://reviewable.k8s.io/reviews/kubernetes/kubernetes/21709) <!-- Reviewable:end -->
-
k8s-merge-robot authored
Automatic merge from submit-queue fix edit on list Fixes https://github.com/kubernetes/kubernetes/issues/20519 This reverts the implementation that removed list editing capability, but leaves its tests intact. This allows edits of lists to work, while still allowing mutation of the annotations. It does this by walking each item and building per item patches. The current implementation will do funny things if you delete entire list entries. A followup could be written to locate the correct list item by name. Right now, it just rejects the patch because its trying to change an immutable field. @janetkuo @kubernetes/kubectl @kargakis
-
k8s-merge-robot authored
Automatic merge from submit-queue Add node problem detector as an addon pod. ```release-note Introduce a new add-on pod NodeProblemDetector. NodeProblemDetector is a DaemonSet running on each node, monitoring node health and reporting node problems as NodeCondition and Event. Currently it already supports kernel log monitoring, and will support more problem detection in the future. It is enabled by default on gce now. ``` This PR enables NodeProblemDetector as an add-on pod. /cc @mikedanese @kubernetes/sig-node []()
-
Sami Wagiaalla authored
-
k8s-merge-robot authored
Automatic merge from submit-queue Handle cAdvisor partial failures Kubernetes side of https://github.com/google/cadvisor/issues/1286 Partially fixes https://github.com/kubernetes/kubernetes/issues/25131 (Depends on cAdvisor Godeps bump https://github.com/kubernetes/kubernetes/pull/25914) /cc @kubernetes/sig-node
-
k8s-merge-robot authored
Automatic merge from submit-queue Add an 'authenticated user' metric to the RequestAuthenticator. Allows metric gathering of cluster access by internal/auto-generated identities vs. users (without actually exposing individual real users' usernames).
-
k8s-merge-robot authored
Automatic merge from submit-queue kubelet/cadvisor: Refactor cadvisor disk stat/usage interfaces. basically 1) cadvisor struct will know what runtime the kubelet is, passed in via additional argument to New() 2) rename cadvisor wrapper function to DockerImagesFsInfo() to ImagesFsInfo() and have linux implementation choose a label based on the runtime inside the cadvisor struct 2a) mock/fake/unsupported modified to take the same additional argument in New() 3) kubelet's wrapper for the cadvisor wrapper is renamed in parallel 4) make all tests use new interface
-
k8s-merge-robot authored
Automatic merge from submit-queue Scheduledjob storage This builds on top of #25475 so only last commit is significant. There's still one small problem with conversions, I'm currently working, but the biggest is still multi-version client tests. Read on... @erictune unfortunately the multi-version tests are biting again, this time in `pkg/registry/scheduledjob/etcd`. If I run the tests with just `batch/v2alpha1` then these are working correctly, but we can't have only `batch/v2alpha1` enabled since `batch/v1` is the preferred version for the entire `batch/` group. We either going to skip the tests here like we did with the scheduledjob client (I'm talking about `pkg/registry/scheduledjob/etcd/etcd_test.go`) or fix it. I've talked with @deads2k about how we can plumb the tests so it just passes, but there's no simple solution we can come up with
😞 (other than the one from #25566), unless @caesarxuchao can chime in and propose something. ```release-note Introducing ScheduledJobs as described in [the proposal](https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/scheduledjob.md) as part of `batch/v2alpha1` version (experimental feature). ``` []() -
k8s-merge-robot authored
Automatic merge from submit-queue Fix useless error message in scheduler log Print the Namespace and Name instead of Kind/ApiVersion. fixes #25950
-
k8s-merge-robot authored
Automatic merge from submit-queue Use SkyDNS as a library for a more integrated kube DNS
-
k8s-merge-robot authored
Automatic merge from submit-queue Configuration for GCP webhook authentication and authorization This PR adds configuration for GCP webhook authentication and authorization in ContainerVM and GCI. The change of configure-vm.sh and kube-apiserver.manifest is directly copied from @cjcullen's PR #25380 and #25296. The change in GCI script configure-helper.sh includes the support for webhook authentication and authorization, and also some code refactor to improve readability. @cjcullen @roberthbailey @zmerlynn please review it. The original PRs are P1, please mark this as P1. cc/ @fabioy @kubernetes/goog-image FYI. I verified it by running e2e tests on GCI cluster. Without the GCI side change, cluster creation fails as being capture by GKE Jenkins tests. I don't test when the two env GCP_AUTHN_URL and GCP_AUTHZ_URL are set, because they are only set in GKE. After this PR is merged, @cjcullen will test in GKE.
-
k8s-merge-robot authored
Automatic merge from submit-queue Fix the bug of the "removePod" function in node_info.go
-
k8s-merge-robot authored
Automatic merge from submit-queue README: be more accurate about where k8s can run
-
k8s-merge-robot authored
Automatic merge from submit-queue Cache webhook authorization responses Similar to #25694, but for authorization.
-
k8s-merge-robot authored
Automatic merge from submit-queue Introduce node memory pressure condition to scheduler Following the work done by @derekwaynecarr at https://github.com/kubernetes/kubernetes/pull/21274, introducing memory pressure predicate for scheduler. Missing: * write down unit-test * test the implementation At the moment this is a heads up for further discussion how the new node's memory pressure condition should be handled in the generic scheduler. **Additional info** * Based on [1], only best effort pods are subject to filtering. * Based on [2], best effort pods are those pods "iff requests & limits are not specified for any resource across all containers". [1] https://github.com/derekwaynecarr/kubernetes/blob/542668cc7998fe0acb315a43731e1f45ecdcc85b/docs/proposals/kubelet-eviction.md#scheduler [2] https://github.com/kubernetes/kubernetes/pull/14943
-
k8s-merge-robot authored
Automatic merge from submit-queue Heredoc fix on k8sm ha document Fix for a missing delimiter on a heredoc in contrib/mesos/docs/ha.md. []()
-
k8s-merge-robot authored
Automatic merge from submit-queue azure: azkube v0.0.5 + deploy kube-system + hack/ script for hyperkube Update the Azure bring up. Also added a script `hack/dev-push-hyperkube.sh` for fast iteration on changes. One can deploy a cluster with a given hyperkube image reference and then use this script to rapidly iterate on changes. Testing changes just requires pulling the updated hyperkube image on the boxes and then cycling kubelet/docker or restarting the node. <!-- Reviewable:start --> --- This change is [<img src="http://reviewable.k8s.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](http://reviewable.k8s.io/reviews/kubernetes/kubernetes/23344) <!-- Reviewable:end -->
-