1. 13 Mar, 2017 6 commits
    • Maru Newby's avatar
      fed: Fix flakey ingress unit test · 02a29453
      Maru Newby authored
      The unit test for the ingress controller was previously adding
      a cluster twice, which resulted in a cluster being deleted and added
      back.  The deletion was racing the controller shutdown to close
      informer channels.  This change ensures that the informer clears its
      map of informers when Stop() is called to prevent a double close, and
      that the test no longer adds the cluster twice.
      02a29453
    • Kubernetes Submit Queue's avatar
      Merge pull request #42915 from kubernetes/fabianofranz-test-approver · ab9b299c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add fabianofranz as approver for test/e2e/kubectl.go
      
      Adding myself as approver for `kubectl` end-to-end tests.
      
      ```release-note
      NONE
      ```
      ab9b299c
    • Kubernetes Submit Queue's avatar
      Merge pull request #42962 from k82cn/fix_min_tolerant_time · e1248bcb
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fixed incorrect result of getMinTolerationTime.
      
      For the following case, `getMinTolerationTime` should return one; but  it returned -1 :
      1. for tolerations[0], TolerationSeconds is nil, minTolerationTime is not set 
      2. for tolerations[1], it's TolerationSeconds (1) is bigger than `minTolerationTime`, so minTolerationTime is still -1 which means infinite.
      
      ```
      +		{
      +			tolerations: []v1.Toleration{
      +				{
      +					TolerationSeconds: nil,
      +				},
      +				{
      +					TolerationSeconds: &one,
      +				},
      +			},
      +		},
      ```
      e1248bcb
    • Kubernetes Submit Queue's avatar
      Merge pull request #42702 from smarterclayton/printer_owners · 65ddace3
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add pkg/printers OWNERS
      
      Should also include more sig-api-machinery as this will be moving to server side
      65ddace3
    • Kubernetes Submit Queue's avatar
      Merge pull request #42966 from apprenda/kubeadm_beta_banner · 33c45527
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42969, 42966)
      
      kubeadm: update kubeadm banner to beta
      
      **What this PR does / why we need it**: Updates the intro banner for kubeadm, which used to  state it is in alpha (but we are going to beta). This also updates the tagged github group (one that no longer exists) to the sig-cluster-lifecycle-misc group.  
      
      **Special notes for your reviewer**: /cc @jbeda 
      
      **Release note**:
      ```release-note
      NONE
      ```
      33c45527
    • Kubernetes Submit Queue's avatar
      Merge pull request #42969 from apprenda/kubeadm_preflight_warning_nil · c0ebd724
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42969, 42966)
      
      kubeadm: fixed warning nil logging
      
      **What this PR does / why we need it**: Fix bug in warning aggregation for preflight checks. Would cause logging like this:
      
      `[preflight] WARNING: %!s(<nil>)`
      
      Will now only append non-nil cases to warning.
      
      **Special notes for your reviewer**: /cc @jbeda 
      
      **Release note**:
      ```release-note
      NONE
      ```
      c0ebd724
  2. 12 Mar, 2017 10 commits
    • Derek McQuay's avatar
      53818b6c
    • Kubernetes Submit Queue's avatar
      Merge pull request #42851 from madhusudancs/fed-down-improvements · e1ec10f2
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      [Federation] Unjoin only the joined clusters while bringing down the federation control plane.
      
      A few other minor improvements.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      e1ec10f2
    • Derek McQuay's avatar
      kubeadm: fixed warning nil logging · 7249ba28
      Derek McQuay authored
      7249ba28
    • Derek McQuay's avatar
      b0fbff65
    • Derek McQuay's avatar
      kubeadm: update kubeadm banner to beta · ab1ce8b8
      Derek McQuay authored
      ab1ce8b8
    • Madhusudan.C.S's avatar
      [Federation] Unjoin only the joined clusters while bringing down the federation control plane. · ed10bb76
      Madhusudan.C.S authored
      A few other minor improvements.
      ed10bb76
    • Kubernetes Submit Queue's avatar
      Merge pull request #42965 from sttts/sttts-godep-resorce-with-godep-v79 · da20ffda
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      hack/godep-restore.sh: use godep v79 which works
      
      Godep v74 gives me:
      
      ```shell
      godep: Checking dependency: k8s.io/metrics/pkg/apis/custom_metrics
      godep: Dep (k8s.io/metrics/pkg/apis/custom_metrics) restored, but was unable to load it with error:
      	Package (k8s.io/apimachinery/pkg/api/resource) not found
      godep: Checking dependency: k8s.io/metrics/pkg/apis/custom_metrics/install
      godep: Dep (k8s.io/metrics/pkg/apis/custom_metrics/install) restored, but was unable to load it with error:
      	Package (k8s.io/apimachinery/pkg/apimachinery/announced) not found
      godep: Checking dependency: k8s.io/metrics/pkg/apis/custom_metrics/v1alpha1
      godep: Dep (k8s.io/metrics/pkg/apis/custom_metrics/v1alpha1) restored, but was unable to load it with error:
      	Package (k8s.io/apimachinery/pkg/api/resource) not found
      godep: Checking dependency: k8s.io/metrics/pkg/apis/metrics
      godep: Dep (k8s.io/metrics/pkg/apis/metrics) restored, but was unable to load it with error:
      	Package (k8s.io/apimachinery/pkg/apis/meta/v1) not found
      godep: Checking dependency: k8s.io/metrics/pkg/apis/metrics/install
      godep: Dep (k8s.io/metrics/pkg/apis/metrics/install) restored, but was unable to load it with error:
      	Package (k8s.io/apimachinery/pkg/apimachinery/announced) not found
      godep: Checking dependency: k8s.io/metrics/pkg/apis/metrics/v1alpha1
      godep: Dep (k8s.io/metrics/pkg/apis/metrics/v1alpha1) restored, but was unable to load it with error:
      	Package (k8s.io/apimachinery/pkg/api/resource) not found
      godep: Checking dependency: k8s.io/metrics/pkg/client/clientset_generated/clientset
      godep: Dep (k8s.io/metrics/pkg/client/clientset_generated/clientset) restored, but was unable to load it with error:
      	Package (k8s.io/client-go/discovery) not found
      godep: Checking dependency: k8s.io/metrics/pkg/client/clientset_generated/clientset/fake
      godep: Dep (k8s.io/metrics/pkg/client/clientset_generated/clientset/fake) restored, but was unable to load it with error:
      	Package (k8s.io/apimachinery/pkg/runtime) not found
      godep: Checking dependency: k8s.io/metrics/pkg/client/clientset_generated/clientset/scheme
      godep: Dep (k8s.io/metrics/pkg/client/clientset_generated/clientset/scheme) restored, but was unable to load it with error:
      	Package (k8s.io/apimachinery/pkg/apis/meta/v1) not found
      godep: Checking dependency: k8s.io/metrics/pkg/client/clientset_generated/clientset/typed/metrics/v1alpha1
      godep: Dep (k8s.io/metrics/pkg/client/clientset_generated/clientset/typed/metrics/v1alpha1) restored, but was unable to load it with error:
      	Package (k8s.io/apimachinery/pkg/apis/meta/v1) not found
      godep: Checking dependency: k8s.io/metrics/pkg/client/clientset_generated/clientset/typed/metrics/v1alpha1/fake
      godep: Dep (k8s.io/metrics/pkg/client/clientset_generated/clientset/typed/metrics/v1alpha1/fake) restored, but was unable to load it with error:
      	Package (k8s.io/apimachinery/pkg/apis/meta/v1) not found
      godep: Checking dependency: k8s.io/metrics/pkg/client/custom_metrics
      godep: Dep (k8s.io/metrics/pkg/client/custom_metrics) restored, but was unable to load it with error:
      	Package (k8s.io/apimachinery/pkg/api/meta) not found
      godep: Checking dependency: k8s.io/metrics/pkg/client/custom_metrics/fake
      godep: Dep (k8s.io/metrics/pkg/client/custom_metrics/fake) restored, but was unable to load it with error:
      	Package (k8s.io/apimachinery/pkg/labels) not found
      godep: Checking dependency: vbom.ml/util/sortorder
      godep: Error checking some deps.
      2,64s user 2,75s system 11% cpu 47,395s total
      ```
      
      v79 works.
      da20ffda
    • Dr. Stefan Schimanski's avatar
      f88bae81
    • Klaus Ma's avatar
      Fixed incorrect result of getMinTolerationTime. · d0e04427
      Klaus Ma authored
      d0e04427
    • Kubernetes Submit Queue's avatar
      Merge pull request #42944 from liggitt/patch-defaulting · e315c388
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Ensure patched objects are defaulted correctly
      
      Restores defaulting behavior for patch API calls removed in https://github.com/kubernetes/kubernetes/commit/e34e1abe3345939268c1fdbc05e2d933396ab2fe#diff-517d1b81963bbc7c9b0a16e6eb3c0e2f
      
      Restores the unit test that ensures we get a defaulted result after applying a patch
      
      Fixes https://github.com/kubernetes/kubernetes/issues/42764
      Fixes #42834
      e315c388
  3. 11 Mar, 2017 13 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #42913 from aveshagarwal/master-fix-taint-based-eviction-no-node-cidr · 3f660a97
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix taint based pod eviction for clusters where controller manager is not running with allocate-node-cidrs set
      
      Fixes https://github.com/kubernetes/kubernetes/issues/42733
      
      In my cluster, I have not set allocate-node-cidr, and It is causing taint based pod eviction to fail. 
      
      @gmarek @kubernetes/sig-scheduling-bugs @davidopp @derekwaynecarr
      3f660a97
    • Kubernetes Submit Queue's avatar
      Merge pull request #42933 from timstclair/bump · b0ce93f9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 41794, 42349, 42755, 42901, 42933)
      
      Bump cluster-proportional-autoscaler to 1.1.1-r2
      
      ```release-note
      Patch CVE-2016-8859 in gcr.io/google-containers/cluster-proportional-autoscaler-amd64
      ```
      
      /cc @ixdy
      b0ce93f9
    • Kubernetes Submit Queue's avatar
      Merge pull request #42901 from fabianofranz/issues_42697 · 81ba4741
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 41794, 42349, 42755, 42901, 42933)
      
      Fixes kubectl skew test failure when using kubectl.sh
      
      Fixes leftovers from https://github.com/kubernetes/kubernetes/pull/42737.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      81ba4741
    • Kubernetes Submit Queue's avatar
      Merge pull request #42755 from aveshagarwal/master-fix-default-toleration-seconds · 8cb14a4f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 41794, 42349, 42755, 42901, 42933)
      
      Fix DefaultTolerationSeconds admission plugin
      
      DefaultTolerationSeconds is not working as expected. It is supposed to add default tolerations (for unreachable and notready conditions). but no pod was getting these toleration. And api server was throwing this error:
      
      ```
      Mar 08 13:43:57 fedora25 hyperkube[32070]: E0308 13:43:57.769212   32070 admission.go:71] expected pod but got Pod
      Mar 08 13:43:57 fedora25 hyperkube[32070]: E0308 13:43:57.789055   32070 admission.go:71] expected pod but got Pod
      Mar 08 13:44:02 fedora25 hyperkube[32070]: E0308 13:44:02.006784   32070 admission.go:71] expected pod but got Pod
      Mar 08 13:45:39 fedora25 hyperkube[32070]: E0308 13:45:39.754669   32070 admission.go:71] expected pod but got Pod
      Mar 08 14:48:16 fedora25 hyperkube[32070]: E0308 14:48:16.673181   32070 admission.go:71] expected pod but got Pod
      ```
      
      The reason for this error is that the input to admission plugins is internal api objects not versioned objects so expecting versioned object is incorrect. Due to this, no pod got desired tolerations and it always showed:
      
      ```
      Tolerations: <none>
      ```
      
      After this fix, the correct  tolerations are being assigned to pods as follows:
      
      ```
      Tolerations:	node.alpha.kubernetes.io/notReady=:Exists:NoExecute for 300s
      		node.alpha.kubernetes.io/unreachable=:Exists:NoExecute for 300s
      ```
      
      @davidopp @kevin-wangzefeng @kubernetes/sig-scheduling-pr-reviews @kubernetes/sig-scheduling-bugs @derekwaynecarr 
      
      Fixes https://github.com/kubernetes/kubernetes/issues/42716
      8cb14a4f
    • Kubernetes Submit Queue's avatar
      Merge pull request #42349 from timstclair/aa-upgrade · ca09352d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 41794, 42349, 42755, 42901, 42933)
      
      AppArmor cluster upgrade test
      
      Add a cluster upgrade test for AppArmor. I still need to test this (having some trouble with the cluster-upgrade tests), but wanted to start the review process.
      
      /cc @dchen1107 @roberthbailey
      ca09352d
    • Kubernetes Submit Queue's avatar
      Merge pull request #41794 from shashidharatd/federation-upgrade-tests-1 · 328e555f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 41794, 42349, 42755, 42901, 42933)
      
      [Federation][e2e] Add framework for upgrade test in federation
      
      Adding framework for federation upgrade tests. please refer to #41791
      
      cc @madhusudancs @nikhiljindal @kubernetes/sig-federation-pr-reviews
      328e555f
    • Anthony Yeh's avatar
      Update CHANGELOG.md for v1.6.0-beta.3. · 633a4428
      Anthony Yeh authored
      633a4428
    • Jordan Liggitt's avatar
      464db160
    • Kubernetes Submit Queue's avatar
      Merge pull request #42922 from csbell/csbell-deployments · c2907e4c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42642, 42899, 42922)
      
      [Federation] Deployments unaware of ReadyReplicas
      
      The Deployment controller was not propagating ReadyReplicas to underlying clusters causing these errors:
      ```
      Error syncing cluster controller: Deployment.apps "federation-deployment" is invalid: status.availableReplicas: Invalid value: 5: cannot be greater than readyReplicas
      ```
      
      This was caught in e2e testing and is a 1.6 regression for support that was added in #37959. Without this fix, users will be unable to scale up their deployments.
      c2907e4c
    • Kubernetes Submit Queue's avatar
      Merge pull request #42899 from dashpole/update_godep_1_6 · be37d475
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42642, 42899, 42922)
      
      Update cadvisor godeps to v0.25.0
      
      Completes #42008, a 1.6 issue.
      
      The cadvisor changes include only a couple minor bug fixes, mainly for the devicemapper storage driver.
      
      cc @dchen1107 
      
      ```release-note
      Disable devicemapper thin_ls due to excessive iops
      ```
      be37d475
    • Kubernetes Submit Queue's avatar
      Merge pull request #42642 from fraenkel/envfrom · 59aa924a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Invalid environment var names are reported and pod starts
      
      When processing EnvFrom items, all invalid keys are collected and
      reported as a single event.
      
      The Pod is allowed to start.
      
      fixes #42583
      59aa924a
    • Tim St. Clair's avatar
      5cda5966
    • Kubernetes Submit Queue's avatar
      Merge pull request #42630 from anguslees/elasticsearch · 17793bcc
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 41830, 42630)
      
      Arrange for elasticsearch to shutdown cleanly
      
      Kubernetes initiates "graceful shutdown" by sending SIGTERM to pid 1, which
      is exactly what elasticsearch is expecting (good!)
      
      The way the existing startup scripts worked however, this signal arrived at
      the shell wrapper, not elasticsearch, and the shell wrapper exited,
      killing the container immediately (bad!)
      
      Before this change:
      ```
          1 ?        Ss     0:00 /bin/sh -c /run.sh
          6 ?        S      0:00 /bin/bash /run.sh
         13 ?        S      0:00  \_ /bin/su -c /elasticsearch/bin/elasticsearch elasticsearch
         14 ?        Ss     0:00      \_ sh -c /elasticsearch/bin/elasticsearch
         15 ?        Sl    19:18          \_ /usr/lib/jvm/java-8-openjdk-amd64/jre/bin/java ... org.elasticsearch.bootstrap.Elasticsearch start
      ```
      After this change:
      ```
          1 ?        Ssl    0:29 /usr/lib/jvm/java-8-openjdk-amd64/jre/bin/java ... org.elasticsearch.bootstrap.Elasticsearch start
      ```
      17793bcc
  4. 10 Mar, 2017 11 commits