Commit ff639e80 authored by Yecheng Fu's avatar Yecheng Fu

RBD Plugin: Fix bug in checking command not found error.

parent 6e950cc6
......@@ -27,6 +27,7 @@ import (
"io/ioutil"
"math/rand"
"os"
"os/exec"
"path"
"regexp"
"strings"
......@@ -43,7 +44,6 @@ import (
const (
imageWatcherStr = "watcher="
kubeLockMagic = "kubelet_lock_magic_"
rbdCmdErr = "executable file not found in $PATH"
)
// search /sys/bus for rbd device that matches given pool and image
......@@ -117,8 +117,10 @@ func (util *RBDUtil) MakeGlobalPDName(rbd rbd) string {
}
func rbdErrors(runErr, resultErr error) error {
if runErr.Error() == rbdCmdErr {
return fmt.Errorf("rbd: rbd cmd not found")
if err, ok := runErr.(*exec.Error); ok {
if err.Err == exec.ErrNotFound {
return fmt.Errorf("rbd: rbd cmd not found")
}
}
return resultErr
}
......@@ -479,10 +481,12 @@ func (util *RBDUtil) rbdStatus(b *rbdMounter) (bool, string, error) {
break
}
if err.Error() == rbdCmdErr {
glog.Errorf("rbd cmd not found")
// fail fast if command not found
return false, output, err
if err, ok := err.(*exec.Error); ok {
if err.Err == exec.ErrNotFound {
glog.Errorf("rbd cmd not found")
// fail fast if command not found
return false, output, err
}
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment