Merge pull request #63572 from haz-mat/aws-lb-sg-scope-icmp

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. scope AWS LoadBalancer security group ICMP rules to spec.loadBalancerSourceRanges /sig aws **What this PR does / why we need it**: Make the client CIDR ranges for MTU consistent with what [the documentation appears to describe](https://kubernetes.io/docs/concepts/services-networking/service/#type-loadbalancer), where the ranges should be equal to `spec.loadBalancerSourceRanges` if supplied. **Which issue(s) this PR fixes**: Fixes #63564 **Release note**: ```release-note scope AWS LoadBalancer security group ICMP rules to spec.loadBalancerSourceRanges ```

Merge pull request #63572 from haz-mat/aws-lb-sg-scope-icmp
fc89a809 · Kubernetes Submit Queue · GitHub · 2fa93a94 · 98b21faa · fc89a809
Unverified Commit fc89a809 authored Aug 07, 2018 by Kubernetes Submit Queue Committed by GitHub Aug 07, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

aws.go pkg/cloudprovider/providers/aws/aws.go +1 -1

No files found.
--- a/pkg/cloudprovider/providers/aws/aws.go
+++ b/pkg/cloudprovider/providers/aws/aws.go
@@ -3533,7 +3533,7 @@ func (c *Cloud) EnsureLoadBalancer(ctx context.Context, clusterName string, apiS
 				IpProtocol: aws.String("icmp"),
 				FromPort:   aws.Int64(3),
 				ToPort:     aws.Int64(4),
-				IpRanges:   []*ec2.IpRange{{CidrIp: aws.String("0.0.0.0/0")}},
+				IpRanges:   ec2SourceRanges,
 			}

 			permissions.Insert(permission)