Skip to content

K
k3s
Unverified Commit fbc28fd1 authored by Kubernetes Prow Robot's avatar Kubernetes Prow Robot Committed by GitHub
Browse files
Options

Merge pull request #76280 from xichengliudui/fixshellcheck0409

Fix shellcheck failures in update-workspace-mirror.sh
parents fa9b36de 961f1621
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 4 deletions
hack/.shellcheck_failures
View file @ fbc28fd1
...@@ -53,7 +53,6 @@ ...@@ -53,7 +53,6 @@
./hack/update-translations.sh ./hack/update-translations.sh
./hack/update-vendor-licenses.sh ./hack/update-vendor-licenses.sh
./hack/update-vendor.sh ./hack/update-vendor.sh
./hack/update-workspace-mirror.sh
./hack/verify-api-groups.sh ./hack/verify-api-groups.sh
./hack/verify-boilerplate.sh ./hack/verify-boilerplate.sh
./hack/verify-cli-conventions.sh ./hack/verify-cli-conventions.sh
......
hack/update-workspace-mirror.sh
View file @ fbc28fd1
...@@ -29,8 +29,8 @@ BUCKET="gs://k8s-bazel-cache" ...@@ -29,8 +29,8 @@ BUCKET="gs://k8s-bazel-cache"
gsutil acl get "${BUCKET}" > /dev/null gsutil acl get "${BUCKET}" > /dev/null
tmpfile=$(mktemp bazel_workspace_mirror.XXXXXX) tmpfile=$(mktemp bazel_workspace_mirror.XXXXXX)
trap "rm ${tmpfile}" EXIT trap 'rm ${tmpfile}' EXIT
cat "$1" | while read url; do while read -r url; do
echo "${url}" echo "${url}"
if gsutil ls "${BUCKET}/${url}" &> /dev/null; then if gsutil ls "${BUCKET}/${url}" &> /dev/null; then
echo present echo present
...@@ -40,4 +40,4 @@ cat "$1" | while read url; do ...@@ -40,4 +40,4 @@ cat "$1" | while read url; do
gsutil cp -a public-read "${tmpfile}" "${BUCKET}/${url}" gsutil cp -a public-read "${tmpfile}" "${BUCKET}/${url}"
fi fi
fi fi
done done < "$1"
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment