Merge pull request #48317 from CaoShuFeng/impersonation_group

Automatic merge from submit-queue remove useless check from impersonation filter When groupsSpecified is false, that means no other groups are added rather than the service account groups. So this check doesn't make any sense. **Release note**: ``` NONE ```

Merge pull request #48317 from CaoShuFeng/impersonation_group
fbba6709 · Kubernetes Submit Queue · GitHub · 73a94eac · 0a1e24f3 · fbba6709
Commit fbba6709 authored Jun 30, 2017 by Kubernetes Submit Queue Committed by GitHub Jun 30, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 11 deletions

impersonation.go ...c/k8s.io/apiserver/pkg/endpoints/filters/impersonation.go +1 -11

No files found.
--- a/staging/src/k8s.io/apiserver/pkg/endpoints/filters/impersonation.go
+++ b/staging/src/k8s.io/apiserver/pkg/endpoints/filters/impersonation.go
@@ -118,18 +118,8 @@ func WithImpersonation(handler http.Handler, requestContextMapper request.Reques

 		if !groupsSpecified && username != user.Anonymous {
 			// When impersonating a non-anonymous user, if no groups were specified
-			// if neither the system:authenticated nor system:unauthenticated groups are explicitly included,
 			// include the system:authenticated group in the impersonated user info
-			found := false
-			for _, group := range groups {
-				if group == user.AllAuthenticated || group == user.AllUnauthenticated {
-					found = true
-					break
-				}
-			}
-			if !found {
-				groups = append(groups, user.AllAuthenticated)
-			}
+			groups = append(groups, user.AllAuthenticated)
 		}

 		newUser := &user.DefaultInfo{