Commit fa0c81cb authored by guineveresaenger's avatar guineveresaenger

Remove golint failures from pkg/apis/admissionregistration

Adds test/integration/apiserver/admissionwebhook to golint_failures; it is failing on kubernetes/master currently
parent ce3ddcd5
...@@ -4,7 +4,6 @@ cmd/kube-controller-manager/app ...@@ -4,7 +4,6 @@ cmd/kube-controller-manager/app
cmd/kubeadm/app/apis/kubeadm/v1beta1 cmd/kubeadm/app/apis/kubeadm/v1beta1
pkg/apis/abac/latest pkg/apis/abac/latest
pkg/apis/admission pkg/apis/admission
pkg/apis/admissionregistration
pkg/apis/admissionregistration/v1beta1 pkg/apis/admissionregistration/v1beta1
pkg/apis/admissionregistration/validation pkg/apis/admissionregistration/validation
pkg/apis/apps pkg/apis/apps
......
...@@ -21,6 +21,7 @@ import ( ...@@ -21,6 +21,7 @@ import (
"k8s.io/apimachinery/pkg/runtime/schema" "k8s.io/apimachinery/pkg/runtime/schema"
) )
// GroupName is the name used for this API group
const GroupName = "admissionregistration.k8s.io" const GroupName = "admissionregistration.k8s.io"
// SchemeGroupVersion is group version used to register these objects // SchemeGroupVersion is group version used to register these objects
...@@ -37,8 +38,10 @@ func Resource(resource string) schema.GroupResource { ...@@ -37,8 +38,10 @@ func Resource(resource string) schema.GroupResource {
} }
var ( var (
// SchemeBuilder is the scheme builder with scheme init functions to run for this API package
SchemeBuilder = runtime.NewSchemeBuilder(addKnownTypes) SchemeBuilder = runtime.NewSchemeBuilder(addKnownTypes)
AddToScheme = SchemeBuilder.AddToScheme // AddToScheme is a global function that registers this API group & version to a scheme
AddToScheme = SchemeBuilder.AddToScheme
) )
// Adds the list of known types to scheme. // Adds the list of known types to scheme.
......
...@@ -63,6 +63,7 @@ type Rule struct { ...@@ -63,6 +63,7 @@ type Rule struct {
Scope *ScopeType Scope *ScopeType
} }
// ScopeType specifies the type of scope being used
type ScopeType string type ScopeType string
const ( const (
...@@ -75,6 +76,7 @@ const ( ...@@ -75,6 +76,7 @@ const (
AllScopes ScopeType = "*" AllScopes ScopeType = "*"
) )
// FailurePolicyType specifies the type of failure policy
type FailurePolicyType string type FailurePolicyType string
const ( const (
...@@ -84,6 +86,7 @@ const ( ...@@ -84,6 +86,7 @@ const (
Fail FailurePolicyType = "Fail" Fail FailurePolicyType = "Fail"
) )
// SideEffectClass denotes the type of side effects resulting from calling the webhook
type SideEffectClass string type SideEffectClass string
const ( const (
...@@ -263,6 +266,7 @@ type RuleWithOperations struct { ...@@ -263,6 +266,7 @@ type RuleWithOperations struct {
Rule Rule
} }
// OperationType specifies what type of operation the admission hook cares about.
type OperationType string type OperationType string
// The constants should be kept in sync with those defined in k8s.io/kubernetes/pkg/admission/interface.go. // The constants should be kept in sync with those defined in k8s.io/kubernetes/pkg/admission/interface.go.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment