Remove superfluous MkdirAll from MakeTempDirOrDie

After the call to ioutil.TempDir, the directory has already been created, and MkdirAll therefore can't do anything. The mode argument in particular is misleading.

Remove superfluous MkdirAll from MakeTempDirOrDie
f841f3ab · Justin Santa Barbara · d4c48718 · f841f3ab
Commit f841f3ab authored Oct 08, 2018 by Justin Santa Barbara
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 4 deletions

tmpdir.go test/utils/tmpdir.go +0 -4

No files found.
--- a/test/utils/tmpdir.go
+++ b/test/utils/tmpdir.go
@@ -18,7 +18,6 @@ package utils

 import (
 	"io/ioutil"
-	"os"

 	"github.com/golang/glog"
 )
@@ -31,8 +30,5 @@ func MakeTempDirOrDie(prefix string, baseDir string) string {
 	if err != nil {
 		glog.Fatalf("Can't make a temp rootdir: %v", err)
 	}
-	if err = os.MkdirAll(tempDir, 0750); err != nil {
-		glog.Fatalf("Can't mkdir(%q): %v", tempDir, err)
-	}
 	return tempDir
 }